| 2024-08-08 11:20:07 |
Roxana Nicolescu |
description |
RU Justification:
[Impact]
* bpf selftest do not compile. See the error below.
Commit "bpf: Allow reads from uninit stack" introduced the usage of '__failure',
without bringing the commit where this is defined.
This prevents us from running other tests and it also affects the netselfts because they are dependant on it.
Logs:
17242 progs/test_global_func10.c:24:17: error: expected parameter declarator
17243 __failure __msg("invalid indirect access to stack")
17244 ^
17245 progs/test_global_func10.c:24:17: error: expected ')'
17246 progs/test_global_func10.c:24:16: note: to match this '('
17247 __failure __msg("invalid indirect access to stack")
17248 ^
17249 progs/test_global_func10.c:24:52: error: expected ';' after top level declarator
17250 __failure __msg("invalid indirect access to stack")
17251 ^
[Fix]
* While discussing with upstream a revert of this commit will be the fix for now.
[Test Plan]
* Revert, build the kernel, run the ubuntu_bpf_selftests and see it they build. |
SRU Justification:
[Impact]
* bpf selftest do not compile. See the error below.
Commit "bpf: Allow reads from uninit stack" introduced the usage of '__failure',
without bringing the commit where this is defined.
This prevents us from running other tests and it also affects the netselfts because they are dependant on it.
Logs:
17242 progs/test_global_func10.c:24:17: error: expected parameter declarator
17243 __failure __msg("invalid indirect access to stack")
17244 ^
17245 progs/test_global_func10.c:24:17: error: expected ')'
17246 progs/test_global_func10.c:24:16: note: to match this '('
17247 __failure __msg("invalid indirect access to stack")
17248 ^
17249 progs/test_global_func10.c:24:52: error: expected ';' after top level declarator
17250 __failure __msg("invalid indirect access to stack")
17251 ^
[Fix]
* While discussing with upstream a revert of this commit will be the fix for now.
[Test Plan]
* Revert, build the kernel, run the ubuntu_bpf_selftests and see it they build. |
|
