illuminator control in driver sonixj

[Jean COLIN]

https://packages.ubuntu.com/bionic/kernel/linux-modules-4.15.0-196-generic
file kernel/drivers/media/usb/gspca/gspca_sonixj.ko

in this driver, the illuminator est considered driven by the sensor chip.
i buyed recently an hercules (guillemot) webcam with illuminator .. 06f8:3008 the illuminator dont work.
found the sonixj.c driver source ... webcam are considered as a coupling of two main chips
-a sensor chip with an array of photodiodes which creates the image
-a controller wich processes the image and sent the the image on the usb line

found the tech_ref of the sensor chip = NO pin to drive any led.
so, the led is driven by the controller (logic, no !)

made some modification on the sonixj.c source, build it, it works for my webcam on an very old asus L5D (athlon 64 processor - first generation)

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1997102

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Jean COLIN (carl174)]

i a not able to have a log file when a light remain switched off

[Jean COLIN (carl174)]

details of modification (4 program lines were modified)

modification in initialisation

static const struct usb_device_id device_table[]
...
/* {USB_DEVICE(0x06f8, 0x3008), BS(SN9C105, OV7660)}, la webcam a des LED d'éclairage*/
 {USB_DEVICE(0x06f8, 0x3008), BSF(SN9C105, OV7660, F_ILLUM)},

modification in function

static void setillum(struct gspca_dev *gspca_dev)
...
 /* switch (sd->sensor) {*/
 switch (sd->bridge) {
 /* SN9C120 */
 /* case SENSOR_ADCM1700:*/
 case BRIDGE_SN9C120:
...
 /* SN9C105 */
 /* case SENSOR_MT9V111:*/
 case BRIDGE_SN9C105:

[Kai-Heng Feng (kaihengfeng)]

Please send the patch to upstream.

[Jean COLIN (carl174)]

And what means "upstream" for you ?

[Kai-Heng Feng (kaihengfeng)]

https://kernelnewbies.org/FirstKernelPatch

[Jean COLIN (carl174)]

Too complicated for me ... there is only 4 lines to change ... and il will not spend one full day to understand your labyrinthic method.

Regards

Jean COLIN