[Ubuntu 22.04] mpi3mr: Request to include latest bug fixes

Bug #1967116 reported by Sumit Saxena
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
In Progress
Undecided
Jeff Lane 
Jammy
Fix Released
Medium
Jeff Lane 

Bug Description

Request to include below mpi3mr driver bug fix patches in Ubuntu 22.04 kernel. These patches got accepted by the upstream and please find the corresponding commit IDs as below:

334ae6459aa3 scsi: mpi3mr: Fix flushing !WQ_MEM_RECLAIM events warning
22754f7fbb40 scsi: mpi3mr: Bump driver version to 8.0.0.68.0
d44b5fefb22e scsi: mpi3mr: Fix memory leaks
21401408ddeb scsi: mpi3mr: Update the copyright year
999224612724 scsi: mpi3mr: Fix reporting of actual data transfer size
b3911ab3a76e scsi: mpi3mr: Fix cmnd getting marked as in use forever
191a3ef58634 scsi: mpi3mr: Fix hibernation issue
04b27e538d50 scsi: mpi3mr: Update MPI3 headers
6d211f1d2635 scsi: mpi3mr: Fix printing of pending I/O count
580e6742205e scsi: mpi3mr: Fix deadlock while canceling the fw event
3bb3c24e268a scsi: mpi3mr: Fix formatting problems in some kernel-doc comments
5867b8569e64 scsi: mpi3mr: Fix some spelling mistakes
c77b1f8a8fae scsi: mpi3mr: Bump driver version to 8.0.0.61.0
a91603a5d504 scsi: mpi3mr: Enhanced Task Management Support Reply handling
c86651345ca5 scsi: mpi3mr: Use TM response codes from MPI3 headers
afd3a5793fe2 scsi: mpi3mr: Add io_uring interface support in I/O-polled mode
95cca8d5542a scsi: mpi3mr: Print cable mngnt and temp threshold events
78b76a0768ef scsi: mpi3mr: Support Prepare for Reset event
c1af985d27da scsi: mpi3mr: Add Event acknowledgment logic
c5758fc72b92 scsi: mpi3mr: Gracefully handle online FW update operation
b64845a7d403 scsi: mpi3mr: Detect async reset that occurred in firmware
c0b00a931e5e scsi: mpi3mr: Add IOC reinit function
fe6db6151565 scsi: mpi3mr: Handle offline FW activation in graceful manner
59bd9cfe3fa0 scsi: mpi3mr: Code refactor of IOC init - part2
e3605f65ef69 scsi: mpi3mr: Code refactor of IOC init - part1
a6856cc4507b scsi: mpi3mr: Fault IOC when internal command gets timeout
2ac794baaec9 scsi: mpi3mr: Display IOC firmware package version
13fd7b1555b6 scsi: mpi3mr: Handle unaligned PLL in unmap cmnds
4f08b9637f63 scsi: mpi3mr: Increase internal cmnds timeout to 60s
ba68779a518d scsi: mpi3mr: Do access status validation before adding devices
17d6b9cf89cf scsi: mpi3mr: Add support for PCIe Managed Switch SES device
ec5ebd2c14a9 scsi: mpi3mr: Update MPI3 headers - part2
d00ff7c31195 scsi: mpi3mr: Update MPI3 headers - part1
fbaa9aa48bb4 scsi: mpi3mr: Don't reset IOC if cmnds flush with reset status
a83ec831b24a scsi: mpi3mr: Replace spin_lock() with spin_lock_irqsave()
9cf0666f34b1 scsi: mpi3mr: Add debug APIs based on logging_level bits
30e99f05f8b1 scsi: mpi3mr: Use scnprintf() instead of snprintf()
97e6ea6d7806 scsi: mpi3mr: Fix duplicate device entries when scanning through sysfs
1a30fd18f21b scsi: mpi3mr: Call scsi_done() directly
76a4f7cc5973 scsi: mpi3mr: Clean up mpi3mr_print_ioc_info()
92cc94adfce4 scsi: mpi3mr: Use the proper SCSI midlayer interfaces for PI
69868c3b6939 scsi: mpi3mr: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
aa0dc6a73309 scsi: mpi3mr: Fix W=1 compilation warnings
62e528b80d6b scsi: mpi3mr: Fix warnings reported by smatch
a254eae30b45 scsi: mpi3mr: Fix error return code in mpi3mr_init_ioc()
f9dc034d0402 scsi: mpi3mr: Fix missing unlock on error
2938bedd0efa scsi: mpi3mr: Fix error handling in mpi3mr_setup_isr()
d46bdecd9f3c scsi: mpi3mr: Delete unnecessary NULL check
d3d61f9c8c2d scsi: mpi3mr: Fix a double free
7b8a49881b01 scsi: mpi3mr: Fix fall-through warning for Clang
9fc4abfe5a5f scsi: mpi3mr: Add event handling debug prints

Thanks,
Sumit

CVE References

Sumit Saxena (ssaxena)
summary: - [Ubuntu 22.04] mpt3sas: Request to include latest bug fix patches
- Edit[Ubuntu 22.04] mpi3mr: Request to include latest bug fixes
+ [Ubuntu 22.04] mpi3mr: Request to include latest bug fixes
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1967116

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Jeff Lane  (bladernr)
tags: added: servcert-230
Revision history for this message
Jeff Lane  (bladernr) wrote :
Download full text (3.3 KiB)

Linux Next
334ae6459aa3 scsi: mpi3mr: Fix flushing !WQ_MEM_RECLAIM events warning
22754f7fbb40 scsi: mpi3mr: Bump driver version to 8.0.0.68.0
d44b5fefb22e scsi: mpi3mr: Fix memory leaks
21401408ddeb scsi: mpi3mr: Update the copyright year
999224612724 scsi: mpi3mr: Fix reporting of actual data transfer size
b3911ab3a76e scsi: mpi3mr: Fix cmnd getting marked as in use forever
191a3ef58634 scsi: mpi3mr: Fix hibernation issue
04b27e538d50 scsi: mpi3mr: Update MPI3 headers
6d211f1d2635 scsi: mpi3mr: Fix printing of pending I/O count
580e6742205e scsi: mpi3mr: Fix deadlock while canceling the fw event

5.17 Mainline
3bb3c24e268a scsi: mpi3mr: Fix formatting problems in some kernel-doc comments
5867b8569e64 scsi: mpi3mr: Fix some spelling mistakes
c77b1f8a8fae scsi: mpi3mr: Bump driver version to 8.0.0.61.0
a91603a5d504 scsi: mpi3mr: Enhanced Task Management Support Reply handling
c86651345ca5 scsi: mpi3mr: Use TM response codes from MPI3 headers
afd3a5793fe2 scsi: mpi3mr: Add io_uring interface support in I/O-polled mode
95cca8d5542a scsi: mpi3mr: Print cable mngnt and temp threshold events
78b76a0768ef scsi: mpi3mr: Support Prepare for Reset event
c1af985d27da scsi: mpi3mr: Add Event acknowledgment logic
c5758fc72b92 scsi: mpi3mr: Gracefully handle online FW update operation
b64845a7d403 scsi: mpi3mr: Detect async reset that occurred in firmware
c0b00a931e5e scsi: mpi3mr: Add IOC reinit function
fe6db6151565 scsi: mpi3mr: Handle offline FW activation in graceful manner
59bd9cfe3fa0 scsi: mpi3mr: Code refactor of IOC init - part2
e3605f65ef69 scsi: mpi3mr: Code refactor of IOC init - part1
a6856cc4507b scsi: mpi3mr: Fault IOC when internal command gets timeout
2ac794baaec9 scsi: mpi3mr: Display IOC firmware package version
13fd7b1555b6 scsi: mpi3mr: Handle unaligned PLL in unmap cmnds
4f08b9637f63 scsi: mpi3mr: Increase internal cmnds timeout to 60s
ba68779a518d scsi: mpi3mr: Do access status validation before adding devices
17d6b9cf89cf scsi: mpi3mr: Add support for PCIe Managed Switch SES device
ec5ebd2c14a9 scsi: mpi3mr: Update MPI3 headers - part2
d00ff7c31195 scsi: mpi3mr: Update MPI3 headers - part1
fbaa9aa48bb4 scsi: mpi3mr: Don't reset IOC if cmnds flush with reset status
a83ec831b24a scsi: mpi3mr: Replace spin_lock() with spin_lock_irqsave()
9cf0666f34b1 scsi: mpi3mr: Add debug APIs based on logging_level bits

5.16 Mainline
30e99f05f8b1 scsi: mpi3mr: Use scnprintf() instead of snprintf()
1a30fd18f21b scsi: mpi3mr: Call scsi_done() directly
76a4f7cc5973 scsi: mpi3mr: Clean up mpi3mr_print_ioc_info()

Ubuntu-5.15.0 - no need to pull
97e6ea6d7806 scsi: mpi3mr: Fix duplicate device entries when scanning through sysfs
92cc94adfce4 scsi: mpi3mr: Use the proper SCSI midlayer interfaces for PI
69868c3b6939 scsi: mpi3mr: Use scsi_cmd_to_rq() instead of scsi_cmnd.request
aa0dc6a73309 scsi: mpi3mr: Fix W=1 compilation warnings
62e528b80d6b scsi: mpi3mr: Fix warnings reported by smatch
a254eae30b45 scsi: mpi3mr: Fix error return code in mpi3mr_init_ioc()
f9dc034d0402 scsi: mpi3mr: Fix missing unlock on error
2938bedd0efa scsi: mpi3mr: Fix error handling in mpi3mr_setup_isr()
d46bdecd9f3c scsi: mpi3mr: Delete unnecessary NULL check
d3d61f9c8c2d scsi...

Read more...

Revision history for this message
Jeff Lane  (bladernr) wrote :

This one is causing the kernel build to fail after pulling all of these into our 5.15 tree:

1a30fd18f21b scsi: mpi3mr: Call scsi_done() directly

Is there a missing patch in this set that perhaps sets up this one?

Revision history for this message
Jeff Lane  (bladernr) wrote :

Hi Sumit, could you please verify the test kernel here:
https://kernel.ubuntu.com/~kmously/kernel-kmously-2e0820d-jmN7/

Revision history for this message
Sumit Saxena (ssaxena) wrote :

Test driver testing went well. Please include the driver patches in the Ubuntu22.04 LTS.

Jeff Lane  (bladernr)
Changed in linux (Ubuntu):
status: Incomplete → In Progress
assignee: nobody → Jeff Lane (bladernr)
Revision history for this message
Jeff Lane  (bladernr) wrote :

This will hit the first SRU for 5.15.

Stefan Bader (smb)
Changed in linux (Ubuntu Jammy):
importance: Undecided → Medium
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux/5.15.0-28.29 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-jammy
Revision history for this message
Sumit Saxena (ssaxena) wrote :

Please include below commits also in the Ubuntu 22.04(5.15 kernel):

dde822e21700 scsi: mpi3mr: Update driver version to 8.0.0.69.0
04dfa01e77ea scsi: mpi3mr: Add support for NVMe passthrough
937a6f2c4f2e scsi: mpi3mr: Expose adapter state to sysfs
83959ce5204a scsi: mpi3mr: Add support for PEL commands
eb8a3217cd7d scsi: mpi3mr: Add support for MPT commands
455aac4f7a13 scsi: mpi3mr: Move data structures/definitions from MPI headers to uapi header
a212ebe7d4b1 scsi: mpi3mr: Add support for driver commands
7fbaf8b0d8b8 scsi: mpi3mr: Add bsg device support

Thanks,
Sumit

Revision history for this message
Sumit Saxena (ssaxena) wrote :

One more commit to be included:
ed567615f7ec scsi: mpi3mr: Fix build errors in uapi header scsi_bsg_mpi3mr.h

Revision history for this message
Jeff Lane  (bladernr) wrote : Re: [Bug 1967116] Re: [Ubuntu 22.04] mpi3mr: Request to include latest bug fixes
Download full text (5.3 KiB)

Hi Sumit,

Can you file a separate bug for these new patches? The original patch set
has been pulled and is in the process of being included in a kernel update
and at this point these should be part of a new request.

On Sun, May 1, 2022 at 20:16 Sumit Saxena <email address hidden>
wrote:

> One more commit to be included:
> ed567615f7ec scsi: mpi3mr: Fix build errors in uapi header
> scsi_bsg_mpi3mr.h
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1967116
>
> Title:
> [Ubuntu 22.04] mpi3mr: Request to include latest bug fixes
>
> Status in linux package in Ubuntu:
> In Progress
> Status in linux source package in Jammy:
> Fix Committed
>
> Bug description:
> Request to include below mpi3mr driver bug fix patches in Ubuntu 22.04
> kernel. These patches got accepted by the upstream and please find the
> corresponding commit IDs as below:
>
> 334ae6459aa3 scsi: mpi3mr: Fix flushing !WQ_MEM_RECLAIM events warning
> 22754f7fbb40 scsi: mpi3mr: Bump driver version to 8.0.0.68.0
> d44b5fefb22e scsi: mpi3mr: Fix memory leaks
> 21401408ddeb scsi: mpi3mr: Update the copyright year
> 999224612724 scsi: mpi3mr: Fix reporting of actual data transfer size
> b3911ab3a76e scsi: mpi3mr: Fix cmnd getting marked as in use forever
> 191a3ef58634 scsi: mpi3mr: Fix hibernation issue
> 04b27e538d50 scsi: mpi3mr: Update MPI3 headers
> 6d211f1d2635 scsi: mpi3mr: Fix printing of pending I/O count
> 580e6742205e scsi: mpi3mr: Fix deadlock while canceling the fw event
> 3bb3c24e268a scsi: mpi3mr: Fix formatting problems in some kernel-doc
> comments
> 5867b8569e64 scsi: mpi3mr: Fix some spelling mistakes
> c77b1f8a8fae scsi: mpi3mr: Bump driver version to 8.0.0.61.0
> a91603a5d504 scsi: mpi3mr: Enhanced Task Management Support Reply
> handling
> c86651345ca5 scsi: mpi3mr: Use TM response codes from MPI3 headers
> afd3a5793fe2 scsi: mpi3mr: Add io_uring interface support in I/O-polled
> mode
> 95cca8d5542a scsi: mpi3mr: Print cable mngnt and temp threshold events
> 78b76a0768ef scsi: mpi3mr: Support Prepare for Reset event
> c1af985d27da scsi: mpi3mr: Add Event acknowledgment logic
> c5758fc72b92 scsi: mpi3mr: Gracefully handle online FW update operation
> b64845a7d403 scsi: mpi3mr: Detect async reset that occurred in firmware
> c0b00a931e5e scsi: mpi3mr: Add IOC reinit function
> fe6db6151565 scsi: mpi3mr: Handle offline FW activation in graceful
> manner
> 59bd9cfe3fa0 scsi: mpi3mr: Code refactor of IOC init - part2
> e3605f65ef69 scsi: mpi3mr: Code refactor of IOC init - part1
> a6856cc4507b scsi: mpi3mr: Fault IOC when internal command gets timeout
> 2ac794baaec9 scsi: mpi3mr: Display IOC firmware package version
> 13fd7b1555b6 scsi: mpi3mr: Handle unaligned PLL in unmap cmnds
> 4f08b9637f63 scsi: mpi3mr: Increase internal cmnds timeout to 60s
> ba68779a518d scsi: mpi3mr: Do access status validation before adding
> devices
> 17d6b9cf89cf scsi: mpi3mr: Add support for PCIe Managed Switch SES device
> ec5ebd2c14a9 scsi: mpi3mr: Update MPI3 headers - part2
> d00ff7c31195 scsi: mpi3mr: Update MPI3 headers - part1
> fbaa9aa48...

Read more...

Revision history for this message
Sumit Saxena (ssaxena) wrote :

Hi Jeff,

I have filed bug: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1971151 for new patches.

Thank you.

-Sumit

Revision history for this message
Michael Reed (mreed8855) wrote :

Hi Sumit,

This bug is still in the verification-needed-jammy stage. Can you test it and then change the state of the bug to verification-done-jammy?

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-hwe-5.15/5.15.0-32.33~20.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Sumit Saxena (ssaxena) wrote :

Hi,

I have responded to bug: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1971151
Please help with the test kernel with BSG patches included.

Thanks,
Sumit

Revision history for this message
Sumit Saxena (ssaxena) wrote :

I have tested the kernel 5.15.0-32.33 with the patches mentioned in bug description.
Looks good.

tags: added: verification-done-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (101.7 KiB)

This bug was fixed in the package linux - 5.15.0-35.36

---------------
linux (5.15.0-35.36) jammy; urgency=medium

  * CVE-2022-21499
    - SAUCE: debug: Lock down kgdb

linux (5.15.0-34.35) jammy; urgency=medium

  * jammy/linux: 5.15.0-34.35 -proposed tracker (LP: #1974322)

  * AMD APU s2idle is broken after the ASIC reset fix (LP: #1972134)
    - drm/amdgpu: unify BO evicting method in amdgpu_ttm
    - drm/amdgpu: explicitly check for s0ix when evicting resources

  * amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x0000 to IRQ, err -517
    (LP: #1971597)
    - gpio: Request interrupts after IRQ is initialized

  * config CONFIG_HISI_PMU for kunpeng920 (LP: #1956086)
    - [Config] CONFIG_HISI_PMU=m

  * Mute/mic LEDs no function on EliteBook G9 platfroms (LP: #1970552)
    - ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops

  * network-manager/1.36.4-2ubuntu1 ADT test failure with linux/5.15.0-28.29
    (LP: #1971418)
    - Revert "rfkill: make new event layout opt-in"

  * PCIE LnkCtl ASPM not enabled under VMD mode for Alder Lake platforms
    (LP: #1942160)
    - SAUCE: vmd: fixup bridge ASPM by driver name instead

  * Mute/mic LEDs no function on HP EliteBook 845/865 G9 (LP: #1970178)
    - ALSA: hda/realtek: Enable mute/micmute LEDs and limit mic boost on EliteBook
      845/865 G9

  * Enable headset mic on Lenovo P360 (LP: #1967069)
    - ALSA: hda/realtek: Enable headset mic on Lenovo P360

  * WCN6856 BT keep in OFF state after coldboot system (LP: #1967067)
    - Bluetooth: btusb: Improve stability for QCA devices

  * Screen sometimes can't update [Failed to post KMS update: CRTC property
    (GAMMA_LUT) not found] (LP: #1967274)
    - drm/i915/xelpd: Enable Pipe color support for D13 platform
    - drm/i915: Use unlocked register accesses for LUT loads
    - drm/i915/xelpd: Enable Pipe Degamma
    - drm/i915/xelpd: Add Pipe Color Lut caps to platform config

  * Jammy update: v5.15.35 upstream stable release (LP: #1969857)
    - drm/amd/display: Add pstate verification and recovery for DCN31
    - drm/amd/display: Fix p-state allow debug index on dcn31
    - hamradio: defer 6pack kfree after unregister_netdev
    - hamradio: remove needs_free_netdev to avoid UAF
    - cpuidle: PSCI: Move the `has_lpi` check to the beginning of the function
    - ACPI: processor idle: Check for architectural support for LPI
    - ACPI: processor: idle: fix lockup regression on 32-bit ThinkPad T40
    - btrfs: remove unused parameter nr_pages in add_ra_bio_pages()
    - btrfs: remove no longer used counter when reading data page
    - btrfs: remove unused variable in btrfs_{start,write}_dirty_block_groups()
    - soc: qcom: aoss: Expose send for generic usecase
    - dt-bindings: net: qcom,ipa: add optional qcom,qmp property
    - net: ipa: request IPA register values be retained
    - btrfs: release correct delalloc amount in direct IO write path
    - ALSA: core: Add snd_card_free_on_error() helper
    - ALSA: sis7019: Fix the missing error handling
    - ALSA: ali5451: Fix the missing snd_card_free() call at probe error
    - ALSA: als300: Fix the missing snd_card_free() call at probe error
    - ALSA: als4000: Fix ...

Changed in linux (Ubuntu Jammy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers