Thinkpad E14 Gen2: Kernel panic with trackpad and trackpoint enabled

Bug #1945590 reported by Pietro Mingo
382
This bug affects 65 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
Critical
Andrea Righi
Impish
Fix Released
Critical
Andrea Righi
Jammy
Fix Released
Critical
Andrea Righi

Bug Description

[Impact]

On some thinkpads we may get a kernel panic at boot, because the elantech driver (trakcpad) can trigger out-of-bounds access in the stack.

[Test case]

Simply boot the kernel on one of the affected systems (e.g., Thinkpad E14 Gen2).

[Fix]

Prevent the stack out of bound access by applying the following upstream commit (from linux-next):

1d72d9f960cc ("Input: elantech - fix stack out of bound access in elantech_change_report_id()")

[Regression potential]

The fix is touching the elantech driver, so we could only see regressions with this specific trackpad/mouse driver.

[Original bug report]

I installed the Ubuntu 21.10 beta and as soon as I boot I get the kernel panic that I am attaching.

I also installed Ubuntu 21.04 and upgraded, as soon as I boot with the 5.13 kernel I get the same problem, disabling the trackpad and trackpoint in the bios the problem disappears.

Everything works with the 5.11 kernel.
I remain available for further details and sorry for my lack of experience.

ProblemType: Bug
DistroRelease: Ubuntu 21.10
Package: linux-image-5.13.0-16-generic 5.13.0-16.16
ProcVersionSignature: Ubuntu 5.13.0-16.16-generic 5.13.13
Uname: Linux 5.13.0-16-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.11-0ubuntu69
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: pietro 1810 F.... pulseaudio
CasperMD5CheckResult: pass
CurrentDesktop: ubuntu:GNOME
Date: Thu Sep 30 10:26:10 2021
InstallationDate: Installed on 2021-09-29 (0 days ago)
InstallationMedia: Ubuntu 21.04 "Hirsute Hippo" - Release amd64 (20210420)
MachineType: LENOVO 20TA0033IX
ProcEnviron:
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=it_IT.UTF-8
 SHELL=/bin/bash
ProcFB: 0 i915drmfb
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-5.13.0-16-generic root=UUID=b5ea9465-4cd9-408b-8e30-458acf90181b ro quiet splash vt.handoff=7
RelatedPackageVersions:
 linux-restricted-modules-5.13.0-16-generic N/A
 linux-backports-modules-5.13.0-16-generic N/A
 linux-firmware 1.201
SourcePackage: linux
UpgradeStatus: Upgraded to impish on 2021-09-29 (0 days ago)
dmi.bios.date: 09/02/2021
dmi.bios.release: 1.43
dmi.bios.vendor: LENOVO
dmi.bios.version: R1EET43W(1.43 )
dmi.board.asset.tag: Not Available
dmi.board.name: 20TA0033IX
dmi.board.vendor: LENOVO
dmi.board.version: SDK0J40697 WIN
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: None
dmi.ec.firmware.release: 1.43
dmi.modalias: dmi:bvnLENOVO:bvrR1EET43W(1.43):bd09/02/2021:br1.43:efr1.43:svnLENOVO:pn20TA0033IX:pvrThinkPadE14Gen2:skuLENOVO_MT_20TA_BU_Think_FM_ThinkPadE14Gen2:rvnLENOVO:rn20TA0033IX:rvrSDK0J40697WIN:cvnLENOVO:ct10:cvrNone:
dmi.product.family: ThinkPad E14 Gen 2
dmi.product.name: 20TA0033IX
dmi.product.sku: LENOVO_MT_20TA_BU_Think_FM_ThinkPad E14 Gen 2
dmi.product.version: ThinkPad E14 Gen 2
dmi.sys.vendor: LENOVO

CVE References

Revision history for this message
Pietro Mingo (skar395) wrote :
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Status changed to Confirmed

This change was made by a bot.

Changed in linux (Ubuntu):
status: New → Confirmed
Pietro Mingo (skar395)
no longer affects: linux
Revision history for this message
Andrea Righi (arighi) wrote :

@Pietro, thanks for reporting this.

Can you do a test with the kernel that is currently in impish-proposed (5.13.0-18.18)? See https://wiki.ubuntu.com/Testing/EnableProposed on how to enable proposed (for this you need to upgrade from 21.04, then enable proposed, install 5.13.0-18.18, then reboot). Thanks!

Revision history for this message
Pietro Mingo (skar395) wrote :

@Andrea
I just tried, the difference is I don't get an error message like before, but the PC gets stuck with the Lenovo logo with no sign of loading, I couldn't see any output.
I went back to kernel 5.11, I remain available for other tests

Revision history for this message
Andrea Righi (arighi) wrote :

ok, another interesting test to do would be to see what happens with a mainline kernel (just to see if the problem is a mainline issue or if it's limited to the Ubuntu kernel).

Can you try to do a test with this kernel?

https://kernel.ubuntu.com/~kernel-ppa/mainline/v5.13.19/

^ This is basically the latest 5.13 mainline kernel with the Ubuntu config, but no special Ubuntu patches applied.

Revision history for this message
Pietro Mingo (skar395) wrote :

@Andrea
Just this morning I installed Mainline (https://github.com/bkw777/mainline) to install the latest available kernel, the problem is that with SecureBoot I can't boot because the kernel is not signed.
How can I do?

Revision history for this message
Andrea Righi (arighi) wrote :

Maybe disable secure boot from the BIOS? Test kernels can't be signed, so I guess that's the only way...

Revision history for this message
Pietro Mingo (skar395) wrote :

@Andrea I have disabled secure boot and tried mainline kernel 5.13.19 and 5.14.10, same kernel panic

Revision history for this message
Andrea Righi (arighi) wrote :

OK, so at least we know that it's a mainline issue. I'll investigate a bit and will keep you informed. Thank you so much for all the tests!

1 comments hidden view all 152 comments
Revision history for this message
Stephan (sphrases) wrote :

@Andrea,

not sure if it helps to investigate. I have same issue on my E14 Gen2
with ubuntu 21.10

5.14.10-051410 (mainline) -> kernel panic
5.14.9-051409 (mainline) -> kernel panic
5.13.0-18 (impish) -> kernel panic
5.13.0-17 (impish) -> kernel panic
5.11.0-38 the last working one

Stephan

Revision history for this message
Pietro Mingo (skar395) wrote :

Thanks to you!

1 comments hidden view all 152 comments
Revision history for this message
Benjamin Stanger (stbe1014) wrote :

I just want to confirm this problem also with impish-proposed kernel, same hardware here and exactly same situation.

Revision history for this message
Andrea Righi (arighi) wrote :

Looking at the oops it seems that the stack gets corrupted inside elantech_change_report_id(), that is defined in drivers/input/mouse/elantech.c.

According to Stephan it seems that 5.11 is the last kernel that seems to work.

If we look at the changes between 5.11 and 5.13 that are touching drivers/input/mouse/elantech.c there's only one commit:

  9d383e96448dbfdd97a37e618f6af5a17a60ce0d ("Input: elantech - Prepare a complete software node for the device")

It'd be interesting to revert this commit in the latest 5.13 and see if the problem goes away.

I'll prepare a test kernel later (if you haven't done it already).

Revision history for this message
Andrea Righi (arighi) wrote (last edit ):

Edit: wrong patch ignore this.

Revision history for this message
Andrea Righi (arighi) wrote :

Hm.. it's not trivial to revert that commit, because it depends on other subsystem changes. I was thinking that we may actually corrupt the stack because elantech_create_smbus() is using too much stack. How about allocating that i2c_props array in the heap. See the patch in attach.

Revision history for this message
Andrea Righi (arighi) wrote :

Test kernel is available here, if you want to give it a try:

https://kernel.ubuntu.com/~arighi/lp1945590/

Thanks!

Changed in linux (Ubuntu Impish):
assignee: nobody → Andrea Righi (arighi)
importance: Undecided → High
tags: added: patch
Revision history for this message
Pietro Mingo (skar395) wrote :

I have downloaded all the files and tried to install them but I have these errors:
There were errors in processing:
 linux-cloud-tools-5.13.0-19-generic
 linux-headers-5.13.0-19-generic
 linux-tools-5.13.0-19-generic

dpkg: error in processing the package linux-tools-5.13.0-19-generic (--install):
problems with dependencies - left unconfigured

I don't know if this can cause problems, I tried the kernel but I am stuck with the Lenovo logo without errors

Revision history for this message
Benjamin Stanger (stbe1014) wrote (last edit ):

After installation same situation for me, i've attached a photo of the output. It's really weird: On some boots i am stuck also just at the Lenovo Logo without any more possibillities, on other try of boot, i've got the kernel panic. Even if i disable trackpad and touchpad, but if disabled sometimes the notebooks is booting normal.

What seems to work is turn on Notebook, go to BIOS, don't change anything but save with F10 and then reboot.
Notebook boots normal without error. But if i turn it off and on again -> kernel panic.

Revision history for this message
Pietro Mingo (skar395) wrote :

@Benjamin Your trick does not seem to work for me

Revision history for this message
Stephan (sphrases) wrote :

After installing test kernel it turns out, that

"linux-cloud-tools-5.13.0-19-generic" is missing "linux-cloud-tools-5.13.0-19"
"linux-tools-5.13.0-19-generic" is missing "linux-tools-5.13.0-19"

Revision history for this message
Andrea Righi (arighi) wrote :

You just need to install linux and linux-modules (sorry I wasn't very clear). But it looks like my patch didn't make any difference.

I'll investigate a bit more. Thanks for testing!

Revision history for this message
Reinhard Enders (randombop) wrote :

Same for me (Thinkpad E15 Gen3)
The last kernel that worked was 5.12.19-051219-generic
(which I need to make wifi work)

Revision history for this message
Reinhard Enders (randombop) wrote :

5.13.8-051308-generic still boots ok, but
5.13.9-051309-generic fails

Revision history for this message
Pietro Mingo (skar395) wrote :

I can confirm also for me 5.13.8-051308-generic boots ok

1 comments hidden view all 152 comments
Revision history for this message
Matthew Ruffell (mruffell) wrote :

Hi Andrea,

Chris Chu mentioned it might be caused by `-fcf-protection=none`

in https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1941773/comments/19

Maybe should try a build without that flag?

I went and added all the duplicates to this bug, there is some more information in some of them.

Thanks,
Matthew

Revision history for this message
elguavas (elguavas.) wrote :

hi all, exactly the same issue here. this is on a Thinkpad E15 Gen 2 (AMD) which is the same hardware as the E14 in the bug title (with just a larger screen).

i also get alternately the "stack corruption" in the elantech driver message or freezing on the Lenovo logo, as mentioned above. this is since upgrading to 21.10.

the machine in question was booting fine on 21.04 with the latest kernel updates.

Revision history for this message
elguavas (elguavas.) wrote :

oh, i should mention i tried running the 21.10 installer on the same machine and (as expected) since no-one would know to disable their trackpad before trying to install, this bug effectively makes 21.10 uninstallable on this hardware, so for installation purposes i'd call the bug critical.

Revision history for this message
randomdave (randomdave) wrote :

Impish is now released but this problem persists in
linux-image-5.13.0-19-generic. Any idea when this will be fixed?

This isn't urgent because the kernel at https://people.canonical.com/~mschiu77/lp1941773/I/ is working for me for now on my Thinkpad E15 Gen 2 (AMD).

Revision history for this message
elguavas (elguavas.) wrote :

> This isn't urgent because the kernel at https://people.canonical.com/~mschiu77
> /lp1941773/I/ is working for me for now on my Thinkpad E15 Gen 2 (AMD).

why does a working non-standard kernel mean it's not urgent? this is urgent, and for the installer, critical, until a fix is released in the official distribution kernel.

Revision history for this message
randomdave (randomdave) wrote :

Good point. I stand corrected.

Revision history for this message
Atilla Birer (birera) wrote :

I also confirm this bug on the bootable USB installer on Thinkpad E15 Gen 2, it kernel panics into the elantech error mentioned.

Revision history for this message
DOA (daoangio) wrote :

hi all, exactly the same issue here. this is on a Thinkpad E14 Gen 2 (AMD)

Revision history for this message
as (ip413as3) wrote :

The same issue on Thinkpad E14 gen2 AMD with kernel 5.13.0.19.30. Kernel 5.11.0-38 is ok.

Revision history for this message
elguavas (elguavas.) wrote (last edit ):

@arighi hi Andrea, any update on where this is going? is there anything else we can do to test or provide extra info? even "still investigating" would be good to know. ;) cheers.

Revision history for this message
Alvaro (alvarodelcastillo) wrote :

I have only the buggy kernel 5.13 for booting in my Lenovo laptop, so I can not boot at all into the system.

If you have the same problem, you can avoid loading the psmouse adding to the kernel boot params:

modprobe.blacklist=psmouse

and at least you can boot the system and use it to install a new kernel once the problem is fixed.

Revision history for this message
elguavas (elguavas.) wrote :

you can also just disable the trackpad in the bios settings.

then enable it again when a fixed kernel is available.

bit of a super pita having a laptop with no trackpad though, ;) and for people running the installer (who would have no reason to know to disable their trackpad or apply boot params in advance) they just see that the installer crashes and wont run.

Revision history for this message
Marco De Felice (marco-098) wrote (last edit ):

I have the same issue on my ThinkPad E14 Gen 2 Type 20TA with the latest firmware.

Just wanted to add that the proposed workaround of disabling psmouse (via boot options or via disabling in bios) is not working for me.

Also tried the kernel at https://people.canonical.com/~mschiu77/lp1941773/I/ but this too is not working.

I have a zfs encripted filesystem, when I boot normally I get the same error others are getting.

When I boot with modprobe.blacklist=psmouse I can go past the previous error and get to the point where the system asks for the password to decrypt the filesystem, but then I get a different error (picture attached)

edit: looks like it's hitting zfs bug https://bugs.launchpad.net/ubuntu/+source/zfs-linux/+bug/1906476

Revision history for this message
Ahmet Yıldırım (regenx) wrote :

I returned to kernel 5.11 because of this problem.

I hope that it will be fixed as soon as possible.

Revision history for this message
Claudio Romeo (registrazioni-h) wrote :

I got the same kernel panic error showed in the "S13 kernel panic" image by Pietro Mingo (skar395).
I workarounded the problem by entering the BIOS and disabling the trackpoint.
The trackpad can remain active.
This is not a solution, but it works.
Please, forgive my bad English

Kenth K (kenth-kvien)
Changed in linux (Ubuntu):
assignee: Andrea Righi (arighi) → Kenth K (kenth-kvien)
assignee: Kenth K (kenth-kvien) → nobody
Andrea Righi (arighi)
Changed in linux (Ubuntu Jammy):
assignee: nobody → Andrea Righi (arighi)
Andrea Righi (arighi)
Changed in linux (Ubuntu Impish):
importance: High → Critical
Changed in linux (Ubuntu Jammy):
importance: High → Critical
Andrea Righi (arighi)
description: updated
Changed in linux (Ubuntu Impish):
status: Confirmed → Fix Committed
Changed in linux (Ubuntu Impish):
status: Fix Committed → Fix Released
Peter Antoniac (pan1nx)
Changed in linux (Ubuntu Impish):
status: Fix Released → Fix Committed
Gaurav Negi (g2440)
Changed in linux (Ubuntu Impish):
status: Fix Committed → Fix Released
Peter Antoniac (pan1nx)
Changed in linux (Ubuntu Impish):
status: Fix Released → Fix Committed
72 comments hidden view all 152 comments
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux/5.13.0-24.24 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-impish' to 'verification-done-impish'. If the problem still exists, change the tag 'verification-needed-impish' to 'verification-failed-impish'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-impish
Revision history for this message
elguavas (elguavas.) wrote :

just tested the 5.13.0-24.24 kernel from proposed, it does NOT fix the problem on my ThinkPad E15 AMD Gen 2, this kernel just freezes at the Lenovo logo like all the other broken kernels.

The 5.13.0-22-generic_5.13.0-22.22+arighi20211110+1 kernel still works flawlessly.

what's going on? i thought this new kernel had the same fix as the working one? what has gone wrong here?

Revision history for this message
Ben E-10 (bttksz) wrote (last edit ):

linux/5.13.0-24.24 proposed fixed it for me on a ThinkPad L13 Gen.2 (non-Yoga)
I had to install the linux-modules-extra to get wifi to work as well.

I just changed from fedora to ubuntu three weeks ago (after an unwanted ssd replacement) and can now finally use my ubuntu notebook as it is supposed to be used (without an external mouse)

thanks

Revision history for this message
Yves Roggeman (yrogge) wrote :

I also just installed 5.13.0-24 version from impish-proposed repository on a Lenovo ThinkPad E15 Gen.2.
Everything looks now perfect.
Thank you for the working patch.
Do I have anything more to do, as suggested by #113, or is every now OK?
Have a good day.

Yves Roggeman (yrogge)
tags: added: verification-done-impish
removed: verification-needed-impish
Revision history for this message
seo suchan (abnoeh) wrote :

installed 5.13.0-24 on lenovo thinkpad e14 amd gen 2 (20TA) 4500u and it boots.
P.S I thought this would collide with secure boot (because installing it removed linux-generic-signed) but actually it didn't. is kernels in proposed already signed for secure boot?

Revision history for this message
elguavas (elguavas.) wrote :

ok, well glad to see this is working for others.

now, how can i get extra information about the failed boot to find out why this kernel does NOT work for me but kernel 5.13.0-22-generic_5.13.0-22.22+arighi20211110+1 DOES work for me?

one note: i applied the latest lenovo bios update which came out just a couple of weeks ago for ThinkPad E15/14 AMD Gen 2 machines, can anyone here, who the new kernel works for, please confirm they are using the latest bios??

Revision history for this message
elguavas (elguavas.) wrote :

just to be clear, the updated bios shows as: R1AET40W (1.16) in the bios setup screen.

can someone, who the new kernel works for, please confirm that they are on this new bios version??

thanks in advance.

Revision history for this message
elguavas (elguavas.) wrote :

ok, pleased to report that i did a forced reinstall of the new kernel from proposed and it is now working fine on my E15 AMD Gen2. don't know what went wrong the first time but glad the fix is good.

apologies for the static. don't need anyone to check bios versions anymore. cheers.

Revision history for this message
seo suchan (abnoeh) wrote :

while 5.13.0-24 in impush proposed has the fix, 5.13.0-25 security patch just updated doesn't have it and cause crash

Revision history for this message
Amit Aronovitch (aronovitch) wrote :

(a) confirmed: -25 does not include the patch (kernel panic on E14 G2).

In impish git repo, master (tagged -25) is branching out of -23. Whereas -24 tag is still in `master-next` branch.

(b) I cannot find -24 in proposed. Actually, looking right now, it seems like the whole `binary-amd64` section is missing (here: http://ports.ubuntu.com/ubuntu-ports/dists/impish-proposed/main/ ).

Revision history for this message
Yves Roggeman (yrogge) wrote :

Sadly, indeed, the new "security" -25 version seems to be a regression from the "proposed" one.
How is it possible?

I confirm that the -25 version doesn't boot on a Lenovo ThinkPad E15 G2.
And classically, the proposed version disappears when it is superseded by another one.
Hopefully, I had marked it in a "hold" status.

I thought that the patch was OK and definitely integrated. What happened? Who decided to suppress it?
There is an obvious problem with the version management in the Ubuntu Linux kernel.

Please consider to correct all this poor bad process!

Revision history for this message
Stefan K (stko) wrote (last edit ):

Same on my side. Kernel Version -25 does not boot on ThinkPad E14 Gen3 and is stuck on Lenovo screen. Version -24 works as expected.

1 comments hidden view all 152 comments
Revision history for this message
Amit Aronovitch (aronovitch) wrote :

@yrogge re: How is it possible:

I am not familiar with Ubuntu process, but it is common practice that security updates have high priority, and if there is something urgent enough, the release process should have a way to make a "hotfix" release directly from the previous one, before the (ongoing) review process of the "next master" is done.

(the changelog does not seem too urgent, but who knows - no idea what those issues were... https://launchpad.net/ubuntu/+source/linux/5.13.0-25.26)

Probably the current "master-next" branch (which includes this fix) will have to be rebased/merged on top of the new master (-25) and maybe get a new tag "...-26" or something.

However, I am a little concerned that I cannot find the -24.24 kernel in the proposed repo. Robot message above said it needs to be confirmed in 5 days, but people need to be able to DL it to confirm.
Maybe they will re-add it after it gets a new tag as -26 ? We may need some input from ubuntu devs...

Revision history for this message
Yves Roggeman (yrogge) wrote :

@aronovitch:

Thanks for your explanation.
I hope that somebody will confirm the patch with the correct privileges before -26 freeze.

Maybe there is some rule as "ThinkPad users have to use only even versions, never odd ones" ;-)

Revision history for this message
elguavas (elguavas.) wrote :

yes this is a real mess.

@yrogge according to the kernel bot message when you removed the verification-needed-impish tag and added the verification-done-impish tag that should have been what "confirmed" the fix to be included.

so please, can @arighi the bug assignee, or some other ubuntu person please fix this and get the now well-confirmed fix into a released kernel asap?? thanks.

Revision history for this message
Christo (christogoosen) wrote :

Not a long term fix but just proposing this as this saved me from not booting in pop_os! 21.10.

Disable either the trackpad or trackpoint in BIOS. I disabled my trackpoint and I am able to boot again.

Just so that other users who end up here have some temporary workaround, as to update the kernel to fix this requires booting off usb or with this method.

Revision history for this message
Amit Aronovitch (aronovitch) wrote :

I see people here had been testing -24 kernel, but I do not find it in impish-proposed (in fact, I find only 21,22 & 23 there. Not even 25 which was already released).

Am I looking in the wrong place ( http://archive.ubuntu.com/ubuntu/dists/impish-proposed/ ), or was it removed from there?

Note that in git repo I see that there is already a tag `Ubuntu-5.13.0-26.27` under `master-next` branch. Is that kernel available for testing anywhere?

Revision history for this message
elguavas (elguavas.) wrote (last edit ):

the fix was in *-24 in proposed and it worked and was confirmed, then *-25 was released _without_ the fix, making *-24 redundant (it's gone now).

the bug assignee is mia (probably well deserved seasonal holiday). can someone on the ubuntu kernel team: _please_ fix this mess. the fix in *-24 was confirmed, we need it put in a _released_ kernel!

also the workaround of turning off trackpoint/trackpad was mentioned several times earlier in this bug history. if you search for it or click "See full activity log" at the bottom of the page you will find it there.

Revision history for this message
Ben E-10 (bttksz) wrote :

For me it looks like it is fixed in ppa 5.13.0-26.27
see: https://www.ubuntuupdates.org/package/canonical_kernel_team/impish/main/base/linux
But I don't know if this means it is going to be fixed in the next main update.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 5.15.0-17.17

---------------
linux (5.15.0-17.17) jammy; urgency=medium

  * jammy/linux: 5.15.0-17.17 -proposed tracker (LP: #1957809)

 -- Andrea Righi <email address hidden> Thu, 13 Jan 2022 17:11:21 +0100

Changed in linux (Ubuntu Jammy):
status: Confirmed → Fix Released
Revision history for this message
elguavas (elguavas.) wrote :

So the kernel in jammy has the fix released, well fine. but where is the the fixed released kernel for impish!!

1 comments hidden view all 152 comments
Revision history for this message
bgiac (foliestere) wrote :

I just updated impish to the kernel 5.13.0-27 and the problem persists: system doesn't boot, kernel panic.
It only boots with the kernel 5.13.0-24.
I'm on a thinkpad E14 Gen 2 AMD.

Revision history for this message
elguavas (elguavas.) wrote :

yes, there is still no released kernel with the fix for impish.

Revision history for this message
Amit Aronovitch (aronovitch) wrote :

Indeed -27 does not contain the fix.

We can find the release notes for specific package in https://launchpad.net/ubuntu/+source/linux (in this case https://launchpad.net/ubuntu/+source/linux/5.13.0-27.29), and see if it contains the relevant patch. For this bug, we should find a line with "elantech", probably like this:

`Input: elantech - fix stack out of bound access in elantech_change_report_id()`

Also, thanks @bttksz for pointing to the kernel-team PPA :-)

I was not finding up-to-date "master-next" kernels to try, since it appears they were removed from ubuntu-proposed, but now I can use this to easily check for upcoming kernels (already have -28 there). To set it up I used:

1. `sudo add-apt-repository ppa:canonical-kernel-team/ppa`

2. Since I want to avoid auto-installing the packages from there, and just have them available for manual installation, I also set low priority to this repo:
```
cat >/etc/apt/preferences.d/ubuntu-kernel-ppa-updates <<EOF
# Configure apt for manual-only installs of packages from kernel-team-ppa
Package: *
Pin: release o=LP-PPA-canonical-kernel-team
Pin-Priority: 70
EOF
```

Revision history for this message
Yves Roggeman (yrogge) wrote :

Good news of the day:
There exist now a new released kernel for impish that works perfectly with a ThinkPad E15 G2.
Version 5.13.0-28 is now on impish-proposed repository.
Feel free to install it and enjoy.
Note: don’t forget to mark it as "hold" in your system after install, because it can disappear in a few days, as experimented with 5.13.0-24.

Revision history for this message
Alex D (zviryatko) wrote :

I was able to fix it for Pop!_Os 21.10 only with 5.16.1 kernel, the model is ThinkPad E14 G2 (20ta002grt), updates to any 5.15 didn't help me.

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oem-5.14/5.14.0-1021.23 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Yves Roggeman (yrogge) wrote :

@arighi
Please urgently answer to message #141 changing the tag AND CONFIRM IT.
See message #128: I have done it for previous proposed version, but I'm allowed to confirm, and the patch was removed from new version.
This seems to be the only way to stop this devil cycle fix-unfix.
Thank you.

Revision history for this message
Atilla Birer (birera) wrote :

Wow, decided to come back to this thread out of curiosity after 4 months, still not solved haha

I guess this is a testament to rolling release and having good active maintainers like they have in Arch and OpenSUSE Tumbleweed, things just get fixed and pushed. I will continue using Arch for now.

Revision history for this message
Jan Gerrit (jg-burg-borgholz) wrote :

Hi,
I've tested current proposed kernel 5.13.0-28-generic on Thinkpad E14 Gen2, Kubuntu 21.10.
All working fine, problem seems to be solved.
Greetings, Jan Gerrit

Revision history for this message
Andrea Righi (arighi) wrote :

The impish kernel is already fixed and the fix is applied to the current kernel in released. Comment #142 is referring to linux-oem-5.14 in focal, that also has the fix, so it can be ignored.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Yves Roggeman (yrogge) wrote :

@arighi
Thanks

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (74.6 KiB)

This bug was fixed in the package linux - 5.13.0-28.31

---------------
linux (5.13.0-28.31) impish; urgency=medium

  * amd_sfh: Null pointer dereference on early device init causes early panic
    and fails to boot (LP: #1956519)
    - HID: amd_sfh: Fix potential NULL pointer dereference

  * impish: ddebs build take too long and times out (LP: #1957810)
    - [Packaging] enforce xz compression for ddebs

  * audio mute/ mic mute are not working on a HP machine (LP: #1955691)
    - ALSA: hda/realtek: fix mute/micmute LEDs for a HP ProBook

  * rtw88_8821ce causes freeze (LP: #1927808)
    - rtw88: Disable PCIe ASPM while doing NAPI poll on 8821CE

  * alsa/sdw: fix the audio sdw codec parsing logic in the acpi table
    (LP: #1955686)
    - ALSA: hda: intel-sdw-acpi: harden detection of controller
    - ALSA: hda: intel-sdw-acpi: go through HDAS ACPI at max depth of 2

  * icmp_redirect from selftests fails on F/kvm (unary operator expected)
    (LP: #1938964)
    - selftests: icmp_redirect: pass xfail=0 to log_test()

  * Impish update: upstream stable patchset 2021-12-17 (LP: #1955180)
    - arm64: zynqmp: Do not duplicate flash partition label property
    - arm64: zynqmp: Fix serial compatible string
    - ARM: dts: sunxi: Fix OPPs node name
    - arm64: dts: allwinner: h5: Fix GPU thermal zone node name
    - arm64: dts: allwinner: a100: Fix thermal zone node name
    - staging: wfx: ensure IRQ is ready before enabling it
    - ARM: dts: NSP: Fix mpcore, mmc node names
    - scsi: lpfc: Fix list_add() corruption in lpfc_drain_txq()
    - arm64: dts: rockchip: Disable CDN DP on Pinebook Pro
    - arm64: dts: hisilicon: fix arm,sp805 compatible string
    - RDMA/bnxt_re: Check if the vlan is valid before reporting
    - bus: ti-sysc: Add quirk handling for reinit on context lost
    - bus: ti-sysc: Use context lost quirk for otg
    - usb: musb: tusb6010: check return value after calling
      platform_get_resource()
    - usb: typec: tipd: Remove WARN_ON in tps6598x_block_read
    - ARM: dts: ux500: Skomer regulator fixes
    - staging: rtl8723bs: remove possible deadlock when disconnect (v2)
    - ARM: BCM53016: Specify switch ports for Meraki MR32
    - arm64: dts: qcom: msm8998: Fix CPU/L2 idle state latency and residency
    - arm64: dts: qcom: ipq6018: Fix qcom,controlled-remotely property
    - arm64: dts: freescale: fix arm,sp805 compatible string
    - ASoC: SOF: Intel: hda-dai: fix potential locking issue
    - clk: imx: imx6ul: Move csi_sel mux to correct base register
    - ASoC: nau8824: Add DMI quirk mechanism for active-high jack-detect
    - scsi: advansys: Fix kernel pointer leak
    - ALSA: intel-dsp-config: add quirk for APL/GLK/TGL devices based on ES8336
      codec
    - firmware_loader: fix pre-allocated buf built-in firmware use
    - ARM: dts: omap: fix gpmc,mux-add-data type
    - usb: host: ohci-tmio: check return value after calling
      platform_get_resource()
    - ARM: dts: ls1021a: move thermal-zones node out of soc/
    - ARM: dts: ls1021a-tsn: use generic "jedec,spi-nor" compatible for flash
    - ALSA: ISA: not for M68K
    - tty: tty_buffer: Fix the softlockup issue in flush_to_ldisc
    - MIPS: sni:...

Changed in linux (Ubuntu Impish):
status: Fix Committed → Fix Released
Revision history for this message
Diana (dianaraz) wrote :

Thanks so much for this!!

Revision history for this message
Guillaume C. (cguille+) wrote :

Thank you very much! Works for me on ThinkPad E15 Gen 2.

Revision history for this message
Christian Hoffmann (christian9442) wrote :

Thanks a bunch. It also works on a ThinkPad E14 Gen 2 with Ryzen 7 4700u and AMD Renoir.

When I started with the new kernel I first had graphics issues. No animations, only internal monitor working, black screen after sleep. That was caused by a missing graphics driver. Software Updater suggested me to install some kernel headers for 5.13.0. After installing them and rebooting everything works perfectly now. Maybe I've installed the kernel in a strange way. (just a hint if someone else has this issue)

Revision history for this message
elguavas (elguavas.) wrote :

yes, great we finally got there. thumbs up.

works on my e15 gen 2 amd.

Revision history for this message
Mark Harfouche (mark-harfouche) wrote :

Just updated to 22.04 and seems like the 5.15.0-27-generic is working well with the touchpad.

Thank you all for your hard work

Displaying first 40 and last 40 comments. View all 152 comments or add a comment.