Comment 5 for bug 1929035

Revision history for this message
Frank Heimes (fheimes) wrote :

(repeating my comment from LP#1929060)
Well, if commits are provided here, we expect that they make up the functionality described by the title and bug description, and can be taken as they are (cherry-picked) - and in case not, a backport would be needed.

We cannot just pick all the commits up to a certain date - it's (very) unlikely that this will be acceptable by our kernel team (who reviews all submissions in detail).

What's required (for a patch here, or for an sru) is a minimal set of patches that make up a logical functional unit (like here at the title: "SMC-R v2 Support").
The code also needs to be upstream accepted (that's the case here) and in case of s390x code, it needs to be signed-off by you (actually by IBM, at the commit level - as usual), pre-tested - there must be confidence about the patch set - and the willingness to help maintaining it.

And for the reason of maintenance it's not desired to smash multiple functions addressed in different LP bugs again into one big submission.

(Please notice that we discuss adding code to an upcoming LTS release that will need to be supported by up to 10 years.)