[SRU] mpt3sas: only one vSES is handy even IOC has multi vSES

Bug #1926517 reported by Michael Reed
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Undecided
Unassigned
Focal
Undecided
Unassigned
Groovy
Undecided
Unassigned
Hirsute
Undecided
Unassigned

Bug Description

[Impact]
Whenever the driver is adding a vSES to virtual-phys list it is
reinitializing the list head. Hence those vSES devices which were added
previously are lost.

[FIXES]

Stop reinitializing the list every time a new vSES device is added.

https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?id=4c51f9569651

CommitID: 4c51f956965120b3441cdd39c358b87daba13e19

[TESTING]

Load the mpt3sas driver on the system where Brodcom's HBA 9500 Tri-Mode Storage Adapter (IT HBA Aero/Ventura) is connected to two backplanes (so that two vSES device get configured on the HBA). After loading the driver user should able to access both the vSES devices. Also even after performing host reset operation user must able to access both the vSES devices.
i.e. lsscsi must list both the vSES devices after loading the driver and also after performing host reset operation.

[REGRESSION RISK]

There is no regression risk with this bug fix patch.

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1926517

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Revision history for this message
Michael Reed (mreed8855) wrote : Re: mpt3sas: only one vSES is handy even IOC has multi vSES
summary: - mpt3sas: only one vSES is handy even IOC has multi vSES
+ [SRU] mpt3sas: only one vSES is handy even IOC has multi vSES
Revision history for this message
Michael Reed (mreed8855) wrote :
Revision history for this message
Sreekanth Reddy (srreddy) wrote :

Here I am updating [TESTING] & [REGRESSION RISK] sections from bug description page,

[TESTING]
Load the mpt3sas driver on the system where Brodcom's HBA 9500 Tri-Mode Storage Adapter (IT HBA Aero/Ventura) is connected to two backplanes (so that two vSES device get configured on the HBA). After loading the driver user should able to access both the vSES devices. Also even after performing host reset operation user must able to access both the vSES devices.
i.e. lsscsi must list both the vSES devices after loading the driver and also after performing host reset operation.

[REGRESSION RISK]
There is no regression risk with this bug fix patch.

Michael Reed (mreed8855)
description: updated
Revision history for this message
Jerry Clement (jerry-clement) wrote :

Dell EMC storage team has tested the test kernel and everything is working as expected.

Revision history for this message
Jerry Clement (jerry-clement) wrote :

Dell EMC storage team has tested the test kernels for 5.8 and 5.11 successfully. Working as expected.

Revision history for this message
Kleber Sacilotto de Souza (kleber-souza) wrote :

This patch has already been applied to Hirsute as part of the upstream stable update (bug 1928857). I'm setting the Hirsute nomination as 'Fix Committed', however the task won't be automatically closed when the kernel is released.

Changed in linux (Ubuntu Focal):
status: New → Fix Committed
Changed in linux (Ubuntu Groovy):
status: New → Fix Committed
Changed in linux (Ubuntu Hirsute):
status: New → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-groovy' to 'verification-done-groovy'. If the problem still exists, change the tag 'verification-needed-groovy' to 'verification-failed-groovy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-groovy
tags: added: verification-done-focal verification-done-groovy
removed: verification-needed-focal verification-needed-groovy
Revision history for this message
Sujith Pandel (sujithpandel) wrote :

We have verified focal-proposed kernel and groovy-proposed kernels.
Fix is working fine. We can list both enclosures in lsscsi.

Focal-proposed:
#uname -r
5.4.0-75-generic

#lsscsi -g
[2:0:0:0] disk HGST HUH721212AL5205 NM05 /dev/sda /dev/sg0
[2:0:1:0] disk ATA ST2000NM0033-9ZM GA6C /dev/sdb /dev/sg1
[2:0:2:0] disk HGST HUS726020ALS210 KU27 /dev/sdc /dev/sg2
[2:0:3:0] disk ATA HUS722T1TALA600 MU03 /dev/sdd /dev/sg3
[2:0:4:0] enclosu DP BP15G+ 3.04 - /dev/sg4
[2:0:5:0] disk TOSHIBA AL15SEB060NY EF04 /dev/sde /dev/sg5
[2:0:6:0] disk ATA INTEL SSDSC2BX40 DL2B /dev/sdf /dev/sg6
[2:0:7:0] disk TOSHIBA AL15SEB24EQY EF05 /dev/sdg /dev/sg7
[2:0:8:0] disk ATA ST1000NX0443 NB33 /dev/sdh /dev/sg8
[2:0:9:0] enclosu DP BP15G+ 3.43 - /dev/sg9

Groovy-proposed:
#uname -r
5.8.0-56-generic

#lsscsi -g
[2:0:0:0] disk HGST HUH721212AL5205 NM05 /dev/sda /dev/sg0
[2:0:1:0] disk ATA ST2000NM0033-9ZM GA6C /dev/sdb /dev/sg1
[2:0:2:0] disk HGST HUS726020ALS210 KU27 /dev/sdc /dev/sg2
[2:0:3:0] disk ATA HUS722T1TALA600 MU03 /dev/sdd /dev/sg3
[2:0:4:0] enclosu DP BP15G+ 3.04 - /dev/sg4
[2:0:5:0] disk TOSHIBA AL15SEB060NY EF04 /dev/sde /dev/sg5
[2:0:6:0] disk ATA INTEL SSDSC2BX40 DL2B /dev/sdf /dev/sg6
[2:0:7:0] disk TOSHIBA AL15SEB24EQY EF05 /dev/sdg /dev/sg7
[2:0:8:0] disk ATA ST1000NX0443 NB33 /dev/sdh /dev/sg8
[2:0:9:0] enclosu DP BP15G+ 3.43 - /dev/sg9

Revision history for this message
Sujith Pandel (sujithpandel) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (23.2 KiB)

This bug was fixed in the package linux - 5.8.0-59.66

---------------
linux (5.8.0-59.66) groovy; urgency=medium

  * UAF on CAN J1939 j1939_can_recv (LP: #1932209)
    - SAUCE: can: j1939: delay release of j1939_priv after synchronize_rcu

  * UAF on CAN BCM bcm_rx_handler (LP: #1931855)
    - SAUCE: can: bcm: delay release of struct bcm_op after synchronize_rcu

linux (5.8.0-57.64) groovy; urgency=medium

  * groovy/linux: 5.8.0-57.64 -proposed tracker (LP: #1932047)

  * pmtu.sh from selftests.net in linux ADT test failure with linux/5.8.0-56.63
    (LP: #1931731)
    - net: geneve: modify IP header check in geneve6_xmit_skb and geneve_xmit_skb

linux (5.8.0-56.63) groovy; urgency=medium

  * groovy/linux: 5.8.0-56.63 -proposed tracker (LP: #1930052)

  * Packaging resync (LP: #1786013)
    - update dkms package versions

  * scsi: storvsc: Parameterize number hardware queues (LP: #1930626)
    - scsi: storvsc: Parameterize number hardware queues

  * CVE-2021-33200
    - bpf: Wrap aux data inside bpf_sanitize_info container
    - bpf: Fix mask direction swap upon off reg sign change
    - bpf: No need to simulate speculative domain for immediates

  * CVE-2021-3490
    - SAUCE: Revert "UBUNTU: SAUCE: bpf: verifier: fix ALU32 bounds tracking with
      bitwise ops"
    - gpf: Fix alu32 const subreg bound tracking on bitwise operations

  * CVE-2021-3489
    - SAUCE: Revert "UBUNTU: SAUCE: bpf: prevent writable memory-mapping of read-
      only ringbuf pages"
    - bpf: Prevent writable memory-mapping of read-only ringbuf pages

  * Realtek USB hubs in Dell WD19SC/DC/TB fail to work after exiting s2idle
    (LP: #1928242)
    - USB: Verify the port status when timeout happens during port suspend

  * CVE-2020-26145
    - ath10k: drop fragments with multicast DA for SDIO
    - ath10k: add CCMP PN replay protection for fragmented frames for PCIe
    - ath10k: drop fragments with multicast DA for PCIe

  * CVE-2020-26141
    - ath10k: Fix TKIP Michael MIC verification for PCIe

  * CVE-2020-24587
    - ath11k: Clear the fragment cache during key install

  * CVE-2020-24588
    - mac80211: properly handle A-MSDUs that start with an RFC 1042 header
    - cfg80211: mitigate A-MSDU aggregation attacks
    - mac80211: drop A-MSDUs on old ciphers
    - ath10k: drop MPDU which has discard flag set by firmware for SDIO

  * CVE-2020-26139
    - mac80211: do not accept/forward invalid EAPOL frames

  * CVE-2020-24586 // CVE-2020-24587 // CVE-2020-24587 for such cases.
    - mac80211: extend protection against mixed key and fragment cache attacks

  * CVE-2020-24586 // CVE-2020-24587
    - mac80211: prevent mixed key and fragment cache attacks
    - mac80211: add fragment cache to sta_info
    - mac80211: check defrag PN against current frame
    - mac80211: prevent attacks on TKIP/WEP as well

  * CVE-2020-26147
    - mac80211: assure all fragments are encrypted

  * raid10: Block discard is very slow, causing severe delays for mkfs and
    fstrim operations (LP: #1896578)
    - md: add md_submit_discard_bio() for submitting discard bio
    - md/raid10: extend r10bio devs to raid disks
    - md/raid10: pull the code that wait for blocked dev into one...

Changed in linux (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (34.3 KiB)

This bug was fixed in the package linux - 5.4.0-77.86

---------------
linux (5.4.0-77.86) focal; urgency=medium

  * UAF on CAN J1939 j1939_can_recv (LP: #1932209)
    - SAUCE: can: j1939: delay release of j1939_priv after synchronize_rcu

  * UAF on CAN BCM bcm_rx_handler (LP: #1931855)
    - SAUCE: can: bcm: delay release of struct bcm_op after synchronize_rcu

linux (5.4.0-76.85) focal; urgency=medium

  * focal/linux: 5.4.0-76.85 -proposed tracker (LP: #1932123)

  * Upstream v5.9 introduced 'module' patches that removed exported symbols
    (LP: #1932065)
    - SAUCE: Revert "modules: inherit TAINT_PROPRIETARY_MODULE"
    - SAUCE: Revert "modules: return licensing information from find_symbol"
    - SAUCE: Revert "modules: rename the licence field in struct symsearch to
      license"
    - SAUCE: Revert "modules: unexport __module_address"
    - SAUCE: Revert "modules: unexport __module_text_address"
    - SAUCE: Revert "modules: mark each_symbol_section static"
    - SAUCE: Revert "modules: mark find_symbol static"
    - SAUCE: Revert "modules: mark ref_module static"

linux (5.4.0-75.84) focal; urgency=medium

  * focal/linux: 5.4.0-75.84 -proposed tracker (LP: #1930032)

  * Packaging resync (LP: #1786013)
    - update dkms package versions

  * CVE-2021-33200
    - bpf: Wrap aux data inside bpf_sanitize_info container
    - bpf: Fix mask direction swap upon off reg sign change
    - bpf: No need to simulate speculative domain for immediates

  * Realtek USB hubs in Dell WD19SC/DC/TB fail to work after exiting s2idle
    (LP: #1928242)
    - USB: Verify the port status when timeout happens during port suspend

  * CVE-2020-26145
    - ath10k: drop fragments with multicast DA for SDIO
    - ath10k: add CCMP PN replay protection for fragmented frames for PCIe
    - ath10k: drop fragments with multicast DA for PCIe

  * CVE-2020-26141
    - ath10k: Fix TKIP Michael MIC verification for PCIe

  * CVE-2020-24588
    - mac80211: properly handle A-MSDUs that start with an RFC 1042 header
    - cfg80211: mitigate A-MSDU aggregation attacks
    - mac80211: drop A-MSDUs on old ciphers
    - ath10k: drop MPDU which has discard flag set by firmware for SDIO

  * CVE-2020-26139
    - mac80211: do not accept/forward invalid EAPOL frames

  * CVE-2020-24586 // CVE-2020-24587 // CVE-2020-24587 for such cases.
    - mac80211: extend protection against mixed key and fragment cache attacks

  * CVE-2020-24586 // CVE-2020-24587
    - mac80211: prevent mixed key and fragment cache attacks
    - mac80211: add fragment cache to sta_info
    - mac80211: check defrag PN against current frame
    - mac80211: prevent attacks on TKIP/WEP as well

  * CVE-2020-26147
    - mac80211: assure all fragments are encrypted

  * raid10: Block discard is very slow, causing severe delays for mkfs and
    fstrim operations (LP: #1896578)
    - md: add md_submit_discard_bio() for submitting discard bio
    - md/raid10: extend r10bio devs to raid disks
    - md/raid10: pull the code that wait for blocked dev into one function
    - md/raid10: improve raid10 discard request
    - md/raid10: improve discard request for far layout
    - dm raid: remove unnecessary discard limi...

Changed in linux (Ubuntu Focal):
status: Fix Committed → Fix Released
Michael Reed (mreed8855)
Changed in linux (Ubuntu):
milestone: none → later
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers