[SRU] Add support for E810 NIC to Ice Driver in Focal

[Jeff Lane ]

[Impact]
The Intel Ice driver in 5.4 does not contain the PCIIDs necessary to allow the driver to see the E810 network cards. Without this, users running Focal GA will be unable to deploy Ubuntu via MAAS, or use these cards at all post-install when installing from an ISO.

The patch to resolve this landed in Groovy, so this should be a pretty straightforward pick to 5.4. The patch set is small.

[Test Case]

This is easily reproducible by simply trying to install Focal onto a system with an E810 NIC. The NIC is not recognized and thus is not configurable or usable.

[Where problems could occur]

All this patch does is add PCI ID information for E810 to the driver to enable a wider set of cards to be used. Problems should not involve regressions to existing supported hardware, if anything the biggest issue could be discovering that after adding the PCI IDs, further patches are necessary to fully enable support in the Ice driver.

[Other Info]

This was reported by a hardware partner and blocks certification for systems that use E810 based NICs as their primary network devices.

Git repository:

https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/lp_1912511_e810_3

[Jeff Lane  (bladernr)]

Note, as this patch is already present from 5.7 onward, the only work necessary is a pull into 5.4.

[Jeff Lane  (bladernr)]

fix:
commit 195fb97766da1b41b4d49bccc37e13603bcb49cc
Author: Bruce Allan <email address hidden>
Date: Thu Feb 13 13:31:27 2020 -0800

    ice: add additional E810 device id

    Add support for device id 0x159b.

    Signed-off-by: Bruce Allan <email address hidden>
    Signed-off-by: Tony Nguyen <email address hidden>
    Tested-by: Andrew Bowers <email address hidden>
    Signed-off-by: Jeff Kirsher <email address hidden>

[Michael Reed (mreed8855)]

I have created a test kernel with this patch.

https://people.canonical.com/~mreed/lp1912511_e810/

[prabhakar pujeri (prabhakarpujeri)]

test-build verified with intel E810 card working as expected

1. able to see the network interface up
2. tested ping and wget test

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Michael Reed (mreed8855)]

I installed the proposed kernel and the E810 is working as expected.

The interfaces came up and I was able to ping and ssh into the system using the E810 interfaces.

$ uname -a
Linux C6520-E810-30 5.4.0-78-generic #87-Ubuntu SMP Fri Jun 18 16:29:09 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
ubuntu@C6520-E810-30:~$ sudo apt-cache policy linux-generic
linux-generic:
  Installed: 5.4.0.78.81
  Candidate: 5.4.0.78.81
  Version table:
 *** 5.4.0.78.81 500
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     5.4.0.77.80 500
        500 http://archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu focal-security/main amd64 Packages
     5.4.0.26.32 500
        500 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.4.0-80.90

---------------
linux (5.4.0-80.90) focal; urgency=medium

  * CVE-2021-33909
    - SAUCE: seq_file: Disallow extremely large seq buffer allocations

linux (5.4.0-79.88) focal; urgency=medium

  * focal/linux: 5.4.0-79.88 -proposed tracker (LP: #1934343)

  * lxd exec fails (LP: #1934187)
    - SAUCE: Revert "proc: Check /proc/$pid/attr/ writes against file opener"

linux (5.4.0-78.87) focal; urgency=medium

  * focal/linux: 5.4.0-78.87 -proposed tracker (LP: #1932478)

  * Packaging resync (LP: #1786013)
    - [Packaging] resync getabis
    - [Packaging] update helper scripts
    - update dkms package versions

  * Disable hv-kvp-daemon.service on certain instance types (LP: #1932081)
    - [Packaging]: Add kernel command line condition to hv-kvp-daemon service

  * QLogic Direct-Connect host can't discover SCSI-FC or NVMe/FC devices
    (LP: #1860724)
    - scsi: qla2xxx: Serialize fc_port alloc in N2N
    - scsi: qla2xxx: Set Nport ID for N2N
    - scsi: qla2xxx: Fix point-to-point (N2N) device discovery issue
    - scsi: qla2xxx: Fix N2N and NVMe connect retry failure

  * [SRU] Add support for E810 NIC to Ice Driver in Focal (LP: #1912511)
    - ice: add additional E810 device id

  * Focal update: v5.4.124 upstream stable release (LP: #1931166)
    - ALSA: hda/realtek: Headphone volume is controlled by Front mixer
    - ALSA: usb-audio: scarlett2: Fix device hang with ehci-pci
    - ALSA: usb-audio: scarlett2: Improve driver startup messages
    - cifs: set server->cipher_type to AES-128-CCM for SMB3.0
    - NFSv4: Fix a NULL pointer dereference in pnfs_mark_matching_lsegs_return()
    - iommu/vt-d: Fix sysfs leak in alloc_iommu()
    - perf intel-pt: Fix sample instruction bytes
    - perf intel-pt: Fix transaction abort handling
    - perf scripts python: exported-sql-viewer.py: Fix copy to clipboard from Top
      Calls by elapsed Time report
    - perf scripts python: exported-sql-viewer.py: Fix Array TypeError
    - perf scripts python: exported-sql-viewer.py: Fix warning display
    - proc: Check /proc/$pid/attr/ writes against file opener
    - net: hso: fix control-request directions
    - ath10k: Validate first subframe of A-MSDU before processing the list
    - dm snapshot: properly fix a crash when an origin has no snapshots
    - drm/amdgpu/vcn1: add cancel_delayed_work_sync before power gate
    - drm/amdgpu/vcn2.0: add cancel_delayed_work_sync before power gate
    - drm/amdgpu/vcn2.5: add cancel_delayed_work_sync before power gate
    - selftests/gpio: Use TEST_GEN_PROGS_EXTENDED
    - selftests/gpio: Move include of lib.mk up
    - selftests/gpio: Fix build when source tree is read only
    - kgdb: fix gcc-11 warnings harder
    - Documentation: seccomp: Fix user notification documentation
    - serial: core: fix suspicious security_locked_down() call
    - misc/uss720: fix memory leak in uss720_probe
    - thunderbolt: dma_port: Fix NVM read buffer bounds and offset issue
    - mei: request autosuspend after sending rx flow control
    - staging: iio: cdc: ad7746: avoid overwrite of num_channels
    - iio: gyro: fxas21002c: balance runtime power in error path
    - ...