Tiger Lake PMC core driver fixes

Bug #1899883 reported by Anthony Wong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Undecided
Unassigned
Groovy
Medium
AceLan Kao
linux-oem-5.6 (Ubuntu)
Undecided
Unassigned
Focal
Undecided
AceLan Kao

Bug Description

[Impact]
The power gating status is not correct and the slp_s0 value is not correct on Intel TigerLake platform.

The slp_s0 value is essential for our tools to confirm whether the
system enters deep sleep,
and the power gating is critical for another tool to check which
device is still running when the system is suspended.
Both are not that useful for a normal user, but useful for developers
to debug power consumption issues.

[Fix]
The patchset in https://<email address hidden>/ provides several critical fixes for intel_pmc_core driver.

[Test]
Verified on some TigerLake platforms

[Regression Potential]
Low, the fix for status bits map and the slp_s0 calculation are simple and clear, should have low impact on regression.

CVE References

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1899883

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Changed in linux (Ubuntu Focal):
status: New → Incomplete
AceLan Kao (acelankao)
no longer affects: linux (Ubuntu Focal)
no longer affects: linux-oem-5.6 (Ubuntu Groovy)
Changed in linux (Ubuntu):
status: Incomplete → Invalid
Changed in linux-oem-5.6 (Ubuntu):
status: New → Invalid
Changed in linux (Ubuntu Groovy):
status: Incomplete → In Progress
Changed in linux-oem-5.6 (Ubuntu Focal):
status: New → In Progress
Changed in linux (Ubuntu Groovy):
assignee: nobody → AceLan Kao (acelankao)
Changed in linux-oem-5.6 (Ubuntu Focal):
assignee: nobody → AceLan Kao (acelankao)
AceLan Kao (acelankao)
description: updated
Stefan Bader (smb)
Changed in linux (Ubuntu Groovy):
importance: Undecided → Medium
description: updated
Ian May (ian-may)
Changed in linux (Ubuntu Groovy):
status: In Progress → Fix Committed
Timo Aaltonen (tjaalton)
Changed in linux-oem-5.6 (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-groovy' to 'verification-done-groovy'. If the problem still exists, change the tag 'verification-needed-groovy' to 'verification-failed-groovy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-groovy
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Ian May (ian-may) wrote :

@Anthony can you confirm this is resolved in -proposed versions of Focal and Groovy?

Thanks,
Ian

AceLan Kao (acelankao)
tags: added: verification-done-focal verification-done-groovy
removed: verification-needed-focal verification-needed-groovy
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.7 KiB)

This bug was fixed in the package linux-oem-5.6 - 5.6.0-1035.37

---------------
linux-oem-5.6 (5.6.0-1035.37) focal; urgency=medium

  * focal/linux-oem-5.6: 5.6.0-1035.37 -proposed tracker (LP: #1903149)

  * Packaging resync (LP: #1786013)
    - update dkms package versions

  * drm/i915/dp_mst - wait longer during the clock recovery for Display port
    (LP: #1902861)
    - SAUCE: drm/i915/dp_mst: wait longer during the clock recovery

  * Remove NVMe suspend-to-idle workaround (LP: #1897227)
    - Revert "UBUTU: SAUCE: pci: prevent Intel NVMe SSDPEKKF from entering D3"
    - Revert "UBUNTU: SAUCE: pci: prevent sk hynix nvme from entering D3"

  * Tiger Lake PMC core driver fixes (LP: #1899883)
    - x86/devicetable: Move x86 specific macro out of generic code
    - x86/cpu: Add consistent CPU match macros
    - platform/x86: Convert to new CPU match macros
    - platform/x86: intel_pmc_core: Add Atom based Jasper Lake (JSL) platform
      support
    - platform/x86: intel_pmc_core: Add debugfs entry to access sub-state
      residencies
    - platform/x86: intel_pmc_core: Add debugfs entry for low power mode status
      registers
    - platform/x86: intel_pmc_core: Refactor the driver by removing redundant code
    - platform/x86: intel_pmc_core: Remove slp_s0 attributes from tgl_reg_map
    - platform/x86: intel_pmc_core: Add an additional parameter to
      pmc_core_lpm_display()
    - platform/x86: intel_pmc_core: Dump low power status registers on an S0ix.y
      failure
    - platform/x86: intel_pmc_core: Add debugfs support to access live status
      registers
    - platform/x86: intel_pmc_core: Relocate pmc_core_*_display() to outside of
      CONFIG_DEBUG_FS
    - platform/x86: intel_pmc_core: Remove duplicate 'if' to create debugfs entry
    - platform/x86: intel_pmc_core: Add slp_s0_offset attribute back to
      tgl_reg_map
    - platform/x86: intel_pmc_core: Make pmc_core_lpm_display() generic for
      platforms that support sub-states
    - platform/x86: intel_pmc_core: Make pmc_core_substate_res_show() generic
    - platform/x86: intel_pmc_core: Change Jasper Lake S0ix debug reg map back to
      ICL
    - platform/x86: intel_pmc_core: avoid unused-function warnings
    - platform/x86: intel_pmc_core: update TGL's LPM0 reg bit map name
    - platform/x86: intel_pmc_core: fix bound check in pmc_core_mphy_pg_show()
    - platform/x86: pmc_core: Use descriptive names for LPM registers
    - platform/x86: intel_pmc_core: Fix TigerLake power gating status map
    - platform/x86: intel_pmc_core: Fix the slp_s0 counter displayed value

  * [SRU][OEM-5.6]Fix no video out from some monitors on amdgpu (LP: #1901135)
    - drm/amd/display: Retry AUX write when fail occurs

  * drm/i915/dp_mst - only read the base capability in DPCD. (LP: #1902613)
    - Revert "UBUNTU: SAUCE: drm/dp_mst: Retrieve extended DPCD caps for topology
      manager"

  * TGL system automatically resumes from s2idle when connecting to a docking
    station with a monitor (LP: #1902577)
    - SAUCE: ACPI: avoid auto-wakeup with an _OSI string

  * Fix non-working NVMe after S3 (LP: #1895718)
    - SAUCE: PCI: Enable ACS quirk on all CML root ports

  * drm...

Read more...

Changed in linux-oem-5.6 (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (50.5 KiB)

This bug was fixed in the package linux - 5.8.0-31.33

---------------
linux (5.8.0-31.33) groovy; urgency=medium

  * groovy/linux: 5.8.0-31.33 -proposed tracker (LP: #1905299)

  * Groovy 5.8 kernel hangs on boot on CPUs with eLLC (LP: #1903397)
    - drm/i915: Mark ininitial fb obj as WT on eLLC machines to avoid rcu lockup
      during fbdev init

  * CVE-2020-4788
    - selftests/powerpc: rfi_flush: disable entry flush if present
    - powerpc/64s: flush L1D on kernel entry
    - powerpc/64s: flush L1D after user accesses
    - selftests/powerpc: entry flush test

linux (5.8.0-30.32) groovy; urgency=medium

  * groovy/linux: 5.8.0-30.32 -proposed tracker (LP: #1903194)

  * Update kernel packaging to support forward porting kernels (LP: #1902957)
    - [Debian] Update for leader included in BACKPORT_SUFFIX

  * Avoid double newline when running insertchanges (LP: #1903293)
    - [Packaging] insertchanges: avoid double newline

  * EFI: Fails when BootCurrent entry does not exist (LP: #1899993)
    - efivarfs: Replace invalid slashes with exclamation marks in dentries.

  * raid10: Block discard is very slow, causing severe delays for mkfs and
    fstrim operations (LP: #1896578)
    - md: add md_submit_discard_bio() for submitting discard bio
    - md/raid10: extend r10bio devs to raid disks
    - md/raid10: pull codes that wait for blocked dev into one function
    - md/raid10: improve raid10 discard request
    - md/raid10: improve discard request for far layout
    - dm raid: fix discard limits for raid1 and raid10
    - dm raid: remove unnecessary discard limits for raid10

  * Bionic: btrfs: kernel BUG at /build/linux-
    eTBZpZ/linux-4.15.0/fs/btrfs/ctree.c:3233! (LP: #1902254)
    - btrfs: extent_io: do extra check for extent buffer read write functions
    - btrfs: extent-tree: kill BUG_ON() in __btrfs_free_extent()
    - btrfs: extent-tree: kill the BUG_ON() in insert_inline_extent_backref()
    - btrfs: ctree: check key order before merging tree blocks

  * Tiger Lake PMC core driver fixes (LP: #1899883)
    - platform/x86: intel_pmc_core: update TGL's LPM0 reg bit map name
    - platform/x86: intel_pmc_core: fix bound check in pmc_core_mphy_pg_show()
    - platform/x86: pmc_core: Use descriptive names for LPM registers
    - platform/x86: intel_pmc_core: Fix TigerLake power gating status map
    - platform/x86: intel_pmc_core: Fix the slp_s0 counter displayed value

  * drm/i915/dp_mst - System would hang during the boot up. (LP: #1902469)
    - Revert "UBUNTU: SAUCE: drm/i915/display: Fix null deref in
      intel_psr_atomic_check()"
    - drm/i915: Fix encoder lookup during PSR atomic check

  * Undetected Data corruption in MPI workloads that use VSX for reductions on
    POWER9 DD2.1 systems (LP: #1902694)
    - powerpc: Fix undetected data corruption with P9N DD2.1 VSX CI load emulation
    - selftests/powerpc: Make alignment handler test P9N DD2.1 vector CI load
      workaround

  * [20.04 FEAT] Support/enhancement of NVMe IPL (LP: #1902179)
    - s390/ipl: support NVMe IPL kernel parameters

  * uvcvideo: add mapping for HEVC payloads (LP: #1895803)
    - media: uvcvideo: Add mapping for HEVC payloads

  * risc-v 5.8 ...

Changed in linux (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 5.8.0-36.40+21.04.1

---------------
linux (5.8.0-36.40+21.04.1) hirsute; urgency=medium

  * Packaging resync (LP: #1786013)
    - update dkms package versions

  [ Ubuntu: 5.8.0-36.40 ]

  * debian/scripts/file-downloader does not handle positive failures correctly
    (LP: #1878897)
    - [Packaging] file-downloader not handling positive failures correctly

  [ Ubuntu: 5.8.0-35.39 ]

  * Packaging resync (LP: #1786013)
    - update dkms package versions
  * CVE-2021-1052 // CVE-2021-1053
    - [Packaging] NVIDIA -- Add the NVIDIA 460 driver

 -- Kleber Sacilotto de Souza <email address hidden> Thu, 07 Jan 2021 11:57:30 +0100

Changed in linux (Ubuntu):
status: Invalid → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers