2020-08-13 08:49:41 |
bugproxy |
bug |
|
|
added bug |
2020-08-13 08:49:43 |
bugproxy |
tags |
|
architecture-s39064 bugnameltc-187544 severity-high targetmilestone-inin2004 |
|
2020-08-13 08:49:44 |
bugproxy |
attachment added |
|
s390/cpum_cf,perf: change DFLT_CCERROR counter name https://bugs.launchpad.net/bugs/1891454/+attachment/5401272/+files/0001-s390-cpum_cf-perf-change-DFLT_CCERROR-counter-name.patch |
|
2020-08-13 08:49:46 |
bugproxy |
ubuntu: assignee |
|
Skipper Bug Screeners (skipper-screen-team) |
|
2020-08-13 08:49:49 |
bugproxy |
affects |
ubuntu |
linux (Ubuntu) |
|
2020-08-13 08:54:30 |
Frank Heimes |
bug task added |
|
ubuntu-z-systems |
|
2020-08-14 10:43:03 |
Frank Heimes |
nominated for series |
|
Ubuntu Xenial |
|
2020-08-14 10:43:03 |
Frank Heimes |
bug task added |
|
linux (Ubuntu Xenial) |
|
2020-08-14 10:43:03 |
Frank Heimes |
nominated for series |
|
Ubuntu Groovy |
|
2020-08-14 10:43:03 |
Frank Heimes |
bug task added |
|
linux (Ubuntu Groovy) |
|
2020-08-14 10:43:03 |
Frank Heimes |
nominated for series |
|
Ubuntu Focal |
|
2020-08-14 10:43:03 |
Frank Heimes |
bug task added |
|
linux (Ubuntu Focal) |
|
2020-08-14 10:43:03 |
Frank Heimes |
nominated for series |
|
Ubuntu Bionic |
|
2020-08-14 10:43:03 |
Frank Heimes |
bug task added |
|
linux (Ubuntu Bionic) |
|
2020-08-14 10:43:34 |
Frank Heimes |
linux (Ubuntu Groovy): status |
New |
Fix Committed |
|
2020-08-14 10:43:56 |
Frank Heimes |
ubuntu-z-systems: status |
New |
Triaged |
|
2020-08-14 10:48:27 |
bugproxy |
attachment added |
|
Patch for Ubuntu 18.04 branch master-next https://bugs.launchpad.net/bugs/1891454/+attachment/5401424/+files/u18-0001-s390-cpum_cf-Add-new-extended-counters-for-IBM-z15.patch |
|
2020-08-14 18:10:15 |
Frank Heimes |
bug task deleted |
linux (Ubuntu Xenial) |
|
|
2020-08-24 11:32:23 |
Frank Heimes |
ubuntu-z-systems: assignee |
|
Skipper Bug Screeners (skipper-screen-team) |
|
2020-08-24 11:33:13 |
Frank Heimes |
linux (Ubuntu Bionic): assignee |
|
Frank Heimes (fheimes) |
|
2020-08-24 11:33:17 |
Frank Heimes |
linux (Ubuntu Focal): assignee |
|
Frank Heimes (fheimes) |
|
2020-08-25 13:57:56 |
Frank Heimes |
linux (Ubuntu Bionic): status |
New |
In Progress |
|
2020-08-25 13:57:59 |
Frank Heimes |
linux (Ubuntu Focal): status |
New |
In Progress |
|
2020-08-25 13:58:03 |
Frank Heimes |
ubuntu-z-systems: status |
Triaged |
In Progress |
|
2020-08-25 13:58:53 |
Frank Heimes |
description |
Description: kernel: s390/cpum_cf,perf: change DFLT_CCERROR counter name
Symptom: Counter name CCERROR is misleading.
Problem: Change the counter name DLFT_CCERROR to DLFT_CCFINISH on
IBM z15. This counter counts completed DEFLATE instructions
with exit code 0, 1 or 2. Since exit code 0 means success
and exit code 1 or 2 indicate errors, change the counter
name to avoid confusion. This counter is incremented each
time the DEFLATE instruction completed regardless if an
error was detected or not.
Solution: Rename s390 z15 counter named DFLT_CCERROR to DFLT_CCFINISH
Reproduction: Command # ls /sys/devices/cpum_cf/events/DFLT_CCERROR
currently succeeds. After this patch has been applied the
command does not work anymore. The file does not exist
anymore. Use command
# ls /sys/devices/cpum_cf/events/DFLT_CCFINISH
instead.
Upstream-ID: 5ce1a24dd98c00a57a8fa13660648abf7e08e3ef
Component: kernel 5.8
Will be integrated into 20.10 by kernel 5.8 integration.
Backport available for 20.04.
To be checked for 18.04 and 16.04, update will be provided
Here is the backported patch.
The upstream commit id is 3d3af181d370069861a3be94608464e2ff3682e2
("s390/cpum_cf,perf: change DFLT_CCERROR counter name") |
SRU Justification:
==================
[Impact]
* Change the counter name DLFT_CCERROR to DLFT_CCFINISH on IBM z15 to avoid confusion.
* This counter counts completed DEFLATE instructions with exit code 0, 1 or 2.
* And since exit code 0 means success and exit code 1 or 2 indicate errors the name can be ambiguous.
[Fix]
* Rename s390 z15 counter named DFLT_CCERROR to DFLT_CCFINISH.
* Backport Focal: https://launchpadlibrarian.net/493272507/0001-s390-cpum_cf-perf-change-DFLT_CCERROR-counter-name.patch
* Backport Bionic: https://launchpadlibrarian.net/493439681/u18-0001-s390-cpum_cf-Add-new-extended-counters-for-IBM-z15.patch
[Test Case]
* Enable hardware counters in the activation profile of a z15 LPAR.
* Just check the countername in sysfs with: ls /sys/devices/cpum_cf/events/{DFLT_CCERROR,DFLT_CCFINISH}
[Regression Potential]
* The regression potential can be considered as low, since:
* Counters like these are usually not activated by default and need to be explicitly enabled.
* No code functionality is changed with that patch, only a renaming is done at 3 places in one code file arch/s390/kernel/perf_cpum_cf_events.c as well as in /tools/perf/pmu-events/arch/s390/cf_z15/extended.json.
* The fix got already upstream accepted in 5.8-rc7, hence it got upstream reviewed,
* and the modifications are limited to s390x, are only relevant for the z15 / LinuxONE III hw generation that are relatively new.
* Issue with the renaming I can think of are that people don't know about the new name and may look for the old one and don't find it anymore,
* and with that also if the old counter name is used in scripts or applications, these may fails due to an unknown counter name.
[Other Info]
* The backports are based on commit 3d3af181d370069861a3be94608464e2ff3682e2 ("s390/cpum_cf,perf: change DFLT_CCERROR counter name") that is upstream accepted since v5.8-rc7.
* Hence this SRU is not requested for groovy, since it's already in groovys kernel 5.8 in proposed, but only requested for focal and bionic.
__________
Description: kernel: s390/cpum_cf,perf: change DFLT_CCERROR counter name
Symptom: Counter name CCERROR is misleading.
Problem: Change the counter name DLFT_CCERROR to DLFT_CCFINISH on
IBM z15. This counter counts completed DEFLATE instructions
with exit code 0, 1 or 2. Since exit code 0 means success
and exit code 1 or 2 indicate errors, change the counter
name to avoid confusion. This counter is incremented each
time the DEFLATE instruction completed regardless if an
error was detected or not.
Solution: Rename s390 z15 counter named DFLT_CCERROR to DFLT_CCFINISH
Reproduction: Command # ls /sys/devices/cpum_cf/events/DFLT_CCERROR
currently succeeds. After this patch has been applied the
command does not work anymore. The file does not exist
anymore. Use command
# ls /sys/devices/cpum_cf/events/DFLT_CCFINISH
instead.
Upstream-ID: 5ce1a24dd98c00a57a8fa13660648abf7e08e3ef
Component: kernel 5.8
Will be integrated into 20.10 by kernel 5.8 integration.
Backport available for 20.04.
To be checked for 18.04 and 16.04, update will be provided
Here is the backported patch.
The upstream commit id is 3d3af181d370069861a3be94608464e2ff3682e2
("s390/cpum_cf,perf: change DFLT_CCERROR counter name") |
|
2020-08-28 05:12:07 |
Kelsey Steele |
linux (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
2020-08-28 10:29:10 |
Frank Heimes |
summary |
[UBUNTU 20.04] kernel: s390/cpum_cf,perf: change DFLT_CCERROR counter name |
[UBUNTU 20.04] s390/cpum_cf,perf: change/add DFLT_CCERROR counter name |
|
2020-08-28 10:29:57 |
Frank Heimes |
summary |
[UBUNTU 20.04] s390/cpum_cf,perf: change/add DFLT_CCERROR counter name |
[UBUNTU 20.04] kernel: s390/cpum_cf,perf: changeDFLT_CCERROR counter name |
|
2020-08-31 21:02:46 |
Ubuntu Kernel Bot |
tags |
architecture-s39064 bugnameltc-187544 severity-high targetmilestone-inin2004 |
architecture-s39064 bugnameltc-187544 severity-high targetmilestone-inin2004 verification-needed-focal |
|
2020-09-01 07:17:39 |
Frank Heimes |
tags |
architecture-s39064 bugnameltc-187544 severity-high targetmilestone-inin2004 verification-needed-focal |
architecture-s39064 bugnameltc-187544 severity-high targetmilestone-inin2004 verification-done-focal |
|
2020-09-02 08:14:21 |
Stefan Bader |
linux (Ubuntu Bionic): importance |
Undecided |
Medium |
|
2020-09-02 08:14:28 |
Stefan Bader |
linux (Ubuntu Focal): importance |
Undecided |
Medium |
|
2020-09-02 08:14:33 |
Stefan Bader |
linux (Ubuntu Groovy): importance |
Undecided |
Medium |
|
2020-09-16 05:07:49 |
Khaled El Mously |
linux (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
2020-09-16 05:17:10 |
Frank Heimes |
ubuntu-z-systems: status |
In Progress |
Fix Committed |
|
2020-09-21 10:38:15 |
Launchpad Janitor |
linux (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
2020-09-21 10:38:15 |
Launchpad Janitor |
cve linked |
|
2019-19770 |
|
2020-09-21 10:38:15 |
Launchpad Janitor |
cve linked |
|
2020-12888 |
|
2020-09-21 11:06:52 |
Frank Heimes |
linux (Ubuntu Groovy): status |
Fix Committed |
Fix Released |
|
2020-09-21 21:33:32 |
Ubuntu Kernel Bot |
tags |
architecture-s39064 bugnameltc-187544 severity-high targetmilestone-inin2004 verification-done-focal |
architecture-s39064 bugnameltc-187544 severity-high targetmilestone-inin2004 verification-done-focal verification-needed-bionic |
|
2020-09-22 12:54:26 |
Frank Heimes |
tags |
architecture-s39064 bugnameltc-187544 severity-high targetmilestone-inin2004 verification-done-focal verification-needed-bionic |
architecture-s39064 bugnameltc-187544 severity-high targetmilestone-inin2004 verification-done-bionic verification-done-focal |
|
2020-10-13 22:42:20 |
Launchpad Janitor |
linux (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
2020-10-13 22:42:20 |
Launchpad Janitor |
cve linked |
|
2018-10322 |
|
2020-10-13 22:42:20 |
Launchpad Janitor |
cve linked |
|
2020-16119 |
|
2020-10-13 22:42:20 |
Launchpad Janitor |
cve linked |
|
2020-16120 |
|
2020-10-14 04:28:40 |
Frank Heimes |
ubuntu-z-systems: status |
Fix Committed |
Fix Released |
|