$ git bisect bad 851cc40f47677174527a1decbd1074feacd15a93 is the first bad commit commit 851cc40f47677174527a1decbd1074feacd15a93 Author: Hui Wang Date: Tue Apr 14 22:27:25 2020 +0800 ALSA: hda: call runtime_allow() for all hda controllers BugLink: https://bugs.launchpad.net/bugs/1876765 [ Upstream commit 9a6418487b566503c772cb6e7d3d44e652b019b0 ] Before the pci_driver->probe() is called, the pci subsystem calls runtime_forbid() and runtime_get_sync() on this pci dev, so only call runtime_put_autosuspend() is not enough to enable the runtime_pm on this device. For controllers with vgaswitcheroo feature, the pci/quirks.c will call runtime_allow() for this dev, then the controllers could enter rt_idle/suspend/resume, but for non-vgaswitcheroo controllers like Intel hda controllers, the runtime_pm is not enabled because the runtime_allow() is not called. Since it is no harm calling runtime_allow() twice, here let hda driver call runtime_allow() for all controllers. Then the runtime_pm is enabled on all controllers after the put_autosuspend() is called. Signed-off-by: Hui Wang Link: https://lore.kernel.org/r/20200414142725.6020-1-hui.wang@canonical.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin Signed-off-by: Kamal Mostafa Signed-off-by: Stefan Bader sound/pci/hda/hda_intel.c | 1 + 1 file changed, 1 insertion(+)