[Ubuntu 20.04] net/mlx5e: Fix endianness handling in pedit mask
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu on IBM z Systems |
Fix Released
|
Medium
|
Skipper Bug Screeners | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
Canonical Kernel Team | ||
Focal |
Fix Released
|
Undecided
|
Canonical Kernel Team | ||
Groovy |
Fix Released
|
Undecided
|
Canonical Kernel Team |
Bug Description
SRU Justification:
==================
[Impact]
* An issue with the endianess handling in the Mellanox mlx5 driver was found.
* The mask value is provided as 64 bit and has to be casted in either 32 or 16 bit.
* On big endian systems the wrong half was casted which resulted in an all zero mask.
[Fix]
* Backport: https:/
[Test Case]
* An s390x system with RoCE Express 2(.1) system is needed and the driver loaded.
* Check whether the mask value stays zero, or if it also get's non-zero values.
* Functional testing is currently only doable by IBM, since we only have RoCE (1) hardware that uses the mlx4 driver.
[Regression Potential]
* There is regression potential is moderate, since:
* the RoCE 2(.1) cards are pretty new and not very wide spread, yet
* the fix got already upstream accepted with 5.6
* However, at the end the patch modifies Mellanox common code (drivers/
* but the changes were reviewed, signed off by Mellanox engineers and are very limited.
[Other Info]
* The above backport (patch-file) is based on commit 404402abd5f90aa
* The commit itself got upstream accepted with kernel v5.6, hence should automatically land in 'gorilla', but since gorilla is still based on 5.4, I'm adding 'G' to this SRU.
__________
Issue found in the Mellanox mlx5 device driver:
The mask value is provided as 64 bit and has to be casted in
either 32 or 16 bit. On big endian systems the wrong half was
casted which resulted in an all zero mask.
We need to get the upstream commit picked up for the Ubuntu 20.04 kernel.
CVE References
tags: | added: architecture-s39064 bugnameltc-185119 severity-medium targetmilestone-inin2004 |
Changed in ubuntu-z-systems: | |
assignee: | nobody → Canonical Kernel Team (canonical-kernel-team) |
importance: | Undecided → Medium |
no longer affects: | ubuntu |
Changed in ubuntu-z-systems: | |
status: | New → Incomplete |
Changed in ubuntu-z-systems: | |
status: | Incomplete → Triaged |
Changed in linux (Ubuntu Focal): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in ubuntu-z-systems: | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Focal): | |
status: | Fix Committed → In Progress |
Changed in linux (Ubuntu Groovy): | |
status: | Fix Committed → In Progress |
Changed in linux (Ubuntu Focal): | |
status: | In Progress → Fix Committed |
Changed in ubuntu-z-systems: | |
assignee: | Canonical Kernel Team (canonical-kernel-team) → Skipper Bug Screeners (skipper-screen-team) |
Changed in linux (Ubuntu Focal): | |
assignee: | nobody → Canonical Kernel Team (canonical-kernel-team) |
tags: |
added: verification-done-focal removed: verification-needed-focal |
Changed in ubuntu-z-systems: | |
status: | Fix Committed → Fix Released |
It's upstream accepted since 5.6:
$ git tag --contains 404402abd5f9 | grep ^v
v5.6
v5.7-rc1