Suspend triggers Hardware Error in e1000e driver

[roland]

I'm experiencing problems since a recent kernel update.

The laptop, a Lenovo X1 gen 7, won't suspend.

This is the relevant kernel log

--> # modprobe e1000e:

[ 129.848320] e1000e: Intel(R) PRO/1000 Network Driver - 3.2.6-k
[ 129.848321] e1000e: Copyright(c) 1999 - 2015 Intel Corporation.
[ 129.848592] e1000e 0000:00:1f.6: Interrupt Throttling Rate (ints/sec) set to dynamic conservative mode
[ 130.041352] e1000e 0000:00:1f.6 0000:00:1f.6 (uninitialized): registered PHC clock
[ 130.108943] e1000e 0000:00:1f.6 eth0: (PCI Express:2.5GT/s:Width x1) 98:fa:9b:7a:d9:f8
[ 130.108945] e1000e 0000:00:1f.6 eth0: Intel(R) PRO/1000 Network Connection
[ 130.109109] e1000e 0000:00:1f.6 eth0: MAC: 13, PHY: 12, PBA No: FFFFFF-0FF
[ 130.110252] e1000e 0000:00:1f.6 enp0s31f6: renamed from eth0
--> Close laptop cover
[ 135.766644] PM: suspend entry (s2idle)
[ 135.827181] Filesystems sync: 0.060 seconds
[ 135.827625] Freezing user space processes ... (elapsed 0.001 seconds) done.
[ 135.829446] OOM killer disabled.
[ 135.829446] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done.
[ 135.830557] printk: Suspending console(s) (use no_console_suspend to debug)
[ 135.847372] wlp0s20f3: deauthenticating from 6c:3b:6b:45:31:33 by local choice (Reason: 3=DEAUTH_LEAVING)
[ 135.952129] e1000e: EEE TX LPI TIMER: 00000011
[ 168.243513] iwlwifi 0000:00:14.3: Applying debug destination EXTERNAL_DRAM
[ 168.552833] iwlwifi 0000:00:14.3: Applying debug destination EXTERNAL_DRAM
[ 168.620018] iwlwifi 0000:00:14.3: FW already configured (0) - re-configuring
[ 171.122887] e1000e 0000:00:1f.6 enp0s31f6: PHY Wakeup cause - Unicast Packet
[ 171.789683] e1000e 0000:00:1f.6 enp0s31f6: Hardware Error
[ 172.316635] OOM killer enabled.
[ 172.316635] Restarting tasks ... done.
[ 172.524828] PM: suspend exit
[ 173.520752] e1000e 0000:00:1f.6 enp0s31f6: Hardware Error
[ 173.823096] e1000e: enp0s31f6 NIC Link is Down
[ 173.832543] iwlwifi 0000:00:14.3: Applying debug destination EXTERNAL_DRAM
[ 173.947544] iwlwifi 0000:00:14.3: Applying debug destination EXTERNAL_DRAM
[ 174.012469] iwlwifi 0000:00:14.3: FW already configured (0) - re-configuring
[ 174.950102] e1000e 0000:00:1f.6 enp0s31f6: Hardware Error
[ 179.453930] wlp0s20f3: authenticate with 6c:3b:6b:45:31:33
[ 179.456251] wlp0s20f3: send auth to 6c:3b:6b:45:31:33 (try 1/3)
[ 179.494829] wlp0s20f3: authenticated
[ 179.496193] wlp0s20f3: associate with 6c:3b:6b:45:31:33 (try 1/3)
[ 179.498191] wlp0s20f3: RX AssocResp from 6c:3b:6b:45:31:33 (capab=0x431 status=0 aid=2)
[ 179.500628] wlp0s20f3: associated
[ 179.512786] IPv6: ADDRCONF(NETDEV_CHANGE): wlp0s20f3: link becomes ready

ProblemType: Bug
DistroRelease: Ubuntu 19.10
Package: linux-modules-5.3.0-42-generic 5.3.0-42.34
ProcVersionSignature: Ubuntu 5.3.0-42.34-generic 5.3.18
Uname: Linux 5.3.0-42-generic x86_64
ApportVersion: 2.20.11-0ubuntu8.5
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: roland 2099 F.... pulseaudio
CurrentDesktop: ubuntu:GNOME
Date: Thu Mar 5 11:10:06 2020
Dependencies:

InstallationDate: Installed on 2019-10-07 (149 days ago)
InstallationMedia: Ubuntu 19.04 "Disco Dingo" - Release amd64 (20190416)
MachineType: LENOVO 20QDCTO1WW
ProcFB: 0 i915drmfb
ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-5.3.0-42-generic root=UUID=298d5179-f5b4-410d-aafb-92630b5b48a1 ro quiet splash vt.handoff=7
RelatedPackageVersions:
 linux-restricted-modules-5.3.0-42-generic N/A
 linux-backports-modules-5.3.0-42-generic N/A
 linux-firmware 1.183.4
SourcePackage: linux
UpgradeStatus: Upgraded to eoan on 2019-11-19 (107 days ago)
dmi.bios.date: 02/21/2020
dmi.bios.vendor: LENOVO
dmi.bios.version: N2HET46W (1.29 )
dmi.board.asset.tag: Not Available
dmi.board.name: 20QDCTO1WW
dmi.board.vendor: LENOVO
dmi.board.version: SDK0J40697 WIN
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: None
dmi.modalias: dmi:bvnLENOVO:bvrN2HET46W(1.29):bd02/21/2020:svnLENOVO:pn20QDCTO1WW:pvrThinkPadX1Carbon7th:rvnLENOVO:rn20QDCTO1WW:rvrSDK0J40697WIN:cvnLENOVO:ct10:cvrNone:
dmi.product.family: ThinkPad X1 Carbon 7th
dmi.product.name: 20QDCTO1WW
dmi.product.sku: LENOVO_MT_20QD_BU_Think_FM_ThinkPad X1 Carbon 7th
dmi.product.version: ThinkPad X1 Carbon 7th
dmi.sys.vendor: LENOVO

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This change was made by a bot.

[Kai-Heng Feng (kaihengfeng)]

Does this issue happen to previous 5.3.0 kernel versions?

[roland (roland-micite)]

I first noticed the bug on: 5.3.0-41.33-generic 5.3.18

[Kai-Heng Feng (kaihengfeng)]

Can you please test kernel here:
https://people.canonical.com/~khfeng/lp1866170/

[roland (roland-micite)]

Could you describe how I can test this kernel and revert back to my current kernel?

Furthermore, I assume you made some changes to that your kernel, could you elaborate on what you changed and what the result should be?

[Kai-Heng Feng (kaihengfeng)]

Could you describe how I can test this kernel and revert back to my current kernel?

Download the debs and use `dpkg -i *debs` to install.
To remove them, run
$ sudo apt purge `dpkg -l | grep 1866170 | awk '{print $2}'`

Furthermore, I assume you made some changes to that your kernel, could you elaborate on what you changed and what the result should be?

It reverts the following commit:
commit 57adc534f78e86fb66417a9d73d65d1ea40f6b61
Author: Sasha Neftin <email address hidden>
Date: Fri Jan 10 06:44:00 2020 +0100

    e1000e: Add support for S0ix

I don't know the result and that why we need to test it.

[roland (roland-micite)]

I don't know if I can test whole new unsigned kernels soon.

Would it be possible to just test the modified e1000e driver?
I could build the source and do a insmod/modprobe.

[Hui Wang (hui.wang)]

So you put the options snd-hda-intel dmic_detect=0, right? And 5.0.0-43-generic will fix all audio issues, and the sof driver will work and don't need to add dmic_detect=0 anymore.

And with 5.0.0-42-generic, I added dmic_detect=0 too and tried to reproduced your problem, but I couldn't reproduce the problem, the machine suspend/resume for 3 times successfully.

Please refer to my dmesg.

[Hui Wang (hui.wang)]

So you put the options snd-hda-intel dmic_detect=0, right? And 5.0.0-43-generic will fix all audio issues, and the sof driver will work and don't need to add dmic_detect=0 anymore.

And with 5.0.0-42-generic, I added dmic_detect=0 too and tried to reproduced your problem, but I couldn't reproduce the problem, the machine suspend/resume for 3 times successfully.

Please refer to my dmesg.

[Hui Wang (hui.wang)]

replace all 5.0.0 to 5.3.0 in the comment#10.

[AaronMa (mapengyu)]

Tried but not reproduced too.

This is the module you preferred:
please test the latest e1000e driver from intel:
https://downloadcenter.intel.com/download/15817

Please file a bug in bugzilla.kernel.org too if driver above failed.

[roland (roland-micite)]

Couldn't test it, since the driver won't load with:

modprobe: ERROR: could not insert 'e1000e': Operation not permitted

It seems Secure boot related.

[breezer (jgbreezer)]

Pointed here as possible duplicate from bug https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1867388. Tested the .deb kernel packages from link in #5 in this bug with my HP Elitebook 830 (which also suspends fine and has audio on 5.3.0-40 but not on later versions); no change, still fails to suspend with this 5.3.0-43.35~lp1866170

[Kai-Heng Feng (kaihengfeng)]

#1867388 doesn't seem to be caused by e1000e.

[Kai-Heng Feng (kaihengfeng)]

A test kernel can be found here:
https://people.canonical.com/~khfeng/lp1865570/eoan/