Update mpt3sas Driver to 33.100.00.00 for Ubuntu 20.04

Bug #1863574 reported by Suganath Prabu
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Medium
Michael Reed
Focal
Medium
Michael Reed

Bug Description

[IMPACT]
This is a feature request to update the mpt3sas driver in focal to latest version 33.100.00.00 in Ubuntu 20.04. This will allow users to use
fixes and enhancements that landed upstream in 5.6. For this reason,
Broadcom and Dell have requested that we pull these patches to update the
mpt3sas driver to the current upstream version.

[FIXES]
The following commit ID's from Broadcom that whould be cherry-picked form mainline

commit c53cf10ef6d9faeee9baa1fab824139c6f10a134
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=c53cf10ef6d9faeee9baa1fab824139c6f10a134
commit c50ed99cd56ee725d9e14dffec8e8f1641b8ca30
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=c50ed99cd56ee725d9e14dffec8e8f1641b8ca30
commit c6bdb6a10892d1130638a5e28d1523a813e45d5e
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=c6bdb6a10892d1130638a5e28d1523a813e45d5e
commit 5b061980e362820894d7d884370b37005bed23ec
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=5b061980e362820894d7d884370b37005bed23ec
commit c59777189433621392f6f5c82ecfc62f00a1232d
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=c59777189433621392f6f5c82ecfc62f00a1232d
commit fce0aa08792b3ae725395fa25d44507dee0b603b
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=fce0aa08792b3ae725395fa25d44507dee0b603b
commit e8c2307e6a690db9aaff84153b2857c5c4dfd969
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=e8c2307e6a690db9aaff84153b2857c5c4dfd969
commit 36c6c7f75b0998f5a4b5c79cbb94ee1ab4ee35c0
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=36c6c7f75b0998f5a4b5c79cbb94ee1ab4ee35c0
commit d3f623ae8e0323ca434ee9029100312a8be37773
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=d3f623ae8e0323ca434ee9029100312a8be37773
commit 1ade26b616cc2da0b7277a97e3799c99bae0655b
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=1ade26b616cc2da0b7277a97e3799c99bae0655b
commit ee560e7bbab0c10cf3f0e71997fbc354ab2ee5cb
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=ee560e7bbab0c10cf3f0e71997fbc354ab2ee5cb
commit 5bb2f743cdaa6da618e77a6aab5c38b46072365b
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=5bb2f743cdaa6da618e77a6aab5c38b46072365b
commit 3524a38e594dd5f090cbc3226e5f47cb4067fac7
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=3524a38e594dd5f090cbc3226e5f47cb4067fac7
commit d8b2625f4699a36b1753d87e96b0c50a4531c065
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=d8b2625f4699a36b1753d87e96b0c50a4531c065
commit 9e64fd1e65f72d229f96fcf390576e772770a01c
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=9e64fd1e65f72d229f96fcf390576e772770a01c
commit 77fd4f2c88bf83205a21f9ca49fdcc0c7868dba9
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=77fd4f2c88bf83205a21f9ca49fdcc0c7868dba9
commit b06ff10249036eec74fa8565503ac40d0ee92213
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=b06ff10249036eec74fa8565503ac40d0ee92213
commit 29f571f8b4cc652cae9244630f714a610549d301
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=29f571f8b4cc652cae9244630f714a610549d301
commit a8a6cbcd038de4ee3722c17edd7a4d84ce423f7d
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=a8a6cbcd038de4ee3722c17edd7a4d84ce423f7d
commit a066f4c31359d07b1a2c5144b4b9a29901365fd0
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=a066f4c31359d07b1a2c5144b4b9a29901365fd0
commit dd180e4eedfd85b80020a6fd566601f4765a9d69
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=dd180e4eedfd85b80020a6fd566601f4765a9d69
commit 08e7378ee331a803cfdd91c512a3dea040f1da79
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=08e7378ee331a803cfdd91c512a3dea040f1da79
commit 764f472ba4a7a0c18107ebfbe1a9f1f5f5a1e411
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=764f472ba4a7a0c18107ebfbe1a9f1f5f5a1e411
commit 782b281883caf70289ba6a186af29441a117d23e
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=782b281883caf70289ba6a186af29441a117d23e
commit 4bc50dc1afb7b77dfc80a1f8f0742b14d6f6e376
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=4bc50dc1afb7b77dfc80a1f8f0742b14d6f6e376
commit d04a6edfed0b2e99d9a8385503737944db3d5649
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=d04a6edfed0b2e99d9a8385503737944db3d5649
commit 8dc8d29a00e29c679f027102fb9c6709347ca8ca
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=8dc8d29a00e29c679f027102fb9c6709347ca8ca

Thanks,
Suganath

All are clean cherry picks into the 5.4 branch and can be pulled from the
following branch:

https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/focal/+ref/lp1863574_mpt3sas

[TESTING]
Modinfo for mpt3sas should show the version of mpt3sas is 33.100.00.00

[REGRESSION RISK]
Low - Focal is not yet released, this is not being backported to current releases.

CVE References

Changed in linux (Ubuntu):
status: New → Incomplete
status: Incomplete → New
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1863574

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Changed in linux (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Michael Reed (mreed8855) wrote :

Are these the correct patches for 33.100.00.00?

This patch bumps the patch version to 32.100.00.00 and not 33.100.00.00. This along with other patches are causing issues when I am cherry picking the patches. Can you verify the "exact" patches needed for version 33.100.00.00.

commit d8b2625f4699a36b1753d87e96b0c50a4531c065
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=d8b2625f4699a36b1753d87e96b0c50a4531c065

Revision history for this message
Suganath Prabu (suganath) wrote :
Download full text (6.1 KiB)

Hi Michael,

Yes, those commits are correct. You need to apply last commit first.
I have reversed the order and below it is.

8dc8d29a00e29c679f027102fb9c6709347ca8ca scsi: mpt3sas: Introduce module parameter to override queue depth
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=8dc8d29a00e29c679f027102fb9c6709347ca8ca

d04a6edfed0b2e99d9a8385503737944db3d5649 scsi: mpt3sas: Register trace buffer based on NVDATA settings
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=d04a6edfed0b2e99d9a8385503737944db3d5649

4bc50dc1afb7b77dfc80a1f8f0742b14d6f6e376 scsi: mpt3sas: Display message before releasing diag buffer
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=4bc50dc1afb7b77dfc80a1f8f0742b14d6f6e376

782b281883caf70289ba6a186af29441a117d23e scsi: mpt3sas: Fix clear pending bit in ioctl status
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=782b281883caf70289ba6a186af29441a117d23e

764f472ba4a7a0c18107ebfbe1a9f1f5f5a1e411 scsi: mpt3sas: Free diag buffer without any status check
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=764f472ba4a7a0c18107ebfbe1a9f1f5f5a1e411

08e7378ee331a803cfdd91c512a3dea040f1da79 scsi: mpt3sas: Maintain owner of buffer through UniqueID
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=08e7378ee331a803cfdd91c512a3dea040f1da79

dd180e4eedfd85b80020a6fd566601f4765a9d69 scsi: mpt3sas: clear release bit when buffer reregistered
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=dd180e4eedfd85b80020a6fd566601f4765a9d69

a066f4c31359d07b1a2c5144b4b9a29901365fd0 scsi: mpt3sas: Reuse diag buffer allocated at load time
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=a066f4c31359d07b1a2c5144b4b9a29901365fd0

a8a6cbcd038de4ee3722c17edd7a4d84ce423f7d scsi: mpt3sas: Add app owned flag support for diag buffer
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=a8a6cbcd038de4ee3722c17edd7a4d84ce423f7d

29f571f8b4cc652cae9244630f714a610549d301 scsi: mpt3sas: Fail release cmnd if diag buffer is released
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=29f571f8b4cc652cae9244630f714a610549d301

b06ff10249036eec74fa8565503ac40d0ee92213 scsi: mpt3sas: Use Component img header to get Package ver
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=b06ff10249036eec74fa8565503ac40d0ee92213

77fd4f2c88bf83205a21f9ca49fdcc0c7868dba9 scsi: mpt3sas: Reject NVMe Encap cmnds to unsupported HBA
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=77fd4f2c88bf83205a21f9ca49fdcc0c7868dba9

9e64fd1e65f72d229f96fcf390576e772770a01c scsi: mpt3sas: Fix module parameter max_msix_vectors
https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/commit/?h=5.6/scsi-queue&id=9e64fd1e65f72d229f96fcf390576e772770a01c

d8b2625f4699a36b1753d87e96b0c50a4531c065 scsi: mpt3sas: Bump mpt3sas driver vers...

Read more...

Revision history for this message
Michael Reed (mreed8855) wrote :

Thanks for rearranging the patches as they did in fact apply cleanly.

Michael Reed (mreed8855)
description: updated
Changed in linux (Ubuntu):
status: Confirmed → In Progress
assignee: nobody → Michael Reed (mreed8855)
Revision history for this message
Michael Reed (mreed8855) wrote :

Hi Suganath

I have placed the test kernel at the following link, could you test it?

https://people.canonical.com/~mreed/lp1863574_mpt3sas/

Regards,
Michael

Revision history for this message
Suganath Prabu (suganath) wrote :

Hi Michael,

Thank you, I have download the images, Will test and update in a week.

Revision history for this message
Suganath Prabu (suganath) wrote :

Hi Michael,

I have covered basic sanity test with below test cases.
1) Reboot test and driver load/unload.
2) Drive Discovery and IO's.
3) IO's with Controller Resets.

Thanks,
Suganath

Michael Reed (mreed8855)
Changed in linux (Ubuntu Focal):
importance: Undecided → Medium
Michael Reed (mreed8855)
tags: added: focal hwcert-server
Stefan Bader (smb)
Changed in linux (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Michael Reed (mreed8855) wrote :

Hi Suganath,

Can you test this in proposed, it is available now in 5.4.0-23.27

https://launchpad.net/~canonical-kernel-team/+archive/ubuntu/proposed?field.series_filter=focal

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed.

Thank you,
Michael

Michael Reed (mreed8855)
tags: added: verification-done-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (35.2 KiB)

This bug was fixed in the package linux - 5.4.0-24.28

---------------
linux (5.4.0-24.28) focal; urgency=medium

  * focal/linux: 5.4.0-24.28 -proposed tracker (LP: #1871939)

  * getitimer returns it_value=0 erroneously (LP: #1349028)
    - [Config] CONTEXT_TRACKING_FORCE policy should be unset

  * 12d1:1038 Dual-Role OTG device on non-HNP port - unable to enumerate USB
    device on port 1 (LP: #1047527)
    - [Config] USB_OTG_FSM policy not needed

  * Add DCPD backlight support for HP CML system (LP: #1871589)
    - SAUCE: drm/i915: Force DPCD backlight mode for HP CML 2020 system

  * Backlight brightness cannot be adjusted using keys (LP: #1860303)
    - SAUCE drm/i915: Force DPCD backlight mode for HP Spectre x360 Convertible
      13t-aw100

  * CVE-2020-11494
    - slcan: Don't transmit uninitialized stack data in padding

  * Ubuntu Kernel Support for OpenPOWER NV Secure & Trusted Boot (LP: #1866909)
    - powerpc: Detect the secure boot mode of the system
    - powerpc/ima: Add support to initialize ima policy rules
    - powerpc: Detect the trusted boot state of the system
    - powerpc/ima: Define trusted boot policy
    - ima: Make process_buffer_measurement() generic
    - certs: Add wrapper function to check blacklisted binary hash
    - ima: Check against blacklisted hashes for files with modsig
    - powerpc/ima: Update ima arch policy to check for blacklist
    - powerpc/ima: Indicate kernel modules appended signatures are enforced
    - powerpc/powernv: Add OPAL API interface to access secure variable
    - powerpc: expose secure variables to userspace via sysfs
    - x86/efi: move common keyring handler functions to new file
    - powerpc: Load firmware trusted keys/hashes into kernel keyring
    - x86/efi: remove unused variables

  * [roce-0227]sync mainline kernel 5.6rc3 roce patchset into ubuntu HWE kernel
    branch (LP: #1864950)
    - RDMA/hns: Cleanups of magic numbers
    - RDMA/hns: Optimize eqe buffer allocation flow
    - RDMA/hns: Add the workqueue framework for flush cqe handler
    - RDMA/hns: Delayed flush cqe process with workqueue
    - RDMA/hns: fix spelling mistake: "attatch" -> "attach"
    - RDMA/hns: Initialize all fields of doorbells to zero
    - RDMA/hns: Treat revision HIP08_A as a special case
    - RDMA/hns: Use flush framework for the case in aeq
    - RDMA/hns: Stop doorbell update while qp state error
    - RDMA/hns: Optimize qp destroy flow
    - RDMA/hns: Optimize qp context create and destroy flow
    - RDMA/hns: Optimize qp number assign flow
    - RDMA/hns: Optimize qp buffer allocation flow
    - RDMA/hns: Optimize qp param setup flow
    - RDMA/hns: Optimize kernel qp wrid allocation flow
    - RDMA/hns: Optimize qp doorbell allocation flow
    - RDMA/hns: Check if depth of qp is 0 before configure

  * [hns3-0316]sync mainline kernel 5.6rc4 hns3 patchset into ubuntu HWE kernel
    branch (LP: #1867586)
    - net: hns3: modify an unsuitable print when setting unknown duplex to fibre
    - net: hns3: add enabled TC numbers and DWRR weight info in debugfs
    - net: hns3: add support for dump MAC ID and loopback status in debugfs
    - net: hns3: add missing help info for QS shaper...

Changed in linux (Ubuntu Focal):
status: Fix Committed → Fix Released
Changed in linux (Ubuntu Focal):
status: Fix Released → Confirmed
Revision history for this message
Jeff Lane (bladernr) wrote :

Hi Suganath, is there a reason why you re-opened this bug?

Revision history for this message
Suganath Prabu (suganath) wrote :

Sorry, I have closed it.
I have raised another bug "https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1935034" for Updating mpt3sas Driver to 38.100.00.00.

Changed in linux (Ubuntu Focal):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers