p54usb module in linux-modules-extra-5.0.0-23-generic does not work
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Disco |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
Eoan |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
== SRU Justification ==
User report that the p54usb driver will crash when trying to load it on 5.0 kernel for a Dell Wireless 1450 Dual-band (802.11a/b/g) USB 2.0 adapter. This was caused by commit e3554197 (p54: Use skb_peek_tail() instead of direct head pointer accesses.)
== Fix ==
* 1645ab93 (p54: fix crash during initialization)
This patch added a check for target_skb to determine where to queue the buffer. It can be cherry-picked into Disco.
Eoan got this patch from v5.2.1 upstream stable release update.
== Test ==
Test kernel could be found here:
https:/
This issue was reported against Bionic HWE 5.0 kernel, user confirmed that the patched B-hwe kernel can fix this issue.
== Regression Potential ==
Low, change limited to p54usb driver, patch tested with positive test result.
== Original Bug Report ==
I am using the Product: Dell Wireless 1450 Dual-band (802.11a/b/g) USB 2.0 Adapter
This relies on the p54usb driver. It works great on kernel 4.18. I upgraded to 5.0.0-3 and the device fails to start.
On the older kernel, things seem good:
[ 1255.546620] usb 3-1: new high-speed USB device number 3 using xhci_hcd
[ 1255.704106] usb 3-1: New USB device found, idVendor=413c, idProduct=8104, bcdDevice=10.50
[ 1255.704110] usb 3-1: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[ 1255.704112] usb 3-1: Product: Dell Wireless 1450 Dual-band (802.11a/b/g) USB 2.0 Adapter
[ 1255.704115] usb 3-1: Manufacturer: DELL
[ 1255.830808] usb 3-1: reset high-speed USB device number 3 using xhci_hcd
[ 1255.979753] usb 3-1: Loading firmware file isl3887usb
[ 1255.980055] ieee80211 phy1: p54 detected a LM87 firmware
[ 1255.980058] p54: rx_mtu reduced from 3240 to 2384
[ 1255.980060] ieee80211 phy1: FW rev 2.13.25.0 - Softmac protocol 5.9
[ 1255.980063] ieee80211 phy1: cryptographic accelerator WEP:YES, TKIP:YES, CCMP:YES
[ 1256.974586] ieee80211 phy1: hwaddr 00:14:a5:c6:56:ca, MAC:isl3892 RF:Xbow
[ 1256.976368] ieee80211 phy1: Selected rate control algorithm 'minstrel_ht'
[ 1256.976974] usb 3-1: is registered as 'phy1'
[ 1256.981866] p54usb 3-1:1.0 wlx0014a5c656ca: renamed from wlan0
I'm using:
Description: Ubuntu 18.04.3 LTS
Release: 18.04
Changed in linux-hwe (Ubuntu): | |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
affects: | linux-hwe (Ubuntu) → linux (Ubuntu) |
Changed in linux (Ubuntu Eoan): | |
status: | Incomplete → Fix Released |
Changed in linux (Ubuntu Disco): | |
status: | New → In Progress |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
Changed in linux (Ubuntu Eoan): | |
assignee: | Po-Hsu Lin (cypressyew) → nobody |
tags: | added: disco |
Changed in linux (Ubuntu Disco): | |
status: | In Progress → Fix Committed |
Aug 8 23:09:17 airbnb-desktop kernel: [ 15.932908] usbcore: registered new interface driver p54usb tx_pending+ 0x128/0x1b0 [p54common] eeprom+ 0xca/0x140 [p54common] eeprom+ 0x8c/0xc0 [p54common] firmware_ cb+0x140/ 0x1f0 [p54usb] temp_thermal intel_powerclamp kvmgt vfio_mdev snd_seq_midi mdev coretemp vfio_iommu_type1 snd_seq_midi_event vfio snd_rawmidi kvm drm_kms_helper irqbypass drm snd_seq i2c_algo_bit snd_seq_device fb_sys_fops snd_timer syscopyarea crct10dif_pclmul crc32_pclmul sysfillrect ghash_clmulni_intel sysimgblt aesni_intel snd soundcore mei_me aes_x86_64 crypto_simd mei cryptd glue_helper lpc_ich ie31200_edac intel_cstate intel_rapl_perf mac_hid wmi_bmof sch_fq_codel parport_pc ppdev lp parport ip_tables x_tables autofs4 hid_generic usbhid hid e1000e ahci libahci wmi video tx_pending+ 0x128/0x1b0 [p54common] tx_pending+ 0x128/0x1b0 [p54common] eeprom+ 0xca/0x140 [p54common] eeprom+ 0x8c/0xc0 [p54common] firmware_ cb+0x140/ 0x1f0 [p54usb] codec_realtek snd_hda_ codec_generic ledtrig_audio p54usb p54common mac80211 cfg80211 snd_hda_intel snd_hda_codec snd_hda_core snd_hwdep input_leds i915 snd_pcm intel_rapl x86_pkg_ temp_thermal intel_powerclamp kvmgt vfio_mdev snd_seq_midi mdev coretemp vfio_iommu_type1 snd_seq_midi_event vfio snd_rawmidi kvm drm_kms_helper irqbypass drm snd_seq i2c_algo_bit snd_seq_device fb_sys_fops snd_timer syscopyarea crct10dif_pclmul crc32_pclmul sysfillrect ghash_clmulni_intel sysimgblt aesni_intel snd soundcore mei_me aes_x86_64 crypto_simd mei cryptd glue_helper lpc_ich ie31200_edac intel_cstate intel_rapl_perf mac_hid wmi_bmof sch_fq_codel parport_pc ppdev lp parport ip_tables x_tables autofs4 hid_generic usbhid hid e1000e ahci libahci wmi video
Aug 8 23:09:17 airbnb-desktop kernel: [ 15.998959] ieee80211 phy0: p54 detected a LM87 firmware
Aug 8 23:09:17 airbnb-desktop kernel: [ 15.998960] p54: rx_mtu reduced from 3240 to 2384
Aug 8 23:09:17 airbnb-desktop kernel: [ 16.239810] RIP: 0010:p54_
Aug 8 23:09:17 airbnb-desktop kernel: [ 16.239822] p54_tx+0x1e/0x30 [p54common]
Aug 8 23:09:17 airbnb-desktop kernel: [ 16.239824] p54_download_
Aug 8 23:09:17 airbnb-desktop kernel: [ 16.239825] p54_read_
Aug 8 23:09:17 airbnb-desktop kernel: [ 16.239827] p54u_load_
Aug 8 23:09:17 airbnb-desktop kernel: [ 16.239840] Modules linked in: p54usb p54common mac80211 cfg80211 snd_hda_intel snd_hda_codec snd_hda_core snd_hwdep input_leds i915 snd_pcm intel_rapl x86_pkg_
Aug 8 23:09:17 airbnb-desktop kernel: [ 16.239859] RIP: 0010:p54_
Aug 8 23:13:05 airbnb-desktop kernel: [ 256.789506] ieee80211 phy1: p54 detected a LM87 firmware
Aug 8 23:13:05 airbnb-desktop kernel: [ 256.789510] p54: rx_mtu reduced from 3240 to 2384
Aug 8 23:13:05 airbnb-desktop kernel: [ 256.990501] RIP: 0010:p54_
Aug 8 23:13:05 airbnb-desktop kernel: [ 256.990529] p54_tx+0x1e/0x30 [p54common]
Aug 8 23:13:05 airbnb-desktop kernel: [ 256.990533] p54_download_
Aug 8 23:13:05 airbnb-desktop kernel: [ 256.990537] p54_read_
Aug 8 23:13:05 airbnb-desktop kernel: [ 256.990541] p54u_load_
Aug 8 23:13:05 airbnb-desktop kernel: [ 256.990568] Modules linked in: snd_hda_codec_hdmi snd_hda_
Aug 8 23:13:05 airbnb-desktop kernel: [ 25...