| 2019-01-18 09:01:39 |
Po-Hsu Lin |
bug |
|
|
added bug |
| 2019-01-18 09:01:49 |
Po-Hsu Lin |
linux (Ubuntu): assignee |
|
Po-Hsu Lin (cypressyew) |
|
| 2019-01-18 09:01:54 |
Po-Hsu Lin |
nominated for series |
|
Ubuntu Bionic |
|
| 2019-01-18 09:30:16 |
Ubuntu Kernel Bot |
linux (Ubuntu): status |
New |
Incomplete |
|
| 2019-01-18 10:37:20 |
Po-Hsu Lin |
linux (Ubuntu): status |
Incomplete |
In Progress |
|
| 2019-01-18 10:43:24 |
Po-Hsu Lin |
nominated for series |
|
Ubuntu Xenial |
|
| 2019-01-18 10:43:33 |
Po-Hsu Lin |
nominated for series |
|
Ubuntu Trusty |
|
| 2019-01-18 10:46:48 |
Po-Hsu Lin |
bug task added |
|
ubuntu-kernel-tests |
|
| 2019-03-28 14:10:34 |
Kleber Sacilotto de Souza |
bug task added |
|
linux (Ubuntu Bionic) |
|
| 2019-03-28 14:10:39 |
Kleber Sacilotto de Souza |
bug task added |
|
linux (Ubuntu Trusty) |
|
| 2019-03-28 14:10:43 |
Kleber Sacilotto de Souza |
bug task added |
|
linux (Ubuntu Xenial) |
|
| 2019-05-28 07:58:19 |
Po-Hsu Lin |
linux (Ubuntu): status |
In Progress |
Confirmed |
|
| 2019-05-28 07:58:22 |
Po-Hsu Lin |
linux (Ubuntu): assignee |
Po-Hsu Lin (cypressyew) |
|
|
| 2019-09-16 12:53:10 |
Po-Hsu Lin |
tags |
|
ubuntu-kernel-selftests |
|
| 2019-09-16 12:53:34 |
Po-Hsu Lin |
tags |
ubuntu-kernel-selftests |
bionic trusty ubuntu-kernel-selftests |
|
| 2019-09-16 12:53:41 |
Po-Hsu Lin |
tags |
bionic trusty ubuntu-kernel-selftests |
bionic trusty ubuntu-kernel-selftests xenial |
|
| 2019-09-18 12:59:06 |
Po-Hsu Lin |
linux (Ubuntu Trusty): status |
New |
Invalid |
|
| 2019-09-26 13:51:19 |
Sean Feole |
tags |
bionic trusty ubuntu-kernel-selftests xenial |
bionic sru-20190902 trusty ubuntu-kernel-selftests xenial |
|
| 2019-09-26 13:51:37 |
Sean Feole |
tags |
bionic sru-20190902 trusty ubuntu-kernel-selftests xenial |
bionic linux-kvm sru-20190902 trusty ubuntu-kernel-selftests xenial |
|
| 2019-10-30 09:20:23 |
Po-Hsu Lin |
linux (Ubuntu Bionic): assignee |
|
Po-Hsu Lin (cypressyew) |
|
| 2019-10-30 09:20:26 |
Po-Hsu Lin |
linux (Ubuntu Bionic): status |
New |
In Progress |
|
| 2019-11-06 09:04:53 |
Po-Hsu Lin |
ubuntu-kernel-tests: assignee |
|
Po-Hsu Lin (cypressyew) |
|
| 2019-11-06 09:04:56 |
Po-Hsu Lin |
ubuntu-kernel-tests: status |
New |
In Progress |
|
| 2019-11-06 09:32:27 |
Po-Hsu Lin |
description |
In the selftests tool, we are using a KSFT_SKIP=4 return code for those skipped tests in the latest upstream kernel tree.
But the corresponding code to take care of this return value does not exist in Bionic and Xenial kernel, this will cause the test still being marked as failed:
selftests: test_user_copy.sh
========================================
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL] |
== Justification ==
In the ubuntu_kernel_selftests, the skipped test will uses return code 4 (KSFT_SKIP).
However the code to handle this non-zero return code was not implemented in the kselftest framework. And this will generate some false-positives results as those skipped tests were treated as a failure.
For example the raw_skew test in timers on 4.15:
1..0 # Skipped: The clock was adjusted externally. Shutdown NTPd or other time sync daemons
not ok 1..7 selftests: raw_skew [FAIL]
And the test_user_copy.sh test in user:
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL]
== Fix ==
771cbc3b (selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers)
a3355440 (selftests: Fix lib.mk run_tests target shell script)
42b44c34 (selftests: lib.mk: cleanup RUN_TESTS define and make it readable)
3f4435b5 (selftests: lib.mk: add SKIP handling to RUN_TESTS define)
All these can be cherry-picked into Bionic.
The crucial patch is commit 3f4435b5, the other three patches just paves the road for it to be cherry-picked.
== Test ==
Tested on a Bionic amd64 node, the result shows positive outcome.
A test summary before the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END ERROR ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrace
A test summary after the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END GOOD ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrac
The raw_skew test in timers is now marked as [SKIPPED] and no longer causing failure.
A complete test report could be found in the bug report attachment.
== Regression Potential ==
Low, this patch set just added support to handle the skip return code and changes are limited to the kselftest framework itself, no actual impact to normal users.
In the selftests tool, we are using a KSFT_SKIP=4 return code for those skipped tests in the latest upstream kernel tree.
But the corresponding code to take care of this return value does not exist in Bionic and Xenial kernel, this will cause the test still being marked as failed:
selftests: test_user_copy.sh
========================================
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL] |
|
| 2019-11-06 09:33:57 |
Po-Hsu Lin |
attachment added |
|
B-client.DEBUG https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1812352/+attachment/5303235/+files/B-client.DEBUG |
|
| 2019-11-06 09:34:14 |
Po-Hsu Lin |
attachment added |
|
B-client.DEBUG-patched https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1812352/+attachment/5303236/+files/B-client.DEBUG-patched |
|
| 2019-11-06 09:34:49 |
Po-Hsu Lin |
description |
== Justification ==
In the ubuntu_kernel_selftests, the skipped test will uses return code 4 (KSFT_SKIP).
However the code to handle this non-zero return code was not implemented in the kselftest framework. And this will generate some false-positives results as those skipped tests were treated as a failure.
For example the raw_skew test in timers on 4.15:
1..0 # Skipped: The clock was adjusted externally. Shutdown NTPd or other time sync daemons
not ok 1..7 selftests: raw_skew [FAIL]
And the test_user_copy.sh test in user:
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL]
== Fix ==
771cbc3b (selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers)
a3355440 (selftests: Fix lib.mk run_tests target shell script)
42b44c34 (selftests: lib.mk: cleanup RUN_TESTS define and make it readable)
3f4435b5 (selftests: lib.mk: add SKIP handling to RUN_TESTS define)
All these can be cherry-picked into Bionic.
The crucial patch is commit 3f4435b5, the other three patches just paves the road for it to be cherry-picked.
== Test ==
Tested on a Bionic amd64 node, the result shows positive outcome.
A test summary before the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END ERROR ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrace
A test summary after the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END GOOD ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrac
The raw_skew test in timers is now marked as [SKIPPED] and no longer causing failure.
A complete test report could be found in the bug report attachment.
== Regression Potential ==
Low, this patch set just added support to handle the skip return code and changes are limited to the kselftest framework itself, no actual impact to normal users.
In the selftests tool, we are using a KSFT_SKIP=4 return code for those skipped tests in the latest upstream kernel tree.
But the corresponding code to take care of this return value does not exist in Bionic and Xenial kernel, this will cause the test still being marked as failed:
selftests: test_user_copy.sh
========================================
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL] |
== Justification ==
In the ubuntu_kernel_selftests, the skipped test will uses return code 4 (KSFT_SKIP).
However the code to handle this non-zero return code was not implemented in the kselftest framework. And this will generate some false-positives results as those skipped tests were treated as a failure.
For example the raw_skew test in timers on 4.15:
1..0 # Skipped: The clock was adjusted externally. Shutdown NTPd or other time sync daemons
not ok 1..7 selftests: raw_skew [FAIL]
And the test_user_copy.sh test in user (failure could be found in KVM kernels):
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL]
== Fix ==
771cbc3b (selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers)
a3355440 (selftests: Fix lib.mk run_tests target shell script)
42b44c34 (selftests: lib.mk: cleanup RUN_TESTS define and make it readable)
3f4435b5 (selftests: lib.mk: add SKIP handling to RUN_TESTS define)
All these can be cherry-picked into Bionic.
The crucial patch is commit 3f4435b5, the other three patches just paves the road for it to be cherry-picked.
== Test ==
Tested on a Bionic amd64 node, the result shows positive outcome.
A test summary before the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END ERROR ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrace
A test summary after the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END GOOD ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrac
The raw_skew test in timers is now marked as [SKIPPED] and no longer causing failure.
A complete test report could be found in the bug report attachment.
== Regression Potential ==
Low, this patch set just added support to handle the skip return code and changes are limited to the kselftest framework itself, no actual impact to normal users.
In the selftests tool, we are using a KSFT_SKIP=4 return code for those skipped tests in the latest upstream kernel tree.
But the corresponding code to take care of this return value does not exist in Bionic and Xenial kernel, this will cause the test still being marked as failed:
selftests: test_user_copy.sh
========================================
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL] |
|
| 2019-11-06 10:15:26 |
Po-Hsu Lin |
summary |
Handle the skip return code in kernel_selftests |
Handle the skip return code in kernel_selftests on Bionic |
|
| 2019-11-06 10:16:41 |
Po-Hsu Lin |
linux (Ubuntu Xenial): status |
New |
Invalid |
|
| 2019-11-06 10:18:20 |
Po-Hsu Lin |
linux (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2019-11-06 10:20:05 |
Po-Hsu Lin |
description |
== Justification ==
In the ubuntu_kernel_selftests, the skipped test will uses return code 4 (KSFT_SKIP).
However the code to handle this non-zero return code was not implemented in the kselftest framework. And this will generate some false-positives results as those skipped tests were treated as a failure.
For example the raw_skew test in timers on 4.15:
1..0 # Skipped: The clock was adjusted externally. Shutdown NTPd or other time sync daemons
not ok 1..7 selftests: raw_skew [FAIL]
And the test_user_copy.sh test in user (failure could be found in KVM kernels):
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL]
== Fix ==
771cbc3b (selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers)
a3355440 (selftests: Fix lib.mk run_tests target shell script)
42b44c34 (selftests: lib.mk: cleanup RUN_TESTS define and make it readable)
3f4435b5 (selftests: lib.mk: add SKIP handling to RUN_TESTS define)
All these can be cherry-picked into Bionic.
The crucial patch is commit 3f4435b5, the other three patches just paves the road for it to be cherry-picked.
== Test ==
Tested on a Bionic amd64 node, the result shows positive outcome.
A test summary before the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END ERROR ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrace
A test summary after the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END GOOD ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrac
The raw_skew test in timers is now marked as [SKIPPED] and no longer causing failure.
A complete test report could be found in the bug report attachment.
== Regression Potential ==
Low, this patch set just added support to handle the skip return code and changes are limited to the kselftest framework itself, no actual impact to normal users.
In the selftests tool, we are using a KSFT_SKIP=4 return code for those skipped tests in the latest upstream kernel tree.
But the corresponding code to take care of this return value does not exist in Bionic and Xenial kernel, this will cause the test still being marked as failed:
selftests: test_user_copy.sh
========================================
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL] |
== Justification ==
In the ubuntu_kernel_selftests, the skipped test will uses return code 4 (KSFT_SKIP).
However the code to handle this non-zero return code was not implemented in the kselftest framework. And this will generate some false-positives results as those skipped tests were treated as a failure.
For example the raw_skew test in timers on 4.15:
1..0 # Skipped: The clock was adjusted externally. Shutdown NTPd or other time sync daemons
not ok 1..7 selftests: raw_skew [FAIL]
And the test_user_copy.sh test in user (failure could be found in KVM kernels):
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL]
== Fix ==
771cbc3b (selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers)
a3355440 (selftests: Fix lib.mk run_tests target shell script)
42b44c34 (selftests: lib.mk: cleanup RUN_TESTS define and make it readable)
3f4435b5 (selftests: lib.mk: add SKIP handling to RUN_TESTS define)
All these can be cherry-picked into Bionic.
The crucial patch is commit 3f4435b5, the other three patches just paves the road for it to be cherry-picked.
== Test ==
Tested on a Bionic amd64 node, the result shows positive outcome.
A test summary before the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END ERROR ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrace
A test summary after the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END GOOD ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrac
The raw_skew test in timers is now marked as [SKIPPED] and no longer causing failure.
A complete test report could be found in the bug report attachment.
== Regression Potential ==
Low, this patch set just added support to handle the skip return code and changes are limited to the kselftest framework itself, no actual impact to normal users.
== Original bug report ==
In the selftests tool, we are using a KSFT_SKIP=4 return code for those skipped tests in the latest upstream kernel tree.
But the corresponding code to take care of this return value does not exist in Bionic and Xenial kernel, this will cause the test still being marked as failed:
selftests: test_user_copy.sh
========================================
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL] |
|
| 2019-11-06 10:27:53 |
Po-Hsu Lin |
description |
== Justification ==
In the ubuntu_kernel_selftests, the skipped test will uses return code 4 (KSFT_SKIP).
However the code to handle this non-zero return code was not implemented in the kselftest framework. And this will generate some false-positives results as those skipped tests were treated as a failure.
For example the raw_skew test in timers on 4.15:
1..0 # Skipped: The clock was adjusted externally. Shutdown NTPd or other time sync daemons
not ok 1..7 selftests: raw_skew [FAIL]
And the test_user_copy.sh test in user (failure could be found in KVM kernels):
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL]
== Fix ==
771cbc3b (selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers)
a3355440 (selftests: Fix lib.mk run_tests target shell script)
42b44c34 (selftests: lib.mk: cleanup RUN_TESTS define and make it readable)
3f4435b5 (selftests: lib.mk: add SKIP handling to RUN_TESTS define)
All these can be cherry-picked into Bionic.
The crucial patch is commit 3f4435b5, the other three patches just paves the road for it to be cherry-picked.
== Test ==
Tested on a Bionic amd64 node, the result shows positive outcome.
A test summary before the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END ERROR ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrace
A test summary after the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END GOOD ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrac
The raw_skew test in timers is now marked as [SKIPPED] and no longer causing failure.
A complete test report could be found in the bug report attachment.
== Regression Potential ==
Low, this patch set just added support to handle the skip return code and changes are limited to the kselftest framework itself, no actual impact to normal users.
== Original bug report ==
In the selftests tool, we are using a KSFT_SKIP=4 return code for those skipped tests in the latest upstream kernel tree.
But the corresponding code to take care of this return value does not exist in Bionic and Xenial kernel, this will cause the test still being marked as failed:
selftests: test_user_copy.sh
========================================
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL] |
== Justification ==
In the ubuntu_kernel_selftests, the skipped test will uses return code 4
(KSFT_SKIP).
However the code to handle this non-zero return code was not implemented
in the kselftest framework. And this will generate some false-positive
results as those skipped tests were treated as a failure.
For example the raw_skew test in timers on 4.15:
1..0 # Skipped: The clock was adjusted externally. Shutdown NTPd or other time sync daemons
not ok 1..7 selftests: raw_skew [FAIL]
And the test_user_copy.sh test in user (failure could be found in KVM kernels):
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL]
Xenial is affected by this issue as well. Considering the fact that this issue in Bionic affects more tests / kernel variants, and it's way easier to fix this in Bionic, I decided to go for Bionic first.
== Fix ==
771cbc3b (selftests: lib.mk set KSFT_TAP_LEVEL to prevent nested TAP headers)
a3355440 (selftests: Fix lib.mk run_tests target shell script)
42b44c34 (selftests: lib.mk: cleanup RUN_TESTS define and make it readable)
3f4435b5 (selftests: lib.mk: add SKIP handling to RUN_TESTS define)
All these can be cherry-picked into Bionic.
The crucial patch is commit 3f4435b5, the other three patches are just
some minor fixes that pave the road for it to be cherry-picked.
== Test ==
Tested on a Bionic amd64 node, the result shows positive.
A test summary before the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END ERROR ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrace
A test summary after the patch:
END GOOD ubuntu_kernel_selftests.setup
END GOOD ubuntu_kernel_selftests.breakpoints
END GOOD ubuntu_kernel_selftests.cpu-hotplug
END GOOD ubuntu_kernel_selftests.efivarfs
END GOOD ubuntu_kernel_selftests.memfd
END GOOD ubuntu_kernel_selftests.memory-hotplug
END GOOD ubuntu_kernel_selftests.mount
END GOOD ubuntu_kernel_selftests.net
END GOOD ubuntu_kernel_selftests.ptrace
END GOOD ubuntu_kernel_selftests.seccomp
END GOOD ubuntu_kernel_selftests.timers
END GOOD ubuntu_kernel_selftests.powerpc
END GOOD ubuntu_kernel_selftests.user
END GOOD ubuntu_kernel_selftests.ftrac
No tests were skipped unintentionally. And the raw_skew test in timers
is now marked as [SKIPPED] and no longer causing failure.
A complete test report could be found in the bug report attachment.
== Regression Potential ==
Low, this patch set just added support to handle the skip return code
and changes are limited to the kselftest framework itself, no actual
impact to normal users.
== Original bug report ==
In the selftests tool, we are using a KSFT_SKIP=4 return code for those skipped tests in the latest upstream kernel tree.
But the corresponding code to take care of this return value does not exist in Bionic and Xenial kernel, this will cause the test still being marked as failed:
selftests: test_user_copy.sh
========================================
user: module test_user_copy is not found [SKIP]
not ok 1..1 selftests: test_user_copy.sh [FAIL] |
|
| 2019-11-13 05:31:07 |
Khaled El Mously |
linux (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2019-11-14 18:48:36 |
Ubuntu Kernel Bot |
tags |
bionic linux-kvm sru-20190902 trusty ubuntu-kernel-selftests xenial |
bionic linux-kvm sru-20190902 trusty ubuntu-kernel-selftests verification-needed-bionic xenial |
|
| 2019-11-19 02:44:52 |
Po-Hsu Lin |
ubuntu-kernel-tests: status |
In Progress |
Fix Released |
|
| 2019-11-19 02:48:29 |
Po-Hsu Lin |
tags |
bionic linux-kvm sru-20190902 trusty ubuntu-kernel-selftests verification-needed-bionic xenial |
bionic linux-kvm sru-20190902 trusty ubuntu-kernel-selftests verification-done-bionic xenial |
|
| 2019-11-19 02:48:49 |
Po-Hsu Lin |
tags |
bionic linux-kvm sru-20190902 trusty ubuntu-kernel-selftests verification-done-bionic xenial |
bionic linux-kvm sru-20190902 trusty ubuntu-kernel-selftests verification-done-bionic |
|
| 2019-12-02 13:04:55 |
Launchpad Janitor |
linux (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
