HDMI/DP audio can't work on the laptop of Dell Latitude 5495
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
HWE Next |
Fix Released
|
Undecided
|
Unassigned | ||
linux (Ubuntu) |
Fix Released
|
Critical
|
Hui Wang | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned | ||
linux-oem (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
In the v2:
the patchset is also sent to OEM-B since the OEM project is waiting for the patchset.
The v1 introduced a building error, my investigation is shown as below:
The declaration of "enum vga_switcheroo_
exist in the kernel (bionic, artful) for a long time, but "-Werror=
that is because the patch touches the definition of "enum vga_switcheroo_
I guess if the definition of enum includes negative number, the c compiler treat it as int type, that is why artful and bionic did not expose building error before.
To fix the building error, I cherry-picked 4 more patches [3/6-6/6], and the purpose of those 4 patches is straightforward.
In the v1:
This bug comes from the OEM project, and the engineer Jim Qu from AMD took almost 2 weeks to investigate this problem, then he worte two patches to fix this problem and now the patches are merged to sound repository.
According to Jim Qu's investigation, the root cause of this problem is:
1. there is two GPU on the system. iGPU has a audio codec for HDMI output, and dGPU is without audio codec it is only for offload rendering.
2. under runtime pm, when dGPU suspend, amdgpu will also call vgaswitchroo driver to power off audio which vgaswitchroo client is VGA_SWITCHEROO_DIS.
3. In current HDA audio driver, the iGPU's audio will register to vgaswitchroo as VGA_SWITCHEROO_DIS, therefore, the audio will be selected and powered off by runtime pm.
[Impact]
On the Dell Latitude 5495, If we plug a monitor with audio capability to the HDMI/DP ports, we can't find HDMI/DP audio sinks as expected, then we can't play any sound through HDMI/DP audio.
[Fix]
With these 6 patches, the driver will not always set vgaswicheroo clients of HDA audio as VGA_SWITCHEROO_DIS, it will set it to _DIS or _IGD with the help of callback function of DRM drivers. So on this machine, the vgaswicheroo client will be set _IGD, then it will not be powered off when discrete gpu is powered off.
[Test Case]
We tested plug/unplug detection and playback through HDMI/DP audio, everything works well.
[Regression Potential]
Very low, without these 6 patches, the vgaswitchroo client of audio will be set to _DIS unconditionally, it did not expose any problem because in the past, all the HDMI/DP audio codecs are in the discreate GPU. But on Latitude 5495, the HDMI/DP audio codec is in the integrated GPU, so we need to change the driver to let DRM driver decide if it is _DIS or _IGD, it will not introduce regression for
old mahcines on old machines, the client will be set to _DIS as before.
And we have tested these two patches on some old machines with two gpus like A+A, I+A and I+N, all of them worked well as before.
tags: | added: originate-from-1775331 somerville |
Changed in linux (Ubuntu): | |
importance: | Undecided → Critical |
description: | updated |
description: | updated |
description: | updated |
Changed in linux (Ubuntu Bionic): | |
status: | New → Fix Committed |
Changed in linux (Ubuntu): | |
status: | Incomplete → Fix Committed |
Changed in linux-oem (Ubuntu): | |
status: | New → Invalid |
Changed in hwe-next: | |
status: | New → Fix Released |
Changed in linux-oem (Ubuntu): | |
status: | Invalid → Fix Released |
tags: |
added: verification-done-bionic removed: verification-needed-bionic |
tags: | added: cscc |
This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:
apport-collect 1782689
and then change the status of the bug to 'Confirmed'.
If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.
This change has been made by an automated script, maintained by the Ubuntu Kernel Team.