[Samsung NP900X3G-S01US] Horizontal lines after update to 4.13.0-43

[Frank Winklmeier]

After updating my Ubuntu 16.04 kernel from 4.13.0-41 to 4.13.0-43, I am seeing horizontal lines on the display. Rebooting into -41 makes them disappear. This is most likely the same problem as seen in 18.04 by another user: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1771204 (also see the attached photo there)

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: linux-image-4.13.0-43-generic 4.13.0-43.48~16.04.1
ProcVersionSignature: Ubuntu 4.13.0-43.48~16.04.1-generic 4.13.16
Uname: Linux 4.13.0-43-generic x86_64
NonfreeKernelModules: openafs
ApportVersion: 2.20.1-0ubuntu2.17
Architecture: amd64
CurrentDesktop: Unity
Date: Sat May 26 22:56:48 2018
InstallationDate: Installed on 2014-05-19 (1468 days ago)
InstallationMedia: Ubuntu 14.04 LTS "Trusty Tahr" - Release amd64 (20140417)
SourcePackage: linux-hwe
UpgradeStatus: No upgrade log present (probably fresh install)
---
ApportVersion: 2.20.1-0ubuntu2.17
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: fwinkl 2305 F.... pulseaudio
 /dev/snd/controlC1: fwinkl 2305 F.... pulseaudio
DistroRelease: Ubuntu 16.04
HibernationDevice: RESUME=UUID=00a4b15e-a4f1-4b35-9c8a-5ea33b1c6762
InstallationDate: Installed on 2014-05-19 (1468 days ago)
InstallationMedia: Ubuntu 14.04 LTS "Trusty Tahr" - Release amd64 (20140417)
MachineType: SAMSUNG ELECTRONICS CO., LTD. 900X3G
NonfreeKernelModules: openafs
Package: linux (not installed)
ProcFB: 0 inteldrmfb
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-4.13.0-43-generic root=UUID=ed5ec6cc-07cf-4e98-8b4e-efa0ba2d07a9 ro quiet splash vt.handoff=7
ProcVersionSignature: Ubuntu 4.13.0-43.48~16.04.1-generic 4.13.16
PulseList:
 Error: command ['pacmd', 'list'] failed with exit code 1: Home directory not accessible: Permission denied
 No PulseAudio daemon running, or not running as session daemon.
RelatedPackageVersions:
 linux-restricted-modules-4.13.0-43-generic N/A
 linux-backports-modules-4.13.0-43-generic N/A
 linux-firmware 1.157.18
Tags: xenial
Uname: Linux 4.13.0-43-generic x86_64
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups:

_MarkForUpload: True
dmi.bios.date: 10/31/2014
dmi.bios.vendor: American Megatrends Inc.
dmi.bios.version: P07ADU.029.141031.PS
dmi.board.asset.tag: No Asset Tag
dmi.board.name: NP900X3G-S01US
dmi.board.vendor: SAMSUNG ELECTRONICS CO., LTD.
dmi.board.version: SAMSUNG_SW_REVISION_1234567890ABCD
dmi.chassis.asset.tag: No Asset Tag
dmi.chassis.type: 9
dmi.chassis.vendor: SAMSUNG ELECTRONICS CO., LTD.
dmi.chassis.version: N/A
dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvrP07ADU.029.141031.PS:bd10/31/2014:svnSAMSUNGELECTRONICSCO.,LTD.:pn900X3G:pvrP07ADU:rvnSAMSUNGELECTRONICSCO.,LTD.:rnNP900X3G-S01US:rvrSAMSUNG_SW_REVISION_1234567890ABCD:cvnSAMSUNGELECTRONICSCO.,LTD.:ct9:cvrN/A:
dmi.product.family: SAMSUNG SENS
dmi.product.name: 900X3G
dmi.product.version: P07ADU
dmi.sys.vendor: SAMSUNG ELECTRONICS CO., LTD.

[penalvch (penalvch)]

Frank Winklmeier, thank you for reporting this and helping make Ubuntu better.

Could you please run the following command once from a terminal by ensuring you have the package xdiagnose installed, and that you click the Yes button for attaching additional debugging information:
apport-collect 1773581

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

apport information

[Frank Winklmeier (frank-winklmeier)]

I have attached the additional apport information. I hope it's what you wanted.

[penalvch (penalvch)]

Frank Winklmeier, in order to allow additional upstream mainline kernel developers to examine the issue, at your earliest convenience, could you please test the latest mainline kernel available from http://kernel.ubuntu.com/~kernel-ppa/mainline/?C=N;O=D ? Please keep in mind the following:
1) The one to test is at the very top line at the top of the page (not the daily folder).
2) The release names are irrelevant.
3) The folder time stamps aren't indicative of when the kernel actually was released upstream.
4) Install instructions are available at https://wiki.ubuntu.com/Kernel/MainlineBuilds .

If testing on your main install would be inconvenient, one may:
1) Install Ubuntu to a different partition and then test this there.
2) Backup, or clone the primary install.

If the latest kernel did not allow you to test to the issue (ex. you couldn't boot into the OS) please make a comment in your report about this, and continue to test the next most recent kernel version until you can test to the issue. Once you've tested the mainline kernel, please comment on which kernel version specifically you tested. If this issue is not reproducible in the mainline kernel, please add the following tags by clicking on the yellow circle with a black pencil icon, next to the word Tags, located at the bottom of the Bug Description:
kernel-fixed-upstream
kernel-fixed-upstream-X.Y-rcZ

Where X, and Y are the first two numbers of the kernel version, and Z is the release candidate number if it exists.

If the issue is reproducible with the mainline kernel, please add the following tags:
kernel-bug-exists-upstream
kernel-bug-exists-upstream-X.Y-rcZ

Please note, an error to install the kernel does not fit the criteria of kernel-bug-exists-upstream.

Also, you don't need to apport-collect further unless specifically requested to do so.

It is most helpful that after testing of the latest mainline kernel is complete, you mark this report Status Confirmed.

Lastly, to keep this issue relevant to upstream, please continue to test the latest mainline kernel as it becomes available.

Thank you for your help.

[Frank Winklmeier (frank-winklmeier)]

The instructions at https://wiki.ubuntu.com/Kernel/MainlineBuilds don't seem to work anymore for recent kernels:

Unpacking linux-modules-4.17.0-041700rc6-generic (4.17.0-041700rc6.201805202330) ...
dpkg: dependency problems prevent configuration of linux-headers-4.17.0-041700rc6-generic:
 linux-headers-4.17.0-041700rc6-generic depends on linux-headers-4.17.0-041700rc6; however:
  Package linux-headers-4.17.0-041700rc6 is not installed.
 linux-headers-4.17.0-041700rc6-generic depends on libssl1.1 (>= 1.1.0); however:
  Package libssl1.1 is not installed.

dpkg: error processing package linux-headers-4.17.0-041700rc6-generic (--install):
 dependency problems - leaving unconfigured

So unless someone can advice how to install a recent mainline kernel on 16.04 I cannot test with a more recent kernel.

Looking at the source code diffs between 4.13.0-41 and 4.13.0-43 my guess is that it is a regression introduced by https://bugs.launchpad.net/ubuntu/+source/linux-oem/+bug/1763271

[penalvch (penalvch)]

Frank Winklmeier:

>"The instructions at https://wiki.ubuntu.com/Kernel/MainlineBuilds don't seem to work anymore for recent kernels: Unpacking linux-modules-4.17.0-041700rc6-generic (4.17.0-041700rc6.201805202330) ...
dpkg: dependency problems prevent configuration of linux-headers-4.17.0-041700rc6-generic:
 linux-headers-4.17.0-041700rc6-generic depends on linux-headers-4.17.0-041700rc6; however:
  Package linux-headers-4.17.0-041700rc6 is not installed. linux-headers-4.17.0-041700rc6-generic depends on libssl1.1 (>= 1.1.0); however: Package libssl1.1 is not installed. dpkg: error processing package linux-headers-4.17.0-041700rc6-generic (--install): dependency problems - leaving unconfigured
So unless someone can advice how to install a recent mainline kernel on 16.04 I cannot test with a more recent kernel."

As advised previously in https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773581/comments/18:
"If the latest kernel did not allow you to test to the issue (ex. you couldn't boot into the OS) please make a comment in your report about this, and continue to test the next most recent kernel version until you can test to the issue."

>"Looking at the source code diffs between 4.13.0-41 and 4.13.0-43 my guess is that it is a regression introduced by https://bugs.launchpad.net/ubuntu/+source/linux-oem/+bug/1763271"

Unfortunately, speculation on what may or may not be a regression isn't helpful.

Despite this, if you think it is a regression, please confirm so following https://wiki.ubuntu.com/Kernel/KernelBisection and advise which commit specifically you tested that when reverted is the root cause here.

[AceLan Kao (acelankao)]

I reverted the suspicious commit

commit 2103fba9710ece54a38b2ae16359d59e904521b5 (HEAD -> refs/heads/master)
Author: AceLan Kao <email address hidden>
Date: Mon May 28 23:09:37 2018 -0400

    Revert "drm/i915/edp: Do not do link training fallback or prune modes on EDP"

    This reverts commit 116b5d52ac58a123903bfbb876c8024cfcd7b745.

And here is the test kernel, please try and check if it helps, and please make sure you boot the machine with the correct kernel, this is unsigned version.
Thanks.
   http://people.canonical.com/~acelan/bugs/lp1773581/

[Frank Winklmeier (frank-winklmeier)]

Sorry for the delay. I just manged to test the patched kernel:

> uname -a
Linux winki 4.13.0-43-generic #48 SMP Tue May 29 03:12:08 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

but unfortunately that didn't solve the issue (see attached photo). I wonder if some of the other three commits are responsible:

> git log --oneline Ubuntu-hwe-4.13.0-41.46_16.04.1..Ubuntu-hwe-4.13.0-43.48_16.04.1 -- drivers/gpu/drm/i915

116b5d5 drm/i915/edp: Do not do link training fallback or prune modes on EDP
01a7507 drm/i915/dp: make is_edp non-static and rename to intel_dp_is_edp
a3b2967 drm/i915/dp: rename intel_dp_is_edp to intel_dp_is_port_edp
9081fd9 drm/i915/edp: Allow alternate fixed mode for eDP if available.

[Frank Winklmeier (frank-winklmeier)]

I just compiled my own 4.13.0-43 kernel reverting all of the above 4 commits and I confirm that this fixes the problem with the horizontal lines:

[winki] ~/git/ubuntu-xenial > uname -a
Linux winki 4.13.0-43-generic #48~16.04.1 SMP Sat Jun 16 11:59:59 CEST 2018 x86_64 x86_64 x86_64 GNU/Linux
[winki] ~/git/ubuntu-xenial > git log --oneline HEAD...Ubuntu-hwe-4.13.0-43.48_16.04.1 | cat
fd18173 Revert "drm/i915/edp: Allow alternate fixed mode for eDP if available."
4fb94d0 Revert "drm/i915/dp: rename intel_dp_is_edp to intel_dp_is_port_edp"
7547d0c Revert "drm/i915/dp: make is_edp non-static and rename to intel_dp_is_edp"
cb6c81f Revert "drm/i915/edp: Do not do link training fallback or prune modes on EDP"

So now that we identified the problematic commits, what are the next steps?

[penalvch (penalvch)]

Frank Winklmeier:
>"...what are the next steps?"

In order to upstream, please test the latest mainline kernel as it becomes available (now 4.17.2).

If reproducible in latest mainline, then test drm-tip (not daily, drm-intel, etc.).

[Frank Winklmeier (frank-winklmeier)]

I checked the latest mainline kernel and the problem with the horizontal lines is still present there:

Linux winki 4.17.2-041702-generic #201806160433 SMP Sat Jun 16 08:35:37 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

I am not familiar with your other instructions. Which kernels exactly should I test next?

[Frank Winklmeier (frank-winklmeier)]

OK, found it. I tested drm-tip from http://kernel.ubuntu.com/~kernel-ppa/mainline/drm-tip/current:

Linux winki 4.17.0-994-generic #201806152200 SMP Sat Jun 16 02:03:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

and the problem is fixed in that kernel. And looking at the log

https://git.launchpad.net/~ubuntu-kernel-test/ubuntu/+source/linux/+git/mainline-crack/log/drivers/gpu/drm/i915

the problematic commit "9081fd9 drm/i915/edp: Allow alternate fixed mode for eDP if available." was reverted there on 2018-05-31.

[penalvch (penalvch)]

Frank Winklmeier, the issue you are reporting is an upstream one. Could you please report this problem to Intel following their instructions via https://01.org/linuxgraphics/documentation/how-report-bugs ?

Please provide a direct URL to your report so that it may be tracked.

Thank you for your help.

[Frank Winklmeier (frank-winklmeier)]

I am not sure I am following. As I said above, the problem is fixed in the drm-tip kernel. So why would we want to report this to Intel if it's already fixed there?

[penalvch (penalvch)]

Frank Winklmeier, mainline (i.e. kernel.org) is where Ubuntu sources their kernel. drm-tip is an unsupported kernel which may or may not have commits from it pulled into mainline. Reporting your results to Intel will provide Intel developers support to review what fixes your problem, and consider it for inclusion into mainline, and subsequently being pulled into Ubuntu.

[Frank Winklmeier (frank-winklmeier)]

Thanks for the explanation. Makes sense now and I submitted https://bugs.freedesktop.org/show_bug.cgi?id=106943

[Frank Winklmeier (frank-winklmeier)]

In the meantime the problem got fixed in the upstream v4.18.0-rc1 kernel by this commit:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/i915?id=368b554d63948133aca05e63ff8f5f4fbc2804d4

Revert "drm/i915/edp: Allow alternate fixed mode for eDP if available."

I have confirmed that compiling v4.18.0-rc1 without this commit shows the horizontal lines again. This is in agreement with my earlier findings in comment #23. Let me know if you need more information. I hope this fix can now quickly be back-ported to the Ubuntu 4.13 and 4.15 kernels.

[Frank Winklmeier (frank-winklmeier)]

The problem is now also fixed in 4.15.0-24.26~16.04.1 from linux-hwe (proposed). For reference, it was fixed as part of https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1773520

[Jonas Lippuner (flecto)]

Thank you so much Frank for digging down into this issue! I had to use kernel 4.13.0-1 until now. I can confirm that it's fixed in kernel 4.18.0-1.