Request to revert SAUCE patches in the 18.04 SRU and update with upstream version
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
The Ubuntu-power-systems project |
Fix Released
|
Medium
|
Canonical Kernel Team | ||
linux (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Bionic |
Fix Released
|
Medium
|
Unassigned | ||
Cosmic |
Fix Released
|
Medium
|
Unassigned |
Bug Description
== SRU Justification ==
This SRU was requested by IBM. It contains one SAUCE patch and three
commits from linux.next.
IBM requested that we revert a set of SAUCE patches from 18.04 and
replace them with patches from linux-next. Based on review comments,
there has been minor changes from the original SAUCE patches and the
versions in linux-next.
The first SAUCE patch contains all the changes between the current version
of SAUCE patches for latest cxlflash patches in bionic and the latest
version accepted by the community. This only has the needed changes and
makes it so we don't have to revert and re-apply a high number of patches.
In addition to the SAUCE patch, IBM requested the 3 additional new patches
from the linux-next tree.
== Fixes ==
UBUNTU: SAUCE: (no-up) cxlflash: OCXL diff between v2 and v3
a3feb6ef50de ("scsi: cxlflash: Synchronize reset and remove ops")
9a597cd4c0ce ("scsi: cxlflash: Remove commmands from pending list on timeout)"
d2d354a606d5 ("scsi: cxlflash: Handle spurious interrupts")
== Regression Potential ==
Medium. All the patches are specific to the cxlflash driver, but there
are four of them and one is a SAUCE patch.
== Test Case ==
A test kernel was built with these patches and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.
== Comment: #0 - UMA KRISHNAN <email address hidden> - 2018-04-30 14:41:30 ==
---Problem Description---
Request to revert SAUCE patches from 18.04 and apply the patches from next/master.
Below set of cxlflash patches were submitted to Canonical after they were sent to the community. Based on review comments, there has been minor changes from that version. This BZ is to request reverting those SAUCE patches with the ones that are queued in next/master tree for 4.18.
- SAUCE: cxlflash: Preserve number of interrupts for master contexts
- SAUCE: cxlflash: Avoid clobbering context control register value
- SAUCE: cxlflash: Add argument identifier names
- SAUCE: cxlflash: Introduce OCXL backend
- SAUCE: cxlflash: Hardware AFU for OCXL
- SAUCE: cxlflash: Read host function configuration
- SAUCE: cxlflash: Setup function acTag range
- SAUCE: cxlflash: Read host AFU configuration
- SAUCE: cxlflash: Setup AFU acTag range
- SAUCE: cxlflash: Setup AFU PASID
- SAUCE: cxlflash: Adapter context support for OCXL
- SAUCE: cxlflash: Use IDR to manage adapter contexts
- SAUCE: cxlflash: Support adapter file descriptors for OCXL
- SAUCE: cxlflash: Support adapter context discovery
- SAUCE: cxlflash: Support image reload policy modification
- SAUCE: cxlflash: MMIO map the AFU
- SAUCE: cxlflash: Support starting an adapter context
- SAUCE: cxlflash: Support process specific mappings
- SAUCE: cxlflash: Support AFU state toggling
- SAUCE: cxlflash: Support reading adapter VPD data
- SAUCE: cxlflash: Setup function OCXL link
- SAUCE: cxlflash: Setup OCXL transaction layer
- SAUCE: cxlflash: Support process element lifecycle
- SAUCE: cxlflash: Support AFU interrupt management
- SAUCE: cxlflash: Support AFU interrupt mapping and registration
- SAUCE: cxlflash: Support starting user contexts
- SAUCE: cxlflash: Support adapter context polling
- SAUCE: cxlflash: Support adapter context reading
- SAUCE: cxlflash: Support adapter context mmap and release
- SAUCE: cxlflash: Support file descriptor mapping
- SAUCE: cxlflash: Introduce object handle fop
- SAUCE: cxlflash: Setup LISNs for user contexts
- SAUCE: cxlflash: Setup LISNs for master contexts
- SAUCE: cxlflash: Update synchronous interrupt status bits
- SAUCE: cxlflash: Introduce OCXL context state machine
- SAUCE: cxlflash: Register for translation errors
- SAUCE: cxlflash: Support AFU reset
- SAUCE: cxlflash: Enable OCXL operations
Also, there are 3 additional patches added to end of this series that we would like to request being pulled into the SRU stream. These 3 patches address bug fixes.
The commit ids for the patches queued in next/master tree are,
768999d6b1eadc6
6c2b116dd38e3fb
fcace1d5e11f518
863dbdc0552f8bc
f2180daa83950ff
104253563355459
ba84823a8b44820
f55ced2dcd00ab2
c5a8fec11278e24
b42d68d728a6333
de25ec59a758025
a76fc993e399f54
09f35da5fe218ba
17f9335bc59c1cf
a5cfe355f23d441
0c62e7c091a4e0a
f39bab766ea4f0b
bef2014e8bd6391
58b43437bd85565
08d6154b6064021
c11b0b435a7b100
fad7fd669ac666e
8733bd8b329124f
eb249077b3fb279
8c58d224f173941
87b78b7cadd5518
65a9b16c95b4838
6a6093bab2df2e4
eff344dc47ce1f3
195fc14998630cf
f9662c034e25c97
3aeb1833e4e2374
41676671021c361
e05df99313b8fed
6d11971a38cce00
d5c11f5c33fb3ed
41ef5d04768990f
6a7969eda1cf4bc
7a3593e6560019c
bcfd01d97570d8a
d54f3841703b313
If you would rather handpick the specific commits that had deviations, please let me know and I can list them. Since 18.04 is a long term release it would help to be in sync with the upstream set of patches to avoid back porting issues in the future. Please let me know if you have questions/concerns. Thanks a LOT !
Contact Information = <email address hidden>
---uname output---
n/a
Machine Type = n/a
---Debugger---
A debugger is not configured
Stack trace output:
no
Oops output:
no
System Dump Info:
The system is not configured to capture a system dump.
*Additional Instructions for <email address hidden>:
-Attach sysctl -a output output to the bug.
CVE References
tags: | added: architecture-ppc64le bugnameltc-167320 severity-medium targetmilestone-inin--- |
Changed in ubuntu: | |
assignee: | nobody → Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) |
affects: | ubuntu → kernel-package (Ubuntu) |
Changed in ubuntu-power-systems: | |
importance: | Undecided → Medium |
assignee: | nobody → Canonical Kernel Team (canonical-kernel-team) |
tags: | added: triage-g |
Changed in ubuntu-power-systems: | |
status: | New → Triaged |
affects: | kernel-package (Ubuntu) → linux (Ubuntu) |
Changed in linux (Ubuntu): | |
importance: | Undecided → Medium |
Changed in linux (Ubuntu Bionic): | |
importance: | Undecided → Medium |
tags: | added: kernel-da-key |
Changed in linux (Ubuntu Bionic): | |
status: | New → Triaged |
Changed in linux (Ubuntu): | |
status: | New → Triaged |
Changed in linux (Ubuntu): | |
status: | Triaged → In Progress |
Changed in linux (Ubuntu Bionic): | |
status: | Triaged → In Progress |
Changed in ubuntu-power-systems: | |
status: | Triaged → In Progress |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
description: | updated |
tags: |
added: verification-done-bionic removed: verification-needed-bionic |
Changed in ubuntu-power-systems: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-power-systems: | |
status: | Fix Committed → Fix Released |
Changed in linux (Ubuntu Cosmic): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Cosmic): | |
status: | Fix Committed → Fix Released |
tags: |
added: targetmilestone-inin18041 removed: targetmilestone-inin--- |
It would be preferable to only handpick the specific commits that had deviations. It would be great if you could list those specific commits.