Incorrect blacklist of bcm2835_wdt

Bug #1766052 reported by Kees Cook on 2018-04-22
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Medium
Unassigned
Artful
Medium
Unassigned
Bionic
Medium
Kees Cook

Bug Description

Without bcm2835_wdt loaded, Raspberry Pi systems cannot reboot or shut down. This needs to be removed from the automatic blacklist generated by the kernel build that ends up in /lib/modprobe.d/blacklist_linux_$(uname -r).conf

CVE References

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1766052

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
Changed in linux (Ubuntu Artful):
status: New → Incomplete
Changed in linux (Ubuntu Artful):
importance: Undecided → Medium
Changed in linux (Ubuntu Bionic):
importance: Undecided → Medium
Changed in linux (Ubuntu Artful):
status: Incomplete → Triaged
Changed in linux (Ubuntu Bionic):
status: Incomplete → Triaged
tags: added: artful bionic kernel-da-key
Kees Cook (kees) wrote :
Kees Cook (kees) wrote :

ping...

Joseph Salisbury (jsalisbury) wrote :

It looks like your patch has two ACKs on the mailing list. It should be applied soon and available in the next round of updates.

I also pinged the mailing list for an update.

Changed in linux (Ubuntu Bionic):
status: Triaged → Fix Committed
Brad Figg (brad-figg) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed-bionic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-bionic
Changed in linux (Ubuntu Bionic):
assignee: nobody → Kees Cook (kees)
Dimitri John Ledkov (xnox) wrote :

Not sure if this raspbery pi is armhf or arm64.

Comparing armhf & arm64 blacklists, neither are changed between release pocket and -proposed.

armhf does not have bcm2835_wdt listed, and arm64 does.

These are for the generic kernel.

$ grep bcm2835 *.conf
blacklist_linux_4.15.0-20-generic.conf:blacklist bcm2835_wdt
blacklist_linux_4.15.0-23-generic.conf:blacklist bcm2835_wdt

$ diff -u blacklist_linux_4.15.0-20-generic.conf blacklist_linux_4.15.0-23-generic.conf
--- blacklist_linux_4.15.0-20-generic.conf 2018-04-24 05:56:17.000000000 +0100
+++ blacklist_linux_4.15.0-23-generic.conf 2018-05-23 17:54:55.000000000 +0100
@@ -1,4 +1,4 @@
-# Kernel supplied blacklist for linux 4.15.0-20-generic arm64
+# Kernel supplied blacklist for linux 4.15.0-23-generic arm64
 # modprobe.d/common.conf
 # LP:1434842 -- disable OSS drivers by default to allow pulseaudio to emulate
 blacklist snd-mixer-oss

This is fine to ship, but it seems like the bug is not fixed yet?! Or which kernel flavour I should be checking, if not generic?!

Dimitri John Ledkov (xnox) wrote :

I wonder if

grep -v '^bcm2835_wdt$$' | \

should actually be

grep -v '^bcm2835_wdt.ko$$' | \

given that next line strips .ko suffix:

sed -e 's/^/blacklist /' -e 's/.ko$$//' | \

Stefan Bader (smb) wrote :

At least the images that generally get generated are raspi2 ones (so armhf) but since the modification is done in a shared part of the build scripts this is done for all kernels based on the bionic (4.15) tree. Looking at the raspi2 build:

wget https://launchpad.net/~canonical-kernel-team/+archive/ubuntu/ppa/+build/14930811/+files/linux-modules-4.15.0-1012-raspi2_4.15.0-1012.13_armhf.deb
dpkg -x linux-modules-4.15.0-1012-raspi2_4.15.0-1012.13_armhf.deb unpack
grep bcm unpack/lib/modprobe.d/blacklist_linux-raspi2_4.15.0-1012-raspi2.conf

Launchpad Janitor (janitor) wrote :
Download full text (11.4 KiB)

This bug was fixed in the package linux - 4.15.0-23.25

---------------
linux (4.15.0-23.25) bionic; urgency=medium

  * linux: 4.15.0-23.25 -proposed tracker (LP: #1772927)

  * arm64 SDEI support needs trampoline code for KPTI (LP: #1768630)
    - arm64: mmu: add the entry trampolines start/end section markers into
      sections.h
    - arm64: sdei: Add trampoline code for remapping the kernel

  * Some PCIe errors not surfaced through rasdaemon (LP: #1769730)
    - ACPI: APEI: handle PCIe AER errors in separate function
    - ACPI: APEI: call into AER handling regardless of severity

  * qla2xxx: Fix page fault at kmem_cache_alloc_node() (LP: #1770003)
    - scsi: qla2xxx: Fix session cleanup for N2N
    - scsi: qla2xxx: Remove unused argument from qlt_schedule_sess_for_deletion()
    - scsi: qla2xxx: Serialize session deletion by using work_lock
    - scsi: qla2xxx: Serialize session free in qlt_free_session_done
    - scsi: qla2xxx: Don't call dma_free_coherent with IRQ disabled.
    - scsi: qla2xxx: Fix warning in qla2x00_async_iocb_timeout()
    - scsi: qla2xxx: Prevent relogin trigger from sending too many commands
    - scsi: qla2xxx: Fix double free bug after firmware timeout
    - scsi: qla2xxx: Fixup locking for session deletion

  * Several hisi_sas bug fixes (LP: #1768974)
    - scsi: hisi_sas: dt-bindings: add an property of signal attenuation
    - scsi: hisi_sas: support the property of signal attenuation for v2 hw
    - scsi: hisi_sas: fix the issue of link rate inconsistency
    - scsi: hisi_sas: fix the issue of setting linkrate register
    - scsi: hisi_sas: increase timer expire of internal abort task
    - scsi: hisi_sas: remove unused variable hisi_sas_devices.running_req
    - scsi: hisi_sas: fix return value of hisi_sas_task_prep()
    - scsi: hisi_sas: Code cleanup and minor bug fixes

  * [bionic] machine stuck and bonding not working well when nvmet_rdma module
    is loaded (LP: #1764982)
    - nvmet-rdma: Don't flush system_wq by default during remove_one
    - nvme-rdma: Don't flush delete_wq by default during remove_one

  * Warnings/hang during error handling of SATA disks on SAS controller
    (LP: #1768971)
    - scsi: libsas: defer ata device eh commands to libata

  * Hotplugging a SATA disk into a SAS controller may cause crash (LP: #1768948)
    - ata: do not schedule hot plug if it is a sas host

  * ISST-LTE:pKVM:Ubuntu1804: rcu_sched self-detected stall on CPU follow by CPU
    ATTEMPT TO RE-ENTER FIRMWARE! (LP: #1767927)
    - powerpc/powernv: Handle unknown OPAL errors in opal_nvram_write()
    - powerpc/64s: return more carefully from sreset NMI
    - powerpc/64s: sreset panic if there is no debugger or crash dump handlers

  * fsnotify: Fix fsnotify_mark_connector race (LP: #1765564)
    - fsnotify: Fix fsnotify_mark_connector race

  * Hang on network interface removal in Xen virtual machine (LP: #1771620)
    - xen-netfront: Fix hang on device removal

  * HiSilicon HNS NIC names are truncated in /proc/interrupts (LP: #1765977)
    - net: hns: Avoid action name truncation

  * Ubuntu 18.04 kernel crashed while in degraded mode (LP: #1770849)
    - SAUCE: powerpc/perf: Fix memory allocation for...

Changed in linux (Ubuntu Bionic):
status: Fix Committed → Fix Released
Changed in linux (Ubuntu):
status: Triaged → Fix Released
Dimitri John Ledkov (xnox) wrote :

ah, thanks smb!

This bug was nominated against a series that is no longer supported, ie artful. The bug task representing the artful nomination is being closed as Won't Fix.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu Artful):
status: Triaged → Won't Fix
Andy Whitcroft (apw) on 2019-02-14
tags: added: kernel-fixup-verification-needed-bionic
removed: verification-needed-bionic
Brad Figg (brad-figg) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed-bionic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-bionic
Andy Whitcroft (apw) wrote :

This bug was erroneously marked for verification in bionic; verification is not required and verification-needed-bionic is being removed.

tags: removed: verification-needed-bionic
Andy Whitcroft (apw) on 2019-02-14
tags: added: verification-done-bionic
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers