ubuntu_bpf_jit test failed on Bionic s390x systems

[Po-Hsu Lin]

== SRU Justification ==
The ubuntu_bpf_jit test will fail with the following 5 test cases:

test_bpf: #292 BPF_MAXINSNS: Ctx heavy transformations FAIL to prog_create err=-524 len=4096
test_bpf: #293 BPF_MAXINSNS: Call heavy transformations FAIL to prog_create err=-524 len=4096
test_bpf: #298 BPF_MAXINSNS: ld_abs+get_processor_id FAIL to prog_create err=-524 len=4096
test_bpf: #299 BPF_MAXINSNS: ld_abs+vlan_push/pop FAIL to select_runtime err=-524
test_bpf: #300 BPF_MAXINSNS: jump around ld_abs FAIL to select_runtime err=-524

test_bpf: Summary: 337 PASSED, 5 FAILED, [329/329 JIT'ed]

And modprobe error can be found in the report as well:
modprobe: ERROR: could not insert 'test_bpf': Invalid argument

Issue can be reproduce on both zVM and Ubuntu on LPAR s390x systems.

== Fix ==
3203c9010060 ("test_bpf: flag tests that cannot be jited on s390")

A backport of the fix is needed to compile out "BPF_MAXINSNS: ld_abs+vlan_push/pop" and "BPF_MAXINSNS: jump around ld_abs' testcases. They have been removed from lib/test_bpf.c on 93731ef086ce ("bpf: migrate ebpf ld_abs/ld_ind tests to test_verifier"), however, backporting this patch would require pulling other patches as prereqs.

== Regression Potential ==
None, the fix is in a test module and only masks failing testcases on s390 only.

== Test Case ==
Load the test_bpf module, it should load without errors.

Not sure if this is related to bug 1751234 (error on AMD64 system is different)

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: linux-image-4.15.0-11-generic 4.15.0-11.12
ProcVersionSignature: Ubuntu 4.15.0-11.12-generic 4.15.5
Uname: Linux 4.15.0-11-generic s390x
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
AlsaDevices: Error: command ['ls', '-l', '/dev/snd/'] failed with exit code 2: ls: cannot access '/dev/snd/': No such file or directory
AplayDevices: Error: [Errno 2] No such file or directory: 'aplay': 'aplay'
ApportVersion: 2.20.8-0ubuntu10
Architecture: s390x
ArecordDevices: Error: [Errno 2] No such file or directory: 'arecord': 'arecord'
CRDA: Error: command ['iw', 'reg', 'get'] failed with exit code 1: nl80211 not found.
CurrentDmesg:

Date: Wed Mar 7 08:13:51 2018
IwConfig: Error: [Errno 2] No such file or directory: 'iwconfig': 'iwconfig'
Lspci:

Lsusb: Error: command ['lsusb'] failed with exit code 1:
PciMultimedia:

ProcFB: Error: [Errno 2] No such file or directory: '/proc/fb'
ProcKernelCmdLine: root=/dev/mapper/kl02vg01-root crashkernel=196M BOOT_IMAGE=0
RelatedPackageVersions:
 linux-restricted-modules-4.15.0-11-generic N/A
 linux-backports-modules-4.15.0-11-generic N/A
 linux-firmware 1.172
RfKill: Error: [Errno 2] No such file or directory: 'rfkill': 'rfkill'
SourcePackage: linux
UpgradeStatus: No upgrade log present (probably fresh install)

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1753941

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Kleber Sacilotto de Souza (kleber-souza)]

There are still failures with the mainline kernel:

[ 708.771634] test_bpf: #284 BPF_MAXINSNS: Maximum possible literals jited:1 16 PASS
[ 708.772842] test_bpf: #285 BPF_MAXINSNS: Single literal jited:1 16 PASS
[ 708.774050] test_bpf: #286 BPF_MAXINSNS: Run/add until end jited:1 2201 PASS
[ 708.777064] test_bpf: #287 BPF_MAXINSNS: Too many instructions PASS
[ 708.777066] test_bpf: #288 BPF_MAXINSNS: Very long jump jited:1 16 PASS
[ 708.778295] test_bpf: #289 BPF_MAXINSNS: Ctx heavy transformations FAIL to prog_create err=-524 len=4096
[ 708.779585] test_bpf: #290 BPF_MAXINSNS: Call heavy transformations FAIL to prog_create err=-524 len=4096
[ 708.781170] test_bpf: #291 BPF_MAXINSNS: Jump heavy test jited:1 728 PASS
[ 708.783236] test_bpf: #292 BPF_MAXINSNS: Very long jump backwards jited:1 16 PASS
[ 708.783683] test_bpf: #293 BPF_MAXINSNS: Edge hopping nuthouse jited:1 6150 PASS
[ 708.790265] test_bpf: #294 BPF_MAXINSNS: Jump, gap, jump, ... jited:1 42 PASS
[ 708.791130] test_bpf: #295 BPF_MAXINSNS: jump over MSH PASS
[ 708.791679] test_bpf: #296 BPF_MAXINSNS: exec all MSH FAIL to prog_create err=-524 len=4096
[ 708.797987] test_bpf: #297 BPF_MAXINSNS: ld_abs+get_processor_id FAIL to prog_create err=-524 len=4096

[Kleber Sacilotto de Souza (kleber-souza)]

I have sent a patch upstream to fix these issues. It has been applied to the bpf tree:
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git/commit/?id=3203c9010060806ff88c9989aeab4dc8d9a474dc

[Kleber Sacilotto de Souza (kleber-souza)]

Patch landed on Linus' tree:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/lib/test_bpf.c?id=3203c9010060806ff88c9989aeab4dc8d9a474dc

[Kleber Sacilotto de Souza (kleber-souza)]

SRU request sent to the mailing-list:
https://lists.ubuntu.com/archives/kernel-team/2018-July/093749.html

[Brad Figg (brad-figg)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed-bionic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Kleber Sacilotto de Souza (kleber-souza)]

Test is now successful on s390x systems:

08/17 07:43:34 INFO |ubuntu_bpf:0013| [ 955.792526] test_bpf: Summary: 340 PASSED, 0 FAILED, [329/329 JIT'ed]

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 4.15.0-33.36

---------------
linux (4.15.0-33.36) bionic; urgency=medium

  * linux: 4.15.0-33.36 -proposed tracker (LP: #1787149)

  * RTNL assertion failure on ipvlan (LP: #1776927)
    - ipvlan: drop ipv6 dependency
    - ipvlan: use per device spinlock to protect addrs list updates
    - SAUCE: fix warning from "ipvlan: drop ipv6 dependency"

  * ubuntu_bpf_jit test failed on Bionic s390x systems (LP: #1753941)
    - test_bpf: flag tests that cannot be jited on s390

  * HDMI/DP audio can't work on the laptop of Dell Latitude 5495 (LP: #1782689)
    - drm/nouveau: fix nouveau_dsm_get_client_id()'s return type
    - drm/radeon: fix radeon_atpx_get_client_id()'s return type
    - drm/amdgpu: fix amdgpu_atpx_get_client_id()'s return type
    - platform/x86: apple-gmux: fix gmux_get_client_id()'s return type
    - ALSA: hda: use PCI_BASE_CLASS_DISPLAY to replace PCI_CLASS_DISPLAY_VGA
    - vga_switcheroo: set audio client id according to bound GPU id

  * locking sockets broken due to missing AppArmor socket mediation patches
    (LP: #1780227)
    - UBUNTU SAUCE: apparmor: fix apparmor mediating locking non-fs, unix sockets

  * Update2 for ocxl driver (LP: #1781436)
    - ocxl: Fix page fault handler in case of fault on dying process

  * netns: unable to follow an interface that moves to another netns
    (LP: #1774225)
    - net: core: Expose number of link up/down transitions
    - dev: always advertise the new nsid when the netns iface changes
    - dev: advertise the new ifindex when the netns iface changes

  * [Bionic] Disk IO hangs when using BFQ as io scheduler (LP: #1780066)
    - block, bfq: fix occurrences of request finish method's old name
    - block, bfq: remove batches of confusing ifdefs
    - block, bfq: add requeue-request hook

  * HP ProBook 455 G5 needs mute-led-gpio fixup (LP: #1781763)
    - ALSA: hda: add mute led support for HP ProBook 455 G5

  * [Bionic] bug fixes to improve stability of the ThunderX2 i2c driver
    (LP: #1781476)
    - i2c: xlp9xx: Fix issue seen when updating receive length
    - i2c: xlp9xx: Make sure the transfer size is not more than
      I2C_SMBUS_BLOCK_SIZE

  * x86/kvm: fix LAPIC timer drift when guest uses periodic mode (LP: #1778486)
    - x86/kvm: fix LAPIC timer drift when guest uses periodic mode

  * Please include ax88179_178a and r8152 modules in d-i udeb (LP: #1771823)
    - [Config:] d-i: Add ax88179_178a and r8152 to nic-modules

  * Nvidia fails after switching its mode (LP: #1778658)
    - PCI: Restore config space on runtime resume despite being unbound

  * Kernel error "task zfs:pid blocked for more than 120 seconds" (LP: #1781364)
    - SAUCE: (noup) zfs to 0.7.5-1ubuntu16.3

  * CVE-2018-12232
    - PATCH 1/1] socket: close race condition between sock_close() and
      sockfs_setattr()

  * CVE-2018-10323
    - xfs: set format back to extents if xfs_bmap_extents_to_btree

  * change front mic location for more lenovo m7/8/9xx machines (LP: #1781316)
    - ALSA: hda/realtek - Fix the problem of two front mics on more machines
    - ALSA: hda/realtek - two more lenovo models need fixup of MIC_LOCATION

  * Cephfs + fscache: unab...