Comment 3 for bug 1745130

Revision history for this message
Jan-Marek Glogowski (jmglogow) wrote :

Thanks a lot. After apw's comment on IRC I expected something in the next weeks :-)

I can just tell you it boots and seems to work. When I tried to manually build my hw-support-dkms against the kernel I got:

LANG=C ./r
+ pwd
+ make -C /usr/src/linux-headers-4.4.0-112-generic M=/home/glg/mod
make: Entering directory `/usr/src/linux-headers-4.4.0-112-generic'
Makefile:702: Cannot use CONFIG_CC_STACKPROTECTOR_STRONG: -fstack-protector-strong not supported by compiler
  CC [M] /home/glg/mod/fujitsu-laptop.o
gcc: error: unrecognized command line option '-fstack-protector-strong'
make[1]: *** [/home/glg/mod/fujitsu-laptop.o] Error 1
make: *** [_module_/home/glg/mod] Error 2
make: Leaving directory `/usr/src/linux-headers-4.4.0-112-generic'

So I guess this kernel was build on Xenial, which I don't have installed. I have Trusty and Bionic, which has the upstream patch included.

But generally it looks ok'ish, as rfkill-any shows up:

$ cat /sys/class/leds/input2\:\:capslock/trigger
none rfkill-any kbd-scrolllock kbd-numlock [kbd-capslock] kbd-kanalock kbd-shiftlock kbd-altgrlock kbd-ctrllock kbd-altlock kbd-shiftllock kbd-shiftrlock kbd-ctrlllock kbd-ctrlrlock AC-online CMB1-charging-or-full CMB1-charging CMB1-full CMB1-charging-blink-full-solid usb-gadget usb-host cpu0 cpu1 cpu2 cpu3 cpu4 cpu5 cpu6 cpu7 mmc0 rfkill0 rfkill1 phy0rx phy0tx phy0assoc phy0radio

For a test I used the the caspslock led and manually set the soft rfkill, which triggers the led correctly:

$ echo "rfkill-any" | sudo tee /sys/class/leds/input2\:\:capslock/trigger
rfkill-any
$ cat /sys/class/leds/input2\:\:capslock/trigger
none [rfkill-any] kbd-scrolllock kbd-numlock kbd-capslock kbd-kanalock kbd-shiftlock kbd-altgrlock kbd-ctrllock kbd-altlock kbd-shiftllock kbd-shiftrlock kbd-ctrlllock kbd-ctrlrlock AC-online CMB1-charging-or-full CMB1-charging CMB1-full CMB1-charging-blink-full-solid usb-gadget usb-host cpu0 cpu1 cpu2 cpu3 cpu4 cpu5 cpu6 cpu7 mmc0 rfkill0 rfkill1 phy0rx phy0tx phy0assoc phy0radio

=> capslock led is on

$ sudo rfkill list
0: hci0: Bluetooth
        Soft blocked: no
        Hard blocked: no
1: phy0: Wireless LAN
        Soft blocked: no
        Hard blocked: no

$ sudo rfkill block 0
$ sudo rfkill block 1

=> capslock led is off

I tried all combinations of block and unblock.
No stacks in the dmesg.

So I guess it works as expected.

If you can provide a Trusty based kernel, I'll test it tomorrow.