Suspend broken after kernel upgrade

[Jeffrey Bouter]

My machine (XPS 13 9360) won't go into suspend properly after upgrading from linux-image-4.13.0-17-generic to linux-image-4.13.0-19-generic.

This affects both suspend through lid close and "systemctl suspend". Screen goes off, power led remains lit. Then after some time the screen comes back on, is stuck and lets me wait for a few before becoming responsive again.

Booting back into 4.13.0-17 resolved the issue.
---
ApportVersion: 2.20.7-0ubuntu3.6
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: jeffrey 1963 F.... pulseaudio
CurrentDesktop: GNOME
DistroRelease: Ubuntu 17.10
HibernationDevice: RESUME=UUID=0253ffe9-bdbf-4825-b583-e8055f7bffe5
InstallationDate: Installed on 2017-10-18 (56 days ago)
InstallationMedia: Ubuntu 17.10 "Artful Aardvark" - Release amd64 (20171017.1)
MachineType: Dell Inc. XPS 13 9360
Package: linux (not installed)
ProcFB: 0 inteldrmfb
ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-4.13.0-19-generic.efi.signed root=/dev/mapper/ubuntu--vg-root ro quiet splash vt.handoff=7
ProcVersionSignature: Ubuntu 4.13.0-19.22-generic 4.13.13
RelatedPackageVersions:
 linux-restricted-modules-4.13.0-19-generic N/A
 linux-backports-modules-4.13.0-19-generic N/A
 linux-firmware 1.169.1
Tags: artful wayland-session
Uname: Linux 4.13.0-19-generic x86_64
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip docker input libvirt lpadmin plugdev sambashare sudo
_MarkForUpload: True
dmi.bios.date: 10/03/2017
dmi.bios.vendor: Dell Inc.
dmi.bios.version: 2.3.1
dmi.board.name: 0839Y6
dmi.board.vendor: Dell Inc.
dmi.board.version: A00
dmi.chassis.type: 9
dmi.chassis.vendor: Dell Inc.
dmi.modalias: dmi:bvnDellInc.:bvr2.3.1:bd10/03/2017:svnDellInc.:pnXPS139360:pvr:rvnDellInc.:rn0839Y6:rvrA00:cvnDellInc.:ct9:cvr:
dmi.product.family: XPS
dmi.product.name: XPS 13 9360
dmi.sys.vendor: Dell Inc.

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1738224

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Joseph Salisbury (jsalisbury)]

Would it be possible for you to test the latest upstream kernel? Refer to https://wiki.ubuntu.com/KernelMainlineBuilds . Please test the latest v4.15 kernel[0].

If this bug is fixed in the mainline kernel, please add the following tag 'kernel-fixed-upstream'.

If the mainline kernel does not fix this bug, please add the tag: 'kernel-bug-exists-upstream'.

Once testing of the upstream kernel is complete, please mark this bug as "Confirmed".

Thanks in advance.

[0] http://kernel.ubuntu.com/~kernel-ppa/mainline/v4.15-rc3

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

apport information

[Jeffrey Bouter (jbouter)]

Joseph, I've added the requested tag. Upstream/mainline (4.15) fixes the issue.

[Jeffrey Bouter (jbouter)]

Updating my XPS to the latest firmware (I was only one release behind) has resolved the issue.

[Jeffrey Bouter (jbouter)]

Nevermind. Only worked once. After a reboot, just to check, the issue still persists. Both on battery and on regular power.

[Kai-Heng Feng (kaihengfeng)]

Do you have anything connected to your thunderbolt/USB type-c port?

[Kai-Heng Feng (kaihengfeng)]

This commit might cause your issue: http://kernel.ubuntu.com/git/ubuntu/ubuntu-artful.git/commit/?id=56aa325de02d0448345358cb1b851a4c1e94f758

Return to s2idle should solve the issue.
# echo s2idle > /sys/power/mem_sleep

[Jeffrey Bouter (jbouter)]

kai-Heng, on both occasions (suspend working and broken on latest kernel) I had nothing connected to my USB-C port. I'll test s2idle later and get back to you.

[Mario Limonciello (superm1)]

That particular commit actually breaks proper s2idle. Because of it S3
should be used instead on 9360.

It was intentionally broken because of some reported regression by one guy
with an nvme SSD of a particular vendor.

Can you please check which SSD you have? Nvme info command on it can be
helpful.

On Sat, Dec 16, 2017, 16:05 Jeffrey Bouter <email address hidden>
wrote:

> kai-Heng, on both occasions (suspend working and broken on latest
> kernel) I had nothing connected to my USB-C port. I'll test s2idle later
> and get back to you.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1738224
>
> Title:
> Suspend broken after kernel upgrade
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1738224/+subscriptions
>

[Jeffrey Bouter (jbouter)]

Mario,

THNSN5512GPUK NVMe TOSHIBA 512GB would be the model

[Jeffrey Bouter (jbouter)]

Kai-Heng,

A cat on /sys/power/mem_sleep already shows:

[s2idle] deep

[Mario Limonciello (superm1)]

Did you manually set s2idle? That policy shouldn't have been picked unless
you were on 4.14.

On Sat, Dec 16, 2017, 17:55 Jeffrey Bouter <email address hidden>
wrote:

> Kai-Heng,
>
> A cat on /sys/power/mem_sleep already shows:
>
> [s2idle] deep
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1738224
>
> Title:
> Suspend broken after kernel upgrade
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1738224/+subscriptions
>

[Jeffrey Bouter (jbouter)]

No, I did not.

[Kai-Heng Feng (kaihengfeng)]

What's the value of "/sys/power/mem_sleep" on 4.13.0-19?

[Jeffrey Bouter (jbouter)]

Kai, it is: s2idle [deep]

[Kai-Heng Feng (kaihengfeng)]

I can't reproduce the issue on the XPS 9360 at my hand, which unfortunately is not the mass production one, with both BIOS 2.3.1 (the version you currently used) and 2.4.2.

The TBT's XHCI HC failed to suspend,
[ 87.718350] xhci_hcd 0000:39:00.0: WARN: xHC CMD_RUN timeout
[ 87.718372] suspend_common(): xhci_pci_suspend+0x0/0xd0 returns -110
[ 87.718377] pci_pm_suspend(): hcd_pci_suspend+0x0/0x30 returns -110
[ 87.718385] dpm_run_callback(): pci_pm_suspend+0x0/0x130 returns -110
[ 87.718391] PM: Device 0000:39:00.0 failed to suspend async: error -110

Also we can see that:
01:00.0 PCI bridge [0604]: Intel Corporation DSL6340 Thunderbolt 3 Bridge [Alpine Ridge 2C 2015] [8086:1576] (rev ff) (prog-if ff)
 !!! Unknown header type 7f
 Kernel driver in use: pcieport
 Kernel modules: shpchp

02:00.0 PCI bridge [0604]: Intel Corporation DSL6340 Thunderbolt 3 Bridge [Alpine Ridge 2C 2015] [8086:1576] (rev ff) (prog-if ff)
 !!! Unknown header type 7f
 Kernel driver in use: pcieport
 Kernel modules: shpchp

02:01.0 PCI bridge [0604]: Intel Corporation DSL6340 Thunderbolt 3 Bridge [Alpine Ridge 2C 2015] [8086:1576] (rev ff) (prog-if ff)
 !!! Unknown header type 7f
 Kernel driver in use: pcieport
 Kernel modules: shpchp

02:02.0 PCI bridge [0604]: Intel Corporation DSL6340 Thunderbolt 3 Bridge [Alpine Ridge 2C 2015] [8086:1576] (rev ff) (prog-if ff)
 !!! Unknown header type 7f
 Kernel driver in use: pcieport
 Kernel modules: shpchp

03:00.0 System peripheral [0880]: Intel Corporation DSL6340 Thunderbolt 3 NHI [Alpine Ridge 2C 2015] [8086:1575] (rev ff) (prog-if ff)
 !!! Unknown header type 7f
 Kernel driver in use: thunderbolt
 Kernel modules: thunderbolt

39:00.0 USB controller [0c03]: Intel Corporation DSL6340 USB 3.1 Controller [Alpine Ridge] [8086:15b5] (rev ff) (prog-if ff)
 !!! Unknown header type 7f
 Kernel driver in use: xhci_hcd

All these PCI devices are not responsive.

Can you attach the output `lspci` right after boot, without plugging any USB-C/TBT device?

Also, can you upgrade your BIOS and Thunderbolt firmware? Hopefully this can fix the issue.

[Mario Limonciello (superm1)]

Thunderbolt NVM isn't on LVFS stable but it's on testing. Either turn on
fwupd LVFS testing remote or install manually from this file:

https://fwupd.org/lvfs/device/dfd51125-338f-56ff-b721-fa3bea8e534e

On Tue, Dec 19, 2017, 02:45 Kai-Heng Feng <email address hidden>
wrote:

> I can't reproduce the issue on the XPS 9360 at my hand, which
> unfortunately is not the mass production one, with both BIOS 2.3.1 (the
> version you currently used) and 2.4.2.
>
> The TBT's XHCI HC failed to suspend,
> [ 87.718350] xhci_hcd 0000:39:00.0: WARN: xHC CMD_RUN timeout
> [ 87.718372] suspend_common(): xhci_pci_suspend+0x0/0xd0 returns -110
> [ 87.718377] pci_pm_suspend(): hcd_pci_suspend+0x0/0x30 returns -110
> [ 87.718385] dpm_run_callback(): pci_pm_suspend+0x0/0x130 returns -110
> [ 87.718391] PM: Device 0000:39:00.0 failed to suspend async: error -110
>
> Also we can see that:
> 01:00.0 PCI bridge [0604]: Intel Corporation DSL6340 Thunderbolt 3 Bridge
> [Alpine Ridge 2C 2015] [8086:1576] (rev ff) (prog-if ff)
> !!! Unknown header type 7f
> Kernel driver in use: pcieport
> Kernel modules: shpchp
>
> 02:00.0 PCI bridge [0604]: Intel Corporation DSL6340 Thunderbolt 3 Bridge
> [Alpine Ridge 2C 2015] [8086:1576] (rev ff) (prog-if ff)
> !!! Unknown header type 7f
> Kernel driver in use: pcieport
> Kernel modules: shpchp
>
> 02:01.0 PCI bridge [0604]: Intel Corporation DSL6340 Thunderbolt 3 Bridge
> [Alpine Ridge 2C 2015] [8086:1576] (rev ff) (prog-if ff)
> !!! Unknown header type 7f
> Kernel driver in use: pcieport
> Kernel modules: shpchp
>
> 02:02.0 PCI bridge [0604]: Intel Corporation DSL6340 Thunderbolt 3 Bridge
> [Alpine Ridge 2C 2015] [8086:1576] (rev ff) (prog-if ff)
> !!! Unknown header type 7f
> Kernel driver in use: pcieport
> Kernel modules: shpchp
>
> 03:00.0 System peripheral [0880]: Intel Corporation DSL6340 Thunderbolt 3
> NHI [Alpine Ridge 2C 2015] [8086:1575] (rev ff) (prog-if ff)
> !!! Unknown header type 7f
> Kernel driver in use: thunderbolt
> Kernel modules: thunderbolt
>
> 39:00.0 USB controller [0c03]: Intel Corporation DSL6340 USB 3.1
> Controller [Alpine Ridge] [8086:15b5] (rev ff) (prog-if ff)
> !!! Unknown header type 7f
> Kernel driver in use: xhci_hcd
>
> All these PCI devices are not responsive.
>
> Can you attach the output `lspci` right after boot, without plugging any
> USB-C/TBT device?
>
> Also, can you upgrade your BIOS and Thunderbolt firmware? Hopefully this
> can fix the issue.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1738224
>
> Title:
> Suspend broken after kernel upgrade
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1738224/+subscriptions
>

[Jeffrey Bouter (jbouter)]

Kai-Heng,

As posted before, I have since upgraded to 2.4.2 - this *sometimes* fixes the issue, but not always. Currently, it is fixed. So I don't plan on rebooting my machine (just letting it suspend) until either a new kernel release comes out, or a firmware update comes out.

Mario,

What would this firmware upgrade fix? Is it advised to install testing firmware onto my XPS?

[Mario Limonciello (superm1)]

Information isn't available on what has changed between NVM releases from
Intel. It generally improves performance and resolves issues with the ICM
stack. Those could lead to for example the controller not going to sleep
when it should.

On Wed, Dec 20, 2017, 11:26 Jeffrey Bouter <email address hidden>
wrote:

> Kai-Heng,
>
> As posted before, I have since upgraded to 2.4.2 - this *sometimes*
> fixes the issue, but not always. Currently, it is fixed. So I don't plan
> on rebooting my machine (just letting it suspend) until either a new
> kernel release comes out, or a firmware update comes out.
>
> Mario,
>
> What would this firmware upgrade fix? Is it advised to install testing
> firmware onto my XPS?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1738224
>
> Title:
> Suspend broken after kernel upgrade
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1738224/+subscriptions
>

[Jeffrey Bouter (jbouter)]

Fair enough. Thanks for the information.

I just rebooted into 4.13.0-21-generic. Either it's a lucky boot in which suspend works, or the issue has been resolved.

For those interested, the value of /sys/power/mem_sleep (after a clean boot, suspended once) is: s2idle [deep]

[Kai-Heng Feng (kaihengfeng)]

Thanks for the info.

Please reopen this bug once the issue appears again.