Mute key LED does not work on HP ProBook 440

[Benjamin Halbrock]

[SRU Justification]
[Impact]
Mic mute led on HP ProBook 440 G4 does not work.

[Test Case]
The led should indicate mic mute/unmute status.

[Fix]
Commit 5cd5b1bdfb0137d0e814a51ff203d72c76b9f375 add GPIO mic mute led
support for HP ZBook 15u G3. Mic mute led on HP ProBook 440 G4 is also
supported.

[Regression Potential]
Low, very limited laptops will be affected.

---

this is probably a duplicate of https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1683277, but I was asked to file a new bug.

The mute button on my laptop has a led that changes the color based on the status of the audio-master channel. At least it should.

There is a slider for the LED in alsamixer but it doesn't change anything.

Are there any tests I should run?

cat /proc/version_signature > Ubuntu 4.10.0-28.32-generic 4.10.17
---
ApportVersion: 2.20.4-0ubuntu4.5
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: benjamin 2550 F.... pulseaudio
CurrentDesktop: Unity:Unity7
DistroRelease: Ubuntu 17.04
HibernationDevice: RESUME=UUID=4ce0e490-8f95-4de2-9a8f-456e1455444d
InstallationDate: Installed on 2015-06-07 (774 days ago)
InstallationMedia: Ubuntu 15.04 "Vivid Vervet" - Release amd64 (20150422)
Lsusb:
 Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
 Bus 001 Device 003: ID 8087:0a2a Intel Corp.
 Bus 001 Device 002: ID 04ca:7063 Lite-On Technology Corp.
 Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
MachineType: HP HP ProBook 440 G4
Package: linux (not installed)
ProcFB: 0 inteldrmfb
ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-4.10.0-28-generic.efi.signed root=UUID=27108123-06bd-4347-a0c5-9ea2ba62a034 ro quiet splash vt.handoff=7
ProcVersionSignature: Ubuntu 4.10.0-28.32-generic 4.10.17
RelatedPackageVersions:
 linux-restricted-modules-4.10.0-28-generic N/A
 linux-backports-modules-4.10.0-28-generic N/A
 linux-firmware 1.164.1
Tags: zesty
Uname: Linux 4.10.0-28-generic x86_64
UpgradeStatus: Upgraded to zesty on 2017-07-09 (11 days ago)
UserGroups: adm cdrom dip libvirt libvirtd lpadmin plugdev sambashare sudo
_MarkForUpload: True
dmi.bios.date: 06/18/2017
dmi.bios.vendor: HP
dmi.bios.version: P85 Ver. 01.06
dmi.board.name: 822E
dmi.board.vendor: HP
dmi.board.version: KBC Version 42.65
dmi.chassis.asset.tag: 5CD709684F
dmi.chassis.type: 10
dmi.chassis.vendor: HP
dmi.modalias: dmi:bvnHP:bvrP85Ver.01.06:bd06/18/2017:svnHP:pnHPProBook440G4:pvr:rvnHP:rn822E:rvrKBCVersion42.65:cvnHP:ct10:cvr:
dmi.product.name: HP ProBook 440 G4
dmi.sys.vendor: HP

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1705586

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Benjamin Halbrock (kontakt-bennis-blog)]

apport information

[Joseph Salisbury (jsalisbury)]

Would it be possible for you to test the latest upstream kernel? Refer to https://wiki.ubuntu.com/KernelMainlineBuilds . Please test the latest v4.13 kernel[0].

If this bug is fixed in the mainline kernel, please add the following tag 'kernel-fixed-upstream'.

If the mainline kernel does not fix this bug, please add the tag: 'kernel-bug-exists-upstream'.

Once testing of the upstream kernel is complete, please mark this bug as "Confirmed".

Thanks in advance.

[0] http://kernel.ubuntu.com/~kernel-ppa/mainline/v4.13-rc1/

[Benjamin Halbrock (kontakt-bennis-blog)]

still exists with Linux ThinkPad-Edge 4.12.0-041200-generic #201707022031 SMP Mon Jul 3 00:32:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

and yes, I should rename my computer :)

[Kai-Heng Feng (kaihengfeng)]

Add "options snd-hda-intel mode=mute-led-gpio" to "/etc/modprobe.d/alsa-base.conf", see if this works.

[Benjamin Halbrock (kontakt-bennis-blog)]

hello kai,
unfortunately
adding "options snd-hda-intel mode=mute-led-gpio" to "/etc/modprobe.d/alsa-base.conf
didn't work.

[Kai-Heng Feng (kaihengfeng)]

Do you use kernel version > 4.12?

[Benjamin Halbrock (kontakt-bennis-blog)]

I'm running it again

Linux probook 4.12.0-041200-generic #201707022031 SMP Mon Jul 3 00:32:52 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

[Kai-Heng Feng (kaihengfeng)]

mode=mute-led-gpio enables mic mute led for 840 G3.

Can you file an upstream bug for this issue? Maybe some dev have the machine to look into this issue.

[Benjamin Halbrock (kontakt-bennis-blog)]

can you give me a hint where exactly I should file this bug.

Is https://bugzilla.kernel.org/ the right place?

And can I just reference this bug here?

[Kai-Heng Feng (kaihengfeng)]

Yes, you can reference the bug here.

And https://bugzilla.kernel.org/ is the right place.

File bug with these additional information:
Product -> Drivers
Component -> Sound(ALSA)

[Kai-Heng Feng (kaihengfeng)]

Sorry, it should be "model" instead of "mode".

[Benjamin Halbrock (kontakt-bennis-blog)]

it is working with

adding "options snd-hda-intel model=mute-led-gpio" in "/etc/modprobe.d/alsa-base.conf

and kernel >= 4-12

Thank you very much :D

Do you know if this change will be merged in the ubuntu kernel?

[Kai-Heng Feng (kaihengfeng)]

The necessary bits to make LED work are all in the kernel, we just need to add new ID to let the driver knows this machine also needs "mute-led-gpio" functionality.

[Benjamin Halbrock (kontakt-bennis-blog)]

So how can I create a patch with the hw-id included?

[Kai-Heng Feng (kaihengfeng)]

Well, I'll send a patch if the result of testing kernel [1] is positive:

[1] http://people.canonical.com/~khfeng/lp1705586/

[Benjamin Halbrock (kontakt-bennis-blog)]

Your build is working flawlessly.

#hp-mute-led-fix
#options snd-hda-intel model=mute-led-gpio
/etc/modprobe.d/alsa-base.conf (END)

and
$ uname -a
Linux probook 4.11.0-12-generic #17~lp1705586 SMP Tue Jul 25 17:49:59 CST 2017 x86_64 x86_64 x86_64 GNU/Linux

[Kai-Heng Feng (kaihengfeng)]

Here's the patch:
http://mailman.alsa-project.org/pipermail/alsa-devel/2017-July/123128.html

[Benjamin Halbrock (kontakt-bennis-blog)]

As I can'T give you a plus one.

Thank you very much for the incredibly fast responses :D

[Bryan Guerrero (bmg1001)]

I am not on Ubuntu, but actually Arch, and creating the file, with gedit, alsa-base.conf in /etc/modprobe.d/ with the line " options snd-hda-intel mode=mute-led-gpio " worked for my HP Spectre X360 (15-ap012dx) so it seems that this fix works throughout various other distros and HP machines as well.

[Kai-Heng Feng (kaihengfeng)]

Well, you need to send a patch to add those models' ID to let Linux kernel supports it out of the box.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 4.12.0-11.12

---------------
linux (4.12.0-11.12) artful; urgency=low

  * linux: 4.12.0-11.12 -proposed tracker (LP: #1709929)

  * CVE-2017-1000111
    - packet: fix tp_reserve race in packet_set_ring

  * CVE-2017-1000112
    - udp: consistently apply ufo or fragmentation

  * Please only recommend or suggest initramfs-tools | linux-initramfs-tool for
    kernels able to boot without initramfs (LP: #1700972)
    - Revert "UBUNTU: [Debian] Don't depend on initramfs-tools"
    - [Debian] Don't depend on initramfs-tools

  * Miscellaneous Ubuntu changes
    - SAUCE: (noup) Update spl to 0.6.5.11-ubuntu1, zfs to 0.6.5.11-1ubuntu3
    - SAUCE: powerpc: Always initialize input array when calling epapr_hypercall()

  * Miscellaneous upstream changes
    - selftests: typo correction for memory-hotplug test
    - selftests: check hot-pluggagble memory for memory-hotplug test
    - selftests: check percentage range for memory-hotplug test
    - selftests: add missing test name in memory-hotplug test
    - selftests: fix memory-hotplug test

 -- Seth Forshee <email address hidden> Thu, 10 Aug 2017 13:37:00 -0500

[Kleber Sacilotto de Souza (kleber-souza)]

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-zesty' to 'verification-done-zesty'. If the problem still exists, change the tag 'verification-needed-zesty' to 'verification-failed-zesty'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Benjamin Halbrock (kontakt-bennis-blog)]

works on
Linux probook 4.10.0-33-generic #37-Ubuntu SMP Fri Aug 11 10:55:28 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

changed tag to verification-done-zesty

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 4.10.0-33.37

---------------
linux (4.10.0-33.37) zesty; urgency=low

  * linux: 4.10.0-33.37 -proposed tracker (LP: #1709303)

  * CVE-2017-1000112
    - Revert "udp: consistently apply ufo or fragmentation"
    - udp: consistently apply ufo or fragmentation

  * CVE-2017-1000111
    - Revert "net-packet: fix race in packet_set_ring on PACKET_RESERVE"
    - packet: fix tp_reserve race in packet_set_ring

  * ThunderX: soft lockup on 4.8+ kernels when running qemu-efi with vhost=on
    (LP: #1673564)
    - irqchip/gic-v3: Add missing system register definitions
    - arm64: KVM: Do not use stack-protector to compile EL2 code
    - KVM: arm/arm64: vgic-v3: Use PREbits to infer the number of ICH_APxRn_EL2
      registers
    - KVM: arm/arm64: vgic-v3: Fix nr_pre_bits bitfield extraction
    - arm64: Add a facility to turn an ESR syndrome into a sysreg encoding
    - KVM: arm/arm64: vgic-v3: Add accessors for the ICH_APxRn_EL2 registers
    - KVM: arm64: Make kvm_condition_valid32() accessible from EL2
    - KVM: arm64: vgic-v3: Add hook to handle guest GICv3 sysreg accesses at EL2
    - KVM: arm64: vgic-v3: Add ICV_BPR1_EL1 handler
    - KVM: arm64: vgic-v3: Add ICV_IGRPEN1_EL1 handler
    - KVM: arm64: vgic-v3: Add ICV_IAR1_EL1 handler
    - KVM: arm64: vgic-v3: Add ICV_EOIR1_EL1 handler
    - KVM: arm64: vgic-v3: Add ICV_AP1Rn_EL1 handler
    - KVM: arm64: vgic-v3: Add ICV_HPPIR1_EL1 handler
    - KVM: arm64: vgic-v3: Enable trapping of Group-1 system registers
    - KVM: arm64: Enable GICv3 Group-1 sysreg trapping via command-line
    - KVM: arm64: vgic-v3: Add ICV_BPR0_EL1 handler
    - KVM: arm64: vgic-v3: Add ICV_IGNREN0_EL1 handler
    - KVM: arm64: vgic-v3: Add misc Group-0 handlers
    - KVM: arm64: vgic-v3: Enable trapping of Group-0 system registers
    - KVM: arm64: Enable GICv3 Group-0 sysreg trapping via command-line
    - arm64: Add MIDR values for Cavium cn83XX SoCs
    - [Config] CONFIG_CAVIUM_ERRATUM_30115=y
    - arm64: Add workaround for Cavium Thunder erratum 30115
    - KVM: arm64: vgic-v3: Add ICV_DIR_EL1 handler
    - KVM: arm64: vgic-v3: Add ICV_RPR_EL1 handler
    - KVM: arm64: vgic-v3: Add ICV_CTLR_EL1 handler
    - KVM: arm64: vgic-v3: Add ICV_PMR_EL1 handler
    - KVM: arm64: Enable GICv3 common sysreg trapping via command-line
    - KVM: arm64: vgic-v3: Log which GICv3 system registers are trapped
    - arm64: KVM: Make unexpected reads from WO registers inject an undef
    - KVM: arm64: Log an error if trapping a read-from-write-only GICv3 access
    - KVM: arm64: Log an error if trapping a write-to-read-only GICv3 access

  * ibmvscsis: Do not send aborted task response (LP: #1689365)
    - target: Fix unknown fabric callback queue-full errors
    - ibmvscsis: Do not send aborted task response
    - ibmvscsis: Clear left-over abort_cmd pointers
    - ibmvscsis: Fix the incorrect req_lim_delta

  * hisi_sas performance improvements (LP: #1708734)
    - scsi: hisi_sas: define hisi_sas_device.device_id as int
    - scsi: hisi_sas: optimise the usage of hisi_hba.lock
    - scsi: hisi_sas: relocate sata_done_v2_hw()
    - scsi: hisi_sas: optimise DMA slot memory

  * hisi_sas...