| 2017-06-19 00:37:13 |
Daniel Axtens |
bug |
|
|
added bug |
| 2017-06-19 00:37:13 |
Daniel Axtens |
attachment added |
|
0001-HiSilicon-Hibmc-vgaarb-fixup-arm64-fixup.patch https://bugs.launchpad.net/bugs/1698706/+attachment/4898283/+files/0001-HiSilicon-Hibmc-vgaarb-fixup-arm64-fixup.patch |
|
| 2017-06-19 00:38:10 |
Daniel Axtens |
bug |
|
|
added subscriber Zhanglei Mao |
| 2017-06-19 14:24:22 |
Joseph Salisbury |
tags |
|
kernel-da-key |
|
| 2017-06-28 14:17:17 |
Daniel Axtens |
linux (Ubuntu): assignee |
|
Daniel Axtens (daxtens) |
|
| 2017-06-28 14:17:23 |
Daniel Axtens |
linux (Ubuntu): importance |
Undecided |
Medium |
|
| 2017-06-29 03:28:36 |
Daniel Axtens |
description |
The HiSilicon D05 board has some PCI bridges (PCI ID 19e5:1610) that are not spec-compliant: they do not set the VGA Enable bit when a VGA card is behind the bridge. This breaks Xorg auto-detection. [0]
Despite this, the hibmc VGA card (PCI ID 19e5:1711) is known to work when behind these bridges.
Provide a quirk so that this combination of bridge and card works.
I will upstream this and then begin the process of back-porting.
[0] https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991 - this bug tracked debugging of a segfault and then this issue. Comments 25 (https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991/comments/25) and 31 onwards detail this issue. |
SRU Justification
[Impact]
Xorg autodetection does not work on HiSilicon D05 boards.
[Fix]
The HiSilicon D05 board has some PCI bridges (PCI ID 19e5:1610) that are not spec-compliant: they do not set the VGA Enable bit when a VGA card is behind the bridge. This stops vgaarb setting the device as a boot vga device, breaking Xorg auto-detection. [0]
Despite this, the hibmc VGA card (PCI ID 19e5:1711) is known to work when behind these bridges.
Provide a quirk so that this combination of bridge and card works.
[Testcase]
On an affected board, run:
# find /sys/devices -name boot_vga -exec cat \{\} \;
This should print 0 without this patch and 1 with this patch.
[Regression Potential]
There is a risk with overriding the VGA arbiter that adding additional VGA cards to the board may go wrong somehow. The fixup specifically tests for the bridge and card on the board, so regressions should be limited to that combination of bridge and card.
[Notes]
HiSilicon is hoping to have 16.04.3 support their board, hence the submission of this patch before it has been accepted upstream. The patch has been submitted upstream and I will continue to work with upstream to land it.[1]
[0] https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991 - this bug tracked debugging of a segfault and then this issue. Comments 25 (https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991/comments/25) and 31 onwards detail this issue.
[1] https://patchwork.ozlabs.org/patch/778054/ |
|
| 2017-06-29 03:36:00 |
Daniel Axtens |
description |
SRU Justification
[Impact]
Xorg autodetection does not work on HiSilicon D05 boards.
[Fix]
The HiSilicon D05 board has some PCI bridges (PCI ID 19e5:1610) that are not spec-compliant: they do not set the VGA Enable bit when a VGA card is behind the bridge. This stops vgaarb setting the device as a boot vga device, breaking Xorg auto-detection. [0]
Despite this, the hibmc VGA card (PCI ID 19e5:1711) is known to work when behind these bridges.
Provide a quirk so that this combination of bridge and card works.
[Testcase]
On an affected board, run:
# find /sys/devices -name boot_vga -exec cat \{\} \;
This should print 0 without this patch and 1 with this patch.
[Regression Potential]
There is a risk with overriding the VGA arbiter that adding additional VGA cards to the board may go wrong somehow. The fixup specifically tests for the bridge and card on the board, so regressions should be limited to that combination of bridge and card.
[Notes]
HiSilicon is hoping to have 16.04.3 support their board, hence the submission of this patch before it has been accepted upstream. The patch has been submitted upstream and I will continue to work with upstream to land it.[1]
[0] https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991 - this bug tracked debugging of a segfault and then this issue. Comments 25 (https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991/comments/25) and 31 onwards detail this issue.
[1] https://patchwork.ozlabs.org/patch/778054/ |
SRU Justification
[Impact]
Xorg autodetection does not work on HiSilicon D05 boards.
[Fix]
The HiSilicon D05 board has some PCI bridges (PCI ID 19e5:1610) that are not spec-compliant: they do not set the VGA Enable bit when a VGA card is behind the bridge. This stops vgaarb setting the device as a boot vga device, breaking Xorg auto-detection. [0]
Despite this, the hibmc VGA card (PCI ID 19e5:1711) is known to work when behind these bridges.
Provide a quirk so that this combination of bridge and card works.
[Testcase]
On an affected board, run:
# find /sys/devices -name boot_vga -exec cat \{\} \;
This should print 0 without this patch and 1 with this patch.
[Regression Potential]
There is a risk with overriding the VGA arbiter that adding additional VGA cards to the board may go wrong somehow. The fixup specifically tests for the bridge and card on the board, so regressions should be limited to that combination of bridge and card.
[Notes]
HiSilicon is hoping to have 16.04.3 HWE kernel support their board, hence the submission of this patch before it has been accepted upstream. The patch has been submitted upstream and I will continue to work with upstream to land it.[1]
[0] https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991 - this bug tracked debugging of a segfault and then this issue. Comments 25 (https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991/comments/25) and 31 onwards detail this issue.
[1] https://patchwork.ozlabs.org/patch/778054/ |
|
| 2017-07-12 13:15:16 |
Seth Forshee |
nominated for series |
|
Ubuntu Zesty |
|
| 2017-07-12 13:15:16 |
Seth Forshee |
bug task added |
|
linux (Ubuntu Zesty) |
|
| 2017-07-12 13:15:22 |
Seth Forshee |
linux (Ubuntu): status |
In Progress |
Fix Committed |
|
| 2017-07-14 15:14:38 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu Zesty): status |
New |
Fix Committed |
|
| 2017-07-21 09:24:47 |
Kleber Sacilotto de Souza |
tags |
kernel-da-key |
kernel-da-key verification-needed-zesty |
|
| 2017-07-21 12:48:57 |
Zhanglei Mao |
tags |
kernel-da-key verification-needed-zesty |
verification-done-zesty |
|
| 2017-07-21 12:57:23 |
Zhanglei Mao |
attachment added |
|
image.png https://bugs.launchpad.net/bugs/1698706/+attachment/4918803/+files/image.png |
|
| 2017-07-21 15:32:42 |
Daniel Axtens |
tags |
verification-done-zesty |
kernel-da-key verification-done-zesty |
|
| 2017-08-03 16:29:32 |
Launchpad Janitor |
linux (Ubuntu Zesty): status |
Fix Committed |
Fix Released |
|
| 2017-08-03 16:29:32 |
Launchpad Janitor |
cve linked |
|
2017-1000364 |
|
| 2017-08-03 16:29:32 |
Launchpad Janitor |
cve linked |
|
2017-1000365 |
|
| 2017-08-03 16:29:32 |
Launchpad Janitor |
cve linked |
|
2017-10810 |
|
| 2017-08-03 16:29:32 |
Launchpad Janitor |
cve linked |
|
2017-7482 |
|
| 2017-08-03 16:29:32 |
Launchpad Janitor |
cve linked |
|
2017-7533 |
|
| 2017-08-10 05:56:17 |
Launchpad Janitor |
linux (Ubuntu): status |
Fix Committed |
Fix Released |
|
