Comment 16 for bug 1698700

Revision history for this message
Daniel Axtens (daxtens) wrote : Re: [Bug 1698700] Re: hibmc driver does not include "pci:" prefix in bus ID

Hi Fred,

The artful repository is git://kernel.ubuntu.com/ubuntu/ubuntu-artful.git

It contains 4417ec7a7c8d ("UBUNTU: SAUCE: PCI: Support hibmc VGA cards
behind a misbehaving HiSilicon bridge")

This was an earlier version of those patches and should allow xorg
autoconfiguration to work.

Regards,
Daniel

On Fri, Dec 15, 2017 at 6:38 PM, Fred Kimmy
<email address hidden> wrote:
> hi daniel:
>
> whether this following mainline patchset have merge into this artful branch or not?
> If do not merge this patchset, this xwindow function will fail it.
>
> Can you confirm it and provide this artful branch in order to test it
> for me
>
> 505a1b5 vgaarb: Factor out EFI and fallback default device selection
> a37c0f4 vgaarb: Select a default VGA device even if there's no legacy VGA
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1698700
>
> Title:
> hibmc driver does not include "pci:" prefix in bus ID
>
> Status in linux package in Ubuntu:
> Incomplete
> Status in linux source package in Zesty:
> Fix Released
> Status in linux source package in Artful:
> Fix Released
>
> Bug description:
> SRU Justification
>
> [Impact]
> On the HiSilicon D05 (arm64) board, X crashes when started. [0]
>
> [Fix]
> The crash is attributable to the bus ID that the hibmc driver reports for the hibmc graphics card on the board. In particular, the bus id is missing the "pci:" prefix that most other cards provide: [1]
> - The busid reported on the arm64 system is "0007:a1:00.0"
> - The busid reported on a amd64 system is "pci:0000:00:02.0"
>
> X tests for this prefix. A missing prefix for PCI cards leads to an
> Xorg crash.
>
> Fix this by using the set_pci_busid function from the DRM core.
>
> [Testcase]
> Successfully tested on a D05 board. [2]
>
> [Regression Potential]
> Changes are limited to the hibmc driver, so any regression should also be limited to that driver.
>
> [Notes]
> I submitted the patch upstream. However, upstream is refactoring the drm core, and set_busid is going away. That does fix this issue but the regression potential of the refactor is enormous, so this seems like the wiser approach. [3]
>
> [0]: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991
> [1]: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991/comments/16
> [2]: https://bugs.launchpad.net/ubuntu/+source/xorg/+bug/1691991/comments/29
> [3]: https://www.spinics.net/lists/dri-devel/msg143831.html
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1698700/+subscriptions