Enable suspend function for i2c-hid device in Vivid

Bug #1535513 reported by Phidias on 2016-01-19
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Undecided
Phidias
Vivid
Undecided
Phidias
linux (Ubuntu)
Medium
Unassigned
Vivid
Undecided
Unassigned

Bug Description

[Impact]
On some platforms the touchpad relies on pinctrl devices to provide GPIO interrupt, but in 3.19.0 pinctrl-cherryview doesn't support suspend well and will lose the config after suspend/resume, then touchpad can't be used.

Also, there is a racing condition in i2c-hid module which makes touchpad unusable when waking up.

[Fix]
This fix has two parts. First part is to enable the suspend/resume function in pinctrl-cherryview:

commit 9eb457b547cc731bc2fc251bd79891a60c64fc3e
Refs: [HEAD]
Author: Mika Westerberg <email address hidden>
Date: Thu Dec 4 12:32:50 2014 +0200

    pinctrl: cherryview: Save and restore pin configs over system sleep

The second part is to eliminate the racing condition in i2c-hid:

commit 9a327405014f4ef4cdad67a0686db82b9f23c62c
Author: Mika Westerberg <email address hidden>
Date: Mon Dec 21 15:26:31 2015 +0200

    HID: i2c-hid: Prevent sending reports from racing with device reset

CVE References

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1535513

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
tags: added: vivid
dino99 (9d9) wrote :

Vivid will be dead in the coming days:
http://fridge.ubuntu.com/2016/01/14/ubuntu-15-04-vivid-vervet-reaches-end-of-life-on-february-4-2016/

so its time to dist-upgrade; and check if that issue exist with the newer version(s)

Changed in linux (Ubuntu):
assignee: Phidias (phidias-chiang) → nobody
Phidias (phidias-chiang) on 2016-01-20
Changed in hwe-next:
assignee: nobody → Phidias (phidias-chiang)
Changed in linux (Ubuntu):
importance: Undecided → Medium

dino99, while you are 100% correct in Vivid expiring soon (Feb. 2016), the 3.19.x series enablement kernel for Trusty has a little bit more life left in that it expires in Aug. 2016.

Hence, I don't see the problem with this going forward as is, given the fix commits are already identified, and it's not being pursued on a high priority basis.

tags: added: cherry-pick
Changed in linux (Ubuntu):
status: Incomplete → Triaged
Brad Figg (brad-figg) on 2016-02-23
Changed in linux (Ubuntu Vivid):
status: New → Fix Committed
Brad Figg (brad-figg) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-vivid' to 'verification-done-vivid'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-vivid
Phidias (phidias-chiang) wrote :

3.19.0-52: 10/10 passed

Set to verification-done-vivid

tags: added: verification-done-vivid
removed: verification-needed-vivid
Launchpad Janitor (janitor) wrote :
Download full text (21.3 KiB)

This bug was fixed in the package linux - 3.19.0-56.62

---------------
linux (3.19.0-56.62) vivid; urgency=low

  [ Brad Figg ]

  * Release Tracking Bug
    - LP: #1555832

  [ Florian Westphal ]

  * SAUCE: [nf,v2] netfilter: x_tables: don't rely on well-behaving
    userspace
    - LP: #1555338

linux (3.19.0-55.61) vivid; urgency=low

  [ Brad Figg ]

  * Release Tracking Bug
    - LP: #1554708

  [ Upstream Kernel Changes ]

  * Revert "drm/radeon: call hpd_irq_event on resume"
    - LP: #1554608

linux (3.19.0-54.60) vivid; urgency=low

  [ Luis Henriques ]

  * Release Tracking Bug
    - LP: #1552337

  [ Upstream Kernel Changes ]

  * Revert "firmware: dmi_scan: Fix UUID endianness for SMBIOS >= 2.6"
    - LP: #1551419

linux (3.19.0-53.59) vivid; urgency=low

  [ Kamal Mostafa ]

  * Release Tracking Bug
    - LP: #1550576

  [ Kamal Mostafa ]

  * Merged back 3.19.0-52.58

linux (3.19.0-52.58) vivid; urgency=low

  [ Brad Figg ]

  * Release Tracking Bug
    - LP: #1548548

  [ Dan Streetman ]

  * SAUCE: nbd: ratelimit error msgs after socket close
    - LP: #1505564

  [ Upstream Kernel Changes ]

  * Revert "ACPI / LPSS: allow to use specific PM domain during ->probe()"
    - LP: #1542457
  * Revert "workqueue: make sure delayed work run in local cpu"
    - LP: #1546320
  * net: ipmr: fix static mfc/dev leaks on table destruction
    - LP: #1542457
  * drm/nouveau/nv46: Change mc subdev oclass from nv44 to nv4c
    - LP: #1542457
  * ovl: allow zero size xattr
    - LP: #1542457
  * ovl: use a minimal buffer in ovl_copy_xattr
    - LP: #1542457
  * [media] vb2: fix a regression in poll() behavior for output,streams
    - LP: #1542457
  * [media] gspca: ov534/topro: prevent a division by 0
    - LP: #1542457
  * [media] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode
    - LP: #1542457
  * tools lib traceevent: Fix output of %llu for 64 bit values read on 32
    bit machines
    - LP: #1542457
  * KVM: x86: expose MSR_TSC_AUX to userspace
    - LP: #1542457
  * KVM: x86: correctly print #AC in traces
    - LP: #1542457
  * drm/radeon: call hpd_irq_event on resume
    - LP: #1542457
  * xhci: refuse loading if nousb is used
    - LP: #1542457
  * arm64: Clear out any singlestep state on a ptrace detach operation
    - LP: #1542457
  * time: Avoid signed overflow in timekeeping_get_ns()
    - LP: #1542457
  * ovl: root: copy attr
    - LP: #1542457
  * Bluetooth: Add support of Toshiba Broadcom based devices
    - LP: #1522949, #1542457
  * rtlwifi: fix memory leak for USB device
    - LP: #1542457
  * wlcore/wl12xx: spi: fix oops on firmware load
    - LP: #1542457
  * ovl: check dentry positiveness in ovl_cleanup_whiteouts()
    - LP: #1542457
  * EDAC, mc_sysfs: Fix freeing bus' name
    - LP: #1542457
  * EDAC: Robustify workqueues destruction
    - LP: #1542457
  * arm64: mm: ensure that the zero page is visible to the page table
    walker
    - LP: #1542457
  * powerpc: Make value-returning atomics fully ordered
    - LP: #1542457
  * powerpc: Make {cmp}xchg* and their atomic_ versions fully ordered
    - LP: #1542457
  * dm space map metadata: remove unused variable in brb_pop()
    - LP: #1542457
  * dm thi...

Changed in linux (Ubuntu Vivid):
status: Fix Committed → Fix Released
Changed in hwe-next:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers