[Hyper-V][ubuntu 15.04] various upstream patches for hyper-v

Bug #1423343 reported by Mark W Wenning
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Medium
Andy Whitcroft
Vivid
Medium
Andy Whitcroft

Bug Description

Following patches are missing from ubuntu vivid 15.04 compared to latest upstream (linux-next) , please include them in ubuntu vivid , all the patches listed here are already upstream .

/arch/x86/include/uapi/asm/hyperv.h

1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=4061ed9e2aaac31daef44f06e9b83143c78b24b2
2. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=9e7827b5ea4ca93b4d864bc07c0fafb838d496b1

/drivers/hv/hyperv_vmbus.h
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=4061ed9e2aaac31daef44f06e9b83143c78b24b2

drivers/hv/vmbus_drv.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a45de93eb10ae44446aec2c73d722562ab46092a
2. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d8a60e000c951f845d9a5fb3e67853e0e63a5659
3. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=4061ed9e2aaac31daef44f06e9b83143c78b24b2
4. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=90f3453585479d5beb75058da46eb573ced0e6ac
5. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=302a3c0f2757ae1a3e7df3f9fa1f20e2214ab945
6. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=b0209501dc7586cbfbf6d023f2dd3ce4621aff2c

/drivers/hv/hv_snapshot.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=8d9560ebcc6448472b3afe8f36f37d6b0de8f5a4
2. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=649142074d86afebe0505431a93957505d244dd6

/drivers/hv/hv_kvp.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=8d9560ebcc6448472b3afe8f36f37d6b0de8f5a4

/drivers/hv/hv_fcopy.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d9b1652947c695d247b5e4603a16213ec55661ed

/drivers/hv/channel.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=67fae053bfc6e84144150e4c6c62670abb215c33
2. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d61031ee8df6214d58371a1cc36a0591e242fba0
3. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=9f52a1630922bcdab75fc72e59ed58db8e164314

/drivers/hv/channel_mgmt.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d7f2fbafb4f84306436277664cf28042beaf252a
2. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=67fae053bfc6e84144150e4c6c62670abb215c33
3. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=9c3a6f7e476fc4961297fc66b1177f9f8c8dd238
4. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=87712bf81dd092821c406ea3fb47a07222484a64
5. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=c3582a2c4d0baf1fa3955c8b3d3d61308df474c7

/drivers/hv/hv_balloon.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=ab3de22bb4a3d4bda2d0ec8bebcb76a40f1cbf9b
2. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=22f88475b62ac826acae2f77c3e1bd9543e87b2a
3. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=79208c57da5311860f165b613c89b3f647e357cd
4. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=f6712238471a8afdbfcea482483fc121281292d8

/tools/hv/hv_vss_daemon.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=9e5db05aae4657c7ade34ccc4b93f27ab647498e
2. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=7a401744d517864f8f2f2afba589e58a71d03aa6
3. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=170f4bea2008054e5098f99359e29823a7b4b1b9
4. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=4f689190bb55d171d2f6614f8a6cbd4b868e48bd

/tools/hv/hv_fcopy_daemon.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=c1136da62170465920eea1ae9ba9ce2234091f77
2. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=aba474b8185d60ca8cdbf3049fe6d655aa761e23

/drivers/net/hyperv/netvsc.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=da19fcd0d85f36420f578fe6dfe7a2a581b4fa6e
2. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d953ca4ddf71aa91a4596b2ff7ff1598f6ad4708
3. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=7390fe9c9a7ffdb0947add66efe7dedbe6b1cb6f
4. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=c51ed18257e731e15541324cd58bd3761d9d3b1c
5. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=aa99c47933d2c9a7622440d1b08ebb46ad8bd741
6. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=4d3c9d37f77566b04216dfc9a6513082002d7a1f

/drivers/scsi/storvsc_drv.c
1. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=b0a93d96b2814c725161f91a4e35d0c29ec0f95b
2. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=0fb8db29f2a02e8451e4e56d364c706f70a9ef00
3. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=34a716bc345ba06c34aa33d09536fcb607523818
4. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=2a09ed3d97ff8b5b377f86da9b9afd9ebd97b362
5. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=ead3700d893654d440edcb66fb3767a0c0db54cf
6. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=db5ed4dfd5dd0142ec36ff7b335e0ec3b836b3e6
7. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=c8b09f6fb67df7fc1b51ced1037fa9b677428149
8. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=d811b848ebb78a1135658aa20a80e31994df47f7

Revision history for this message
Brad Figg (brad-figg) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1423343

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
tags: added: vivid
Changed in linux (Ubuntu):
status: Incomplete → Opinion
status: Opinion → Confirmed
Changed in linux (Ubuntu):
importance: Undecided → Medium
Revision history for this message
Mark W Wenning (mwenning) wrote :

These are requested patches from the Microsoft Hyper-v team, I don't think apport will do much.

tags: added: kernel-da-key kernel-hyper-v
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
milestone: none → ubuntu-15.03
assignee: nobody → Andy Whitcroft (apw)
Revision history for this message
Andy Whitcroft (apw) wrote :
Download full text (16.4 KiB)

@Mark -- of the 41 unique patches listed above a goodly portion seem to be already applied. There seem to be some 20 which are applicable, though I would argue a number of these are code prettyness and not functional:

commit 4675b0f4137b44af01b20c2f5043a35d8d386adb
Author: Lad, Prabhakar <email address hidden>
Date: Thu Feb 5 15:06:33 2015 +0000

    hyperv: fix sparse warnings

    this patch fixes following sparse warnings:

    netvsc.c:688:5: warning: symbol 'netvsc_copy_to_send_buf' was not declared. Should it be static?
    rndis_filter.c:627:5: warning: symbol 'rndis_filter_set_offload_params' was not declared. Should it be static?
    rndis_filter.c:702:5: warning: symbol 'rndis_filter_set_rss_param' was not declared. Should it be static?

    Signed-off-by: Lad, Prabhakar <email address hidden>
    Signed-off-by: Haiyang Zhang <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>
    (cherry picked from commit da19fcd0d85f36420f578fe6dfe7a2a581b4fa6e)
    Signed-off-by: Andy Whitcroft <email address hidden>

commit 08a6c6fff1cd85d354c81477b0839f7d127f3677
Author: Nicholas Mc Guire <email address hidden>
Date: Sun Jan 25 15:46:31 2015 +0100

    hyperv: netvsc.c: match wait_for_completion_timeout return type

    Signed-off-by: Nicholas Mc Guire <email address hidden>
    Signed-off-by: David S. Miller <email address hidden>
    (cherry picked from commit 7390fe9c9a7ffdb0947add66efe7dedbe6b1cb6f)
    Signed-off-by: Andy Whitcroft <email address hidden>

commit 4fb9d6200a772fbba36492816713d44519c18011
Author: kbuild test robot <email address hidden>
Date: Mon Jan 26 01:17:54 2015 +0800

    Drivers: hv: vmbus: hv_process_timer_expiration() can be static

    drivers/hv/vmbus_drv.c:582:6: sparse: symbol 'hv_process_timer_expiration' was not declared. Should it be static?

    Signed-off-by: Fengguang Wu <email address hidden>
    Cc: Vitaly Kuznetsov <email address hidden>
    Cc: "K. Y. Srinivasan" <email address hidden>
    Cc: Haiyang Zhang <email address hidden>
    Signed-off-by: Greg Kroah-Hartman <email address hidden>
    (cherry picked from commit d8a60e000c951f845d9a5fb3e67853e0e63a5659)
    Signed-off-by: Andy Whitcroft <email address hidden>

commit 880bbd9b213da54767df2261f94568e797c34365
Author: Vitaly Kuznetsov <email address hidden>
Date: Tue Jan 20 16:45:06 2015 +0100

    Drivers: hv: vmbus: serialize Offer and Rescind offer

    Commit 4b2f9abea52a ("staging: hv: convert channel_mgmt.c to not call
    osd_schedule_callback")' was written under an assumption that we never receive
    Rescind offer while we're still processing the initial Offer request. However,
    the issue we fixed in 04a258c162a8 could be caused by this assumption not
    always being true.

    In particular, we need to protect against the following:
    1) Receiving a Rescind offer after we do queue_work() for processing an Offer
       request and before we actually enter vmbus_process_offer(). work.func points
       to vmbus_process_offer() at this moment and in vmbus_onoffer_rescind() we do
       another queue_work() without a check so we'll enter vmbus_process_offer()
   ...

Revision history for this message
Andy Whitcroft (apw) wrote :

Could you test the kernels at the URL below and confirm they work correctly on Azure:

    http://people.canonical.com/~apw/lp1423343-vivid/

Please report any testing back here. Thanks.

Changed in linux (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Chris Valean (cvalean) wrote :

Thank you Andy!
So all patches have been included in the test kernel provided, or the ones you've mentioned in Comment #3 have not been picked up?

Revision history for this message
Chris Valean (cvalean) wrote :

It seems that from the files provided we're missing these 2 packages, that prevent the daemons installation.
Forcing the installation of the linux*-generic packages will work, however the LIS daemons will not get installed.

root@ubuntu1504:~# uname -a
Linux ubuntu1504 3.19.0-11-generic #11~lp1423343v201503271335 SMP Fri Mar 27 13:39:40 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

root@ubuntu1504:~# dpkg -i linux-tools-3.19.0-11-generic_3.19.0-11.11~lp1423343v201503271335_amd64.deb
(Reading database ... 63748 files and directories currently installed.)
Preparing to unpack linux-tools-3.19.0-11-generic_3.19.0-11.11~lp1423343v201503271335_amd64.deb ...
Unpacking linux-tools-3.19.0-11-generic (3.19.0-11.11~lp1423343v201503271335) over (3.19.0-11.11~lp1423343v201503271335) ...
dpkg: dependency problems prevent configuration of linux-tools-3.19.0-11-generic:
 linux-tools-3.19.0-11-generic depends on linux-tools-3.19.0-11; however:
  Package linux-tools-3.19.0-11 is not installed.

dpkg: error processing package linux-tools-3.19.0-11-generic (--install):
 dependency problems - leaving unconfigured
Errors were encountered while processing:
 linux-tools-3.19.0-11-generic
---------------------

root@ubuntu1504:~# dpkg -i linux-cloud-tools-3.19.0-11-generic_3.19.0-11.11~lp1423343v201503271335_amd64.deb
(Reading database ... 63748 files and directories currently installed.)
Preparing to unpack linux-cloud-tools-3.19.0-11-generic_3.19.0-11.11~lp1423343v201503271335_amd64.deb ...
Unpacking linux-cloud-tools-3.19.0-11-generic (3.19.0-11.11~lp1423343v201503271335) over (3.19.011.11~lp1423343v201503271335) ...
dpkg: dependency problems prevent configuration of linux-cloud-tools-3.19.0-11-generic:
 linux-cloud-tools-3.19.0-11-generic depends on linux-cloud-tools-3.19.0-11; however:
  Package linux-cloud-tools-3.19.0-11 is not installed.

dpkg: error processing package linux-cloud-tools-3.19.0-11-generic (--install):
 dependency problems - leaving unconfigured
Errors were encountered while processing:
 linux-cloud-tools-3.19.0-11-generic

Revision history for this message
Andy Whitcroft (apw) wrote :

Ok seems we were missing a couple of packages in those test builds, particularly the cloud common packages. I've rebased this patch kit to the latest vivid and rebuilt them, hopefully this lot will work. Test builds at the URL below:

    http://people.canonical.com/~apw/lp1423343-vivid/

Please report any further testing here. Thanks.

Revision history for this message
Andy Whitcroft (apw) wrote :

A couple of people pointed out that these builds have the tools but
the ancillary scripts and systemd configuration etc is all missing.
Turned out to be a bug in the test build system which was incorrectly
building the indep packages on the wrong architecture (which includes the
common packages), which in turn was exposing a bug in our packaging
which meant if you did that the contents got lost. Anyhow, those are both
now fixed and I have built some new test builds which looks right to my eye.

Those are at the URL below (a new one for transparency):

    http://people.canonical.com/~apw/lp1423343-2-vivid/

Let me know what you find. Thanks.

Revision history for this message
Joshua R. Poulson (jrp) wrote :

Thank you apw, we'll take another look at it soon.

Revision history for this message
Andy Whitcroft (apw) wrote :

It seems that due to a bug in debhelper the system units for the hyper-v daemons
are not being enabled correctly. I think I have this worked around. Could you test these
further builds and confirm whether the daemons start correctly on boot for you:

    http://people.canonical.com/~apw/lp1423343-3-vivid/

Let me know what you find. Thanks.

Revision history for this message
Andy Whitcroft (apw) wrote :

Any luck with testing these latest builds?

Revision history for this message
Chris Valean (cvalean) wrote :

Hi Andy,
The LIS daemons are now automatically installed and enabled, so that issue has been resolved.

Andy Whitcroft (apw)
Changed in linux (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Chris Valean (cvalean) wrote :

Hi Andy,
Verifying the sources for 3.19.0 in the latest daily build - April 15th, at a quick check it seems that this patch is not present:
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=a45de93eb10ae44446aec2c73d722562ab46092a

Can you please double-check on it? The other patches are in place, will update if we find any other missing.
Thank you!

Revision history for this message
Joseph Salisbury (jsalisbury) wrote :

Confirmed that commit a45de93 is missing from Vivid. I build a Vivid test kernel with this commit and posted it for download from:

http://kernel.ubuntu.com/~jsalisbury/lp1423343/

Can you test this kernel and comfirm it resolves this bug?

Changed in linux (Ubuntu):
status: Fix Committed → Triaged
Changed in linux (Ubuntu Vivid):
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Andy Whitcroft (apw)
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
milestone: ubuntu-15.03 → ubuntu-15.07
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
milestone: ubuntu-15.07 → ubuntu-15.08
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
milestone: ubuntu-15.08 → ubuntu-15.09
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
milestone: ubuntu-15.09 → ubuntu-15.10
Revision history for this message
Mark W Wenning (mwenning) wrote :

Marked Invalid, Josh will submit in a set of different bug(s)

Changed in linux (Ubuntu):
status: Triaged → Invalid
Changed in linux (Ubuntu Vivid):
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints