Ubuntu
linux package

Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

Bug #1291890 reported by Micha Moskovic on 2014-03-13

This bug affects 4 people

Affects		Status	Importance	Assigned to	Milestone
	linux (Ubuntu)	Fix Released	Medium	Unassigned
	Trusty	Fix Released	Medium	Unassigned

Bug Description

Many new Thinkpad laptops have a dock (Thinkpad OneLink Dock) containing a usb ethernet chip that is supported by the ax88179 driver.
However its USB ID is not included in the driver shipped with the 3.13 kernel used in Trusty.
A patch to add this ID has been sent to the LKML (see https://lkml.org/lkml/2014/2/24/649 ) and it would be very convenient for all users of the dock if it could be applied to the Trusty kernel.

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: linux-image-3.13.0-17-generic 3.13.0-17.37
ProcVersionSignature: Ubuntu 3.13.0-17.37-generic 3.13.6
Uname: Linux 3.13.0-17-generic x86_64
ApportVersion: 2.13.3-0ubuntu1
Architecture: amd64
AudioDevicesInUse:
USER PID ACCESS COMMAND
/dev/snd/controlC2: micha 8607 F.... pulseaudio
/dev/snd/controlC1: micha 8607 F.... pulseaudio
/dev/snd/controlC0: micha 8607 F.... pulseaudio
CurrentDesktop: GNOME
Date: Thu Mar 13 10:41:12 2014
HibernationDevice: RESUME=UUID=94a8f353-1b7f-4d32-ad21-b39573948adf
InstallationDate: Installed on 2014-03-08 (4 days ago)
InstallationMedia: Ubuntu-GNOME 14.04 "Trusty Tahr" - Alpha amd64 (20140307)
MachineType: LENOVO 20CD0038MB
ProcFB: 0 inteldrmfb
ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-3.13.0-17-generic.efi.signed root=UUID=db82a119-3fe0-4ecb-b3f8-728fc1896ae8 ro quiet splash vt.handoff=7
RelatedPackageVersions:
linux-restricted-modules-3.13.0-17-generic N/A
linux-backports-modules-3.13.0-17-generic N/A
linux-firmware 1.126
SourcePackage: linux
UpgradeStatus: No upgrade log present (probably fresh install)
dmi.bios.date: 01/22/2014
dmi.bios.vendor: LENOVO
dmi.bios.version: GQET32WW (1.12 )
dmi.board.asset.tag: Not Available
dmi.board.name: 20CD0038MB
dmi.board.vendor: LENOVO
dmi.board.version: SDK0E50510 Pro
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: Not Available
dmi.modalias: dmi:bvnLENOVO:bvrGQET32WW(1.12):bd01/22/2014:svnLENOVO:pn20CD0038MB:pvrThinkPadS1Yoga:rvnLENOVO:rn20CD0038MB:rvrSDK0E50510Pro:cvnLENOVO:ct10:cvrNotAvailable:
dmi.product.name: 20CD0038MB
dmi.product.version: ThinkPad S1 Yoga
dmi.sys.vendor: LENOVO

Tags:

CVE References

Revision history for this message

Micha Moskovic (micha-mosk) wrote on 2014-03-13:

AlsaInfo.txt Edit (44.9 KiB, text/plain; charset="utf-8")
BootDmesg.txt Edit (68.9 KiB, text/plain; charset="utf-8")
CRDA.txt Edit (192 bytes, text/plain; charset="utf-8")
CurrentDmesg.txt Edit (95.6 KiB, text/plain; charset="utf-8")
Dependencies.txt Edit (2.7 KiB, text/plain; charset="utf-8")
IwConfig.txt Edit (471 bytes, text/plain; charset="utf-8")
Lspci.txt Edit (8.6 KiB, text/plain; charset="utf-8")
Lsusb.txt Edit (727 bytes, text/plain; charset="utf-8")
ProcCpuinfo.txt Edit (3.9 KiB, text/plain; charset="utf-8")
ProcEnviron.txt Edit (109 bytes, text/plain; charset="utf-8")
ProcInterrupts.txt Edit (2.1 KiB, text/plain; charset="utf-8")
ProcModules.txt Edit (5.4 KiB, text/plain; charset="utf-8")
PulseList.txt Edit (33.2 KiB, text/plain; charset="utf-8")
RfKill.txt Edit (182 bytes, text/plain; charset="utf-8")
UdevDb.txt Edit (162.1 KiB, text/plain; charset="utf-8")
UdevLog.txt Edit (340.0 KiB, text/plain; charset="utf-8")
WifiSyslog.txt Edit (254.6 KiB, text/plain; charset="utf-8")

Revision history for this message

Micha Moskovic (micha-mosk) wrote on 2014-03-13:

Patch provided on the LKML Edit (973 bytes, text/plain)

Micha Moskovic (micha-mosk) on 2014-03-13

tags:

added: patch

Revision history for this message

Brad Figg (brad-figg) wrote on 2014-03-13: Status changed to Confirmed

This change was made by a bot.

Changed in linux (Ubuntu):
status:	New → Confirmed

Revision history for this message

Micha Moskovic (micha-mosk) wrote on 2014-03-13:

The driver was patched upstream in commit http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/net/usb/ax88179_178a.c?id=e5fe0cd442e50f156bb54f5385b19eda50a13ccd

Micha Moskovic (micha-mosk) on 2014-03-13

tags:

added: cherry-pick kernel-net
removed: amd64 apport-bug

Revision history for this message

Andy Whitcroft (apw) wrote on 2014-03-14:

I have pulled this patch into a test kernel, could you test the kernel below and let me know if they work as expected:

http://people.canonical.com/~apw/lp1291890-trusty/

Please report any testing back here.

Revision history for this message

Micha Moskovic (micha-mosk) wrote on 2014-03-14: Re: [Bug 1291890] Re: Add Lenovo ThinkPad OneLink GigaLAN USB ID to ax88179 driver

The test kernel works, the ethernet adapter is detected and I am
successfully connected to the network.

Tim Gardner (timg-tpi) on 2014-03-14

Changed in linux (Ubuntu Trusty):
status:	Confirmed → Fix Committed

Joseph Salisbury (jsalisbury) on 2014-03-17

Changed in linux (Ubuntu Trusty):
importance:	Undecided → Medium

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-03-18:

This bug was fixed in the package linux - 3.13.0-18.38

---------------
linux (3.13.0-18.38) trusty; urgency=low

[ Tim Gardner ]

  * Release Tracking Bug
    - LP: #1293725
  * [Config] Add hv_balloon to d-i virtio-modules
    - LP: #1292216

[ Andy Whitcroft ]

* [Config] d-i -- add virtio_scsi to virtio-modules
- LP: #1288607

[ Colin Ian King ]

* SAUCE: intel_pstate: inform user that thermald is worth considering

[ dann frazier ]

* [Config] arm64: KVM=y

[ Gerd Hoffmann ]

  * SAUCE: vmbus: add missing breaks
    - LP: #1287398
  * SAUCE: vmbus: use resource for hyperv mmio region
    - LP: #1287398
  * SAUCE: hyperv-fb: add support for generation 2 virtual machines.
    - LP: #1287398
  * SAUCE: hyperv-fb: kick off efifb early
    - LP: #1287398

[ Haiyang Zhang ]

* SAUCE: hyperv: Change the receive buffer size for legacy hosts
- LP: #1290151

[ K. Y. Srinivasan ]

* SAUCE: Drivers: hv: vmbus: Extract the mmio information from DSDT
- LP: #1287398

[ Paolo Pisati ]

  * SAUCE: leds-gpio: of: introduce MODULE_DEVICE_TABLE for module
    autoloading
  * [Config] amhf: LEDS_TRIGGER_HEARTBEAT=y

[ Upstream Kernel Changes ]

  * Revert "xhci 1.0: Limit arbitrarily-aligned scatter gather."
    - LP: #1293361
  * Revert "USBNET: ax88179_178a: enable tso if usb host supports sg dma"
    - LP: #1293361
  * powerpc/tm: Fix crash when forking inside a transaction
  * AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN
    - LP: #1291890
  * drm/vmwgfx: Fix a surface reference corner-case in legacy emulation
    mode
  * Input: wacom - scale up touch width and height values for Intuos Pro
  * Input: wacom - make sure touch_max is set for touch devices
  * Input: wacom - add support for three new Intuos devices
  * Input: wacom - add reporting of SW_MUTE_DEVICE events
  * Input: wacom - fix wacom->shared guards for dual input devices
  * Input: wacom - add support for DTU-1031
  * net: fix for a race condition in the inet frag code
    - CVE-2014-0100
  * net: sctp: fix sctp_sf_do_5_1D_ce to verify if we/peer is AUTH capable
    - CVE-2014-0101
  * KEYS: Make the keyring cycle detector ignore other keyrings of the same
    name
    - CVE-2014-0102
  * ipv6: don't set DST_NOCOUNT for remotely added routes
    - CVE-2014-2309
-- Andy Whitcroft <email address hidden> Thu, 13 Mar 2014 10:06:05 +0000

This bug was fixed in the package linux - 3.13.0-18.38

---------------
linux (3.13.0-18.38) trusty; urgency=low

[ Tim Gardner ]

* Release Tracking Bug
    - LP: #1293725
  * [Config] Add hv_balloon to d-i virtio-modules
    - LP: #1292216

[ Andy Whitcroft ]

* [Config] d-i -- add virtio_scsi to virtio-modules
    - LP: #1288607

[ Colin Ian King ]

* SAUCE: intel_pstate: inform user that thermald is worth considering

[ dann frazier ]

* [Config] arm64: KVM=y

[ Gerd Hoffmann ]

[ Haiyang Zhang ]

* SAUCE: hyperv: Change the receive buffer size for legacy hosts
    - LP: #1290151

[ K. Y. Srinivasan ]

* SAUCE: Drivers: hv: vmbus: Extract the mmio information from DSDT
    - LP: #1287398

[ Paolo Pisati ]

* SAUCE: leds-gpio: of: introduce MODULE_DEVICE_TABLE for module
    autoloading
  * [Config] amhf: LEDS_TRIGGER_HEARTBEAT=y

[ Upstream Kernel Changes ]

* Revert "xhci 1.0: Limit arbitrarily-aligned scatter gather."
    - LP: #1293361
  * Revert "USBNET: ax88179_178a: enable tso if usb host supports sg dma"
    - LP: #1293361
  * powerpc/tm: Fix crash when forking inside a transaction
  * AX88179_178A: Add VID:DID for Lenovo OneLinkDock Gigabit LAN
    - LP: #1291890
  * drm/vmwgfx: Fix a surface reference corner-case in legacy emulation
    mode
  * Input: wacom - scale up touch width and height values for Intuos Pro
  * Input: wacom - make sure touch_max is set for touch devices
  * Input: wacom - add support for three new Intuos devices
  * Input: wacom - add reporting of SW_MUTE_DEVICE events
  * Input: wacom - fix wacom->shared guards for dual input devices
  * Input: wacom - add support for DTU-1031
  * net: fix for a race condition in the inet frag code
    - CVE-2014-0100
  * net: sctp: fix sctp_sf_do_5_1D_ce to verify if we/peer is AUTH capable
    - CVE-2014-0101
  * KEYS: Make the keyring cycle detector ignore other keyrings of the same
    name
    - CVE-2014-0102
  * ipv6: don't set DST_NOCOUNT for remotely added routes
    - CVE-2014-2309
 -- Andy Whitcroft <apw@canonical.com>   Thu, 13 Mar 2014 10:06:05 +0000

Changed in linux (Ubuntu Trusty):
status:	Fix Committed → Fix Released

Revision history for this message

Felix Lammermann (felix-lammermann) wrote on 2015-12-29:

It doesn't work for me, I have pretty much no idea how to do this. Can anyone please post step by step instructions for me?

What I did so far:

I have found a file called "ax88179_178a.ko" in "/lib/modules/3.13.0-74-generic/kernel/drivers/net" as well as in "/lib/modules/3.19.0-31-generic/kernel/drivers/net". I tried patching each of them with:

patch "ax88179_178a.ko" < "0001-AX88179_178A-Add-VID-DID-for-Lenovo-OneLinkDock-Giga.patch"

which returned in both cases:

patching file ax88179_178a.ko
Hunk #1 FAILED at 1418.
Hunk #2 FAILED at 1435.
2 out of 2 hunks FAILED -- saving rejects to file ax88179_178a.ko.rej

So my questions are:

1. What am I doing wrong?
2. "3.13.0-74-generic" and "3.19.0-31-generic" seem to be better than "3.13.0-18-generic", should the ethernet therefore work out of the box and I don't need to patch this? If so, I probably have another problem with my ethernet and would be grateful if someone can help me.