Comment 7 for bug 1156077

Revision history for this message
Joseph Salisbury (jsalisbury) wrote :

@Chris Wilson,

Your patch applied to the Raring tree without an issue. However, there were some build warnings and a build error, which prevented the kernel from compiling.

The following is the warnings and the error:

/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c: In function '__check_redraw':
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c:70:1: warning: return from incompatible pointer type [enabled by default]
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c: In function '__check_ypan':
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c:71:1: warning: return from incompatible pointer type [enabled by default]
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c: In function '__check_ywrap':
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c:72:1: warning: return from incompatible pointer type [enabled by default]
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c: In function '__check_vgapal':
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c:73:1: warning: return from incompatible pointer type [enabled by default]
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c: In function '__check_pmipal':
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c:75:1: warning: return from incompatible pointer type [enabled by default]
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c: In function '__check_nomtrr':
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c:79:1: warning: return from incompatible pointer type [enabled by default]
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c: In function 'aperture_already_claimed':
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c:268:23: error: 'size_total' undeclared (first use in this function)
/home/jsalisbury/bugs/lp1156077/ubuntu-raring/drivers/video/vesafb.c:268:23: note: each undeclared identifier is reported only once for each function it appears in
  CC [M] drivers/staging/vt6655/tkip.o
make[4]: *** [drivers/video/vesafb.o] Error 1
make[4]: *** Waiting for unfinished jobs....

It looks like size_total was not declared in your new function: aperture_already_claimed(). Were you able to compile your patch? Does comment #3 contain the latest version?