Ubuntu

Mute LED not working on another HP machine

Reported by David Henningsson on 2013-02-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Undecided
David Henningsson

Bug Description

This bug is for tracking purposes, please do not triage.

This bug is missing log files that will aid in diagnosing the problem. From a terminal window please run:

apport-collect 1128934

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete

These two machines have no mute LED string in BIOS.

BugLink: https://bugs.launchpad.net/bugs/1128934
Tested-by: Tammy Yang <email address hidden>
Signed-off-by: David Henningsson <email address hidden>
---

Should be sent to stable too, but I guess the patch have to be
rewritten to fit.

 sound/pci/hda/patch_realtek.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 48c9d10..e575685 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2726,6 +2726,18 @@ static void alc269_fixup_hp_mute_led(struct hda_codec *codec,
  }
 }

+static void alc269_fixup_hp_mute_led_mic1(struct hda_codec *codec,
+ const struct hda_fixup *fix, int action)
+{
+ struct alc_spec *spec = codec->spec;
+ if (action == HDA_FIXUP_ACT_PRE_PROBE) {
+ spec->mute_led_polarity = 0;
+ spec->mute_led_nid = 0x18;
+ spec->gen.vmaster_mute.hook = alc269_fixup_mic_mute_hook;
+ spec->gen.vmaster_mute_enum = 1;
+ }
+}
+
 static void alc269_fixup_hp_mute_led_mic2(struct hda_codec *codec,
     const struct hda_fixup *fix, int action)
 {
@@ -2771,6 +2783,7 @@ enum {
  ALC269VB_FIXUP_AMIC,
  ALC269VB_FIXUP_DMIC,
  ALC269_FIXUP_HP_MUTE_LED,
+ ALC269_FIXUP_HP_MUTE_LED_MIC1,
  ALC269_FIXUP_HP_MUTE_LED_MIC2,
  ALC269_FIXUP_INV_DMIC,
  ALC269_FIXUP_LENOVO_DOCK,
@@ -2903,6 +2916,10 @@ static const struct hda_fixup alc269_fixups[] = {
   .type = HDA_FIXUP_FUNC,
   .v.func = alc269_fixup_hp_mute_led,
  },
+ [ALC269_FIXUP_HP_MUTE_LED_MIC1] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc269_fixup_hp_mute_led_mic1,
+ },
  [ALC269_FIXUP_HP_MUTE_LED_MIC2] = {
   .type = HDA_FIXUP_FUNC,
   .v.func = alc269_fixup_hp_mute_led_mic2,
@@ -2947,6 +2964,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x1025, 0x029b, "Acer 1810TZ", ALC269_FIXUP_INV_DMIC),
  SND_PCI_QUIRK(0x1025, 0x0349, "Acer AOD260", ALC269_FIXUP_INV_DMIC),
  SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
+ SND_PCI_QUIRK(0x103c, 0x1973, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
+ SND_PCI_QUIRK(0x103c, 0x1983, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
  SND_PCI_QUIRK_VENDOR(0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED),
  SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_DMIC),
  SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_DMIC),
--
1.7.9.5

Changed in linux (Ubuntu):
assignee: nobody → David Henningsson (diwic)
status: Incomplete → In Progress
Takashi Iwai (tiwai) wrote :

At Mon, 18 Feb 2013 11:41:55 +0100,
David Henningsson wrote:
>
> These two machines have no mute LED string in BIOS.
>
> BugLink: https://bugs.launchpad.net/bugs/1128934
> Tested-by: Tammy Yang <email address hidden>
> Signed-off-by: David Henningsson <email address hidden>

Thanks, applied.

> ---
>
> Should be sent to stable too, but I guess the patch have to be
> rewritten to fit.

Yes, once when this patch is merged, feel free to send such one to
stable tree.

Takashi

> sound/pci/hda/patch_realtek.c | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 48c9d10..e575685 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -2726,6 +2726,18 @@ static void alc269_fixup_hp_mute_led(struct hda_codec *codec,
> }
> }
>
> +static void alc269_fixup_hp_mute_led_mic1(struct hda_codec *codec,
> + const struct hda_fixup *fix, int action)
> +{
> + struct alc_spec *spec = codec->spec;
> + if (action == HDA_FIXUP_ACT_PRE_PROBE) {
> + spec->mute_led_polarity = 0;
> + spec->mute_led_nid = 0x18;
> + spec->gen.vmaster_mute.hook = alc269_fixup_mic_mute_hook;
> + spec->gen.vmaster_mute_enum = 1;
> + }
> +}
> +
> static void alc269_fixup_hp_mute_led_mic2(struct hda_codec *codec,
> const struct hda_fixup *fix, int action)
> {
> @@ -2771,6 +2783,7 @@ enum {
> ALC269VB_FIXUP_AMIC,
> ALC269VB_FIXUP_DMIC,
> ALC269_FIXUP_HP_MUTE_LED,
> + ALC269_FIXUP_HP_MUTE_LED_MIC1,
> ALC269_FIXUP_HP_MUTE_LED_MIC2,
> ALC269_FIXUP_INV_DMIC,
> ALC269_FIXUP_LENOVO_DOCK,
> @@ -2903,6 +2916,10 @@ static const struct hda_fixup alc269_fixups[] = {
> .type = HDA_FIXUP_FUNC,
> .v.func = alc269_fixup_hp_mute_led,
> },
> + [ALC269_FIXUP_HP_MUTE_LED_MIC1] = {
> + .type = HDA_FIXUP_FUNC,
> + .v.func = alc269_fixup_hp_mute_led_mic1,
> + },
> [ALC269_FIXUP_HP_MUTE_LED_MIC2] = {
> .type = HDA_FIXUP_FUNC,
> .v.func = alc269_fixup_hp_mute_led_mic2,
> @@ -2947,6 +2964,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1025, 0x029b, "Acer 1810TZ", ALC269_FIXUP_INV_DMIC),
> SND_PCI_QUIRK(0x1025, 0x0349, "Acer AOD260", ALC269_FIXUP_INV_DMIC),
> SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
> + SND_PCI_QUIRK(0x103c, 0x1973, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> + SND_PCI_QUIRK(0x103c, 0x1983, "HP Pavilion", ALC269_FIXUP_HP_MUTE_LED_MIC1),
> SND_PCI_QUIRK_VENDOR(0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", ALC269VB_FIXUP_DMIC),
> SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", ALC269VB_FIXUP_DMIC),
> --
> 1.7.9.5
>

Changed in linux (Ubuntu):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 3.9.0-0.2

---------------
linux (3.9.0-0.2) saucy; urgency=low

  [ Tim Gardner ]

  * Enable extras packaging for amd64/i386.
    Fixes build depenencies with brittany and linux-meta.
 -- Tim Gardner <email address hidden> Mon, 29 Apr 2013 05:37:01 -0600

Changed in linux (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers