Wrong get_gate_vma call in i386 NX emulation code

Bug #1009200 reported by Herton R. Krzesinski on 2012-06-05
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Undecided
Herton R. Krzesinski
Oneiric
Medium
Herton R. Krzesinski
Precise
Medium
Herton R. Krzesinski

Bug Description

Since commit 31db58b3 ("mm: arch: make get_gate_vma take an mm_struct
instead of a task_struct"), that went in linux 2.6.39, get_gate_vma is
expected to take an struct mm_struct pointer as its parameter. But
get_gate_vma in i386 NX emulation code patch is still using the old way.

SRU Justification

Impact: seems we could have problems only if acessing something vdso related, not sure, anyway we should fix the issue.

Fix: pass the proper parameter to get_gate_vma

Test Case: without the fix, you get this build warning on i386:
ubuntu-precise/arch/x86/kernel/traps.c: In function 'check_lazy_exec_limit':
ubuntu-precise/arch/x86/kernel/traps.c:145:3: warning: passing argument 1 of 'get_gate_vma' from incompatible pointer type [enabled by default]
ubuntu-precise/include/linux/mm.h:1569:31: note: expected 'struct mm_struct *' but argument is of type 'struct task_struct *'

description: updated
description: updated
Herton R. Krzesinski (herton) wrote :

Quantal doesn't have the NX emulation patches, set main linux task to invalid.

Changed in linux (Ubuntu Oneiric):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Herton R. Krzesinski (herton)
Changed in linux (Ubuntu Precise):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Herton R. Krzesinski (herton)
Changed in linux (Ubuntu):
status: In Progress → Invalid
Luis Henriques (henrix) wrote :

The compilation warnings in oneiric are now fixed. Tagging as verified.

tags: added: verification-done-oneiric
Luis Henriques (henrix) wrote :

The compilation warnings in precise are now fixed. Tagging as verified.

tags: added: verification-done-precise
Changed in linux (Ubuntu Oneiric):
status: In Progress → Fix Committed
Changed in linux (Ubuntu Precise):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :
Download full text (4.9 KiB)

This bug was fixed in the package linux - 3.0.0-22.36

---------------
linux (3.0.0-22.36) oneiric-proposed; urgency=low

  [Luis Henriques]

  * Release Tracking Bug
    - LP: #1012040

  [ Herton Ronaldo Krzesinski ]

  * SAUCE: fix get_gate_vma call in i386 NX emulation code
    - LP: #1009200

  [ Upstream Kernel Changes ]

  * Avoid reading past buffer when calling GETACL
    - LP: #1002505
    - CVE-2012-2375
  * Avoid beyond bounds copy while caching ACL
    - LP: #1002505
    - CVE-2012-2375
  * Fix length of buffer copied in __nfs4_get_acl_uncached
    - LP: #1002505
    - CVE-2012-2375
  * tilegx: enable SYSCALL_WRAPPERS support
    - LP: #1008697
  * block: fix buffer overflow when printing partition UUIDs
    - LP: #1008697
  * block: don't mark buffers beyond end of disk as mapped
    - LP: #1008697
  * PARISC: fix PA1.1 oops on boot
    - LP: #1008697
  * PARISC: fix crash in flush_icache_page_asm on PA1.1
    - LP: #1008697
  * PARISC: fix panic on prefetch(NULL) on PA7300LC
    - LP: #1008697
  * isdn/gigaset: ratelimit CAPI message dumps
    - LP: #1008697
  * vfs: make AIO use the proper rw_verify_area() area helpers
    - LP: #1008697
  * cfg80211: warn if db.txt is empty with CONFIG_CFG80211_INTERNAL_REGDB
    - LP: #1008697
  * Fix blocking allocations called very early during bootup
    - LP: #1008697
  * s390/pfault: fix task state race
    - LP: #1008697
  * SCSI: mpt2sas: Fix for panic happening because of improper memory
    allocation
    - LP: #1008697
  * RDMA/cxgb4: Drop peer_abort when no endpoint found
    - LP: #1008697
  * KEYS: Use the compat keyctl() syscall wrapper on Sparc64 for Sparc32
    compat
    - LP: #1008697
  * SELinux: if sel_make_bools errors don't leave inconsistent state
    - LP: #1008697
  * drivers/staging/comedi/comedi_fops.c: add missing vfree
    - LP: #1008697
  * perf/x86: Update event scheduling constraints for AMD family 15h models
    - LP: #1008697
  * mtd: sm_ftl: fix typo in major number.
    - LP: #1008697
  * ahci: Detect Marvell 88SE9172 SATA controller
    - LP: #1008697
  * um: Fix __swp_type()
    - LP: #1008697
  * um: Implement a custom pte_same() function
    - LP: #1008697
  * docs: update HOWTO for 2.6.x -> 3.x versioning
    - LP: #1008697
  * USB: cdc-wdm: poll must return POLLHUP if device is gone
    - LP: #1008697
  * workqueue: skip nr_running sanity check in worker_enter_idle() if
    trustee is active
    - LP: #1008697
  * mm: mempolicy: Let vma_merge and vma_split handle vma->vm_policy
    linkages
    - LP: #1008697
  * md: using GFP_NOIO to allocate bio for flush request
    - LP: #1008697
  * Add missing call to uart_update_timeout()
    - LP: #1008697
  * tty: Allow uart_register/unregister/register
    - LP: #1008697
  * USB: ftdi-sio: add support for Physik Instrumente E-861
    - LP: #1008697
  * usb-storage: unusual_devs entry for Yarvik PMP400 MP4 player
    - LP: #1008697
  * USB: ffs-test: fix length argument of out function call
    - LP: #1008697
  * drivers/rtc/rtc-pl031.c: configure correct wday for 2000-01-01
    - LP: #1008697
  * SCSI: hpsa: Fix problem with MSA2xxx devices
    - LP: #1008697
  * usb: usbtest: two super speed fixes for usbt...

Read more...

Changed in linux (Ubuntu Oneiric):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :
Download full text (13.2 KiB)

This bug was fixed in the package linux - 3.2.0-26.41

---------------
linux (3.2.0-26.41) precise-proposed; urgency=low

  [Luis Henriques]

  * Release Tracking Bug
    - LP: #1012057

  [ Andy Whitcroft ]

  * [Config] fix up postinst to ensure we know which error is which
    - LP: #1002388
  * [Config] highbank -- commonise filesystems
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise subsystems
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise network protocols
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise input drivers
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise CRYPTO options
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise HID options
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise sensors options
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise EXPORTFS/FHANDLE
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise CONFIG_CRYPTO_LZO
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise ENCRYPTED_KEYS
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise CONFIG_ATALK
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise INET/INET6
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise NLS
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise BLK/CHR
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise PHY settings
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise CRC settings
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise BINFMT settings
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise DM settings
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise RTC_DRV settings
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise KEYBOARD/MOUSE settings
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise USB settings
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise GPIO settings
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise I2C settings
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise numerous subsystem selectors
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise A-C modules missmatches
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise D-F modules missmatches
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise G-I modules missmatches
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise J-L modules missmatches
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise M modules missmatches
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise N-P modules missmatches
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise Q-R modules missmatches
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise S modules missmatches
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise T modules missmatches
    - LP: #1000831, #1010463
  * [Config] highbank -- commonise U-Z modules missmatches
    - LP: #1000831, #1010463

  [ Herton Ronaldo Krzesinski ]

  * SAUCE: fix get_gate_vma call in i386 NX emulation code
    - LP: #1009200

  [ Ike Panhc ]

  * [Config] add...

Changed in linux (Ubuntu Precise):
status: Fix Committed → Fix Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers