yama_ptracer_del lockdep warning

Bug #791019 reported by Ming Lei on 2011-06-01
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Undecided
Unassigned
Natty
Undecided
Unassigned
Oneiric
Undecided
Unassigned
linux-ti-omap4 (Ubuntu)
Medium
Ming Lei
Natty
Undecided
Unassigned
Oneiric
Medium
Ming Lei

Bug Description

See attachment log when the lockdep compile option is enabled.

Ming Lei (tom-leiming) wrote :
Bryan Wu (cooloney) on 2011-06-21
Changed in linux-ti-omap4 (Ubuntu):
assignee: nobody → Ming Lei (tom-leiming)
importance: Undecided → Medium
status: New → Triaged
Ming Lei (tom-leiming) wrote :

attach another lockdep warning in yama_ptracer_del path.

Ming Lei (tom-leiming) wrote :

The attachment patch does fix the warning, yama_ptracer_del can be called in softirq context, also
can be run in common process context, so use spin_lock_bh to fix it.

Kees Cook (kees) wrote :

Thanks for catching this! Is this perhaps a problem at a higher level? (I.e. should security_task_free be called in a different way so that its hooks (like yama_ptracer_del) do not need to use the _bh locking mechanisms?

Ming Lei (tom-leiming) wrote :

Now security_task_free is called from __put_task_struct in ubuntu kernel, and __put_task_struct c
can surely be called in softirq context. In upstream, there are no security_task_free at all.

If not calling security_task_free, where is it called from? Seems depending on security implementation,
also more difficult fix will be involved than *_bh fix.

Any way, using spin_[un]lock_bh is a easy fix, and no obvious performance degrade is introduced.

I don't know security well, so let your guys decide how to fix this, :-)

thanks,

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 3.0.0-4.5

---------------
linux (3.0.0-4.5) oneiric; urgency=low

  [ Ming Lei ]

  * SAUCE: fix yama_ptracer_del lockdep warning
    - LP: #791019

  [ Seth Forshee ]

  * SAUCE: (drop after 3.0) asus-wmi: Add callback for hotkey filtering
  * SAUCE: (drop after 3.0) eeepc-wmi: Add support for T101MT Home/Express Gate key
  * SAUCE: (drop after 3.0) asus-wmi: Enable autorepeat for hotkey input device
  * [Config] CONFIG_{ASUS,ASUS_NB,EEEPC}_WMI=m
    - LP: #805218

  [ Tim Gardner ]

  * [Config] updateconfigs after rebase to -rc6+
    Rebased against 4dd1b49c6d215dc41ce50c80b4868388b93f31a3
  * Adopt a 3 digit verion, e.g., 3.0.0-x.x
  * Revert "UBUNTU: add dependancies for module-init-tools"
    This dependency is no longer required for a 3 digit version.
 -- Tim Gardner <email address hidden> Tue, 05 Jul 2011 14:03:04 +0100

Changed in linux (Ubuntu Oneiric):
status: New → Fix Released
Herton R. Krzesinski (herton) wrote :

This bug misses SRU justification, please update this bug with it as explained on
https://wiki.ubuntu.com/KernelTeam/StableHandbook/StableProcess#Workflow_for_SRU_Patches

Also, this bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-natty' to 'verification-done-natty'.

If verification is not done by one week from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-natty
Tim Gardner (timg-tpi) wrote :

SRU Justification

Impact: yama_ptracer_del can be called in softirq context causing lockdep warnings

Patch Description: Use spin_lock_bh/spin_unlock_bh to protect list manipulation against soft IRQ contexts.

Ming Lei (tom-leiming) wrote :

In fact, I have done SRU Justification before submitting the patch into <email address hidden>.

see
         https://lists.ubuntu.com/archives/kernel-team/2011-June/016037.html

I am sure the patch did not affect normal function and only fixed the lockdep warning, and Tim
already Acked it.

thanks,

Ming Lei (tom-leiming) wrote :

SRU Justification against Ubuntu-2.6.38-11.47:

- does fix the lockdep warning
- normal function is good, and can boot well into natty

see attachment dmesg

tags: added: erification-done-natty
removed: verification-needed-natty
tags: added: verification-done-natty
removed: erification-done-natty
Launchpad Janitor (janitor) wrote :
Download full text (13.4 KiB)

This bug was fixed in the package linux - 2.6.38-11.48

---------------
linux (2.6.38-11.48) natty-proposed; urgency=low

  [Herton R. Krzesinski]

  * Release Tracking Bug
    - LP: #818175

  [ Upstream Kernel Changes ]

  * Revert "HID: magicmouse: ignore 'ivalid report id' while switching
    modes"
    - LP: #814250

linux (2.6.38-11.47) natty-proposed; urgency=low

  [Steve Conklin]

  * Release Tracking Bug
    - LP: #811180

  [ Keng-Yu Lin ]

  * SAUCE: Revert: "dell-laptop: Toggle the unsupported hardware
    killswitch"
    - LP: #775281

  [ Ming Lei ]

  * SAUCE: fix yama_ptracer_del lockdep warning
    - LP: #791019

  [ Stefan Bader ]

  * SAUCE: Re-enable RODATA for i386 virtual
    - LP: #809838

  [ Tim Gardner ]

  * [Config] Add grub-efi as a recommended bootloader for server and
    generic
    - LP: #800910
  * SAUCE: rtl8192se: Force a build for a 2.6/3.0 kernel
    - LP: #805494

  [ Upstream Kernel Changes ]

  * Revert "bridge: Forward reserved group addresses if !STP"
    - LP: #793702
  * Fix up ABI directory
  * bonding: Incorrect TX queue offset, CVE-2011-1581
    - LP: #792312
    - CVE-2011-1581
  * fs/partitions/efi.c: corrupted GUID partition tables can cause kernel
    oops
    - LP: #795418
    - CVE-2011-1577
  * usbnet/cdc_ncm: add missing .reset_resume hook
    - LP: #793892
  * ath5k: Disable fast channel switching by default
    - LP: #767192
  * mm: vmscan: correctly check if reclaimer should schedule during
    shrink_slab
    - LP: #755066
  * mm: vmscan: correct use of pgdat_balanced in sleeping_prematurely
    - LP: #755066
  * ALSA: hda - Use LPIB for ATI/AMD chipsets as default
    - LP: #741825
  * ALSA: hda - Enable snoop bit for AMD controllers
    - LP: #741825
  * ALSA: hda - Enable sync_write workaround for AMD generically
    - LP: #741825
  * cpuidle: menu: fixed wrapping timers at 4.294 seconds
    - LP: #774947
  * drm/i915: Fix gen6 (SNB) missed BLT ring interrupts.
    - LP: #761065
  * USB: ehci: remove structure packing from ehci_def
    - LP: #791552
  * drm/i915: disable PCH ports if needed when disabling a CRTC
    - LP: #791752
  * kmemleak: Do not return a pointer to an object that kmemleak did not
    get
    - LP: #793702
  * kmemleak: Initialise kmemleak after debug_objects_mem_init()
    - LP: #793702
  * Fix _OSC UUID in pcc-cpufreq
    - LP: #793702
  * CPU hotplug, re-create sysfs directory and symlinks
    - LP: #793702
  * Fix memory leak in cpufreq_stat
    - LP: #793702
  * net: recvmmsg: Strip MSG_WAITFORONE when calling recvmsg
    - LP: #793702
  * ftrace: Only update the function code on write to filter files
    - LP: #793702
  * qla2xxx: Fix hang during driver unload when vport is active.
    - LP: #793702
  * qla2xxx: Fix virtual port failing to login after chip reset.
    - LP: #793702
  * qla2xxx: Fix vport delete hang when logins are outstanding.
    - LP: #793702
  * powerpc/kdump64: Don't reference freed memory as pacas
    - LP: #793702
  * powerpc/kexec: Fix memory corruption from unallocated slaves
    - LP: #793702
  * x86, cpufeature: Fix cpuid leaf 7 feature detection
    - LP: #793702
  * ath9k_hw: do noise floor calibration only on required chain...

Changed in linux (Ubuntu Natty):
status: New → Fix Released
Ming Lei (tom-leiming) on 2011-08-31
Changed in linux-ti-omap4 (Ubuntu Oneiric):
status: Triaged → Fix Committed
Paolo Pisati (p-pisati) on 2012-01-30
Changed in linux-ti-omap4 (Ubuntu Natty):
status: New → Fix Released
Changed in linux-ti-omap4 (Ubuntu Oneiric):
status: Fix Committed → Fix Released
Changed in linux-ti-omap4 (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers