T61 is not in the whitelist for hdaps

Bug #147383 reported by Darren Albers on 2007-09-30
18
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Undecided
Unassigned
linux-source-2.6.22 (Ubuntu)
Medium
Unassigned

Bug Description

Binary package hint: linux-source-2.6.22

The T61 is not listed in the whitelist to load hdaps:

From /hdaps.c:
/* Note that HDAPS_DMI_MATCH_NORMAL("ThinkPad T42") would match
   "ThinkPad T42p", so the order of the entries matters.
   If your ThinkPad is not recognized, please update to latest
   BIOS. This is especially the case for some R52 ThinkPads. */
static struct dmi_system_id __initdata hdaps_whitelist[] = {
 HDAPS_DMI_MATCH_INVERT("IBM", "ThinkPad R50p"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R50"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R51"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R52"),
 HDAPS_DMI_MATCH_INVERT("IBM", "ThinkPad T41p"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T41"),
 HDAPS_DMI_MATCH_INVERT("IBM", "ThinkPad T42p"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T42"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T43"),
 HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad T60"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad X40"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad X41"),
 HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad X60"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad Z60m"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T61P"),
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad R61"),
 { .ident = NULL }
};

All that should be required is to add:
 HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T61"),

Thanks!

CVE References

Brian Murray (brian-murray) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. While I don't think it is absolutely necessary it might be helpful if you could also include the full output of 'sudo dmidecode'. Thanks in advance.

Changed in linux-source-2.6.22:
assignee: nobody → ubuntu-kernel-team
importance: Undecided → Medium
status: New → Incomplete
status: Incomplete → Triaged
Chuck Short (zulcss) wrote :

Ive added this to my git tree thanks.

Changed in linux-source-2.6.22:
status: Triaged → In Progress
Darren Albers (dalbers) wrote :

Thanks Chuck!

Just in case I am including the output of dmidecode.

On a side note I think I may have been wrong and per the comment in the code:
"Note that HDAPS_DMI_MATCH_NORMAL("ThinkPad T42") would match
   "ThinkPad T42p", "

So all that probably needs to be done is remove the p from:
HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T61P"),

And it will match the T61 and T61P

Tim Gardner (timg-tpi) wrote :

Gutsy commit 9d8732904c06a233b1baa83879d7d5274c1bb00d

Changed in linux-source-2.6.22:
assignee: ubuntu-kernel-team → timg-tpi
status: In Progress → Fix Committed
Kyle McMartin (kyle) wrote :
Download full text (5.9 KiB)

linux-source-2.6.22 (2.6.22-13.40) gutsy; urgency=low

  [Amit Kucheria]

  * Enable CONFIG_VM86 for LPIA
    - LP: #146311
  * Update configuration files
  * Disable MSI by default
  * Add mmconf documentation
  * Update configuration files

  [Bartlomiej Zolnierkiewicz]

  * ide-disk: workaround for buggy HPA support on ST340823A (take 3)
    - LP: #26119

  [Ben Collins]

  * ubuntu/cell: Fixup ps3 related modules for d-i, enable RTAS console
  * ubuntu/cell: Enable CELLEB and related modules (pata_scc)
  * ubuntu/cell: Move ps3rom to storage-core. Also use spidernet, not
    spider_net.
  * ubuntu/cell: Set PS3_MANAGER=y
  * ubuntu: Set NR_CPUS=256 for sparc64-smp

  [Chuck Short]

  * [USB] USB] Support for MediaTek MT6227 in cdc-acm.
    - LP: #134123
  * [XEN] Fix xen vif create with more than 14 guests.
    - LP: #14486

  [Jorge Juan Chico]

  * ide: ST320413A has the same problem as ST340823A
    - LP: #26119

  [Kyle McMartin]

  * fix -rt build
  * fix ia32entry-xen.S for CVE-2007-4573
  * fix build when CONFIG_PCI_MSI is not set

  [Matthew Garrett]

  * hostap: send events on data interface as well as master interface
    - LP: #57146
  * A malformed _GTF object should not prevent ATA device recovery
    - LP: #139079
  * hostap: send events on data interface as well as master interface
    - LP: #57146
  * A malformed _GTF object should not prevent ATA device recovery
    - LP: #139079
  * Don't lose appletouch button release events
  * Fix build with appletouch change
  * Disable Thinkpad backlight support on machines with ACPI video
    - LP: #148055
  * Don't attempt to register a callback if there is no CMOS object
    - LP: #145857
  * Update ACPI bay hotswap code to support locking
    - LP: #148219
  * Update ACPI bay hotswap code to support locking
    - LP: #148219
  * Don't attempt to register a callback if there is no CMOS object
    - LP: #145857
  * Disable Thinkpad backlight support on machines with ACPI video
    - LP: #148055

  [Steffen Klassert]

  * 3c59x: fix duplex configuration
    - LP: #94186

  [Thomas Gleixner]

  * clockevents: remove the suspend/resume workaround^Wthinko

  [Tim Gardner]

  * orinoco_cs.ko missing
    - LP: #125832
  * Marvell Technology ethernet card not recognized and not operational
    - LP: #135316
  * Marvell Technology ethernet card not recognized and not operational
    - LP: #135316
  * acpi_scan_rsdp() breaks some PCs by not honouring ACPI specification
    - LP: #144336
  * VIA southbridge Intel id missing
    - LP: #128289
  * Add T-Sinus 111card to hostap_cs driver to be able to upload firmware
    - LP: #132466
  * RTL8111 PCI Express Gigabit driver r8169 big files produce slow file
    transfer
    - LP: #114171
  * Guest OS does not recognize a lun with non zero target id on Vmware ESX
    Server
    - LP: #140761
  * Modualrize vesafb
    - LP: #139505
  * Nikon cameras need support in unusual_devs.h
    - LP: #134477
  * agp for i830m broken in gutsy
    - LP: #139767
  * hdaps: Added support for Thinkpad T61
    - LP: #147383
  * xen: Update config for i386
    - LP: #139047
  * xen: resync for amd64
    - LP: #139047
  * ide-disk: workaround for buggy HPA support ...

Read more...

Changed in linux-source-2.6.22:
status: Fix Committed → Fix Released
Tim Gardner (timg-tpi) on 2007-10-05
Changed in linux-source-2.6.22:
assignee: timg-tpi → nobody
Darren Albers (dalbers) wrote :

I mistakenly put the wrong dmi string for all T61's, some use LENOVO, some Thinkpad.

Changed in linux-source-2.6.22:
status: Fix Released → Incomplete
Darren Albers (dalbers) wrote :

Chuck I think I made a mistake, the module still doesn't load on my system and when I look at my dmidecode I think the vendor is Lenovo and not IBM anymore. Also the axis readings need to be inversed so it should be:
HDAPS_DMI_MATCH_INVERT("LENOVO", "ThinkPad T61"),

Though what is odd is that my work T61 says IBM in the dmidecode... Maybe different manufacturing locations or Bios revisions?

Is it possible to update hdaps.c before release?

Thanks!

ignoto (crocefabiopa) wrote :

HDAPS_DMI_MATCH_NORMAL("IBM", "ThinkPad T61"),

actually the right one should be:

HDAPS_DMI_MATCH_NORMAL("Lenovo", "ThinkPad T61"),

however it still doesn't work on my thinkpad T61

that's the dmesg output:
[ 19.660000] hdaps: inverting axis readings.
[ 19.660000] hdaps: LENOVO ThinkPad T61 detected.
[ 19.660000] input: hdaps as /class/input/input4
[ 19.660000] hdaps: driver successfully loaded.

but that's the "/etc/init.d/hdaps start" output
* Not starting hdapsd: /sys/block/sda/queue/protect does not exist

I actually didn't recompile the whole kernel but just the modified module hdaps.c

Brian Murray (brian-murray) wrote :

Has anybody tested this on the development release of Ubuntu - Hardy Heron? You can learn more about the development release at http://www.ubuntu.com/testing. Thanks in advance.

Changed in linux:
status: New → Incomplete
ignoto (crocefabiopa) wrote :

I'm downloading the alpha4 release to test hdaps, thanks for the information

Noel J. Bergman (noeljb) wrote :

See: https://bugs.launchpad.net/bugs/139881

Basically, hdapsd requires a kernel patch, and Ubuntu is unwilling to support it.

The Ubuntu Kernel Team is planning to move to the 2.6.27 kernel for the upcoming Intrepid Ibex 8.10 release. As a result, the kernel team would appreciate it if you could please test this newer 2.6.27 Ubuntu kernel. There are one of two ways you should be able to test:

1) If you are comfortable installing packages on your own, the linux-image-2.6.27-* package is currently available for you to install and test.

--or--

2) The upcoming Alpha5 for Intrepid Ibex 8.10 will contain this newer 2.6.27 Ubuntu kernel. Alpha5 is set to be released Thursday Sept 4. Please watch http://www.ubuntu.com/testing for Alpha5 to be announced. You should then be able to test via a LiveCD.

Please let us know immediately if this newer 2.6.27 kernel resolves the bug reported here or if the issue remains. More importantly, please open a new bug report for each new bug/regression introduced by the 2.6.27 kernel and tag the bug report with 'linux-2.6.27'. Also, please specifically note if the issue does or does not appear in the 2.6.26 kernel. Thanks again, we really appreicate your help and feedback.

Alvin (alvind) wrote :

I can confirm that hdaps loads with kernel 2.6.27-7 (Intrepid Ibex 8.10 beta)

from dmesg:
hdaps: inverting axis readings.
hdaps: LENOVO ThinkPad T61p detected.
Input: hdaps as /devices/platform/hdaps/input/input13
hdaps: driver successfully loaded.

Thanks for the note. Marking this "Fix Released" for Intrepid. Against 2.6.22 this will be closed. Thanks.

Changed in linux:
status: Incomplete → Fix Released
Changed in linux-source-2.6.22:
milestone: ubuntu-7.10-rc → none
status: Incomplete → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments