Ubuntu

Remote control support for ASUS MyCinema P7131 in saa7134 module

Reported by Данило Шеган on 2007-09-21
6
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Medium
Canonical Ubuntu QA Team
linux-source-2.6.22 (Ubuntu)
Undecided
Unassigned

Bug Description

Binary package hint: linux-source-2.6.22

The TV tuner card identified as "Multimedia controller: Philips Semiconductors SAA7133/SAA7135 Video Broadcast Decoder (rev d1)" with PCI IDs 0480: 1131:7133 (rev d1) has the same GPIO IR chip as the other ASUS MyCinema TV tuner cards, so it's a simple thing of setting the appropriate remote type in saa7134-cards.c and doing the same processing in saa7134-input.c.

saa7134 recognised the card as ASUS TV-FM 7135:
[ 3709.500556] saa7130/34: v4l2 driver version 0.2.14 loaded
[ 3709.503659] saa7133[0]: found at 0000:04:01.0, rev: 209, irq: 21, latency: 32, mmio: 0xf3105000
[ 3709.503666] saa7133[0]: subsystem: 1043:4845, board: ASUS TV-FM 7135 [card=53,autodetected]
[ 3709.503675] saa7133[0]: board init: gpio is 40000
[ 3709.506654] input: saa7134 IR (ASUS TV-FM 7135) as /class/input/input6
[ 3709.686332] tuner 0-004b: chip found @ 0x96 (saa7133[0])
[ 3709.734244] tuner 0-004b: setting tuner address to 61
[ 3709.774175] tuner 0-004b: type set to tda8290+75a
[ 3711.139803] tuner 0-004b: setting tuner address to 61
[ 3711.179732] tuner 0-004b: type set to tda8290+75a

The following simple patch makes the card fully auto-detected:

--- linux-source-2.6.22/drivers/media/video/saa7134/saa7134-cards.c~ 2007-09-21 19:42:22.000000000 +0200
+++ linux-source-2.6.22/drivers/media/video/saa7134/saa7134-cards.c 2007-09-21 19:51:12.000000000 +0200
@@ -4330,6 +4330,7 @@
        case SAA7134_BOARD_AVERMEDIA_A16AR:
        case SAA7134_BOARD_ENCORE_ENLTV:
        case SAA7134_BOARD_ENCORE_ENLTV_FM:
+ case SAA7134_BOARD_ASUSTeK_TVFM7135:
                dev->has_remote = SAA7134_REMOTE_GPIO;
                break;
        case SAA7134_BOARD_FLYDVBS_LR300:

--- linux-source-2.6.22/drivers/media/video/saa7134/saa7134-input.c~ 2007-09-21 19:35:18.000000000 +0200
+++ linux-source-2.6.22/drivers/media/video/saa7134/saa7134-input.c 2007-09-21 19:36:15.000000000 +0200
@@ -323,5 +323,6 @@
        case SAA7134_BOARD_ASUSTeK_P7131_DUAL:
        case SAA7134_BOARD_ASUSTeK_P7131_HYBRID_LNA:
+ case SAA7134_BOARD_ASUSTeK_TVFM7135:
                ir_codes = ir_codes_asus_pc39;
                mask_keydown = 0x0040000;
                rc5_gpio = 1;

Also available on http://kvota.net/hacks/tv-tuner/asus-mycinema-p7131.patch

Chuck Short (zulcss) wrote :

Fixed in my git tree.

Damjan (damjand) wrote :

Hi,

I have this card and it works great under FC7 except for the remote control. Since I don't have the time and know-how to recompile the entire kernel, can anyone please send me the compiled module with this patch?
Or maybe tell me if I can recompile only this module...
I'm running 2.6.22.9-91

Thanks.

Looks like this never got merged. Reassigning to kernel team.

Changed in linux:
assignee: nobody → ubuntu-kernel-team
importance: Undecided → Medium
status: New → Triaged

This report is remaining open against the actively developed kernel. However, against linux-source-2.6.22 this bug does not meet the criteria for a stable release update and is being marked as Won't Fix. You can learn more about the stable release update process at https://wiki.ubuntu.com/StableReleaseUpdates . Thanks!

Changed in linux-source-2.6.22:
status: New → Won't Fix
Tim Gardner (timg-tpi) wrote :

This driver appears to have active upstream support. The 2.6.22 patch does not apply, so how about refactoring the patch and provide some evidence that it will be accepted upstream?

Changed in linux:
status: Triaged → Confirmed
Changed in linux:
status: Confirmed → Incomplete
assignee: ubuntu-kernel-team → canonical-qa

This bug is being closed until we receive further evidence that the patch has been submitted upstream. Please reopen this report when this has been done. To reopen the bug report you can click on the current status, under the Status column, and change the Status back to "New". Thanks!

Changed in linux:
status: Incomplete → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers