[patch] agp for i830m broken in gutsy, works in feisty

Bug #139767 reported by laga on 2007-09-15
4
Affects Status Importance Assigned to Milestone
linux-source-2.6.20 (Ubuntu)
High
Unassigned
linux-source-2.6.22 (Ubuntu)
Medium
Unassigned

Bug Description

Binary package hint: linux-source-2.6.22

Hi,

intel_agp.ko is broken in feisty for me on a i830m box. I reported this problem in greater detail at the LKML and Dave Airlie was kind enough to provide a patch.

Please see http://lkml.org/lkml/2007/9/12/114

CVE References

laga (laga) wrote :

Hello,

this problem is now affecting feisty as well. I believe it was introduced in version 2.6.20-16.31 or linux-source-2.6.20 in this change:

> * Add AGP support for Intel G33 video. Add 3D/mesa support for Intel G33
> video.
> - GIT-SHA 6331663c669b38521a31b04d4f58f9a888b19d2c
> - Bug #121443

Since I know of at least one person besides me who is affected by this bug in feisty and gutsy on the same hardware, I'll set this to "confirmed" and raise the importance to "medium".

Regards,

Michael

p.s.: I'm sorry, I just have to ask: is it common practice to add support for new hardware after a distribution was released? Also, why is hardware support added in kernel releases which are pushed to "feisty-security" instead of, say, the backports or updates repository?

Changed in linux-source-2.6.20:
status: New → Confirmed
Changed in linux-source-2.6.22:
status: New → Confirmed
laga (laga) wrote :

Oops, sorry. In the first message, i meant to say it is broken on gutsy. Subsequently, it was broken in feisty in 2.6.20-16.31.

laga (laga) wrote :

I was asked to attach the patch to this ticket. Here we go:

diff --git a/drivers/char/agp/agp.h b/drivers/char/agp/agp.h
index 35ab1a9..8955e7f 100644
--- a/drivers/char/agp/agp.h
+++ b/drivers/char/agp/agp.h
@@ -176,7 +176,7 @@ struct agp_bridge_data {
 #define I830_GMCH_MEM_MASK 0x1
 #define I830_GMCH_MEM_64M 0x1
 #define I830_GMCH_MEM_128M 0
-#define I830_GMCH_GMS_MASK 0xF0
+#define I830_GMCH_GMS_MASK 0x70
 #define I830_GMCH_GMS_DISABLED 0x00
 #define I830_GMCH_GMS_LOCAL 0x10
 #define I830_GMCH_GMS_STOLEN_512 0x20
@@ -190,6 +190,7 @@ struct agp_bridge_data {
 #define INTEL_I830_ERRSTS 0x92

 /* Intel 855GM/852GM registers */
+#define I855_GMCH_GMS_MASK 0xF0
 #define I855_GMCH_GMS_STOLEN_0M 0x0
 #define I855_GMCH_GMS_STOLEN_1M (0x1 << 4)
 #define I855_GMCH_GMS_STOLEN_4M (0x2 << 4)
diff --git a/drivers/char/agp/intel-agp.c b/drivers/char/agp/intel-agp.c
index 2c9ca2c..c15f5d2 100644
--- a/drivers/char/agp/intel-agp.c
+++ b/drivers/char/agp/intel-agp.c
@@ -506,7 +506,7 @@ static void intel_i830_init_gtt_entries(void)
    break;
   }
  } else {
- switch (gmch_ctrl & I830_GMCH_GMS_MASK) {
+ switch (gmch_ctrl & I855_GMCH_GMS_MASK) {
   case I855_GMCH_GMS_STOLEN_1M:
    gtt_entries = MB(1) - KB(size);
    break;
--
1.5.2.5

Download URL: http://lkml.org/lkml/diff/2007/9/12/138/1

You can also pull this patch from kernel.org git, it was introduced before 2.6.23rc7 in e67aa27a6179c287983c6c525beb5320f5cd1672 - see http://www.kernel.org/pub/linux/kernel/v2.6/testing/ChangeLog-2.6.23-rc7

Tim Gardner (timg-tpi) wrote :

Gutsy commit d05017ef5f9dabd13f0bba3df74b9d8832d7e40f

Changed in linux-source-2.6.22:
assignee: nobody → timg-tpi
importance: Undecided → Medium
status: Confirmed → Fix Committed
Kyle McMartin (kyle) wrote :
Download full text (5.9 KiB)

linux-source-2.6.22 (2.6.22-13.40) gutsy; urgency=low

  [Amit Kucheria]

  * Enable CONFIG_VM86 for LPIA
    - LP: #146311
  * Update configuration files
  * Disable MSI by default
  * Add mmconf documentation
  * Update configuration files

  [Bartlomiej Zolnierkiewicz]

  * ide-disk: workaround for buggy HPA support on ST340823A (take 3)
    - LP: #26119

  [Ben Collins]

  * ubuntu/cell: Fixup ps3 related modules for d-i, enable RTAS console
  * ubuntu/cell: Enable CELLEB and related modules (pata_scc)
  * ubuntu/cell: Move ps3rom to storage-core. Also use spidernet, not
    spider_net.
  * ubuntu/cell: Set PS3_MANAGER=y
  * ubuntu: Set NR_CPUS=256 for sparc64-smp

  [Chuck Short]

  * [USB] USB] Support for MediaTek MT6227 in cdc-acm.
    - LP: #134123
  * [XEN] Fix xen vif create with more than 14 guests.
    - LP: #14486

  [Jorge Juan Chico]

  * ide: ST320413A has the same problem as ST340823A
    - LP: #26119

  [Kyle McMartin]

  * fix -rt build
  * fix ia32entry-xen.S for CVE-2007-4573
  * fix build when CONFIG_PCI_MSI is not set

  [Matthew Garrett]

  * hostap: send events on data interface as well as master interface
    - LP: #57146
  * A malformed _GTF object should not prevent ATA device recovery
    - LP: #139079
  * hostap: send events on data interface as well as master interface
    - LP: #57146
  * A malformed _GTF object should not prevent ATA device recovery
    - LP: #139079
  * Don't lose appletouch button release events
  * Fix build with appletouch change
  * Disable Thinkpad backlight support on machines with ACPI video
    - LP: #148055
  * Don't attempt to register a callback if there is no CMOS object
    - LP: #145857
  * Update ACPI bay hotswap code to support locking
    - LP: #148219
  * Update ACPI bay hotswap code to support locking
    - LP: #148219
  * Don't attempt to register a callback if there is no CMOS object
    - LP: #145857
  * Disable Thinkpad backlight support on machines with ACPI video
    - LP: #148055

  [Steffen Klassert]

  * 3c59x: fix duplex configuration
    - LP: #94186

  [Thomas Gleixner]

  * clockevents: remove the suspend/resume workaround^Wthinko

  [Tim Gardner]

  * orinoco_cs.ko missing
    - LP: #125832
  * Marvell Technology ethernet card not recognized and not operational
    - LP: #135316
  * Marvell Technology ethernet card not recognized and not operational
    - LP: #135316
  * acpi_scan_rsdp() breaks some PCs by not honouring ACPI specification
    - LP: #144336
  * VIA southbridge Intel id missing
    - LP: #128289
  * Add T-Sinus 111card to hostap_cs driver to be able to upload firmware
    - LP: #132466
  * RTL8111 PCI Express Gigabit driver r8169 big files produce slow file
    transfer
    - LP: #114171
  * Guest OS does not recognize a lun with non zero target id on Vmware ESX
    Server
    - LP: #140761
  * Modualrize vesafb
    - LP: #139505
  * Nikon cameras need support in unusual_devs.h
    - LP: #134477
  * agp for i830m broken in gutsy
    - LP: #139767
  * hdaps: Added support for Thinkpad T61
    - LP: #147383
  * xen: Update config for i386
    - LP: #139047
  * xen: resync for amd64
    - LP: #139047
  * ide-disk: workaround for buggy HPA support ...

Read more...

Changed in linux-source-2.6.22:
status: Fix Committed → Fix Released
Tim Gardner (timg-tpi) on 2007-10-05
Changed in linux-source-2.6.22:
assignee: timg-tpi → nobody
Changed in linux-source-2.6.20:
assignee: nobody → ubuntu-kernel-team
importance: Undecided → High
status: Confirmed → Triaged

closing 2.6.20 task as this does not qualify for a stable release update. Thanks.

Changed in linux-source-2.6.20:
status: Triaged → Won't Fix

Per a decision made by the Ubuntu Kernel Team, bugs will longer be assigned to the ubuntu-kernel-team in Launchpad as part of the bug triage process. The ubuntu-kernel-team is being unassigned from this bug report. Refer to https://wiki.ubuntu.com/KernelTeamBugPolicies for more information. Thanks.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers