Regression issue with external-global-acpi_update.dpatch - detecting C2/C3 states for systems without CST

Bug #19156 reported by ooops
6
Affects Status Importance Assigned to Milestone
linux-source-2.6.15 (Ubuntu)
Medium
Fabio Massimo Di Nitto

Bug Description

The respective acpi-update has a regression issue with detecting C2/C3 states
for systems without CST. Either pull in an updated version from the ACPI-tree or
apply the patch below. With the current dpatch C2/C3 states stop working on some
laptops. Actually, pulling in patches and not even given the status or time of
the pull in the patch (see DP-lines) is a quite risky approach. Ubuntu-breezy
should not be a regression-repository for acpi-patches, IMHO.

===========================
From: Jindrich Makovicka
<email address hidden>

Re-enable C2/C3 states for systems without CST. Fixes a regression after
the patch for C2/C3 support for multiprocessors
(http://bugme.osdl.org/show_bug.cgi?id=4401), which accidentally removed
the acpi_processor_power_verify() call.

Signed-off-by: Jindrich Makovicka
<email address hidden>
Cc: "Brown, Len" <email address hidden>
Signed-off-by: Andrew Morton <email address hidden>
---

 drivers/acpi/processor_idle.c | 2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN
drivers/acpi/processor_idle.c~acpi-re-enable-c2-c3-cpu-states-for-systems-without
drivers/acpi/processor_idle.c
---
devel/drivers/acpi/processor_idle.c~acpi-re-enable-c2-c3-cpu-states-for-systems-without
2005-07-14 15:53:47.000000000 -0700
+++ devel-akpm/drivers/acpi/processor_idle.c 2005-07-14 15:53:47.000000000 -0700
@@ -881,7 +881,7 @@ static int acpi_processor_get_power_info
  result = acpi_processor_get_power_info_cst(pr);
  if ((result) || (acpi_processor_power_verify(pr) < 2)) {
   result = acpi_processor_get_power_info_fadt(pr);
- if (result)
+ if ((result) || acpi_processor_power_verify(pr) < 2)
    result = acpi_processor_get_power_info_default_c1(pr);
  }

_

Revision history for this message
Fabio Massimo Di Nitto (fabbione) wrote :

(In reply to comment #0)
> The respective acpi-update has a regression issue with detecting C2/C3 states
> for systems without CST. Either pull in an updated version from the ACPI-tree or
> apply the patch below. With the current dpatch C2/C3 states stop working on some
> laptops.

Matthew what do you prefer? this patch or to give me new acpi crack?

>Actually, pulling in patches and not even given the status or time of
> the pull in the patch (see DP-lines) is a quite risky approach. Ubuntu-breezy
> should not be a regression-repository for acpi-patches, IMHO.
>

DP lines are at maintainer discrection. Matthew is our acpi guru and he keeps
track of what is what and when. Also breezy is a development branch. Breakage
and regression are expected and we are ready to fix them. Thanks for your
report and work.

Fabio

Revision history for this message
Matthew Garrett (mjg59) wrote :

The patch is the correct one - I've had it queued for you, but hadn't got round
to sending it yet.

Revision history for this message
Fabio Massimo Di Nitto (fabbione) wrote :

Fixed in 2.6.12-5.5 upload.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.