| 2019-10-15 09:25:23 |
Juerg Haefliger |
description |
Compiling Bionic 4.15 linux-raspi2 yields:
In file included from ./include/linux/kernel.h:14:0,
from ./include/linux/delay.h:22,
from drivers/mmc/host/bcm2835-sdhost.c:35:
drivers/mmc/host/bcm2835-sdhost.c: In function 'log_init':
./include/linux/kern_levels.h:5:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
./include/linux/printk.h:309:9: note: in definition of macro 'pr_printk_hash'
printk(level pr_fmt(format), ##__VA_ARGS__)
^~~~~
./include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
./include/linux/printk.h:333:17: note: in expansion of macro 'KERN_INFO'
pr_printk_hash(KERN_INFO, fmt, ##__VA_ARGS__)
^~~~~~~~~
drivers/mmc/host/bcm2835-sdhost.c:249:3: note: in expansion of macro 'pr_info'
pr_info("sdhost: log_buf @ %p (%x)\n",
^~~~~~~
drivers/mmc/host/bcm2835-sdhost.c:249:35: note: format string is defined here
pr_info("sdhost: log_buf @ %p (%x)\n",
~^
%llx
drivers/mmc/host/bcm2835-sdhost.c: In function 'bcm2835_sdhost_dma_complete':
drivers/mmc/host/bcm2835-sdhost.c:530:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
log_event("DMA<", (u32)host->data, bcm2835_sdhost_read(host, SDHSTS));
^
[SNIP] |
[Impact]
Compiling Bionic 4.15 linux-raspi2 yields:
In file included from ./include/linux/kernel.h:14:0,
from ./include/linux/delay.h:22,
from drivers/mmc/host/bcm2835-sdhost.c:35:
drivers/mmc/host/bcm2835-sdhost.c: In function 'log_init':
./include/linux/kern_levels.h:5:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
./include/linux/printk.h:309:9: note: in definition of macro 'pr_printk_hash'
printk(level pr_fmt(format), ##__VA_ARGS__)
^~~~~
./include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
#define KERN_INFO KERN_SOH "6" /* informational */
^~~~~~~~
./include/linux/printk.h:333:17: note: in expansion of macro 'KERN_INFO'
pr_printk_hash(KERN_INFO, fmt, ##__VA_ARGS__)
^~~~~~~~~
drivers/mmc/host/bcm2835-sdhost.c:249:3: note: in expansion of macro 'pr_info'
pr_info("sdhost: log_buf @ %p (%x)\n",
^~~~~~~
drivers/mmc/host/bcm2835-sdhost.c:249:35: note: format string is defined here
pr_info("sdhost: log_buf @ %p (%x)\n",
~^
%llx
drivers/mmc/host/bcm2835-sdhost.c: In function 'bcm2835_sdhost_dma_complete':
drivers/mmc/host/bcm2835-sdhost.c:530:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
log_event("DMA<", (u32)host->data, bcm2835_sdhost_read(host, SDHSTS));
^
[SNIP]
[Test Case]
Compile Bionic raspi2 kernel.
[Fix]
Backport commit 328c7a754fde ("mmc: bcm2835-sdhost: Fix warnings on arm64") from raspberry/linux rpi-4.19.y.
[Regression Potential]
Low. Trivial modifications isolated to bcm2835-sdhost. |
|
