The sof-pci-dev and snd-soc-skl all contains the same pciid, if
the soc-skl is loaded ahead of sof-pci-dev, the sof driver will
not work anymore, in the oem project, we manually put the soc-skl
in the blacklist.
From kernel-5.4 (focal kernel), the driver soc-skl is disabled by
default, and there is no users report any issues on it. So let us
disable soc-skl in the eoan and osp1 kernel too.
The patch for eoan kernel doesn't remove the modules because looks
like the abi folder are not controlled by git. This will break the
modulecheck, so if this patch could be merged, please help remove
those modules:
snd-soc-skl
snd-soc-skl-ipc
snd-soc-skl-ssp-clk
[Impact]
If soc-skl driver is loaded ahead of sof driver, the sof could
not work anymore, we need to blacklist the soc-skl manually
[Fix]
Like the focal kernel, we disable the soc_skl driver in the kernel
config
[Test Case]
Tested on Lenovo and Dell machines which has dmic, the sof driver
could be loaded successfully.
Tested on the machinces without the dmic, the legacy hda driver
worked well as before.
[Regression Risk]
Low, Focal kernel and mainine-5.5, 5.6-rc kernel all disabled this
dirver; and We have not met a machine need the soc_skl driver yet;
and Intel claim that the sof could replace the soc_skl driver.
In the -41 kernel, we introduced a patch from stable kernel, that
make the sof driver crash, and there is a fix patch in the 5.6-rc1,
and this fix patch is already in the stable and is merged to focal
kernel, now we backport this patch to Eoan kernel if -42 doesn't
introduce this fix patch from stable.
The patch introduced the crash:
commit 063821115e02229d5fd3de31bad270d5e30aeb41
Author: Dragos Tarcatu <email address hidden>
Date: Mon Dec 9 18:39:38 2019 -0600
ASoC: topology: Check return value for snd_soc_add_dai_link()
BugLink: https://bugs.launchpad.net/bugs/1861929
[ Upstream commit 76d2703649321c296df7ec0dafd50add96215de4 ]
snd_soc_add_dai_link() might fail. This situation occurs for
instance in a very specific use case where a PCM device and a
Back End DAI link are given identical names in the topology.
When this happens, soc_new_pcm_runtime() fails and then
snd_soc_add_dai_link() returns -ENOMEM when called from
soc_tplg_fe_link_create(). Because of that, the link will not
get added into the card list, so any attempt to remove it later
ends up in a panic.
Fix that by checking the return status and free the memory in case
of an error.
Reviewed-by: Ranjani Sridharan <email address hidden>
Signed-off-by: Dragos Tarcatu <email address hidden>
Signed-off-by: Pierre-Louis Bossart <email address hidden>
Link: https://<email address hidden>
Signed-off-by: Mark Brown <email address hidden>
Signed-off-by: Sasha Levin <email address hidden>
Signed-off-by: Kamal Mostafa <email address hidden>
Signed-off-by: Khalid Elmously <email address hidden>
[Impact]
During the boot, the sof driver crash because the hdmi_pcm_list
is not initialized before it is used.
[Fix]
This bug is fixed in the mainline kernel v5.6-rc1, now backport
this patch to ubuntu kernel
[Test Case]
Boot the -41 kernel with this patch added.
blacklist the snd_soc_skl
the kernel can boot successfully, and sof driver worked well
[Regression Risk]
Low, the patches are backported from upstream kernel, and I tested
this patch on Lenovo and Dell dmic machines. Focal kernel already
has this patch and works well.
Probably a kernel bug.
The sound card isn't detected in 5.3.0-41-generic
Booting 5.3.0-40-generic does work.
The relevant dmesg message is:
[ 9.845441] skl_hda_dsp_generic skl_hda_dsp_generic: Unsupported HDAudio/iDisp configuration found
[ 9.845447] skl_hda_dsp_generic: probe of skl_hda_dsp_generic failed with error -22
ProblemType: Bug
DistroRelease: Ubuntu 19.10
Package: alsa-base 1.0.25+dfsg-0ubuntu5
ProcVersionSignature: Ubuntu 5.3.0-41.33-generic 5.3.18
Uname: Linux 5.3.0-41-generic x86_64
ApportVersion: 2.20.11-0ubuntu8.4
Architecture: amd64
AudioDevicesInUse: Error: command ['fuser', '-v', '/dev/snd/seq', '/dev/snd/timer'] failed with exit code 1:
CurrentDesktop: ubuntu:GNOME
Date: Thu Feb 20 16:46:21 2020
InstallationDate: Installed on 2019-10-07 (136 days ago)
InstallationMedia: Ubuntu 19.04 "Disco Dingo" - Release amd64 (20190416)
PackageArchitecture: all
SourcePackage: alsa-driver
Symptom: audio
Title: PCI/internal sound card not detected
UpgradeStatus: Upgraded to eoan on 2019-11-19 (93 days ago)
dmi.bios.date: 01/15/2020
dmi.bios.vendor: LENOVO
dmi.bios.version: N2HET44W (1.27 )
dmi.board.asset.tag: Not Available
dmi.board.name: 20QDCTO1WW
dmi.board.vendor: LENOVO
dmi.board.version: SDK0J40697 WIN
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: None
dmi.modalias: dmi:bvnLENOVO:bvrN2HET44W(1.27):bd01/15/2020:svnLENOVO:pn20QDCTO1WW:pvrThinkPadX1Carbon7th:rvnLENOVO:rn20QDCTO1WW:rvrSDK0J40697WIN:cvnLENOVO:ct10:cvrNone:
dmi.product.family: ThinkPad X1 Carbon 7th
dmi.product.name: 20QDCTO1WW
dmi.product.sku: LENOVO_MT_20QD_BU_Think_FM_ThinkPad X1 Carbon 7th
dmi.product.version: ThinkPad X1 Carbon 7th
dmi.sys.vendor: LENOVO
It seems there were some fixes in the new kernel for the intel sound system.
Including some for the Lenovo X1 carbon 7th gen.
https:/