enable realtek ethernet device ASPM function

Bug #1836030 reported by AceLan Kao
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
HWE Next
Undecided
Unassigned
linux (Ubuntu)
Undecided
Unassigned
Focal
Undecided
Unassigned
linux-oem-osp1 (Ubuntu)
Undecided
Unassigned
Bionic
Undecided
AceLan Kao

Bug Description

============= SRU for 5.4 Focal kernel ===============
[Impact]
The PC state stays at PC3 if r8169 driver doesn't enable ASPM.

[Fix]
Applied same series of patches from v5.5-rc1 and disable ASPM L1.1 only, instead of disable ASPM completely.

[Test]
Verified on machines with realtek Ethernet device, the Ethernet works well after S3 test 30 times and the system can enter PC10.

[Regression Potential]
Low, from realtek engineer, r8169 driver supports ASPM L0s and L1, and we only disable ASPM L1.1 which is pretty safe and should be disabled by default.

================== SRU for 5.0 OEM OSP1 kernel =========================
[Impact]
The PC state stays at PC3 if realtek ethernet doesn't enable ASPM.

[Fix]
Discussed with upstream and they would like to use sysfs to toggle the ASPM link states, but the patches didn't get merged yet, so we merger them as SAUCE patches.

[Test]
Verified on machines with realtek ethernet device, the ethernet works well and the system can enter PC10.

[Regression Potential]
High. From upstream maintainer, enable realtek ethernet ASPM may lead to some serious issue, so regression is expected. Those regression should come from old realtek chips, we'll make sure all new platforms with realtek NIC have no any issues.

CVE References

AceLan Kao (acelankao)
Changed in linux-oem-osp1 (Ubuntu Bionic):
assignee: nobody → AceLan Kao (acelankao)
status: New → In Progress
Changed in linux-oem-osp1 (Ubuntu):
status: New → Invalid
AceLan Kao (acelankao)
tags: added: oem-priority originate-from-1833681 somerville
Revision history for this message
AceLan Kao (acelankao) wrote :

This patchset has been included in linux-oem-osp1: 5.0.0-1014.15

Changed in linux-oem-osp1 (Ubuntu Bionic):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-oem-osp1 - 5.0.0-1015.16

---------------
linux-oem-osp1 (5.0.0-1015.16) bionic; urgency=medium

  * linux-oem-osp1: 5.0.0-1015.16 -proposed tracker (LP: #1836856)

  * System does not auto detect disconnection of external monitor (LP: #1835001)
    - drm/i915: Add support for retrying hotplug
    - drm/i915: Enable hotplug retry

  * alsa/hdmi: add icelake hdmi audio support for a Dell machine (LP: #1836916)
    - ALSA: hda: hdmi - add Icelake support
    - ALSA: hda/hdmi - Remove duplicated define
    - ALSA: hda/hdmi - Fix i915 reverse port/pin mapping

  * input/mouse: alps trackpoint-only device doesn't work (LP: #1836752)
    - Input: alps - don't handle ALPS cs19 trackpoint-only device

  * First click on Goodix touchpad doesn't be recognized after runtime suspended
    (LP: #1836836)
    - SAUCE: i2c: designware: add G3 3590 into i2c quirk

 -- Timo Aaltonen <email address hidden> Thu, 18 Jul 2019 11:29:53 +0300

Changed in linux-oem-osp1 (Ubuntu Bionic):
status: Fix Committed → Fix Released
Changed in linux-oem-osp1 (Ubuntu):
status: Invalid → Fix Released
Changed in hwe-next:
status: New → Fix Released
AceLan Kao (acelankao)
no longer affects: linux (Ubuntu Bionic)
no longer affects: linux-oem-osp1 (Ubuntu Focal)
Changed in linux (Ubuntu Focal):
status: New → In Progress
AceLan Kao (acelankao)
description: updated
description: updated
description: updated
Seth Forshee (sforshee)
Changed in linux (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 5.4.0-21.25

---------------
linux (5.4.0-21.25) focal; urgency=medium

  * CVE-2020-8835
    - SAUCE: bpf: undo incorrect __reg_bound_offset32 handling

 -- Thadeu Lima de Souza Cascardo <email address hidden> Thu, 26 Mar 2020 17:51:28 -0300

Changed in linux (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Jeremy Soller (jackpot51) wrote :
Revision history for this message
1111 (zimuge) wrote :

I also believe this change has caused https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1874464/
ASPM must be disabled completely to avoid network malfunction issue.Even ubuntu 21.04 with kernel 5.11 sees this issue.Any one from Ubuntu is seeing this bug.
pls change the following code:
from rc = pci_disable_link_state(pdev, PCIE_LINK_STATE_L1_1);
to rc = pci_disable_link_state(pdev, PCIE_LINK_STATE_L0S |
                                          PCIE_LINK_STATE_L1);

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers