test_350_retpolined_modules from ubuntu_qrt_kernel_security failed on F-OEM-5.6

[Po-Hsu Lin]

  ======================================================================
  FAIL: test_350_retpolined_modules (__main__.KernelSecurityTest)
  Test to ensure all modules are built with retpoline on x86
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "./test-kernel-security.py", line 2094, in test_350_retpolined_modules
      raise self.failureException('Module %s not compiled with retpoline:\n%s' % (module, error_output))
  AssertionError: Module /lib/modules/5.6.0-1010-oem/kernel/drivers/regulator/da903x.ko not compiled with retpoline:
  Command: 'modinfo', '-k', '5.6.0-1010-oem', '/lib/modules/5.6.0-1010-oem/kernel/drivers/regulator/da903x.ko'
  Output:
  filename: /lib/modules/5.6.0-1010-oem/kernel/drivers/regulator/da903x.ko
  license: GPL v2
  file: drivers/mfd/da903x
  author: Mike Rapoport <email address hidden>
  author: Eric Miao <email address hidden>
  description: PMIC Driver for Dialog Semiconductor DA9034

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: linux-image-5.6.0-1010-oem 5.6.0-1010.10
ProcVersionSignature: User Name 5.6.0-1010.10-oem 5.6.8
Uname: Linux 5.6.0-1010-oem x86_64
ApportVersion: 2.20.11-0ubuntu27
Architecture: amd64
CasperMD5CheckResult: skip
Date: Mon May 18 14:48:02 2020
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=C.UTF-8
 SHELL=/bin/bash
SourcePackage: linux-signed-oem-5.6
UpgradeStatus: No upgrade log present (probably fresh install)

[Steve Beattie (sbeattie)]

Hi, this looks like a legit issue with the linux-oem-5.6 da903x-regulator module, which appears to have been addressed in f16861b12fa0 ("regulator: rename da903x to da903x-regulator") (v5.8-rc6), which points out that kmod gets confused before that commit.

You can verify this with e.g.:

  $ modinfo -k 5.6.0-1055-oem /lib/modules/5.6.0-1055-oem/kernel/drivers/regulator/da903x.ko
  filename: /lib/modules/5.6.0-1055-oem/kernel/drivers/regulator/da903x.ko
  license: GPL v2
  file: drivers/mfd/da903x
  author: Mike Rapoport <email address hidden>
  author: Eric Miao <email address hidden>
  description: PMIC Driver for Dialog Semiconductor DA9034

versus the da903x backlight driver:

  $ modinfo -k 5.6.0-1055-oem /lib/modules/5.6.0-1055-oem/kernel/drivers/video/backlight/da903x_bl.ko
  filename: /lib/modules/5.6.0-1055-oem/kernel/drivers/video/backlight/da903x_bl.ko
  alias: platform:da903x-backlight
  license: GPL
  author: Mike Rapoport <email address hidden>
  author: Eric Miao <email address hidden>
  description: Backlight Driver for Dialog Semiconductor DA9030/DA9034
  srcversion: 5FEF8A3329A530B5C1874A5
  depends:
  retpoline: Y
  intree: Y
  name: da903x_bl
  vermagic: 5.6.0-1055-oem SMP mod_unload modversions
  sig_id: PKCS#7
  signer: Build time autogenerated kernel key
  sig_key: 5B:09:65:9C:C7:55:2E:3D:11:79:28:EA:EE:F1:AD:DB:18:F9:34:F7
  sig_hashalgo: sha512
  signature: 8E:0D:4A:F9:F1:F8:D3:AC:84:0F:D0:77:91:AA:62:1B:C0:65:81:AE:
                  39:19:77:92:9A:99:E2:6A:A5:3A:C1:30:71:2A:89:AB:AD:24:95:06:
                  F5:7D:AD:3D:A2:E6:25:66:8C:E1:44:07:37:39:0F:9F:B4:50:E1:6B:
                  6A:8E:2C:1E:57:A8:76:65:88:46:12:B4:30:A1:3C:B7:96:17:1E:D7:
                  C1:9A:C7:8A:48:05:0A:BF:3E:E3:D6:1B:14:50:EE:E2:FC:00:10:AE:
                  18:7E:04:72:22:A0:61:31:9A:F2:8A:F5:0B:5C:87:F1:E3:63:58:6B:
                  CE:AF:57:6B:EA:B7:E2:ED:17:17:E6:40:C7:92:0B:05:22:E6:06:3B:
                  3B:C5:14:5F:A8:46:C3:20:A6:CB:B6:B9:9D:C9:39:A0:A1:34:90:3F:
                  5B:1A:D2:EC:C4:C5:F5:84:DF:2F:16:B2:E1:92:C0:C0:A1:5F:1B:A6:
                  45:69:6A:4D:16:85:9A:44:2C:13:58:5F:47:33:F3:4D:A6:E0:77:A2:
                  2B:DA:76:C5:5C:17:6C:47:6A:E9:C8:A4:00:DB:F7:AA:27:5E:87:A3:
                  63:BC:1B:C9:75:99:AC:5F:B1:77:18:21:6E:90:D6:70:D8:E9:8E:EE:
                  59:68:44:73:CC:6E:30:FF:9D:A8:41:E2:32:1E:F7:8B:E6:97:F6:3F:
                  D4:70:69:AA:02:9E:AA:C6:D6:5A:F2:64:9F:DA:E5:7F:41:2B:E5:D4:
                  24:DD:20:72:4E:42:F4:5A:D4:73:46:12:61:66:99:0B:D7:35:47:2B:
                  73:A2:9A:1E:4D:18:49:8D:AB:18:82:D7:A3:6C:4E:95:A4:98:7F:88:
                  9E:22:74:F6:20:46:50:E1:E1:32:12:3C:32:C9:89:85:FB:F1:DC:C0:
                  F1:C7:EB:45:89:E9:B5:A0:89:C3:0B:FD:FE:2D:07:28:14:AD:E9:1E:
                  C1:5D:35:79:B0:53:0D:31:15:CB:74:F6:7F:E4:FE:BF:01:D4:35:34:
                  4C:28:86:0A:8D:66:F5:7C:39:D3:7D:FC:69:B4:CD:6D:3A:84:8D:45:
                  87:77:64:C4:A5:AD:7A:11:7C:EF:B8:EC:97:E5:EC:F4:F2:99:3D:54:...