rtw89 kernel module for Realtek 8852 wifi is missing

[Francois Thirioux]

== SRU Justification ==
[Impact]
Realtek 8852AE, which is used by many new laptops, doesn't have a
driver.

[Fix]
Add rtw89 driver to support Realtek 8852AE.

[Test]
After applying the patch, 8852AE can scan, connect and do TX/RX.

[Where problems could occur]
This is a brand new driver, unless the driver hits some subtle PCI or
IOMMU bugs, there isn't much chance to introduce any regression.

== Original Bug Report ==
Hi,

Resulting: no wifi adapter detected.
Currently WIP: https://patchwork.kernel.org/project/linux-wireless/list/?series=534633&state=*

Workaround: use https://github.com/lwfinger/rtw89
that allows to build a dkms deb package.

Ubuntu Impish
kernel 5.13 (or 5.15 from unstable ppa)
---
ProblemType: Bug
ApportVersion: 2.20.11-0ubuntu69
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC1: fthx 4574 F.... pulseaudio
 /dev/snd/controlC2: fthx 4574 F.... pulseaudio
 /dev/snd/controlC0: fthx 4574 F.... pulseaudio
CasperMD5CheckResult: pass
CurrentDesktop: GNOME
DistroRelease: Ubuntu 21.10
InstallationDate: Installed on 2021-09-15 (20 days ago)
InstallationMedia: Ubuntu 21.10 "Impish Indri" - Alpha amd64 (20210910)
MachineType: LENOVO 21A0000VFR
Package: linux (not installed)
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=fr_FR.UTF-8
 SHELL=/bin/bash
ProcFB: 0 amdgpu
ProcKernelCmdLine: BOOT_IMAGE=/vmlinuz-5.15.0-4-generic root=/dev/mapper/vgubuntu-root ro quiet splash vt.handoff=7
ProcVersionSignature: Ubuntu 5.15.0-4.4-generic 5.15.0-rc4
RebootRequiredPkgs: Error: path contained symlinks.
RelatedPackageVersions:
 linux-restricted-modules-5.15.0-4-generic N/A
 linux-backports-modules-5.15.0-4-generic N/A
 linux-firmware 1.201
Tags: wayland-session impish
Uname: Linux 5.15.0-4-generic x86_64
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin lxd plugdev sambashare sudo
_MarkForUpload: True
dmi.bios.date: 06/21/2021
dmi.bios.release: 1.9
dmi.bios.vendor: LENOVO
dmi.bios.version: R1MET39W (1.09 )
dmi.board.asset.tag: Not Available
dmi.board.name: 21A0000VFR
dmi.board.vendor: LENOVO
dmi.board.version: Not Defined
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: None
dmi.ec.firmware.release: 1.9
dmi.modalias: dmi:bvnLENOVO:bvrR1MET39W(1.09):bd06/21/2021:br1.9:efr1.9:svnLENOVO:pn21A0000VFR:pvrThinkPadP14sGen2a:rvnLENOVO:rn21A0000VFR:rvrNotDefined:cvnLENOVO:ct10:cvrNone:skuLENOVO_MT_21A0_BU_Think_FM_ThinkPadP14sGen2a:
dmi.product.family: ThinkPad P14s Gen 2a
dmi.product.name: 21A0000VFR
dmi.product.sku: LENOVO_MT_21A0_BU_Think_FM_ThinkPad P14s Gen 2a
dmi.product.version: ThinkPad P14s Gen 2a
dmi.sys.vendor: LENOVO

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1945967

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

apport information

[Francois Thirioux (fthx)]

Seems the module has been accepted now?
https://patchwork.kernel<email address hidden>/

[Kai-Heng Feng (kaihengfeng)]

Yep, I am working on the backport.

[Francois Thirioux (fthx)]

G.R.E.A.T.

Is it not too late to be ready for the Impish release?
:-))

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the linux-oem-5.14/5.14.0-1006.6 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-oem-5.13 - 5.13.0-1019.23

---------------
linux-oem-5.13 (5.13.0-1019.23) focal; urgency=medium

  * focal/linux-oem-5.13: 5.13.0-1019.23 -proposed tracker (LP: #1949076)

  * Fail to detect audio output from external monitor (LP: #1948767)
    - ALSA: hda: intel: Allow repeatedly probing on codec configuration errors

  * Intel I225-IT ethernet controller: igc: probe of 0000:02:00.0 failed with
    error -1 (LP: #1945576)
    - igc: Remove _I_PHY_ID checking
    - igc: Remove phy->type checking

  * Fix Screen freeze after resume from suspend with iGPU [1002:6987]
    (LP: #1949050)
    - drm/amdgpu: reenable BACO support for 699F:C7 polaris12 SKU
    - drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend
    - drm/amdgpu: Fix crash on device remove/driver unload

  * Need support of Qualcomm WCN6856 (LP: #1939528)
    - Revert "UBUNTU: SAUCE: Bluetooth: btusb: Add support using different nvm for
      variant WCN6855 controller"
    - Revert "UBUNTU: SAUCE: cfg80211: save power spectral density(psd) of
      regulatory rule"
    - Revert "UBUNTU: SAUCE: cfg80211: add definition for 6 GHz power spectral
      density(psd)"
    - Revert "UBUNTU: SAUCE: ath11k: set correct NL80211_FEATURE_DYNAMIC_SMPS for
      WCN6855"
    - Revert "mac80211: save transmit power envelope element and power constraint"
    - Revert "mac80211: add parse regulatory info in 6 GHz operation information"
    - Revert "ieee80211: add power type definition for 6 GHz"
    - Revert "mac80211: use ieee802_11_parse_elems() in ieee80211_prep_channel()"
    - Revert "mac80211: always allocate struct ieee802_11_elems"
    - Revert "mac80211: mlme: find auth challenge directly"
    - Revert "mac80211: move CRC into struct ieee802_11_elems"
    - Revert "mac80211: mesh: clean up rx_bcn_presp API"
    - Revert "ath11k: support SMPS configuration for 6 GHz"
    - Revert "ath11k: add 6 GHz params in peer assoc command"
    - Revert "ieee80211: Add new A-MPDU factor macro for HE 6 GHz peer caps"
    - Revert "ath11k: copy cap info of 6G band under WMI_HOST_WLAN_5G_CAP for
      WCN6855"
    - Revert "ath11k: enable 6G channels for WCN6855"
    - Revert "ath11k: re-enable ht_cap/vht_cap for 5G band for WCN6855"
    - Revert "ath11k: fix survey dump collection in 6 GHz"
    - Revert "ath11k: fix packet drops due to incorrect 6 GHz freq value in rx
      status"
    - Revert "ath11k: add channel 2 into 6 GHz channel list"
    - Revert "ath11k: qmi: avoid error messages when dma allocation fails"
    - Revert "mac80211: parse transmit power envelope element"
    - Revert "ieee80211: add definition for transmit power envelope element"
    - Revert "ieee80211: add definition of regulatory info in 6 GHz operation
      information"
    - Revert "mac80211: notify driver on mgd TX completion"
    - Revert "ath11k: don't call ath11k_pci_set_l1ss for WCN6855"
    - Revert "ath11k: add support for WCN6855"
    - Revert "ath11k: add support to get peer id for WCN6855"
    - Revert "ath11k: setup WBM_IDLE_LINK ring once again"
    - Revert "ath11k: setup REO for WCN6855"
    - Revert "ath11k: add dp support for WCN6855"
    - Revert "ath11k:...

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-oem-5.14 - 5.14.0-1007.7

---------------
linux-oem-5.14 (5.14.0-1007.7) focal; urgency=medium

  * focal/linux-oem-5.14: 5.14.0-1007.7 -proposed tracker (LP: #1949349)

  * Intel I225-IT ethernet controller: igc: probe of 0000:02:00.0 failed with
    error -1 (LP: #1945576)
    - igc: Remove _I_PHY_ID checking
    - igc: Remove phy->type checking

  * Fix Screen freeze after resume from suspend with iGPU [1002:6987]
    (LP: #1949050)
    - drm/amdgpu: reenable BACO support for 699F:C7 polaris12 SKU
    - drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend
    - drm/amdgpu: Fix crash on device remove/driver unload

  * Fail to detect audio output from external monitor (LP: #1948767)
    - ALSA: hda: intel: Allow repeatedly probing on codec configuration errors

  * Fix System hangs on black screen when reboot (LP: #1949321)
    - SAUCE: drm/i915: Don't request GMBUS to generate irqs when called while irqs
      are off
    - SAUCE: drm/i915/hdmi: Turn DP++ TMDS output buffers back on in
      encoder->shutdown()

 -- Timo Aaltonen <email address hidden> Mon, 01 Nov 2021 12:38:15 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-oem-5.10 - 5.10.0-1051.53

---------------
linux-oem-5.10 (5.10.0-1051.53) focal; urgency=medium

  * focal/linux-oem-5.10: 5.10.0-1051.53 -proposed tracker (LP: #1947263)

  * Intel I225-IT ethernet controller: igc: probe of 0000:02:00.0 failed with
    error -1 (LP: #1945576)
    - igc: Remove _I_PHY_ID checking
    - igc: Remove phy->type checking

  * rtw89 kernel module for Realtek 8852 wifi is missing (LP: #1945967)
    - rtw89: add Realtek 802.11ax driver
    - rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
    - rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
    - rtw89: remove unneeded semicolon
    - [Config] RTW89=m

  * Focal update: 5.10.76 upstream stable release (LP: #1949019)
    - parisc: math-emu: Fix fall-through warnings
    - xhci: add quirk for host controllers that don't update endpoint DCS
    - io_uring: fix splice_fd_in checks backport typo
    - arm: dts: vexpress-v2p-ca9: Fix the SMB unit-address
    - ARM: dts: at91: sama5d2_som1_ek: disable ISC node by default
    - block: decode QUEUE_FLAG_HCTX_ACTIVE in debugfs output
    - xen/x86: prevent PVH type from getting clobbered
    - drm/amdgpu/display: fix dependencies for DRM_AMD_DC_SI
    - xtensa: xtfpga: use CONFIG_USE_OF instead of CONFIG_OF
    - xtensa: xtfpga: Try software restart before simulating CPU reset
    - NFSD: Keep existing listeners on portlist error
    - netfilter: xt_IDLETIMER: fix panic that occurs when timer_type has garbage
      value
    - dma-debug: fix sg checks in debug_dma_map_sg()
    - ASoC: wm8960: Fix clock configuration on slave mode
    - ice: fix getting UDP tunnel entry
    - netfilter: ip6t_rt: fix rt0_hdr parsing in rt_mt6
    - netfilter: ipvs: make global sysctl readonly in non-init netns
    - lan78xx: select CRC32
    - tcp: md5: Fix overlap between vrf and non-vrf keys
    - ipv6: When forwarding count rx stats on the orig netdev
    - net: dsa: lantiq_gswip: fix register definition
    - NIOS2: irqflags: rename a redefined register name
    - powerpc/smp: do not decrement idle task preempt count in CPU offline
    - net: hns3: reset DWRR of unused tc to zero
    - net: hns3: add limit ets dwrr bandwidth cannot be 0
    - net: hns3: schedule the polling again when allocation fails
    - net: hns3: fix vf reset workqueue cannot exit
    - net: hns3: disable sriov before unload hclge layer
    - net: stmmac: Fix E2E delay mechanism
    - ice: Add missing E810 device ids
    - drm/panel: ilitek-ili9881c: Fix sync for Feixin K101-IM2BYL02 panel
    - net: enetc: fix ethtool counter name for PM0_TERR
    - can: rcar_can: fix suspend/resume
    - can: peak_usb: pcan_usb_fd_decode_status(): fix back to ERROR_ACTIVE state
      notification
    - can: peak_pci: peak_pci_remove(): fix UAF
    - can: isotp: isotp_sendmsg(): fix return error on FC timeout on TX path
    - can: isotp: isotp_sendmsg(): add result check for wait_event_interruptible()
    - can: j1939: j1939_tp_rxtimer(): fix errant alert in j1939_tp_rxtimer
    - can: j1939: j1939_netdev_start(): fix UAF for rx_kref of j1939_priv
    - can: j1939: j1939_xtp_rx_dat_one(): cancel session i...

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the linux/5.13.0-22.22 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-impish' to 'verification-done-impish'. If the problem still exists, change the tag 'verification-needed-impish' to 'verification-failed-impish'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Régis Desgroppes (rdesgroppes)]

@kaihengfeng
I just switched to linux-oem-20.04d (5.14.0.1007.7) and, wow, it works like a charm. The Wi-Fi 6 throughput is impressive.
Thanks a bunch!
Régis

[Pirouette Cacahuète (lissyx)]

Just enabled impish-proposed, applied upgrades, and 5.13.0-22 is there, rtw89 working well. No more requirement for extra dkms out-of-tree, that's quite cool.

[Matthew (matthewhorizon)]

Ubuntu 21.10 with kernel 5.15.3-051503-generic is affected too.

[Francois Thirioux (fthx)]

For further needs-testing ;-) , latest proposed Jammy's 5.15 kernel solved this issue too.

[Pirouette Cacahuète (lissyx)]

For what it is worth, at some point, using https://github.com/lwfinger/rtw89 branch's v7 was making my laptop crashing, only symptom was me going away and coming back the laptop is rebooted. It was happening after ~24-48h of uptime, regularly enough for it to be painful.

I think my latest build was with https://github.com/lwfinger/rtw89/commit/a3f3f39908872fe9edc887d857836d9cb4cb598c and this was much rather stable.

@kaihengfeng Can we hope you cherry pick all the new fixes coming on v7 branch?

Without stability, I'll have to blacklist the kernel-bundled driver and go back to the dkms one self-built :/

Thanks!

[Pirouette Cacahuète (lissyx)]

Specifically, https://github.com/lwfinger/rtw89/commit/14be64e6e0f6541efee8aaaaa39f3f115b5e0343 mention system crash :)

[Francois Thirioux (fthx)]

FYI I did experience such hard reboots (very annoying, for sure!) with lwfinger dkms driver, but never (never) since some time and especially since Ubuntu did include rtw89 in 5.15 kernel.
Maybe I'm lucky, or that's solved.

[Pirouette Cacahuète (lissyx)]

I'm on the 5.13.0-22, maybe the 5.15 has a few different commits ?

[Matthew (matthewhorizon)]

Kernel 5.16 on Ubuntu 21.10 have this driver!

https://sypalo.com/how-to-upgrade-ubuntu

Worked for me on Lenovo Legion 5.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.13.0-22.22

---------------
linux (5.13.0-22.22) impish; urgency=medium

  * impish/linux: 5.13.0-22.22 -proposed tracker (LP: #1949740)

  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/2021.11.08)

  * ebpf: bpf_redirect fails with ip6 gre interfaces (LP: #1947164)
    - net: handle ARPHRD_IP6GRE in dev_is_mac_header_xmit()

  * require CAP_NET_ADMIN to attach N_HCI ldisc (LP: #1949516)
    - Bluetooth: hci_ldisc: require CAP_NET_ADMIN to attach N_HCI ldisc

  * CVE-2021-3744 // CVE-2021-3764
    - crypto: ccp - fix resource leaks in ccp_run_aes_gcm_cmd()

  * ppc64 BPF JIT mod by 1 will not return 0 (LP: #1948351)
    - powerpc/bpf: Fix BPF_MOD when imm == 1

  * Fix Screen freeze after resume from suspend with iGPU [1002:6987]
    (LP: #1949050)
    - drm/amdgpu: reenable BACO support for 699F:C7 polaris12 SKU
    - drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend
    - drm/amdgpu: Fix crash on device remove/driver unload

  * Intel I225-IT ethernet controller: igc: probe of 0000:02:00.0 failed with
    error -1 (LP: #1945576)
    - igc: Remove _I_PHY_ID checking
    - igc: Remove phy->type checking

  * Fail to detect audio output from external monitor (LP: #1948767)
    - ALSA: hda: intel: Allow repeatedly probing on codec configuration errors

  * Drop "UBUNTU: SAUCE: cachefiles: Page leaking in
    cachefiles_read_backing_file while vmscan is active" (LP: #1947709)
    - Revert "UBUNTU: SAUCE: cachefiles: Page leaking in
      cachefiles_read_backing_file while vmscan is active"

  * rtw89 kernel module for Realtek 8852 wifi is missing (LP: #1945967)
    - rtw89: add Realtek 802.11ax driver
    - rtw89: Remove redundant check of ret after call to rtw89_mac_enable_bb_rf
    - rtw89: fix return value check in rtw89_cam_send_sec_key_cmd()
    - rtw89: remove unneeded semicolon
    - [Config] RTW89=m

  * Impish update: upstream stable patchset 2021-11-03 (LP: #1949636)
    - mm: fix uninitialized use in overcommit_policy_handler
    - usb: gadget: r8a66597: fix a loop in set_feature()
    - usb: dwc2: gadget: Fix ISOC flow for BDMA and Slave
    - usb: dwc2: gadget: Fix ISOC transfer complete handling for DDMA
    - usb: musb: tusb6010: uninitialized data in tusb_fifo_write_unaligned()
    - cifs: fix incorrect check for null pointer in header_assemble
    - xen/x86: fix PV trap handling on secondary processors
    - usb-storage: Add quirk for ScanLogic SL11R-IDE older than 2.6c
    - USB: serial: cp210x: add ID for GW Instek GDM-834x Digital Multimeter
    - USB: cdc-acm: fix minor-number release
    - Revert "USB: bcma: Add a check for devm_gpiod_get"
    - binder: make sure fd closes complete
    - staging: greybus: uart: fix tty use after free
    - Re-enable UAS for LaCie Rugged USB3-FW with fk quirk
    - usb: dwc3: core: balance phy init and exit
    - usb: core: hcd: Add support for deferring roothub registration
    - USB: serial: mos7840: remove duplicated 0xac24 device ID
    - USB: serial: option: add Telit LN920 compositions
    - USB: serial: option: remove duplicate USB device ID
    - USB: serial: option: add d...

[Pirouette Cacahuète (lissyx)]

I have had no instance of a crash such as reported earlier since november 19, so I can't really be sure of the status, but it might not be as bad as I was worrying.

[Pirouette Cacahuète (lissyx)]

FTR, I've had a few hiccups related to the driver filed in https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1954439 and https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1954438

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.15.0-17.17

---------------
linux (5.15.0-17.17) jammy; urgency=medium

  * jammy/linux: 5.15.0-17.17 -proposed tracker (LP: #1957809)

 -- Andrea Righi <email address hidden> Thu, 13 Jan 2022 17:11:21 +0100

[Brian Murray (brian-murray)]

Ubuntu 21.10 (Impish Indri) has reached end of life, so this bug will not be fixed for that specific release.