PCIE LnkCtl ASPM not enabled under VMD mode for Alder Lake platforms

[You-Sheng Yang]

[SRU Justification]

[Impact]

VMD PCI-E bridges on ADL-M/P/S use new device IDs and therefore not
covered by previous LTR reset fix in bug 1896598.

[Fix]

Additional entires to vmd_bridge_tbl in drivers/pci/quirks.c is
requierd:
* ADL-M: [8086:464d]
* ADL-P: [8086:51b0]
* ADL-S: [8086:7ab4]

[Test Case]

$ sudo lspci -vvn | grep -E '^(1|\s+LnkCtl:)'
...
10000:e0:1d.4 0604: 8086:7ab4 (rev 10) (prog-if 00 [Normal decode])
                LnkCtl: ASPM L1 Enabled; RCB 64 bytes Disabled- CommClk+
10000:e1:00.0 0108: 8086:0975 (rev 03) (prog-if 02 [NVM Express])
                LnkCtl: ASPM L1 Enabled; RCB 64 bytes Disabled- CommClk+

[Where problems could occur]

This will reset zeroed PCI_LTR_MAX_SNOOP_LAT and PCI_LTR_MAX_NOSNOOP_LAT
values to a fixed 3145728ns that is used on Windows. Devices might want
to set itself to a smaller value, but while this is not yet correctly
supported by VMD controller driver, so the device power consumption
might be little worse than ideal.

[Other Info]

VMD ASPM was first supported for Tiger Lake cpus, so all kernel versions
newer than 5.6 should have already the supporting function. This patch
targets Alder Lake cpus that are supported since 5.10-oem and on.

========== original bug report ==========

* ADL-M:

$ sudo lspci -vvn | grep -E '^(1|\s+LnkCtl:)'
10000:e0:06.0 PCI bridge [0604]: Intel Corporation Device [8086:464d] (rev 05)
        Kernel driver in use: pcieport
10000:e1:00.0 Non-Volatile memory controller [0108]: Intel Corporation Device [8086:f1aa] (rev 03)
        Subsystem: Intel Corporation Device [8086:390f]
        Kernel driver in use: nvme
        Kernel modules: nvme

* ADL-P:

$ sudo lspci -vvn | grep -E '^(1|\s+LnkCtl:)'
10000:e0:1d.0 0604: 8086:51b0 (prog-if 00 [Normal decode])
                LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- CommClk+
10000:e1:00.0 0108: 8086:f1a8 (rev 03) (prog-if 02 [NVM Express])
                LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- CommClk+

* ADL-S:

$ sudo lspci -vvn | grep -E '^(1|\s+LnkCtl:)'
10000:e0:1d.4 0604: 8086:7ab4 (rev 10) (prog-if 00 [Normal decode])
                LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- CommClk+
10000:e1:00.0 0108: 8086:0975 (rev 03) (prog-if 02 [NVM Express])
                LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- CommClk+

See https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1889384, https://bugs.launchpad.net/bugs/1896598.
---
ProblemType: Bug
ApportVersion: 2.20.11-0ubuntu27.18
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: gdm 1100 F.... pulseaudio
CasperMD5CheckResult: skip
Dependencies:

DistroRelease: Ubuntu 20.04
InstallationDate: Installed on 2021-04-06 (146 days ago)
InstallationMedia: Ubuntu 20.04.2 LTS "Focal Fossa" - Release amd64 (20210204)
Lsusb:
 Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
 Bus 001 Device 003: ID 8087:0032 Intel Corp.
 Bus 001 Device 002: ID 062a:4c01 MosArt Semiconductor Corp. 2.4G INPUT DEVICE
 Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
MachineType: Intel Corporation Alder Lake Client Platform
Package: linux-firmware 1.187.16+staging.11 [origin: unknown]
PackageArchitecture: all
ProcFB: 0 i915drmfb
ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-5.13.0-9010-oem root=UUID=e38f9e97-de55-4524-ba5b-a0ae4d5ea8a7 ro i915.force_probe=4680 quiet splash vt.handoff=7
ProcVersionSignature: Ubuntu 5.13.0-9010.11+staging.9-oem 5.13.1
PulseList: Error: command ['pacmd', 'list'] failed with exit code 1: No PulseAudio daemon running, or not running as session daemon.
RelatedPackageVersions:
 linux-restricted-modules-5.13.0-9010-oem N/A
 linux-backports-modules-5.13.0-9010-oem N/A
 linux-firmware 1.187.16+staging.11
Tags: focal third-party-packages
Uname: Linux 5.13.0-9010-oem x86_64
UnreportableReason: This is not an official Ubuntu package. Please remove any third party package and try again.
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: N/A
_MarkForUpload: True
dmi.bios.date: 04/26/2021
dmi.bios.vendor: Intel Corporation
dmi.bios.version: ADLSFWI1.R00.2181.A00.2104261003
dmi.board.asset.tag: Base Board Asset Tag
dmi.board.name: AlderLake-S ADP-S DDR5 UDIMM CRB
dmi.board.vendor: Intel Corporation
dmi.board.version: 2
dmi.chassis.asset.tag: Chassis Asset Tag
dmi.chassis.type: 3
dmi.chassis.vendor: Intel Corporation
dmi.chassis.version: 0.1
dmi.ec.firmware.release: 1.36
dmi.modalias: dmi:bvnIntelCorporation:bvrADLSFWI1.R00.2181.A00.2104261003:bd04/26/2021:efr1.36:svnIntelCorporation:pnAlderLakeClientPlatform:pvr0.1:sku00001004002B0100:rvnIntelCorporation:rnAlderLake-SADP-SDDR5UDIMMCRB:rvr2:cvnIntelCorporation:ct3:cvr0.1:
dmi.product.family: Alder Lake Client System
dmi.product.name: Alder Lake Client Platform
dmi.product.sku: 00001004002B0100
dmi.product.version: 0.1
dmi.sys.vendor: Intel Corporation

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This change was made by a bot.

[You-Sheng Yang (vicamo)]

PPA: https://launchpad.net/~vicamo/+archive/ubuntu/linux-staging version 5.13.0-9011.14+staging.15 and 5.14.0-9001.1+staging.15

[You-Sheng Yang (vicamo)]

SRU: https://lists.ubuntu.com/archives/kernel-team/2021-August/123683.html (oem-5.10, oem-5,13, oem-5.14, h, i, u)

[You-Sheng Yang (vicamo)]

Missing [8086:7ac8]:

$ sudo lspci -vvn | grep -E '^(1|\s+LnkCtl:)'
10000:e0:1a.0 PCI bridge [0604]: Intel Corporation Device [8086:7ac8] (rev 11)
        Kernel driver in use: pcieport
10000:e1:00.0 Non-Volatile memory controller [0108]: KIOXIA Corporation Device [1e0f:0001]
        Subsystem: KIOXIA Corporation Device [1e0f:0001]
        Kernel driver in use: nvme
        Kernel modules: nvme

[You-Sheng Yang (vicamo)]

Update by review comments.

[Timo Aaltonen (tjaalton)]

oem-5.10 doesn't need this, ADL is enabled with 5.13 (S) and 5.14 (M/P)

[You-Sheng Yang (vicamo)]

SRU v3: https://lists.ubuntu.com/archives/kernel-team/2021-September/124077.html (oem-5.13, oem-5.14, impish, unstable)

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the linux-hwe-5.13/5.13.0-17.17~20.04.1 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.13.0-19.19

---------------
linux (5.13.0-19.19) impish; urgency=medium

  * impish/linux: 5.13.0-19.19 -proposed tracker (LP: #1946337)

  * impish:linux-aws 5.13 panic during systemd autotest (LP: #1946001)
    - [Config] disable KFENCE

 -- Andrea Righi <email address hidden> Thu, 07 Oct 2021 11:09:51 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-oem-5.13 - 5.13.0-1017.21

---------------
linux-oem-5.13 (5.13.0-1017.21) focal; urgency=medium

  * focal/linux-oem-5.13: 5.13.0-1017.21 -proposed tracker (LP: #1946722)

  * Intel AX201 8086:7af0 subsys 8086:4070 hardware reset periodically: FW error
    in SYNC CMD UNKNOWN (LP: #1941665)
    - iwlwifi: mvm: support BIOS enable/disable for 11ax in Russia
    - iwlwifi: mvm: Read acpi dsm to get unii4 enable/disable bitmap.

 -- Timo Aaltonen <email address hidden> Tue, 12 Oct 2021 11:54:40 +0300

[Timo Aaltonen (tjaalton)]

this is applied to impish but not jammy?

[You-Sheng Yang (vicamo)]

Great, missed Timo's message. Yes, in Impish but not in Jammy and above. Fixing this.

And it also depends on patches for bug 1889384 and bug 1896598.

[You-Sheng Yang (vicamo)]

SRU:
* https://lists.ubuntu.com/archives/kernel-team/2022-April/129347.html (jammy)
* https://lists.ubuntu.com/archives/kernel-team/2022-April/129349.html (unstable, oem-5.17)

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the linux/5.15.0-28.29 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Kai-Chuan Hsieh (kchsieh)]

Verify the kernel in #31, the NVME controller LnkCtl will be ASPM L1 Enabled, and device can enter PC8 in short idle.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-oem-5.17 - 5.17.0-1004.4

---------------
linux-oem-5.17 (5.17.0-1004.4) jammy; urgency=medium

  * jammy/linux-oem-5.17: 5.17.0-1004.4 -proposed tracker (LP: #1970584)

  * Packaging resync (LP: #1786013)
    - [Packaging] update Ubuntu.md

  * alsa: enable the cirrus-logic side-codec to make the speaker output sound
    (LP: #1965496)
    - spi: Make spi_alloc_device and spi_add_device public again
    - spi: Create helper API to lookup ACPI info for spi device
    - spi: Support selection of the index of the ACPI Spi Resource before alloc
    - spi: Add API to count spi acpi resources
    - platform/x86: i2c-multi-instantiate: Rename it for a generic serial driver
      name
    - platform/x86: serial-multi-instantiate: Reorganize I2C functions
    - platform/x86: serial-multi-instantiate: Add SPI support
    - ACPI / scan: Create platform device for CS35L41
    - [Config]: enable SERIAL_MULTI_INSTANTIATE

  * Bolt doesn't work with native USB4 hosts (LP: #1962349)
    - thunderbolt: Retry DROM reads for more failure scenarios
    - thunderbolt: Do not resume routers if UID is not set
    - thunderbolt: Do not make DROM read success compulsory
    - PCI/ACPI: Allow D3 only if Root Port can signal and wake from D3

  * DMCUB hangs if a PSR unsupported set version command is sent on AMD
    Rembrandt platform (LP: #1969407)
    - drm/amd/display: Only set PSR version when valid

  * Micmute LED support for Zbook Fury 16 G9 (LP: #1968892)
    - ALSA: hda/realtek: Add support for HP Laptops
    - ALSA: hda/realtek: Add mute and micmut LED support for Zbook Fury 17 G9

  * PCIE LnkCtl ASPM not enabled under VMD mode for Alder Lake platforms
    (LP: #1942160)
    - SAUCE: PCI/ASPM: Enable ASPM for links under VMD domain
    - SAUCE: PCI/ASPM: Enable LTR for endpoints behind VMD
    - SAUCE: vmd: fixup bridge ASPM by driver name instead

  * Support AMD P-State cpufreq control mechanism (LP: #1956509)
    - [Config] enable X86_AMD_PSTATE as built-in on amd64

  * Use kernel-testing repo from launchpad for ADT tests (LP: #1968016)
    - [Debian] Use kernel-testing repo from launchpad

  * Fix beacon loss for rtl8821ce on certain platforms (LP: #1969771)
    - SAUCE: rtw88: pci: 8821c: Disable 21ce completion timeout

  * alsa/sdw: Fix the audio issue on a Dell machine without internal mic
    (LP: #1966841)
    - ASoC: Intel: soc-acpi: add entries in ADL match table

  * WCN6856 BT keep in OFF state after coldboot system (LP: #1967067)
    - Bluetooth: btusb: Improve stability for QCA devices

  * Miscellaneous Ubuntu changes
    - [Config] update configs and annotations after stable updates

  [ Ubuntu: 5.17.0-8.8~22.04.2 ]

  * jammy/linux-hwe-5.17: 5.17.0-8.8~22.04.2 -proposed tracker (LP: #1969219)
  * Packaging resync (LP: #1786013)
    - [Packaging] update Ubuntu.md
    - [Packaging] update update.conf

  [ Ubuntu: 5.17.0-8.8~22.04.1 ]

  * Empty entry

  [ Ubuntu: 5.17.0-8.8 ]

  * jammy/linux-unstable: 5.17.0-8.8 -proposed tracker (LP: #1969016)
  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/master)

  [ Ubuntu: 5.17.0-7.7 ]

  * jammy/linux-unsta...

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.15.0-35.36

---------------
linux (5.15.0-35.36) jammy; urgency=medium

  * CVE-2022-21499
    - SAUCE: debug: Lock down kgdb

linux (5.15.0-34.35) jammy; urgency=medium

  * jammy/linux: 5.15.0-34.35 -proposed tracker (LP: #1974322)

  * AMD APU s2idle is broken after the ASIC reset fix (LP: #1972134)
    - drm/amdgpu: unify BO evicting method in amdgpu_ttm
    - drm/amdgpu: explicitly check for s0ix when evicting resources

  * amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x0000 to IRQ, err -517
    (LP: #1971597)
    - gpio: Request interrupts after IRQ is initialized

  * config CONFIG_HISI_PMU for kunpeng920 (LP: #1956086)
    - [Config] CONFIG_HISI_PMU=m

  * Mute/mic LEDs no function on EliteBook G9 platfroms (LP: #1970552)
    - ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops

  * network-manager/1.36.4-2ubuntu1 ADT test failure with linux/5.15.0-28.29
    (LP: #1971418)
    - Revert "rfkill: make new event layout opt-in"

  * PCIE LnkCtl ASPM not enabled under VMD mode for Alder Lake platforms
    (LP: #1942160)
    - SAUCE: vmd: fixup bridge ASPM by driver name instead

  * Mute/mic LEDs no function on HP EliteBook 845/865 G9 (LP: #1970178)
    - ALSA: hda/realtek: Enable mute/micmute LEDs and limit mic boost on EliteBook
      845/865 G9

  * Enable headset mic on Lenovo P360 (LP: #1967069)
    - ALSA: hda/realtek: Enable headset mic on Lenovo P360

  * WCN6856 BT keep in OFF state after coldboot system (LP: #1967067)
    - Bluetooth: btusb: Improve stability for QCA devices

  * Screen sometimes can't update [Failed to post KMS update: CRTC property
    (GAMMA_LUT) not found] (LP: #1967274)
    - drm/i915/xelpd: Enable Pipe color support for D13 platform
    - drm/i915: Use unlocked register accesses for LUT loads
    - drm/i915/xelpd: Enable Pipe Degamma
    - drm/i915/xelpd: Add Pipe Color Lut caps to platform config

  * Jammy update: v5.15.35 upstream stable release (LP: #1969857)
    - drm/amd/display: Add pstate verification and recovery for DCN31
    - drm/amd/display: Fix p-state allow debug index on dcn31
    - hamradio: defer 6pack kfree after unregister_netdev
    - hamradio: remove needs_free_netdev to avoid UAF
    - cpuidle: PSCI: Move the `has_lpi` check to the beginning of the function
    - ACPI: processor idle: Check for architectural support for LPI
    - ACPI: processor: idle: fix lockup regression on 32-bit ThinkPad T40
    - btrfs: remove unused parameter nr_pages in add_ra_bio_pages()
    - btrfs: remove no longer used counter when reading data page
    - btrfs: remove unused variable in btrfs_{start,write}_dirty_block_groups()
    - soc: qcom: aoss: Expose send for generic usecase
    - dt-bindings: net: qcom,ipa: add optional qcom,qmp property
    - net: ipa: request IPA register values be retained
    - btrfs: release correct delalloc amount in direct IO write path
    - ALSA: core: Add snd_card_free_on_error() helper
    - ALSA: sis7019: Fix the missing error handling
    - ALSA: ali5451: Fix the missing snd_card_free() call at probe error
    - ALSA: als300: Fix the missing snd_card_free() call at probe error
    - ALSA: als4000: Fix ...

[Timo Aaltonen (tjaalton)]

this is still not upstream in 6.0, is there a plan for getting it there?

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux - 5.19.0-15.15

---------------
linux (5.19.0-15.15) kinetic; urgency=medium

  * kinetic/linux: 5.19.0-15.15 -proposed tracker (LP: #1983335)

  * Miscellaneous Ubuntu changes
    - [Config] update annotations to support both gcc-11 and gcc-12

 -- Andrea Righi <email address hidden> Tue, 02 Aug 2022 09:23:01 +0200