[dove] Need to make galcore.ko and bmm_drv.ko built-in

Bug #625090 reported by Eric Miao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-mvl-dove (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

As discussed with pitti and NCommander, the benefits of making them built-in are:

1) to improve the boot performance a bit by avoiding modprobe these two modules
2) to avoid the nasty hacks to the /etc/modules and /etc/modprobe.d as these two modules doesn't support modalias and cannot be automatically loaded on demand

The options to galcore.ko need to be considered though:

options galcore registerMemBase=0xf1840000 irqLine=48 contiguousBase=0x8000000 contiguousSize=0x2000000

And since these two modules are normally always required for the dove kernel image, it's generally a good idea to get them built-in. The galcore doesn't support that, so have to hack into the Makefile a bit.

Eric Miao (eric.y.miao)
description: updated
Revision history for this message
Saeed Bishara (saeed-marvell) wrote :

why do you guys think that having this driver built in will save boot time?
the driver can be loaded in very short time:
root@ubuntu-laptop:~# time modprobe galcore

real 0m0.049s
user 0m0.020s
sys 0m0.010s

also, I see in the git that you reverted the patch the makes this driver static.

Revision history for this message
Colin Watson (cjwatson) wrote :
Download full text (44.8 KiB)

linux-mvl-dove (2.6.32-410.26) maverick; urgency=low

  [ Stefan Bader ]

  * Rebased to 2.6.32-25.43

  [ Upstream Kernel Changes ]

  * dove: make galcore built-in
    - LP: #625090
  * dove: make BMM driver built-in
    - LP: #625090
  * dove: fix incorrect bus base of macro __io()
    - LP: #601226
  * dove: use LCD external clock for videoplug board
    - LP: #625132
  * dove: fix crash issue when lcd1 enabled and the board setup doesn't
    provide mach board info
    - LP: #625132
  * dove: fix bug when clearing the needed bit when handling PMU interrupt
    - LP: #625132
  * fix VGA calibration initial value.
    - LP: #625132
  * dove: fix bug when setting the pcie port control register
    - LP: #625132
  * fix jiggling issue for high resolution in dual display.
    - LP: #625132
  * orion eth: always call the phy_scan from the resume function
    - LP: #625132
  * Enable L2WA only and remove L1WA
    - LP: #625132
  * Enable L2C way 4-7
    - LP: #625132
  * Disable Dual issue of VFP WMMX for stability
    - LP: #625132
  * dove: set the giga phy address for dove db board
    - LP: #625132
  * fix HWC32 enable make system hang while use LCD external clock.
    - LP: #625132
  * dove: use AC97 RT655 codec instead of ASoC version
    - LP: #625132

  [ Ubuntu: 2.6.32-25.43 ]

  * SAUCE: (no-up) Modularize vesafb -- fix initialization
    - LP: #611471
  * Revert "SAUCE: sync before umount to reduce time taken by ext4 umount"
    - LP: #543617, #585092
  * Revert "SAUCE: tulip: Let dmfe handle davicom on non-sparc"
    - LP: #607824
  * [Config] Added ums-cypress to udeb
    - LP: #576066
  * Revert "PCI quirk: Disable MSI on VIA K8T890 systems"
    - LP: #607824
  * Revert "PCI quirks: disable msi on AMD rs4xx internal gfx bridges"
    - LP: #607824
  * Revert "(pre-stable) Input: psmouse - reset all types of mice before
    reconnecting"
    - LP: #607824
  * Revert "jbd: jbd-debug and jbd2-debug should be writable"
    - LP: #607824
  * Revert "ext4: Make fsync sync new parent directories in no-journal
    mode"
    - LP: #615548
  * Revert "ext4: Fix compat EXT4_IOC_ADD_GROUP"
    - LP: #615548
  * Revert "ext4: Conditionally define compat ioctl numbers"
    - LP: #615548
  * Revert "ext4: restart ext4_ext_remove_space() after transaction
    restart"
    - LP: #615548
  * Revert "ext4: Clear the EXT4_EOFBLOCKS_FL flag only when warranted"
    - LP: #615548
  * Revert "ext4: Avoid crashing on NULL ptr dereference on a filesystem
    error"
    - LP: #615548
  * Revert "ext4: Use bitops to read/modify i_flags in struct
    ext4_inode_info"
    - LP: #615548
  * Revert "ext4: Show journal_checksum option"
    - LP: #615548
  * Revert "ext4: check for a good block group before loading buddy pages"
    - LP: #615548
  * Revert "ext4: Prevent creation of files larger than RLIMIT_FSIZE using
    fallocate"
    - LP: #615548
  * Revert "ext4: Remove extraneous newlines in ext4_msg() calls"
    - LP: #615548
  * Revert "ext4: init statistics after journal recovery"
    - LP: #615548
  * Revert "ext4: clean up inode bitmaps manipulation in ext4_free_inode"
    - LP: #615548
  * Revert "ext4: Do not zero out uninitialized extents beyond i_s...

Changed in linux-mvl-dove (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.