user_copy in user from ubuntu_kernel_selftests failed on KVM kernel

Bug #1812198 reported by Po-Hsu Lin on 2019-01-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-kernel-tests
Undecided
Po-Hsu Lin
linux-kvm (Ubuntu)
Undecided
Unassigned
Xenial
Medium
Unassigned
Bionic
Medium
Po-Hsu Lin
Cosmic
Medium
Unassigned

Bug Description

== Justification ==
This user_copy test has failed while attempting to insert the test_user_copy module, but this module does not exist in the Bionic KVM kernel as the CONFIG_TEST_USER_COPY was not enabled.

# modprobe test_user_copy
modprobe: FATAL: Module test_user_copy not found in directory /lib/modules/4.15.0-1028-kvm

== Fix ==
d7d5311 (selftests: user: return Kselftest Skip code for skipped tests)
3c07aae (selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS)
c31d02d (selftests: kselftest: Remove outdated comment)

This fix will make the test return a skipped retun code if the
test_user_copy module does not exist.

This patch set can be cherry-picked into Bionic, and we already have it in Cosmic / Disco.

For Xenial, it already got d7d5311 and does not need the other two.

== Test ==
With this patch, the test will return "skipped" as expected:
    $ sudo ./test_user_copy.sh
    user: module test_user_copy is not found [SKIP]
    $ echo $?
    4

Note that the test framework will need another fix to treat the SKIP return code properly. (bug 1812352)

== Regression potential ==
None,
this patch just change the code for the testing tool.

--

This test_user_copy module will need the CONFIG_TEST_USER_COPY to be enabled
https://cateee.net/lkddb/web-lkddb/TEST_USER_COPY.html

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: linux-image-4.15.0-1028-kvm 4.15.0-1028.28
ProcVersionSignature: User Name 4.15.0-1028.28-kvm 4.15.18
Uname: Linux 4.15.0-1028-kvm x86_64
ApportVersion: 2.20.9-0ubuntu7.5
Architecture: amd64
Date: Thu Jan 17 10:57:57 2019
SourcePackage: linux-kvm
UpgradeStatus: No upgrade log present (probably fresh install)

Po-Hsu Lin (cypressyew) wrote :
description: updated
Po-Hsu Lin (cypressyew) wrote :

In Cosmic, this test can be skipped by checking the module existence.
So maybe we should fix this in the kernel (testing tool).

Po-Hsu Lin (cypressyew) wrote :

In Xenial / Disco, this test can be skipped checking the module existence as well (commit d7d5311).

So please reject the nomination for Xenial and Cosmic.

Changed in ubuntu-kernel-tests:
assignee: nobody → Po-Hsu Lin (cypressyew)
status: New → In Progress
Changed in linux-kvm (Ubuntu):
status: New → In Progress
assignee: nobody → Po-Hsu Lin (cypressyew)
Po-Hsu Lin (cypressyew) on 2019-01-18
description: updated
Po-Hsu Lin (cypressyew) on 2019-01-18
description: updated
description: updated
Po-Hsu Lin (cypressyew) on 2019-01-18
description: updated
Stefan Bader (smb) on 2019-01-21
Changed in linux-kvm (Ubuntu Bionic):
importance: Undecided → Medium
Changed in linux-kvm (Ubuntu Xenial):
status: New → Fix Released
importance: Undecided → Medium
Changed in linux-kvm (Ubuntu Cosmic):
status: New → Fix Released
importance: Undecided → Medium
Changed in linux-kvm (Ubuntu Bionic):
status: New → In Progress
Changed in linux-kvm (Ubuntu Bionic):
status: In Progress → Fix Committed
Brad Figg (brad-figg) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed-bionic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-bionic
Terry Rudd (terrykrudd) wrote :

This is the final reminder to please verify that the kernel in -proposed resolves the issue for which you've filed this bug report. Canonical is planning to release these kernels early next week. Thank you in advance!

Po-Hsu Lin (cypressyew) wrote :

It's now returning the expected SKIP return code:
$ sudo ./test_user_copy.sh
user: module test_user_copy is not found [SKIP]
$ echo $?
4

tags: added: verification-done-bionic
removed: verification-needed-bionic
Changed in ubuntu-kernel-tests:
status: In Progress → Fix Released
Po-Hsu Lin (cypressyew) on 2019-03-05
Changed in linux-kvm (Ubuntu):
status: In Progress → Invalid
Changed in linux-kvm (Ubuntu Bionic):
assignee: nobody → Po-Hsu Lin (cypressyew)
Changed in linux-kvm (Ubuntu):
assignee: Po-Hsu Lin (cypressyew) → nobody
Launchpad Janitor (janitor) wrote :
Download full text (12.0 KiB)

This bug was fixed in the package linux-kvm - 4.15.0-1030.30

---------------
linux-kvm (4.15.0-1030.30) bionic; urgency=medium

  * linux-kvm: 4.15.0-1030.30 -proposed tracker (LP: #1814736)

  * CONFIG_SECURITY_SELINUX_DISABLE should be disabled on KVM kernel
    (LP: #1812153)
    - [Config]: disable CONFIG_SECURITY_SELINUX_DISABLE
    - [Config]: disable CONFIG_SECURITY_WRITABLE_HOOKS

  [ Ubuntu: 4.15.0-46.49 ]

  * linux: 4.15.0-46.49 -proposed tracker (LP: #1814726)
  * mprotect fails on ext4 with dax (LP: #1799237)
    - x86/speculation/l1tf: Exempt zeroed PTEs from inversion
  * kernel BUG at /build/linux-vxxS7y/linux-4.15.0/mm/slub.c:296! (LP: #1812086)
    - iscsi target: fix session creation failure handling
    - scsi: iscsi: target: Set conn->sess to NULL when iscsi_login_set_conn_values
      fails
    - scsi: iscsi: target: Fix conn_ops double free
  * user_copy in user from ubuntu_kernel_selftests failed on KVM kernel
    (LP: #1812198)
    - selftests: user: return Kselftest Skip code for skipped tests
    - selftests: kselftest: change KSFT_SKIP=4 instead of KSFT_PASS
    - selftests: kselftest: Remove outdated comment
  * RTL8822BE WiFi Disabled in Kernel 4.18.0-12 (LP: #1806472)
    - SAUCE: staging: rtlwifi: allow RTLWIFI_DEBUG_ST to be disabled
    - [Config] CONFIG_RTLWIFI_DEBUG_ST=n
    - SAUCE: Add r8822be to signature inclusion list
  * kernel oops in bcache module (LP: #1793901)
    - SAUCE: bcache: never writeback a discard operation
  * CVE-2018-18397
    - userfaultfd: use ENOENT instead of EFAULT if the atomic copy user fails
    - userfaultfd: shmem: allocate anonymous memory for MAP_PRIVATE shmem
    - userfaultfd: shmem/hugetlbfs: only allow to register VM_MAYWRITE vmas
    - userfaultfd: shmem: add i_size checks
    - userfaultfd: shmem: UFFDIO_COPY: set the page dirty if VM_WRITE is not set
  * Ignore "incomplete report" from Elan touchpanels (LP: #1813733)
    - HID: i2c-hid: Ignore input report if there's no data present on Elan
      touchpanels
  * Vsock connect fails with ENODEV for large CID (LP: #1813934)
    - vhost/vsock: fix vhost vsock cid hashing inconsistent
  * SRU: Fix thinkpad 11e 3rd boot hang (LP: #1804604)
    - ACPI / LPSS: Force LPSS quirks on boot
  * Bionic update: upstream stable patchset 2019-01-17 (LP: #1812229)
    - scsi: sd_zbc: Fix variable type and bogus comment
    - KVM/Eventfd: Avoid crash when assign and deassign specific eventfd in
      parallel.
    - x86/apm: Don't access __preempt_count with zeroed fs
    - x86/events/intel/ds: Fix bts_interrupt_threshold alignment
    - x86/MCE: Remove min interval polling limitation
    - fat: fix memory allocation failure handling of match_strdup()
    - ALSA: hda/realtek - Add Panasonic CF-SZ6 headset jack quirk
    - ARCv2: [plat-hsdk]: Save accl reg pair by default
    - ARC: Fix CONFIG_SWAP
    - ARC: configs: Remove CONFIG_INITRAMFS_SOURCE from defconfigs
    - ARC: mm: allow mprotect to make stack mappings executable
    - mm: memcg: fix use after free in mem_cgroup_iter()
    - mm/huge_memory.c: fix data loss when splitting a file pmd
    - cpufreq: intel_pstate: Register when ACPI PCCH is present
    - vfio/pci: Fix potent...

Changed in linux-kvm (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers