Update gvnic driver code

Bug #1953575 reported by Khaled El Mously
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-gcp (Ubuntu)
In Progress
Undecided
Khaled El Mously
Focal
Fix Released
Medium
Khaled El Mously
Impish
Fix Released
Medium
Khaled El Mously
Jammy
Fix Released
Undecided
Unassigned

Bug Description

The GCE internal team responsible for gVNIC would like to have driver updates backported for both Ubuntu 18.04 LTS and Ubuntu 20.04 LTS.

[Impact]
Missing functionality from the Google gvnic driver

[Test Plan]
Confirm that gvnic module still loads and operates the gvnic driver. More extensive testing done by the gvnic developers at GCE

[Regression potential]
Possible regression in gvnic behaviour or functionality. Changes are confined to the gvnic driver code so regression potential is limited to gvnic only.

List of changes:

3712db620c613 gve: DQO: Configure interrupts on device up
a9fd7559a367a gve: Check TX QPL was actually assigned
c69a8892d5836 gve: fix the wrong AdminQ buffer overflow check
f48adc2842b17 gve: DQO: Remove incorrect prefetch
98fd04939ae7e gve: Simplify code and axe the use of a deprecated API
56c0904d8491d gve: Propagate error codes to caller
86cd2b58d1e63 gve: DQO: Fix off by one in gve_rx_dqo()
ea364622fb118 gve: Fix warnings reported for DQO patchset
8890e8783c6e6 gve: DQO: Add RX path
abfc55f80d423 gve: DQO: Add TX path
ef63867982913 gve: DQO: Add ring allocation and initialization
dc3e0aef11bf0 gve: DQO: Add core netdev features
873fd9825efd7 gve: Update adminq commands to support DQO queues
543dc0e670472 gve: Add DQO fields for core data structures
b580730931348 gve: Add dqo descriptors
74e123d3c62b2 gve: Add support for DQO RX PTYPE map
a9a3bfdd5f679 gve: adminq: DQO specific device descriptor logic
3e6d068c103f8 gve: Introduce per netdev `enum gve_queue_format`
a6b09c93c1735 gve: Introduce a new model for device options
34d6b75678979 gve: Add support for raw addressing in the tx path
30b6221596699 Revert "gve: Check TX QPL was actually assigned"
98478993bb3f9 gve: Make gve_rx_slot_page_info.page_offset an absolute offset
ff4b20bb7e5f4 gve: gve_rx_copy: Move padding to an argument
5fc5c482008b5 gve: Move some static functions to a common file
ed1e0daeee1ac gve: Rx Buffer Recycling
da57760d6370d gve: Add support for raw addressing to the rx path
b512608f33d8e gve: Add support for raw addressing device option
e85394c77cdce gve: Enable Link Speed Reporting in the driver.
8961791d8ba16 gve: Batch AQ commands for creating and destroying queues.
50bafd6d5a041 gve: NIC stats for report-stats and for ethtool
feccb84085904 gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags.
08578185ab296 gve: Use dev_info/err instead of netif_info/err.
613ed2d16246f gve: Add stats for gve.
250d220740d21 gve: Get and set Rx copybreak via ethtool

no longer affects: klibc (Ubuntu)
description: updated
Changed in linux-gcp (Ubuntu):
assignee: nobody → Khaled El Mously (kmously)
Changed in linux-gcp (Ubuntu Focal):
assignee: nobody → Khaled El Mously (kmously)
Changed in linux-gcp (Ubuntu):
status: New → In Progress
Changed in linux-gcp (Ubuntu Focal):
status: New → In Progress
Stefan Bader (smb)
Changed in linux-gcp (Ubuntu Focal):
importance: Undecided → Medium
Changed in linux-gcp (Ubuntu Impish):
assignee: nobody → Khaled El Mously (kmously)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gcp/5.4.0-1066.70 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gcp/5.13.0-1016.19 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-impish' to 'verification-done-impish'. If the problem still exists, change the tag 'verification-needed-impish' to 'verification-failed-impish'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-impish
Changed in linux-gcp (Ubuntu Focal):
status: In Progress → Fix Committed
Changed in linux-gcp (Ubuntu Impish):
status: In Progress → Fix Committed
tags: added: verification-done-focal
removed: verification-needed-focal
tags: added: verification-done-impish
removed: verification-needed-impish
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-gcp - 5.13.0-1021.25

---------------
linux-gcp (5.13.0-1021.25) impish; urgency=medium

  * impish/linux-gcp: 5.13.0-1021.25 -proposed tracker (LP: #1964951)

  * Packaging resync (LP: #1786013)
    - debian/dkms-versions -- update from kernel-versions (main/2022.02.21)

  [ Ubuntu: 5.13.0-37.42 ]

  * impish/linux: 5.13.0-37.42 -proposed tracker (LP: #1964959)
  * CVE-2022-0742
    - ipv6: fix skb drops in igmp6_event_query() and igmp6_event_report()

 -- Tim Gardner <email address hidden> Tue, 15 Mar 2022 09:28:30 -0600

Changed in linux-gcp (Ubuntu Impish):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (17.6 KiB)

This bug was fixed in the package linux-gcp - 5.4.0-1072.77

---------------
linux-gcp (5.4.0-1072.77) focal; urgency=medium

  * focal/linux-gcp: 5.4.0-1072.77 -proposed tracker (LP: #1968829)

  * Miscellaneous Ubuntu changes
    - [packaging] Update annotations for arm64
    - [packaging] update getabis for arm64
    - [packaging] Fix annotations file
    - [config] Update config for arm64

  [ Ubuntu: 5.4.0-109.123 ]

  * focal/linux: 5.4.0-109.123 -proposed tracker (LP: #1968290)
  * USB devices not detected during boot on USB 3.0 hubs (LP: #1968210)
    - SAUCE: Revert "Revert "xhci: Set HCD flag to defer primary roothub
      registration""
    - SAUCE: Revert "Revert "usb: core: hcd: Add support for deferring roothub
      registration""

linux-gcp (5.4.0-1071.76) focal; urgency=medium

  * focal/linux-gcp: 5.4.0-1071.76 -proposed tracker (LP: #1967374)

  * Update gvnic driver code (LP: #1953575)
    - netdev: pass the stuck queue to the timeout handler
    - gve: Get and set Rx copybreak via ethtool
    - gve: Add stats for gve.
    - gve: Use dev_info/err instead of netif_info/err.
    - gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags.
    - gve: NIC stats for report-stats and for ethtool
    - gve: Batch AQ commands for creating and destroying queues.
    - gve: Use link status register to report link status
    - gve: Enable Link Speed Reporting in the driver.
    - gve: Replace zero-length array with flexible-array member
    - gve: Add support for raw addressing device option
    - gve: Add support for raw addressing to the rx path
    - gve: Rx Buffer Recycling
    - net: gve: convert strlcpy to strscpy
    - net: gve: remove duplicated allowed
    - gve: Move some static functions to a common file
    - gve: gve_rx_copy: Move padding to an argument
    - gve: Make gve_rx_slot_page_info.page_offset an absolute offset
    - SAUCE: Revert "gve: Check TX QPL was actually assigned"
    - gve: Add support for raw addressing in the tx path
    - gve: Introduce a new model for device options
    - gve: Introduce per netdev `enum gve_queue_format`
    - gve: adminq: DQO specific device descriptor logic
    - gve: Add support for DQO RX PTYPE map
    - gve: Add dqo descriptors
    - gve: Add DQO fields for core data structures
    - gve: Update adminq commands to support DQO queues
    - gve: DQO: Add core netdev features
    - gve: DQO: Add ring allocation and initialization
    - gve: DQO: Configure interrupts on device up
    - gve: DQO: Add TX path
    - gve: DQO: Add RX path
    - gve: Fix warnings reported for DQO patchset
    - gve: DQO: Fix off by one in gve_rx_dqo()
    - gve: Propagate error codes to caller
    - gve: Simplify code and axe the use of a deprecated API
    - gve: DQO: Remove incorrect prefetch
    - gve: fix the wrong AdminQ buffer overflow check
    - gve: DQO: avoid unused variable warnings
    - gve: Check TX QPL was actually assigned
    - gve: Avoid freeing NULL pointer
    - gve: Properly handle errors in gve_assign_qpl
    - gve: report 64bit tx_bytes counter from gve_handle_report_stats()
    - gve: Switch to use napi_complete_done
    - gve: Add rx buffer pagecnt bias
    - gve: Do lazy...

Changed in linux-gcp (Ubuntu Focal):
status: Fix Committed → Fix Released
Changed in linux-gcp (Ubuntu Jammy):
status: New → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-gcp/5.15.0-1022.29 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (74.4 KiB)

This bug was fixed in the package linux-gcp - 5.15.0-1022.29

---------------
linux-gcp (5.15.0-1022.29) jammy; urgency=medium

  * jammy/linux-gcp: 5.15.0-1022.29 -proposed tracker (LP: #1991987)

  * Jammy update: v5.15.61 upstream stable release (LP: #1990162)
    - [Config] updateconfigs for CRYPTO_LIB_BLAKE2S

  * Update gvnic driver code (LP: #1953575)
    - gve: Use kvcalloc() instead of kvzalloc()
    - gve: Switch to use napi_complete_done
    - gve: Add rx buffer pagecnt bias
    - gve: Do lazy cleanup in TX path
    - gve: Add netif_set_xps_queue call
    - gve: Allow pageflips on larger pages
    - gve: Add RX context.
    - gve: Implement packet continuation for RX.
    - gve: Add a jumbo-frame device option.
    - gve: fix unmatched u64_stats_update_end()
    - gve: fix for null pointer dereference.
    - gve: Correct order of processing device options
    - gve: Move the irq db indexes out of the ntfy block struct
    - gve: Update gve_free_queue_page_list signature
    - gve: remove memory barrier around seqno
    - gve: Add optional metadata descriptor type GVE_TXD_MTD
    - gve: Implement suspend/resume/shutdown
    - gve: Add consumed counts to ethtool stats
    - gve: Add tx|rx-coalesce-usec for DQO

  [ Ubuntu: 5.15.0-53.59 ]

  * Fix blank screen on Thinkpad ADL 4K+ panel (LP: #1980621)
    - drm/i915: Implement WaEdpLinkRateDataReload
  * Kernel regresses openjdk on riscv64 (LP: #1992484)
    - SAUCE: Revert "riscv: mmap with PROT_WRITE but no PROT_READ is invalid"
  * iavf: SR-IOV VFs error with no traffic flow when MTU greater than 1500
    (LP: #1983656)
    - iavf: Fix set max MTU size with port VLAN and jumbo frames
    - i40e: Fix VF set max MTU size
  * [Ubuntu 22.04] mpt3sas: Request to include latest bug fix patches
    (LP: #1965927)
    - scsi: mpt3sas: Remove scsi_dma_map() error messages
    - scsi: mpt3sas: Update persistent trigger pages from sysfs interface
  * ACPI: processor idle: Practically limit "Dummy wait" workaround to old Intel
    systems (LP: #1990985)
    - ACPI: processor idle: Practically limit "Dummy wait" workaround to old Intel
      systems
  * Fix resume on AMD platforms when TBT monitor is plugged (LP: #1990920)
    - SAUCE: Revert "drm/amd/display: Add helper for blanking all dp displays"
    - drm/amd/display: Detect dpcd_rev when hotplug mst monitor
    - drm/amd/display: Release remote dc_sink under mst scenario
  * LSM: Configuring Too Many LSMs Causes Kernel Panic on Boot (LP: #1987998)
    - SAUCE: LSM: Change Landlock from LSMBLOB_NEEDED to LSMBLOB_NOT_NEEDED
  * To support Intel Maple Ridge Thunderbolt [8086:1134] (LP: #1990240)
    - thunderbolt: Add support for Intel Maple Ridge single port controller
  * Intel graphic driver is not probing[8086:468b] (LP: #1990242)
    - drm/i915/adl_s: Update ADL-S PCI IDs
    - drm/i915: Add new ADL-S pci id
  * Add HDMI codec ID for Intel Raptor Lake (LP: #1989578)
    - ALSA: hda: Add PCI and HDMI IDs for Intel Raptor Lake
  * Jammy update: v5.15.64 upstream stable release (LP: #1991717)
    - wifi: rtlwifi: remove always-true condition pointed out by GCC 12
    - eth: sun: cassini: remove dead code
    - audit: fix potential double fr...

Changed in linux-gcp (Ubuntu Jammy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers