ifconfig eth0 down will cause system hang after fec.c driver update

Bug #559065 reported by Bryan Wu on 2010-04-09
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-fsl-imx51 (Ubuntu)
High
Bryan Wu
Lucid
High
Bryan Wu

Bug Description

After fec.c driver introduced phylib supporting, 'ifconfig eth0 down' command will cause system hang totally. It can also be found when disabling network interface via NetworkManager and suspend the system.

Bryan Wu (cooloney) on 2010-04-12
Changed in linux-fsl-imx51 (Ubuntu):
assignee: nobody → Bryan Wu (cooloney)
importance: Undecided → High
status: New → In Progress
Bryan Wu (cooloney) wrote :

Paul and Tobin,

Could you please help me to test the following kernel package on your side? See whether suspend/resume works and 'ifconfig eth0 down' works.
http://people.canonical.com/~roc/kernel/fec_suspend/

Thanks,
-Bryan

Paul Larson (pwlars) wrote :

Using the kernel kernel there, I was able to successfully ifconfig eth0 down and also bring it back up without hanging the system. However, suspend/resume still does not work

tags: added: armel
Changed in linux-fsl-imx51 (Ubuntu Lucid):
milestone: none → ubuntu-10.04
Tobin Davis (gruemaster) wrote :

Nice speed improvement. Downloading a test iso from my W2k3 server is now averaging 8.5 MB/s (previous kernel was at ~4.5 MB/s). Unfortunately, suspend/resume still fails.

Amit Kucheria (amitk) on 2010-04-16
Changed in linux-fsl-imx51 (Ubuntu Lucid):
milestone: ubuntu-10.04 → lucid-updates
tags: added: iso-testing
Bryan Wu (cooloney) wrote :

Paul and Tobin,

Please help me to test again to see whether the ifconfig down cause system hang.

I updated this patch according to kernel team review.
http://people.canonical.com/~roc/kernel/ifconfig/

my git tree is here:
http://kernel.ubuntu.com/git?p=roc/ubuntu-lucid.git;a=shortlog;h=refs/heads/fec

Thanks,
-Bryan

Tobin Davis (gruemaster) wrote :

Ifconfig now works, download speed still looks very good. Still no resume from suspend.

Bryan Wu (cooloney) wrote :

Tobin and Paul,

Could you please help me to test again for ifconfig issue and performance? I updated again according to the review from our kernel member.
http://people.canonical.com/~roc/kernel/ifconfig/

my git tree is here:
http://kernel.ubuntu.com/git?p=roc/ubuntu-lucid.git;a=shortlog;h=refs/heads/fec

Thanks,
-Bryan

Tobin Davis (gruemaster) wrote :

I don't see any real difference between this kernel and the previous test kernel (comment #4).

Bryan Wu (cooloney) wrote :

Tobin,

Thanks a lot. My board broke now. Could you please try my testing kernel again?
I updated again according to the review from our kernel member.
http://people.canonical.com/~roc/kernel/ifconfig/

my git tree is here:
http://kernel.ubuntu.com/git?p=roc/ubuntu-lucid.git;a=shortlog;h=refs/heads/fec

Thanks,
-Bryan

Tobin Davis (gruemaster) wrote :

Nope, this kernel had a bad oops during boot, and it fails to boot all the way, suggesting memory corruption.

See attached oops captured from serial console.

Tobin Davis (gruemaster) wrote :

Added full kernel ouput from serial console.

Bryan Wu (cooloney) wrote :

I fixed this oops and please help me to test again. Thanks.
http://people.canonical.com/~roc/kernel/ifconfig/

my git tree is here:
http://kernel.ubuntu.com/git?p=roc/ubuntu-lucid.git;a=shortlog;h=refs/heads/fec

Thanks,
-Bryan

Tobin Davis (gruemaster) wrote :

Tested ifdown3. No oops, download speed is great, and ifconfig eth0 down does not hang the system. Win!

Paul Larson (pwlars) wrote :

@Brian, is the ifconfig eth0 down the same issue that is causing suspend/resume to fail? If not, we should probably split this into two bugs

Bryan Wu (cooloney) wrote :

@Paul,

Actually, I found this ifdown hang issue when I was debugging the suspend/resume regression. But even we fixed the ifdown hang issue, system can suspend now but cannot resume.

Yes, please help me file a bug about the resume failure regression.

Thanks,
-Bryan

Paul Larson (pwlars) wrote :

The suspend/resume problem discussed here has been split into bug #571192

Accepted linux-fsl-imx51 into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in linux-fsl-imx51 (Ubuntu Lucid):
status: In Progress → Fix Committed
tags: added: verification-needed
Tobin Davis (gruemaster) wrote :

Tested and verified that this now works, thanks.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-fsl-imx51 - 2.6.31-608.15

---------------
linux-fsl-imx51 (2.6.31-608.15) lucid-proposed; urgency=low

  [ Andy Whitcroft ]

  * rebase to Ubuntu-2.6.31-22.61
  * update to ubuntu-debian:7e708d33054c373faf41da23b73e8b48c342d958
    - LP: #570500, #576274

  [ Bryan Wu ]

  * SAUCE: IMX51: fix stgl5000 regulator_get failing error
    - LP: #567157

  [ Mattias Walstrom ]

  * (pre-upstream) FEC: Fix kernel panic in fec_set_mac_address.
    - LP: #575558

  [ Upstream Kernel Changes ]

  * ENGR00120510 atlas switch mode control
  * ENGR00120456 mx51: set VIOHI always on
  * ENGR00121069: MX51: Complete the constraints for the various
    regulators.
  * ENGR00121385 MX51: Leave MC13892 VUSB Turned on for USB OTG to work
  * netdev/fec: fix ifconfig eth0 down hang issue
    - LP: #559065

  [ Ubuntu: 2.6.31-22.61 ]

  * SAUCE: docs -- fix doc strings for fc_event_seq
  * update to ubuntu-debian:7e708d33054c373faf41da23b73e8b48c342d958
    - LP: #570500, #576274
  * SAUCE: sched: update load count only once per cpu in 10 tick update
    window
    - LP: #513848
  * (pre-stable) x86-32, resume: do a global tlb flush in S4 resume
    - LP: #531309
  * PCI: Ensure we re-enable devices on resume
    - LP: #566149
 -- Stefan Bader <email address hidden> Mon, 14 Jun 2010 11:58:42 +0200

Changed in linux-fsl-imx51 (Ubuntu Lucid):
status: Fix Committed → Fix Released
Bryan Wu (cooloney) on 2010-08-10
Changed in linux-fsl-imx51 (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers