Upgrade yellow carp DMCUB firmware to fix suspend failure

[Mario Limonciello]

[Impact]
Certain Rembrandt designs use LPDDR memory and current firmware in linux-firmware package in Focal and Jammy has a failure resuming from s0i3 on DC power with it.

Some sample designs affected by the failure are Thinkpad X13, Z13, Z16.

This failure doesn't affect resume with AC power or designs without LPDDR memory.

[Fix]
Upgrade yellow carp DMCUB firmware binary.

https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=4458bb4185b6d6e1f5c586fcf4b8cf6f5d3c8e24

[Test]
Verify suspend/resume works.
Verify that externally plugged displays haven't regressed.

[Where problems could occur]
Firmware is only loaded to Rembrandt designs. Regressions would be tied to those platforms.

[Mario Limonciello (superm1)]

Here is a sample assertion in the wild that making just this fix helps the problem:

https://www.reddit.com/r/thinkpad/comments/voxsr0/thinkpad_t14_gen_3_amd_first_impression_final/ightdbq/?context=8&depth=9

[Jason Yen (jasonyen)]

Any ETA for the fix landed focal proposed or update channel? Thanks.

[Timo Aaltonen (tjaalton)]

Hello Mario, or anyone else affected,

Accepted linux-firmware into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware/20220329.git681281e4-0ubuntu3.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Mario, or anyone else affected,

Accepted linux-firmware into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/linux-firmware/1.187.33 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Bin Li (binli)]

Verified the issue on ThinkPad Z13/Z16/P16s Gen 1, I could suspend and resume successfully.

[Mario Limonciello (superm1)]

> verification-needed-jammy

Juerg - which firmware landed for VCN?

> Binary files /tmp/tmpjfs7by6f/74GQKUQY8t/linux-firmware-20220329.git681281e4/amdgpu/yellow_carp_vcn.bin and /tmp/tmpjfs7by6f/0SroKiuHba/linux-firmware-20220329.git681281e4/amdgpu/yellow_carp_vcn.bin differ

There was a revert that went upstream for VCN, just want to make sure we got the right one.

[AaronMa (mapengyu)]

@Mario,

VCN is updated to commit: 9ed4d42c51aca "amdgpu: update Yellow Carp VCN firmware"

The revert VCN and 22.20 is not merged.

[Mario Limonciello (superm1)]

Great thanks.

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for linux-firmware has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-firmware - 1.187.33

---------------
linux-firmware (1.187.33) focal; urgency=medium

  * Upgrade yellow carp DMCUB firmware to fix suspend failure (LP: #1981922)
    - amdgpu: Update yellow carp firmware from 21.50
    - amdgpu: update yellow carp firmware for 22.10
    - amdgpu: update Yellow Carp VCN firmware
    - amdgpu: update yellow carp DMCUB firmware

 -- Juerg Haefliger <email address hidden> Tue, 26 Jul 2022 10:40:15 +0200

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-firmware - 20220329.git681281e4-0ubuntu3.4

---------------
linux-firmware (20220329.git681281e4-0ubuntu3.4) jammy; urgency=medium

  * Upgrade yellow carp DMCUB firmware to fix suspend failure (LP: #1981922)
    - amdgpu: update yellow carp firmware for 22.10
    - amdgpu: update Yellow Carp VCN firmware
    - amdgpu: update yellow carp DMCUB firmware

 -- Juerg Haefliger <email address hidden> Tue, 26 Jul 2022 10:35:02 +0200