Debian packaging issues

Bug #1440317 reported by djcj on 2015-04-04
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-firmware (Ubuntu)
Undecided
Unassigned

Bug Description

Lintian reports many packaging issues.
The following issues can easily be fixed with small updates inside debian/*:
W: linux-firmware source: debhelper-but-no-misc-depends linux-firmware
E: linux-firmware source: declares-possibly-conflicting-debhelper-compat-versions rules=5 compat=5
E: linux-firmware source: depends-on-build-essential-package-without-using-version gcc [build-depends: gcc]
W: linux-firmware source: debian-rules-sets-DH_COMPAT line 12
W: linux-firmware source: ancient-standards-version 3.6.1 (current is 3.9.5)
W: linux-firmware: copyright-without-copyright-notice
W: linux-firmware: extra-license-file lib/firmware/GPL-3
W: linux-firmware: extra-license-file lib/firmware/carl9170fw/GPL
W: linux-firmware: script-not-executable lib/firmware/configure
W: linux-firmware: executable-not-elf-or-script lib/firmware/ath10k/QCA988X/hw2.0/firmware.bin
W: linux-firmware: executable-not-elf-or-script lib/firmware/ath10k/QCA988X/hw2.0/board.bin
W: linux-firmware: executable-not-elf-or-script lib/firmware/ath10k/QCA988X/hw2.0/otp.bin
W: linux-firmware: executable-not-elf-or-script lib/firmware/qat_895xcc.bin
W: linux-firmware: executable-not-elf-or-script lib/firmware/intel/ibt-hw-37.8.10-fw-1.10.3.11.e.bseq
W: linux-firmware: executable-not-elf-or-script lib/firmware/brcm/brcmfmac43143-sdio.bin

The remaining ones should be overridden:
W: linux-firmware: windows-devel-file-in-package lib/firmware/korg/k1212.dsp << false positive
W: linux-firmware: extra-license-file usr/share/doc/linux-firmware/licenses/LICENSE.* <<
W: linux-firmware: extra-license-file usr/share/doc/linux-firmware/licenses/LICENCE.* << practical reasons (in my opinion)

I'm running Ubuntu 14.04.
Fixed packaging files are attached.
Additionally here's a diff:

--- a/compat
+++ b/compat
@@ -1 +1 @@
-5
+9
--- a/control
+++ b/control
@@ -2,14 +2,15 @@
 Section: misc
 Priority: optional
 Maintainer: Ubuntu Kernel Team <email address hidden>
-Standards-Version: 3.6.1
-Build-Depends: debhelper (>= 4.0.0), rsync, gcc
+Standards-Version: 3.9.5
+Build-Depends: debhelper (>= 9), rsync
 Vcs-Git: git://kernel.ubuntu.com/ubuntu/linux-firmware.git

 Package: linux-firmware
 Architecture: all
 Multi-Arch: foreign
 Priority: optional
+Depends: ${misc:Depends}
 Provides: atmel-firmware
 Conflicts: atmel-firmware
 Replaces: atmel-firmware, linux-restricted-common
@@ -20,6 +21,7 @@
 XC-Package-Type: udeb
 Architecture: all
 Section: debian-installer
+Depends: ${misc:Depends}
 Description: Firmware for NICs
  This package contains firmware needed by some network controllers.

@@ -27,5 +29,6 @@
 XC-Package-Type: udeb
 Architecture: all
 Section: debian-installer
+Depends: ${misc:Depends}
 Description: Firmware for SCSI controllers
  This package contains firmware needed by some scsi controllers.
--- a/copyright
+++ b/copyright
@@ -6,6 +6,9 @@
 This package is currently maintained by the
 Ubuntu Kernel Team <email address hidden>

+Copyright (c) 2008-2015 Ubuntu Kernel Team <email address hidden>
+
+
 FIRMWARE:

 TERMS AND CONDITIONS
--- /dev/null
+++ b/linux-firmware.links
@@ -0,0 +1,2 @@
+/usr/share/common-licenses/GPL-3 /lib/firmware/GPL-3
+/usr/share/common-licenses/GPL-2 /lib/firmware/carl9170fw/GPL
--- /dev/null
+++ b/linux-firmware.lintian-overrides
@@ -0,0 +1,8 @@
+# False positive. This is actually a firmware binary.
+linux-firmware: windows-devel-file-in-package lib/firmware/korg/k1212.dsp
+
+# This is probably better then creating an unreadable wall of text
+# in a single file.
+linux-firmware: extra-license-file usr/share/doc/linux-firmware/licenses/LICENCE.*
+linux-firmware: extra-license-file usr/share/doc/linux-firmware/licenses/LICENSE.*
+
--- a/rules
+++ b/rules
@@ -8,38 +8,40 @@
 #
 #

-# This is the debhelper compatability version to use.
-export DH_COMPAT=5
-export LC_ALL=C
-export SHELL=/bin/bash -e
-
 #
 # A list of the directories created by makefiles under fw_source.
 #
 GENERATED_DIRS=ea

-binary-arch:
-
-build-arch:
- $(MAKE) -C fw_source update
-
-build-indep:
-
 firm_dir = $(CURDIR)/debian/linux-firmware/lib/firmware
 doc_dir = $(CURDIR)/debian/linux-firmware/usr/share/doc/linux-firmware
 license_dir = $(doc_dir)/licenses
 nic_firm_dir = $(CURDIR)/debian/nic-firmware/lib/firmware
 scsi_firm_dir = $(CURDIR)/debian/scsi-firmware/lib/firmware

-install-indep: build-indep
- dh_testdir
- dh_testroot
- dh_clean -k -i

+%:
+ dh $@ --parallel
+
+override_dh_auto_clean:
+ dh_auto_clean
+ rm -rf $(GENERATED_DIRS)
+
+override_dh_auto_build:
+ $(MAKE) -C fw_source update
+
+override_dh_auto_install:
+
+override_dh_install:
  install -d $(firm_dir)

- rsync -a --exclude=WHENCE --exclude=.git --exclude=debian --exclude fw_source * $(firm_dir)
- find $(firm_dir) -type f -name "LICEN[CS]E*" |xargs rm
+ rsync -a --exclude=WHENCE --exclude=WHENCE.ubuntu --exclude=.git --exclude=debian \
+ --exclude=fw_source --exclude=configure --exclude=Makefile * $(firm_dir)
+ find $(firm_dir) -type f -name "LICEN[CS]E*" -delete
+
+ for ext in bin img asc dfu fw z77 S lds c h txt cmake diff cis sbcf bseq ucode dsp dat csp sys ncf; do \
+ chmod 0644 `find $(firm_dir) -type f -name \*.$$ext` ; \
+ done

  for f in $$(cat debian/nic-firmware.lst); do \
   install -m644 -D $$f $(nic_firm_dir)/$$f; \
@@ -55,24 +57,3 @@
  install -d $(license_dir)
  cp LICEN[CS]E* $(license_dir)

-binary-indep: install-indep
- dh_testdir
- dh_testroot
-
- dh_installchangelogs -i
- dh_installdocs -i
- dh_compress -i
- dh_fixperms -i
- dh_installdeb -i
- dh_gencontrol -i
- dh_md5sums -i
- dh_builddeb -i
-
-binary: binary-indep binary-arch
-build: build-arch build-indep
-
-clean:
- rm -rf $(GENERATED_DIRS)
- dh_testdir
- dh_testroot
- dh_clean
--- /dev/null
+++ b/source/format
@@ -0,0 +1 @@
+3.0 (native)
--- /dev/null
+++ b/source/options
@@ -0,0 +1 @@
+compression = bzip2

djcj (djcj) wrote :
tags: added: patch
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers