pwr-mlxbf.c: make hids local variables
Bug #1980774 reported by
Asmaa Mnebhi
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux-bluefield (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Medium
|
Asmaa Mnebhi |
Bug Description
SRU Justification:
[Impact]
Both rst_pwr_hid and low_pwr_hid are only used in a single function so they should be local variables.
[Fix]
* Move rst_pwr_hid and low_pwr_hid to pwr_mlxbf_irq
[Test Case]
* build without warnings
* pwr-mlxbf.c is loaded successfully
* reset via BMC GPIO is successful
[Regression Potential]
Any of the test cases above could be impacted due to these changes.
CVE References
Changed in linux-bluefield (Ubuntu Focal): | |
assignee: | nobody → Asmaa Mnebhi (asmaam) |
importance: | Undecided → Medium |
status: | New → In Progress |
Changed in linux-bluefield (Ubuntu): | |
status: | New → Invalid |
Changed in linux-bluefield (Ubuntu Focal): | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
This bug is awaiting verification that the linux-bluefield /5.4.0- 1043.48 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification- needed- focal' to 'verification- done-focal' . If the problem still exists, change the tag 'verification- needed- focal' to 'verification- failed- focal'.
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you!