Azure: keys: Do not cache key in task struct if key is requested from kernel thread

[Tim Gardner]

SRU Justification

[Impact]

The key which gets cached in task structure from a kernel thread does not
get invalidated even after expiry. Due to which, a new key request from
kernel thread will be served with the cached key if it's present in task
struct irrespective of the key validity.

[Fix]

commit 47f9e4c924025c5be87959d3335e66fcbb7f6b5c ('keys: Do not cache key in task struct if key is requested from kernel thread')
Fixes: 7743c48e54ee ("keys: Cache result of request_key*() temporarily in task_struct")

[Regression potential]

DNS keys used by CIFS could get confused.

[Other Info]

Though this commit is part of stable updates v5.4.240, MSFT has requested that it be applied in advance since Focal is only up to v5.4.233. Linux-azure 5.4 is the only kernel that does not have this patch.

SF: #00359129

[Tim Gardner (timg-tpi)]

https://lists.ubuntu.com/archives/kernel-team/2023-April/139134.html

[Ubuntu Kernel Bot (ubuntu-kernel-bot)]

This bug is awaiting verification that the linux-azure/5.4.0-1110.116 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

[Launchpad Janitor (janitor)]

This bug was fixed in the package linux-azure - 5.4.0-1110.116

---------------
linux-azure (5.4.0-1110.116) focal; urgency=medium

  * focal/linux-azure: 5.4.0-1110.116 -proposed tracker (LP: #2019349)

  * Packaging resync (LP: #1786013)
    - [Packaging] resync git-ubuntu-log
    - [Packaging] resync getabis
    - debian/dkms-versions -- update from kernel-versions (main/2023.04.17)

  * Azure: keys: Do not cache key in task struct if key is requested from kernel
    thread (LP: #2017801)
    - keys: Do not cache key in task struct if key is requested from kernel thread

  [ Ubuntu: 5.4.0-151.168 ]

  * focal/linux: 5.4.0-151.168 -proposed tracker (LP: #2019375)
  * Packaging resync (LP: #1786013)
    - [Packaging] update helper scripts
    - debian/dkms-versions -- update from kernel-versions (main/2023.05.15)
  * CVE-2023-32233
    - netfilter: nf_tables: deactivate anonymous set from preparation phase
  * CVE-2023-2612
    - SAUCE: shiftfs: prevent lock unbalance in shiftfs_create_object()
  * CVE-2023-31436
    - net: sched: sch_qfq: prevent slab-out-of-bounds in qfq_activate_agg
  * CVE-2023-1380
    - wifi: brcmfmac: slab-out-of-bounds read in brcmf_get_assoc_ies()
  * Focal update: Focal update: v5.4.235 upstream stable release (LP: #2017706)
    - HID: asus: Remove check for same LED brightness on set
    - HID: asus: use spinlock to protect concurrent accesses
    - HID: asus: use spinlock to safely schedule workers
    - ARM: OMAP2+: Fix memory leak in realtime_counter_init()
    - arm64: dts: qcom: qcs404: use symbol names for PCIe resets
    - ARM: zynq: Fix refcount leak in zynq_early_slcr_init
    - arm64: dts: meson-gx: Fix Ethernet MAC address unit name
    - arm64: dts: meson-g12a: Fix internal Ethernet PHY unit name
    - arm64: dts: meson-gx: Fix the SCPI DVFS node name and unit address
    - arm64: dts: meson: remove CPU opps below 1GHz for G12A boards
    - ARM: OMAP1: call platform_device_put() in error case in
      omap1_dm_timer_init()
    - ARM: dts: exynos: correct wr-active property in Exynos3250 Rinato
    - ARM: imx: Call ida_simple_remove() for ida_simple_get
    - arm64: dts: amlogic: meson-gx: fix SCPI clock dvfs node name
    - arm64: dts: amlogic: meson-axg: fix SCPI clock dvfs node name
    - arm64: dts: amlogic: meson-gx: add missing SCPI sensors compatible
    - arm64: dts: amlogic: meson-gx: add missing unit address to rng node name
    - arm64: dts: amlogic: meson-gxl: add missing unit address to eth-phy-mux node
      name
    - arm64: dts: amlogic: meson-gxl-s905d-phicomm-n1: fix led node name
    - ARM: dts: imx7s: correct iomuxc gpr mux controller cells
    - arm64: dts: mediatek: mt7622: Add missing pwm-cells to pwm node
    - Revert "scsi: core: run queue if SCSI device queue isn't ready and queue is
      idle"
    - block: Limit number of items taken from the I/O scheduler in one go
    - blk-mq: remove stale comment for blk_mq_sched_mark_restart_hctx
    - blk-mq: wait on correct sbitmap_queue in blk_mq_mark_tag_wait
    - blk-mq: correct stale comment of .get_budget
    - s390/dasd: Prepare for additional path event handling
    - s390/dasd: Fix potential memleak in dasd_eckd_init()
    - s...